Nick Mathewson
a6688c574e
Catch a few more K&R violations with make check-spaces
...
We now catch bare {s that should be on the previous line with a do,
while, if, or for, and elses that should share a line with their
preceding }.
That is,
if (foo)
{
and
if (foo) {
...
}
else
are now detected.
We should think about maybe making Tor uncrustify-clean some day,
but configuring uncrustify is an exercise in bizarreness, and
reformatting huge gobs of Tor is always painful.
2012-06-23 15:54:01 -04:00
Sebastian Hahn
11221d0f17
Update check-spaces to remove false positive for timercmp macro
...
The timercmp macro uses triggers a "space between function name and
opening parentheses" warning for the check spaces script. Work around
this by simply disabling the check for all "functions" named 'op()'.
2011-11-24 09:29:45 +01:00
Sebastian Hahn
a64e660f0e
Add a rule to detect misplaced labels during check-spaces
2010-08-16 00:46:44 +02:00
Mike Perry
21f91dcb50
Patch from karsten to detect unnecessary \n's.
...
Also fix a spacing issue.
2010-02-22 16:52:11 -08:00
Sebastian Hahn
b875a7a0f2
checkSpace.pl doesn't need to worry about svn tags anymore
2009-05-05 17:05:45 +02:00
Nick Mathewson
8bbbbaf87b
Add country-code support to configured node lists to implement the ever-popular "no exits in Monaco" feature (ExcludeExitNodes {MC}). Also allow country codes and IP ranges in ExitNodes. (EntryNodes needs more work.) Based on code by Robert Hogan. Needs more testing.
...
svn:r16966
2008-09-25 20:21:35 +00:00
Nick Mathewson
6d58d80e78
r17472@catbus: nickm | 2008-01-05 22:10:19 -0500
...
Another test for the increasingly bad check-spaces style checker to check: #else\n#if is almost a sure sign of a failure to use #elif. Fortunately, we only did that 3 times.
svn:r13039
2008-01-06 03:16:08 +00:00
Nick Mathewson
fa3ee3600e
r8969@totoro: nickm | 2006-10-09 09:58:38 -0400
...
Another patch to checkSpace.pl: allow type (WINAPI *fn)()
svn:r8668
2006-10-09 15:46:12 +00:00
Nick Mathewson
ea00437f74
r8933@totoro: nickm | 2006-10-07 20:33:16 -0400
...
whitespace fixes; add changelog for last commit.
svn:r8644
2006-10-08 00:33:43 +00:00
Nick Mathewson
3da737ac98
r7303@Kushana: nickm | 2006-08-10 01:52:19 -0700
...
whitespace fixes
svn:r7011
2006-08-10 09:02:12 +00:00
Nick Mathewson
4fe3c607ad
Apply checkSpace.pl to checkSpace.pl.
...
svn:r6901
2006-07-25 22:33:57 +00:00
Nick Mathewson
fc9ed724ed
Allow wide lines if they have svn id tags in them. (This matters for svk: those tags can be *big*.)
...
svn:r6900
2006-07-25 22:30:50 +00:00
Nick Mathewson
1af630d32c
Bite the bullet and limit all our source lines to 80 characters, the way IBM intended.
...
svn:r5582
2005-12-14 20:40:40 +00:00
Roger Dingledine
9b0a40ec78
crank the max line limit down to 150 chars.
...
svn:r5550
2005-12-10 08:27:01 +00:00
Nick Mathewson
39265dd72e
In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down.
...
svn:r5548
2005-12-09 05:37:26 +00:00
Nick Mathewson
26e7a05725
even better function start checks; give dmalloc a chance of working.
...
svn:r5162
2005-09-30 01:39:24 +00:00
Nick Mathewson
6ce1add8da
Make checkSpace.pl enforce our ctags-friendly function declaration rules
...
svn:r5159
2005-09-30 01:07:55 +00:00
Nick Mathewson
787dfac69b
make whitespace checker handle non-C too.
...
svn:r4412
2005-06-11 18:52:37 +00:00
Nick Mathewson
0831823763
Change end-of-file NLNL convention. It turns out arma I and I agree.
...
svn:r4382
2005-06-09 19:03:31 +00:00
Nick Mathewson
a6f51001a5
New whitespace normalization rule: no blank line at EOF.
...
svn:r4378
2005-06-09 16:46:51 +00:00
Nick Mathewson
f7c6ad065e
correct multiple internal spaces
...
svn:r3004
2004-11-28 09:14:07 +00:00
Nick Mathewson
6f5dbefa7e
Normalize space: add one between every control keyword and control clause.
...
svn:r3003
2004-11-28 09:05:49 +00:00
Nick Mathewson
6fc834ab16
Enhancements to whitespace borkage detector
...
svn:r2944
2004-11-22 23:28:54 +00:00
Nick Mathewson
21c92dace0
More whitespace normalization
...
svn:r2768
2004-11-10 01:20:17 +00:00
Nick Mathewson
5a5be93f80
Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c
...
svn:r2758
2004-11-09 20:04:00 +00:00