Nick Mathewson
9fba014e3f
Merge remote-tracking branch 'public/bug3122_memcmp_022' into bug3122_memcmp_023
...
Conflicts in various places, mainly node-related. Resolved them in
favor of HEAD, with copying of tor_mem* operations from bug3122_memcmp_022.
src/common/Makefile.am
src/or/circuitlist.c
src/or/connection_edge.c
src/or/directory.c
src/or/microdesc.c
src/or/networkstatus.c
src/or/router.c
src/or/routerlist.c
src/test/test_util.c
2011-05-11 16:39:45 -04:00
Nick Mathewson
8fb38331c3
Hand-tune the new tor_memcmp instances in 0.2.2
2011-05-11 16:32:30 -04:00
Nick Mathewson
0cbcbc3412
Re-apply the automated conversion to 0.2.2 to make handle any memcmps that snuck in
2011-05-11 16:27:27 -04:00
Nick Mathewson
44ad734573
Merge remote-tracking branch 'public/3122_memcmp_squashed' into bug3122_memcmp_022
...
Conflicts throughout. All resolved in favor of taking HEAD and
adding tor_mem* or fast_mem* ops as appropriate.
src/common/Makefile.am
src/or/circuitbuild.c
src/or/directory.c
src/or/dirserv.c
src/or/dirvote.c
src/or/networkstatus.c
src/or/rendclient.c
src/or/rendservice.c
src/or/router.c
src/or/routerlist.c
src/or/routerparse.c
src/or/test.c
2011-05-11 16:24:29 -04:00
Nick Mathewson
59f9097d5c
Hand-conversion and audit phase of memcmp transition
...
Here I looked at the results of the automated conversion and cleaned
them up as follows:
If there was a tor_memcmp or tor_memeq that was in fact "safe"[*] I
changed it to a fast_memcmp or fast_memeq.
Otherwise if there was a tor_memcmp that could turn into a
tor_memneq or tor_memeq, I converted it.
This wants close attention.
[*] I'm erring on the side of caution here, and leaving some things
as tor_memcmp that could in my opinion use the data-dependent
fast_memcmp variant.
2011-05-11 16:12:51 -04:00
Nick Mathewson
db7b2a33ee
Automated conversion of memcmp to tor_memcmp/tor_mem[n]eq
...
This commit is _exactly_ the result of
perl -i -pe 's/\bmemcmp\(/tor_memcmp\(/g' src/*/*.[ch]
perl -i -pe 's/\!\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch]
perl -i -pe 's/0\s*==\s*tor_memcmp\(/tor_memeq\(/g' src/*/*.[ch]
perl -i -pe 's/0\s*!=\s*tor_memcmp\(/tor_memneq\(/g' src/*/*.[ch]
git checkout src/common/di_ops.[ch]
git checkout src/or/test.c
git checkout src/common/test.h
2011-05-11 16:12:51 -04:00
Nick Mathewson
3df22887a3
Replace _AUTHORITY enum values with _DIRINFO values (automted)
2011-05-05 20:54:12 -04:00
Nick Mathewson
6e58575767
Automated rename from authority_type_t to dirinfo_type_t
...
We were already overloading this type to mean "a directory that can
serve us X" in addition to "a directory that is an authority for X."
2011-05-05 20:54:11 -04:00
Nick Mathewson
08efa70c41
Merge remote-tracking branch 'origin/maint-0.2.2'
2011-05-04 23:29:56 -04:00
Robert Ransom
66339f74b4
Handle crypto_pk_get_digest failures semi-sensibly
...
Fixes bug 3106.
2011-05-04 20:06:24 -07:00
Nick Mathewson
9d67d16c6a
Merge remote-tracking branch 'origin/maint-0.2.2'
2011-04-28 20:38:50 -04:00
Nick Mathewson
5693fedb60
Clarify comment to say which version fixed 2722
2011-04-28 20:38:15 -04:00
Robert Ransom
134da2fbcf
Add an XXX to the DA code regarding bug 2722
2011-04-18 12:00:48 -07:00
Nick Mathewson
67d88a7d60
Merge remote-tracking branch 'origin/maint-0.2.2'
...
Conflicts:
src/common/address.c
src/common/compat_libevent.c
src/common/memarea.c
src/common/util.h
src/or/buffers.c
src/or/circuitbuild.c
src/or/circuituse.c
src/or/connection.c
src/or/directory.c
src/or/networkstatus.c
src/or/or.h
src/or/routerlist.c
2011-04-07 12:17:20 -04:00
Nick Mathewson
05887f10ff
Triage the XXX022 and XXX021 comments remaining in the code
...
Remove some, postpone others, leave some alone. Now the only
remaining XXX022s are ones that seem important to fix or investigate.
2011-03-25 18:32:27 -04:00
Nick Mathewson
f1c365b032
Merge remote branch 'origin/maint-0.2.2'
...
Fix trivial add/add conflict in main.c
Conflicts:
src/or/main.c
2011-03-14 15:31:24 -04:00
Nick Mathewson
b639add1a0
Merge remote branch 'arma/bug2716' into maint-0.2.2
2011-03-14 15:29:02 -04:00
Roger Dingledine
61f648ae37
fix one more typo
2011-03-13 15:22:45 -04:00
Nick Mathewson
176fde505f
Tweak bug2716 patch a little
...
Name the magic value "10" rather than re-deriving it.
Comment more.
Use the pattern that works for periodic timers, not the pattern that
doesn't work. ;)
2011-03-12 00:19:52 -05:00
Nick Mathewson
d52a99dc77
Merge remote branch 'origin/maint-0.2.2'
2011-03-11 23:34:46 -05:00
Roger Dingledine
977e396e86
improve accuracy for when a relay went unreachable
2011-03-11 22:12:15 -05:00
Sebastian Hahn
f7a3cdc8f2
Use observed instead of declared uptime for HSDir
...
It is important to verify the uptime claim of a relay instead of just
trusting it, otherwise it becomes too easy to blackhole a specific
hidden service. rephist already has data available that we can use here.
Bugfix on 0.2.0.10-alpha.
2011-03-11 18:44:35 +01:00
Nick Mathewson
f9bb3ced51
Merge remote branch 'origin/maint-0.2.2'
...
Resolved trivial one-line conflicts.
Conflicts:
src/or/dirserv.c
src/or/rephist.c
2011-03-08 16:10:40 -05:00
Nick Mathewson
0d78a16c36
Merge remote branch 'sebastian/bug1035' into maint-0.2.2
2011-03-08 15:52:43 -05:00
Nick Mathewson
176e8a0a2a
Merge remote branch 'origin/maint-0.2.2'
...
Conflicts:
src/or/routerparse.c
2011-03-06 13:46:11 -05:00
Nick Mathewson
35fcec3880
Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2
2011-03-06 13:42:28 -05:00
Nick Mathewson
bcbc8c51cb
Do not serve encrypt-only descriptors with the "all" request. Reported by piebeer
2011-03-04 00:04:25 -05:00
Sebastian Hahn
9b64227ffd
Routers count as down when they change ORPort, too
...
rransom noticed that a change of ORPort is just as bad as a change of IP
address from a client's perspective, because both mean that the relay is
not available to them while the new information hasn't propagated.
Change the bug1035 fix accordingly.
Also make sure we don't log a bridge's IP address (which might happen
when we are the bridge authority).
2011-02-08 00:38:48 +01:00
Nick Mathewson
8730884ebe
Merge remote branch 'origin/maint-0.2.2'
2011-01-03 11:53:28 -05:00
Nick Mathewson
f1de329e78
Merge remote branch 'origin/maint-0.2.1' into maint-0.2.2
...
Conflicts:
src/common/test.h
src/or/test.c
2011-01-03 11:51:17 -05:00
Nick Mathewson
1a07348a50
Bump copyright statements to 2011
2011-01-03 11:50:39 -05:00
Nick Mathewson
4e9f9a4ee8
Merge remote branch 'origin/maint-0.2.2'
2010-12-07 11:37:14 -05:00
Nick Mathewson
f924fbf19f
Merge branch 'bug2081_followup_022' into maint-0.2.2
2010-12-07 11:35:49 -05:00
Nick Mathewson
5efe6f04c6
Reject relay versions older than 0.2.0.26-rc
...
This was the first version to cache the correct directory information.
Fixes bug 2156.
2010-12-07 11:35:32 -05:00
Nick Mathewson
bbadf07d16
Merge remote branch 'origin/maint-0.2.2'
2010-12-06 11:37:37 -05:00
Nick Mathewson
feffbce814
Add a missing ! to directory_fetches_from_authorities
...
The old logic would have us fetch from authorities if we were refusing
unknown exits and our exit policy was reject*. Instead, we want to
fetch from authorities if we're refusing unknown exits and our exit
policy is _NOT_ reject*.
Fixed by boboper. Fixes more of 2097. Bugfix on 0.2.2.16-alpha.
2010-12-06 11:36:01 -05:00
Nick Mathewson
9908404f01
Merge remote branch 'sjmurdoch/cloexec'
2010-12-01 11:42:34 -05:00
Roger Dingledine
9f51e26715
fix memory leak introduced in 26e89742
...
found via valgrind
2010-11-30 16:52:19 -05:00
Nick Mathewson
bea0a31c1c
Treat routers whose IPs have changed as having been down for MTBF/routerinfo
...
calculation purposes.
2010-11-22 12:32:29 -05:00
Nick Mathewson
2af14b671d
Have authorities reject routers running verions susceptible to bug 1038.
2010-11-22 11:16:36 -05:00
Nick Mathewson
e669d25e43
Do cloexec on socketpairs and stdio files
2010-11-20 01:16:29 -05:00
Nick Mathewson
17fdde3d92
Merge remote branch 'origin/maint-0.2.2'
...
Conflicts:
src/common/tortls.c
2010-10-21 16:23:01 -04:00
Nick Mathewson
1587735c90
Merge branch 'bug988-nm' into maint-0.2.2
2010-10-21 16:11:02 -04:00
Nick Mathewson
444193ff5d
Merge remote branch 'origin/maint-0.2.2'
...
Conflicts:
src/or/networkstatus.c
2010-10-20 13:53:11 -04:00
Nick Mathewson
2849a95691
Add a ! to directory_caches_dir_info() to fix a logic error
...
We want to fetch directory info more aggressively if we need it to
refuseunknownexits. Thus, we'll want it if our exit policy is _NOT_
reject *.
2010-10-20 13:49:38 -04:00
Nick Mathewson
a7cf788740
Merge branch 'bug1992_part1'
2010-10-15 17:08:18 -04:00
Sebastian Hahn
4556f2e7c8
Rename router_get_by_digest()
...
We now call the function router_get_by_id_digest() to make clear that
we're talking about the identity digest here, not descriptor digest.
2010-10-14 17:49:51 +02:00
Nick Mathewson
8c837db38f
Merge branch 'nodes'
2010-10-13 16:04:25 -04:00
Nick Mathewson
9fe3cd0be3
Fix a crash bug when serving microdescs on a bufferevent.
2010-10-07 21:02:12 -04:00
Robert Ransom
a2bb0bfdd5
Maintain separate server and client identity keys when appropriate.
...
Fixes a bug described in ticket #988 .
2010-10-04 21:51:53 -07:00