George Kadianakis
593b7726e9
Hiding crypt_path_t: Trivial changes to satisfy check-local.
2019-05-03 18:15:26 +03:00
George Kadianakis
cd38e41620
Hiding crypt_path_t: Ensure that ->private is initialized.
...
Now that we are using a constructor we should be more careful that we are
always using the constructor to initialize crypt_path_t, so make sure that
->private is initialized.
2019-05-03 18:15:11 +03:00
George Kadianakis
f5635989b0
Hiding crypt_path_t: Create a constructor for crypt_path_t.
...
We are using an opaque pointer so the structure needs to be allocated on the
heap. This means we now need a constructor for crypt_path_t.
Also modify all places initializing a crypt_path_t to use the constructor.
2019-05-03 18:15:11 +03:00
George Kadianakis
18d61c0e6e
Hiding crypt_path_t: Fixup broken unittests.
2019-05-03 18:15:11 +03:00
George Kadianakis
4bd0c4852a
Hiding crypt_path_t: Move the free func in crypt_path.c.
...
Again everything is moved, apart from a free line using ->private.
2019-05-03 18:15:11 +03:00
George Kadianakis
5f96b7abcc
Hiding crypt_path_t: Move some more init funcs in crypt_path.c.
...
Everything is moved, but the argument of the function is edited to access
->private->crypto.
2019-05-03 18:15:11 +03:00
George Kadianakis
0c5176d00c
Hiding crypt_path_t: Start with crypt_path.crypto .
...
Create some functions to eventually be able to hide crypt_path_t.crypto.
2019-05-03 18:15:11 +03:00
George Kadianakis
f74a80dc3b
Hiding crypt_path_t: Move init functions to crypt_path.c.
...
This commit only moves code.
2019-05-03 18:15:00 +03:00
George Kadianakis
9584798e57
Hiding crypt_path_t: Move assert functions in crypt_path.c.
...
This commit only moves code, and makes one function public.
2019-05-03 18:15:00 +03:00
George Kadianakis
c3a5e6b436
Hiding crypt_path_t: Introduce opaque crypt_path_private_t .
...
This will be our base for incrementally hiding crypt_path_t.
2019-05-03 18:15:00 +03:00
David Goulet
b3492d53c3
Merge branch 'tor-github/pr/984'
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2019-05-03 10:56:12 -04:00
Nick Mathewson
d20cfc00ce
Note how to update the new website in the ReleasingTor.md instructions
2019-05-03 08:51:28 -04:00
Nick Mathewson
1f13c2bd23
Merge branch 'maint-0.4.0'
...
"ours" to avoid version bump.
2019-05-02 14:33:09 -04:00
Nick Mathewson
2b54733dc0
Bump to 0.4.0.5-dev
2019-05-02 14:32:55 -04:00
Nick Mathewson
2fca2ed499
forward-port changelog and releasenotes from 0.4.0.5
2019-05-02 14:32:24 -04:00
George Kadianakis
b2c2cb9287
Merge branch 'tor-github/pr/986'
2019-05-02 18:12:52 +03:00
David Goulet
562bcbcfc2
sendme: Add changes file for prop289
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2019-05-02 11:10:41 -04:00
George Kadianakis
4d461e20f7
Merge branch 'tor-github/pr/999'
2019-05-02 17:48:09 +03:00
Nick Mathewson
721e65a1d5
Add comments to include.am files to note where new sources go
...
This mechanism isn't perfect, and sometimes it will guess wrong,
but it will help our automation.
2019-05-02 09:37:18 -04:00
Nick Mathewson
ee36bfa6de
Changes file for improved dirauth modularity (ticket 30345)
2019-05-02 09:22:13 -04:00
Nick Mathewson
0f365e2f46
practracker updates.
2019-05-02 09:22:13 -04:00
Nick Mathewson
9c3aa22740
Remove some now-needless dirauth includes
2019-05-02 09:22:13 -04:00
Nick Mathewson
a45413e7d5
Make keypin.c dirauth-only
2019-05-02 09:22:13 -04:00
Nick Mathewson
31fb4a7845
Make the bwauth.c module dirauth-only.
2019-05-02 09:22:13 -04:00
Nick Mathewson
6f42efaa59
Move voteflags.[ch] to become dirauth only.
...
For various reasons, this was a nontrivial movement. There are
several places in the code where we do something like "update the
flags on this routerstatus or node if we're an authority", and at
least one where we pretended to be an authority when we weren't.
2019-05-02 09:22:13 -04:00
David Goulet
77bd219808
sendme: Improve logging messages
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2019-05-02 08:58:58 -04:00
Nick Mathewson
3d13841fa5
Remove changes files that are already in 0.4.0.5 or earlier
2019-05-02 08:42:01 -04:00
Nick Mathewson
0a2b96cae6
Merge remote-tracking branch 'tor-github/pr/989'
2019-05-02 08:36:09 -04:00
Mike Perry
e1771aeb51
The practracker beatings will continue until our files get smaller.
2019-05-01 21:04:40 +00:00
Mike Perry
332617a81a
Changes file for bug29231.
2019-05-01 21:03:23 +00:00
Mike Perry
d0fb74c902
Bug 29231: Report correct padding write totals and enabled totals.
2019-05-01 21:00:26 +00:00
Nick Mathewson
4973ceb46b
Merge remote-tracking branch 'tor-github/pr/950'
2019-05-01 09:11:20 -04:00
rl1987
d91deeee45
pre-push.git-hook: Allow fixup and squash commits when pushing to non-upstream branches
2019-05-01 14:01:30 +03:00
Nick Mathewson
39bd10dca6
Merge branch 'maint-0.4.0'
...
"ours" to avoid version bump
2019-04-30 15:54:03 -04:00
Nick Mathewson
cafb999810
bump to 0.4.0.5
2019-04-30 15:53:53 -04:00
Nick Mathewson
996f7c75ba
Make the reachability.c module dirauth-only.
2019-04-30 15:00:08 -04:00
Nick Mathewson
339ac4dc67
Make the guardfraction.c module dirauth-only.
2019-04-30 15:00:08 -04:00
Nick Mathewson
857bfc7033
Make the process_descs.c module dirauth-only.
2019-04-30 15:00:07 -04:00
Nick Mathewson
aab0245924
Make the dsigs_parse.c module dirauth-only.
2019-04-30 15:00:07 -04:00
Nick Mathewson
853942b71e
Make the recommend_pkg file dirauth-only.
2019-04-30 15:00:07 -04:00
Nick Mathewson
295feeb093
Replace all remaining tor_mem_is_zero() with fast_mem_is_zero()
2019-04-30 14:49:05 -04:00
Nick Mathewson
0034f10956
Use safe_mem_is_zero in a few more places.
...
I don't believe any of these represent a real timing vulnerability
(remote timing against memcmp() on a modern CPU is not easy), but
these are the ones where I believe we should be more careful.
2019-04-30 14:45:58 -04:00
Nick Mathewson
309467c64e
Rename tor_mem_is_zero to fast_mem_is_zero()
...
For memeq and friends, "tor_" indicates constant-time and "fast_"
indicates optimized. I'm fine with leaving the constant-time
"safe_mem_is_zero" with its current name, but the "tor_" prefix on
the current optimized version is misleading.
Also, make the tor_digest*_is_zero() uniformly constant-time, and
add a fast_digest*_is_zero() version to use as needed.
A later commit in this branch will fix all the users of
tor_mem_is_zero().
Closes ticket 30309.
2019-04-30 14:45:51 -04:00
Taylor Yu
0900367996
Changes file for ticket30007
2019-04-30 13:18:46 -05:00
Taylor Yu
68caca58a8
Clean up formatting after Coccinelle
...
Clean up some minor formatting quirks after the Coccinelle run.
2019-04-30 13:18:46 -05:00
Taylor Yu
983452e221
Run Coccinelle for control.c refactor
2019-04-30 13:18:46 -05:00
Taylor Yu
58ec88e806
Coccinelle scripts for control.c refactor
2019-04-30 13:18:46 -05:00
Taylor Yu
769eb07a7a
Manually fix some control replies
...
Manually fix up some reply-generating code that the Coccinelle scripts
won't match. Some more complicated ones remain -- these are mostly
ones that accumulate data to send, and then call connection_buf_add()
or connection_write_str_to_buf() directly.
2019-04-30 13:18:46 -05:00
Taylor Yu
61976a4b1c
Factor out control reply output
...
Create a set of abstractions for controller commands and events to
output replies to the control channel. The control protocol has a
relatively consistent SMTP-like structure, so it's helpful when code
that implements control commands and events doesn't explicitly format
everything on its own.
2019-04-30 13:18:46 -05:00
Taylor Yu
482437754a
Add clarifying comments to control_proto.c
...
Refer to control-spec.txt grammar productions in comments in
control_proto.c for clarity.
2019-04-30 13:18:46 -05:00