Nick Mathewson
b11b4b7bb7
Add test for dispatch_send() fast path.
2019-03-25 16:35:34 -04:00
Nick Mathewson
ab6ddc7a33
practracker: split shutdown code out of main.c
...
This is necessary to get the number of includes in main.c back under
control. (In the future, we could just use the subsystem manager for
this kind of stuff.)
2019-03-25 16:35:34 -04:00
Nick Mathewson
4bdff5e3e9
practracker compliance: split lint_message into more logical parts
2019-03-25 16:35:34 -04:00
Nick Mathewson
d976cda49f
pubsub: add test for items_out in builder_finalize()
2019-03-25 16:35:34 -04:00
Nick Mathewson
3552cd69bd
coverage: Exclude lines in pubsub_pub that can only be reached on bug
2019-03-25 16:35:34 -04:00
Nick Mathewson
2e7f80d5f4
pubsub_check.c: Stop accepting NULL prefix, which we never send.
...
(Our code to handle it was broken, too)
2019-03-25 16:35:34 -04:00
Nick Mathewson
c40bcab85d
dispatch: Test behavior of formatting type with no set fmt function.
2019-03-25 16:35:34 -04:00
Nick Mathewson
f74301f8fd
Unit test for namemap_fmt_name()
2019-03-25 16:35:34 -04:00
Nick Mathewson
9fb511526a
pubsub test: add a test to make sure typefns can't be changed.
2019-03-25 16:35:34 -04:00
Nick Mathewson
beedadbeac
Try a different approach to making publish function seem used.
...
We want the DISPATCH_ADD_PUB() macro to count as making a
DECLARE_PUBLISH() invocation "used", so let's try a new approach
that preserves that idea. The old one apparently did not work for
some versions of osx clang.
2019-03-25 16:35:34 -04:00
Nick Mathewson
94feec59cf
move pubsub_connector_t typedef to pubsub_connect.h
2019-03-25 16:35:34 -04:00
Nick Mathewson
22ad8658cd
Correct doxygen @file directives
2019-03-25 16:35:34 -04:00
Nick Mathewson
3d6bf7b36e
Document several issues found by Taylor
2019-03-25 16:35:34 -04:00
Nick Mathewson
b4f28b9df8
pubsub: install libevent events separately from the_dispatcher.
...
Also, add documentation, and fix a free-on-error bug.
2019-03-25 16:35:34 -04:00
Nick Mathewson
6d1abd37e2
Connect the mainloop pubsub dispatcher on startup; free it on shutdown.
2019-03-25 16:35:33 -04:00
Nick Mathewson
02e0a39d39
Add msgtypes.h include to pubsub_build.h
...
(The header won't compile without it.)
2019-03-25 16:35:33 -04:00
Nick Mathewson
bdeaf7d4b2
Code to manage publish/subscribe setup via subsystem interface.
...
This commit has the necessary logic to run the publish/subscribe
system from the mainloop, and to initialize it on startup and tear
it down later.
2019-03-25 16:35:33 -04:00
Nick Mathewson
24df14eb09
Pubsub: macros for ease-of-use and typesafety.
2019-03-25 16:35:33 -04:00
Nick Mathewson
a7681525ab
Add function to clear publish bindings.
...
When we clean up, we'd like to clear all the bindings that refer to
a dispatch_t, so that they don't have dangling pointers to it.
2019-03-25 16:35:33 -04:00
Nick Mathewson
271a671822
pubsub: relationship checking functionality
...
This code tries to prevent a large number of possible errors by
enforcing different restrictions on the messages that different
modules publish and subscribe to.
Some of these rules are probably too strict, and some too lax: we
should feel free to change them as needed as we move forward and
learn more.
2019-03-25 16:35:33 -04:00
Nick Mathewson
9e60482b80
Pubsub: an OO layer on top of lib/dispatch
...
This "publish/subscribe" layer sits on top of lib/dispatch, and
tries to provide more type-safety and cross-checking for the
lower-level layer.
Even with this commit, we're still not done: more checking will come
in the next commit, and a set of usability/typesafety macros will
come after.
2019-03-25 16:35:33 -04:00
Nick Mathewson
24b945f713
Debug logs to record all messages sent and delivered.
2019-03-25 16:35:33 -04:00
Nick Mathewson
f5683d90be
Add a naming system for IDs in dispatch.
2019-03-25 16:35:33 -04:00
Nick Mathewson
e4d3098d4d
Low-level dispatch module for publish-subscribe mechanism
...
This module implements a way to send messages from one module to
another, with associated data types. It does not yet do anything to
ensure that messages are correct, that types match, or that other
forms of consistency are preserved.
2019-03-25 16:35:33 -04:00
Nick Mathewson
a62ac17198
Add a new inline function to check whether debug logging is on
...
We already do this in our log_debug() macro, but there are times
when we'd like to avoid allocating or precomputing something that we
are only going to log if debugging is on.
2019-03-25 16:35:33 -04:00
Nick Mathewson
253fea84cf
Add a smartlist_grow() function to expand a smartlist
...
Tests included.
2019-03-25 16:35:33 -04:00
Nick Mathewson
56bda7464f
Add a macro for the fairly common "eat next semicolon" syntax trick
...
You use this when you're defining a macro to be used at file scope,
and you want to require a semicolon afterwards.
2019-03-25 16:35:33 -04:00
Nick Mathewson
0944500a8e
Add MESG as a new log domain.
2019-03-25 16:35:33 -04:00
Nick Mathewson
dfd7a7f5b6
Add a type to map names to short identifiers
...
We'll be using this for four kinds of identifier in dispatch.c
2019-03-25 16:35:33 -04:00
Nick Mathewson
2c8af79de5
Add a practracker-regen make target
2019-03-25 16:09:11 -04:00
Nick Mathewson
c2643842a9
practracker: add ability to regenerate exceptions file.
...
Also add a useful argument parser.
2019-03-25 16:09:11 -04:00
Nick Mathewson
0260e0f6fc
practracker: pass sys.argv to main() as an argument
2019-03-25 16:09:11 -04:00
Nick Mathewson
301e3f22ef
Practracker: add a string explaining the excptions file.
2019-03-25 16:09:11 -04:00
Nick Mathewson
c81b2b09ea
Merge branch 'practracker_comments'
2019-03-25 15:18:36 -04:00
Nick Mathewson
b71febcea8
changes file for control.c splitup
2019-03-25 15:08:36 -04:00
Nick Mathewson
61cebb2035
Minimize the includes in control.c
2019-03-25 14:14:56 -04:00
Nick Mathewson
2917ecaa97
Split command-handling and authentication from control.c
2019-03-25 14:06:56 -04:00
Nick Mathewson
4754e9058b
Split getinfo handling into a new control_getinfo.c
2019-03-25 12:49:24 -04:00
Nick Mathewson
a49f506e05
Split all controller events code into a new control_events.c
...
Also, split the formatting code shared by control.c and
control_events.c into controller_fmt.c.
2019-03-25 12:11:59 -04:00
Nick Mathewson
135b51c9d3
practracker: allow comments in exceptions file
...
Also, distinguish between empty lines (which we should ignore)
and incorrect lines (which we should warn about).
2019-03-25 09:28:24 -04:00
Nick Mathewson
a20a2025a5
practracker: sort filenames and directories.
...
This helps ensure that we'll get output in a stable order.
Closes ticket 29882.
2019-03-25 09:08:04 -04:00
rl1987
68260e85b5
Move sizeof check to torint.h
2019-03-25 10:17:30 +02:00
Taylor Yu
5d2f5e482e
Correctly report PT vs proxy during bootstrap
...
Previously, or_connection_t did not record whether or not the
connection uses a pluggable transport. Instead, it stored the
underlying proxy protocol of the pluggable transport in
proxy_type. This made bootstrap reporting treat pluggable transport
connections as plain proxy connections.
Store a separate bit indicating whether a pluggable transport is in
use, and decode this during bootstrap reporting.
Fixes bug 28925; bugfix on 0.4.0.1-alpha.
2019-03-25 14:13:45 +10:00
teor
d4d541c53c
Merge remote-tracking branch 'tor-github/pr/785'
2019-03-25 14:01:20 +10:00
rl1987
f09205ef53
Refactor test_utils_general() to fix Coverity warnings
2019-03-24 10:10:52 +02:00
rl1987
9529d99982
Tweak changes file
2019-03-24 09:25:30 +02:00
Nick Mathewson
9d0ce0afcc
forward-port changelog for 0.4.0.3-alpha
2019-03-23 08:46:29 -04:00
Nick Mathewson
91c24ad530
Merge branch 'maint-0.4.0'
...
"ours" to avoid version bump
2019-03-23 08:44:44 -04:00
Nick Mathewson
8bc3ac6a84
Bump to 0.4.0.3-alpha-dev
2019-03-23 08:44:36 -04:00
Taylor Yu
307c156fbe
Set file encoding in practracker.py
...
Explicitly set the file encoding to UTF-8 in practracker.py, to avoid
problems in some CI environments. Fixes bug 29789; bug not in any
released Tor.
2019-03-22 17:51:55 -05:00