nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-22 14:04:58 +02:00
Code Issues Packages Projects Releases Wiki Activity
10,775 Commits 53 Branches 629 Tags 108 MiB
793f1ce007
Commit Graph

7162 Commits

Author SHA1 Message Date
Nick Mathewson
6c6b0283cb Ben confirms that the MUST in rfc2631 is only for compatibility with X9.42, and isn't actually a security thing. 
svn:r17685
 2008-12-18 16:11:16 +00:00
Nick Mathewson
8d5a9d762c Log an error on win32 if directory listing fails. 
svn:r17684
 2008-12-18 16:11:12 +00:00
Nick Mathewson
c449e6e5be whitespace fixes. 
svn:r17683
 2008-12-18 16:11:08 +00:00
Nick Mathewson
ecaee1d927 Remove fixed xxx020s; downgrade unfixed ones. 
(The unfixed ones are being downgraded to regular XXXs mainly on the rationale that they don't seem to be exploding Tor, and they were apparently not showstoppers for 0.2.0.x-final.)

svn:r17682
 2008-12-18 16:11:03 +00:00
Nick Mathewson
f9133f2528 Fix a memory leak of one address string per DNSPort request. 
svn:r17681
 2008-12-18 15:00:27 +00:00
Nick Mathewson
148e4e8837 Do not leak the DNS server port structure. 
svn:r17680
 2008-12-18 15:00:18 +00:00
Nick Mathewson
4911ec627b Call release_lockfile() before exiting. 
svn:r17679
 2008-12-18 15:00:13 +00:00
Nick Mathewson
9c3d17ebb5 Fix a small memory leak of around 32 bytes per TLS connection opened. Bugfix on 0.2.1.1-alpha. 
svn:r17678
 2008-12-18 15:00:09 +00:00
Nick Mathewson
290b6f54a3 Make unit tests slower but more reliable by disabling an old optimization. 
To turn it back on, re-define CACHE_GENERATED_KEYS option in test.c.

svn:r17677
 2008-12-18 06:12:19 +00:00
Nick Mathewson
8ba2a15a49 Fix more leaks in unit tests. 
svn:r17676
 2008-12-18 06:02:23 +00:00
Nick Mathewson
1b735e46dd Make it possible to call set_onion_key twice without leaking RAM. 
svn:r17673
 2008-12-18 05:40:57 +00:00
Nick Mathewson
cebdf93949 Fix bug 889: share deep-copied keys between threads to avoid races in reference counts. Bugfix on 0.1.0.1-rc. 
svn:r17672
 2008-12-18 05:28:27 +00:00
Roger Dingledine
7b5be147ee fix a minor memory leak if we start up as a relay but don't 
have any files in the cached-status/ directory


svn:r17671
 2008-12-18 05:15:11 +00:00
Nick Mathewson
d597b23c42 Massage a little code to hopfully please coverity. 
svn:r17669
 2008-12-18 04:45:51 +00:00
Nick Mathewson
f3f6daf819 Avoid nop call to control_event_or_authdir_new_descriptor that makes coverity think we are dereferencing a null pointer. It is safe, I think, but entirely too clever for our own good. 
svn:r17668
 2008-12-18 04:45:47 +00:00
Nick Mathewson
676175103d Fix a valgrind-located memory stomp. Bugfix on 0.2.1.6-alpha. 
svn:r17667
 2008-12-18 04:27:23 +00:00
Nick Mathewson
5c235cb5ec Fix memory leak in rend_cache_store_v2_desc_as_client(), and refactor the function to use the "goto err" idiom. 
svn:r17665
 2008-12-18 00:11:49 +00:00
Nick Mathewson
1510d50fab Oops: SeverDNS->ServerDNS. 
svn:r17664
 2008-12-17 23:20:07 +00:00
Nick Mathewson
7d92053286 Remove RedirectExit feature; it has been deprecated since 0.2.0.3-alpha 
svn:r17663
 2008-12-17 23:02:04 +00:00
Nick Mathewson
6693f32530 Resolve many DOCDOCs. 
svn:r17662
 2008-12-17 22:58:20 +00:00
Nick Mathewson
2ad36f68c8 Rename ServerDNSAllowBrokenResolvConf to ServerDNSAllowBrokenConfig. 
(Many users have no idea what a resolv.conf is, and shouldn't be forced to learn.  The old option will keep working for now.)
Also, document it.

svn:r17661
 2008-12-17 22:58:14 +00:00
Roger Dingledine
03f413f5c7 declare that we're putting out 0.2.1.9-alpha next week 
svn:r17659
 2008-12-17 22:46:00 +00:00
Roger Dingledine
048f2a179b Clip the MaxCircuitDirtiness config option to a minimum of 10 
seconds. Warn the user if lower values are given in the
configuration. Bugfix on 0.1.0.1-rc. Patch by Sebastian.
Clip the CircuitBuildTimeout to a minimum of 30 seconds. Warn the
user if lower values are given in the configuration. Bugfix on
0.1.1.17-rc. Patch by Sebastian.


svn:r17657
 2008-12-17 22:32:17 +00:00
Nick Mathewson
33e2053ebc Make return code from router_add_to_routerlist a nice sensible enum. Based on patch from Sebastian. 
svn:r17656
 2008-12-17 21:50:01 +00:00
Nick Mathewson
2de9bd7bae Rename a couple of v2-networkstatus-only fields so that it is clear they are v2-networkstatus-only. 
svn:r17652
 2008-12-17 17:20:48 +00:00
Nick Mathewson
f43bcdc063 Use ctags and a python script to find identifiers that are never used anywhere, and remove the ones that we really want gone. 
svn:r17651
 2008-12-17 17:20:42 +00:00
Nick Mathewson
fc5e686b19 Whitespace fix. 
svn:r17650
 2008-12-17 17:20:36 +00:00
Nick Mathewson
1beb1c113b Add some missing documentation in or.h 
svn:r17649
 2008-12-17 17:20:31 +00:00
Nick Mathewson
0dc724d19c Make ALLOW_INVALID_* into an enum. 
svn:r17648
 2008-12-17 17:20:26 +00:00
Nick Mathewson
d0e1cc6fe2 Remove the no-longer-used incoming_cmd_type field from control_connection_t. 
svn:r17647
 2008-12-17 17:20:22 +00:00
Nick Mathewson
68a6935afb Change CELL_DIRECTION_* to an enum. 
svn:r17646
 2008-12-17 17:20:19 +00:00
Nick Mathewson
44e19a4949 Oops; remove extraneous comma. 
svn:r17644
 2008-12-17 15:04:43 +00:00
Nick Mathewson
7678ac5193 Move edge-only flags from connection_t to edge_connection_t. 
svn:r17643
 2008-12-17 14:59:28 +00:00
Nick Mathewson
26632d59dd Rename or_is_obsolete and move it to or_connection_t where it belongs. 
svn:r17642
 2008-12-17 14:59:19 +00:00
Nick Mathewson
e53ffaa4e4 Don't extend circuits over noncanonical connections with mismatched addresses. 
Also, refactor the logic to check whether we will use a connection or
launch a new one into a new function.

svn:r17628
 2008-12-15 21:17:53 +00:00
Nick Mathewson
51c29e1e24 Apply rovv's bug 805 fix: take more care never to prefer a non-canonical connection. 
svn:r17627
 2008-12-15 21:17:43 +00:00
Roger Dingledine
5822e14dc9 When a stream at an exit relay is in state "resolving" or 
"connecting" and it receives an "end" relay cell, the exit relay
would silently ignore the end cell and not close the stream. If
the client never closes the circuit, then the exit relay never
closes the TCP connection. Bug introduced in Tor 0.1.2.1-alpha;
reported by "wood".


svn:r17625
 2008-12-14 19:40:56 +00:00
Roger Dingledine
2ad06eef11 comment tweak 
svn:r17624
 2008-12-14 19:39:54 +00:00
Nick Mathewson
a4a481d81c Implement proposal 148: Make client stream end reasons uniform. 
This patch makes every RELAY_COMMAND_END cell that we send pass through one of two functions: connection_edge_end and relay_send_end_cell_from_edge.  Both of these functions check the circuit purpose, and change the reason to MISC if the circuit purpose means that it's for client use.

svn:r17612
 2008-12-12 20:30:42 +00:00
Nick Mathewson
5fb2ab1e65 Implement the /tor/keys/fp-sk/ URL format. That mostly finishes the server side of 157. 
svn:r17611
 2008-12-12 19:05:36 +00:00
Nick Mathewson
69ce955484 Add cross-certification to authority key certificates. Partial implementation of proposal 157. 
svn:r17610
 2008-12-12 18:31:39 +00:00
Nick Mathewson
519de7970e Do not discard sign on return values of iv crypto functions in tests. May fix CID 9. Might not. 
svn:r17603
 2008-12-11 21:11:31 +00:00
Nick Mathewson
7e351a6341 Note that a couple of line in control.c are supposed to be dead-code. 
I'm hoping not to have to litter the rest of our codebase with Coverity ignores, but I think these are the only one we need right now.

svn:r17602
 2008-12-11 21:11:28 +00:00
Nick Mathewson
02e26ebc49 If we are building under Coverity, enable geoip_stats and instrument_downloads. 
This makes sure that a) optional code gets analyzed too, and b) it doesn't
look like dead code to Coverity.

svn:r17601
 2008-12-11 21:11:26 +00:00
Nick Mathewson
98066d62bc Lower sprintf buffer max to ~SSIZE_T_MAX from SIZE_T_CEILING, since we need to compare it to a signed int. 
svn:r17600
 2008-12-11 21:11:22 +00:00
Nick Mathewson
b20694758e Fix two more unit-test bugs (deadcode this time) spotted by Coverity run 7. 
CIDs == 357, 356.

svn:r17599
 2008-12-11 21:11:19 +00:00
Nick Mathewson
04ec7d1f98 Now that tor_assert is no longer using a broken force-to-boolean formulation, we can tor_assert a bitfield without a gcc compile error. 
svn:r17598
 2008-12-11 20:28:50 +00:00
Nick Mathewson
4277b0e926 Remove some cargo-cult gcc hacks around tor_assert and predict_unlikely; instead, use the standard convert-to-boolean hack of "svn st" 
svn:r17597
 2008-12-11 20:23:46 +00:00
Nick Mathewson
d9aa57253d Fix error in last unit test mem-leak-fixing. 
svn:r17596
 2008-12-11 19:41:03 +00:00
Nick Mathewson
bb02f919f1 Refactor find_first_by_keyword into one variant that can return NULL and one that can't. 
This makes it easier for us to avoid errors where we we forgot to list a keyword as mandatory, and easier for Coverity to detect cases like this too.

svn:r17595
 2008-12-11 19:40:58 +00:00
Nick Mathewson
f3b52e331e Avoid multiple descriptor-fetch connections to authorities. Fixes bug 366. 
svn:r17594
 2008-12-11 19:12:55 +00:00
Nick Mathewson
043b4fc59e Add a PDS_ flag to exclude authorities from which we are fetching descs. 
Yes, this is maybe a little overspecific.  Part of a bug 366 fix.

svn:r17593
 2008-12-11 19:12:48 +00:00
Nick Mathewson
29f5a65a16 Change directory_get_from_dirserver to take a set of flags to be passed to pick_(trusted_)dirserver. This lets us make its interface smarter, and makes code that calls it a little more readable. 
svn:r17592
 2008-12-11 19:12:45 +00:00
Nick Mathewson
4e69284e89 Fix wide line in main.c 
svn:r17587
 2008-12-11 17:23:00 +00:00
Nick Mathewson
240ee1866b Add experimental support for learning svn revision number in git-svn based repositories. Fancy. 
svn:r17581
 2008-12-11 06:52:24 +00:00
Nick Mathewson
d7563ee231 Fix memory leaks in test_util_smartlist_* functions. 
svn:r17580
 2008-12-11 06:18:09 +00:00
Nick Mathewson
595e77c8d7 Fix memory leaks in test_v3_networkstatus. 
svn:r17579
 2008-12-11 06:18:01 +00:00
Nick Mathewson
6ffb4d4ab6 Fix memory leaks in test_dir_format 
svn:r17578
 2008-12-11 06:17:59 +00:00
Nick Mathewson
3be88b2c70 Change test_memeq macro to not leak memory. Addresses coverity CID 47. 
svn:r17577
 2008-12-11 06:17:54 +00:00
Nick Mathewson
d8027aa689 Fix a logic error that would automatically reject all but the first configured DNS server. Bugfix on 0.2.1.5-alpha. Possible fix for part of 813/868. Spotted by coderman 
svn:r17569
 2008-12-10 22:57:41 +00:00
Nick Mathewson
53d3f812bd Add new internal-use-only option for controllers to use to prevent SIGHUP from reloading the configuration. Fixes bug 856. 
svn:r17567
 2008-12-10 22:17:02 +00:00
Nick Mathewson
9aa706e20c Bug 691 fix: do not shutdown Tor servers right away if the network is down. 
svn:r17566
 2008-12-10 20:45:31 +00:00
Nick Mathewson
426b53d85a Apply patch from Karsten to fix bug 879. Backport candidate. 
svn:r17562
 2008-12-10 18:16:58 +00:00
Nick Mathewson
7aa7d1a3e7 Give a better error when something has changed our descriptor cache out from under us. Based on patch from Karsten. Addresses bug 885. 
svn:r17550
 2008-12-10 03:01:26 +00:00
Roger Dingledine
d7bf7e0b32 When a directory authority gives us a new guess for our IP address, 
log which authority we used. Hopefully this will help us debug
the recent complaints about bad IP address guesses.


svn:r17549
 2008-12-10 01:46:51 +00:00
Roger Dingledine
4053b47459 note a potential bug in status events. need to look at spec to 
see if it's really a bug.


svn:r17548
 2008-12-10 01:35:21 +00:00
Roger Dingledine
145e589b6c Resume using the correct "REASON=" stream when telling the 
controller why we closed a stream. Bugfix in 0.2.1.1-alpha.


svn:r17547
 2008-12-10 01:34:24 +00:00
Nick Mathewson
d60d8976b9 Better error message when told to setuid to ourself. 
svn:r17543
 2008-12-09 23:26:12 +00:00
Nick Mathewson
ab75c0d9e3 remove a bogus comment. Now that there is no undocumented synonym for EXTENDED_EVENTS, we do not need to point out that EXTENDED_EVENTS is documented 
svn:r17542
 2008-12-09 23:10:38 +00:00
Nick Mathewson
a7b4a7b9f8 Finally remove deprecated-since-0.1.2.4-alpha EXTENDED_FORMAT synonym for EXTENDED_EVENTS 
svn:r17538
 2008-12-09 19:55:19 +00:00
Nick Mathewson
3841e1b230 Bump version to 0.2.1.8-alpha-dev 
svn:r17537
 2008-12-09 18:18:48 +00:00
Nick Mathewson
0280a72500 Add a new status event for consensus arrival 
svn:r17535
 2008-12-09 18:16:41 +00:00
Nick Mathewson
07c8b2be21 Compile without warnings on mingw. 
svn:r17522
 2008-12-08 19:52:26 +00:00
Roger Dingledine
027a8cceed bump to 0.2.1.8-alpha 
svn:r17521
 2008-12-08 19:25:18 +00:00
Nick Mathewson
b32bac88e8 Mark DirPortFrontPage as a FILENAME rather than a STRING. Right now this has no effect. 
svn:r17520
 2008-12-08 18:00:34 +00:00
Roger Dingledine
b1c8fb7058 this function is no longer used. 
svn:r17515
 2008-12-08 00:09:28 +00:00
Roger Dingledine
e5be0504ab When the client is choosing entry guards, now it selects at most 
one guard from a given relay family. Otherwise we could end up with
all of our entry points into the network run by the same operator. 
Suggested by Camilo Viecco. Fix on 0.1.1.11-alpha.

Not a backport candidate, since I think this might break for users
who only have a given /16 in their reachableaddresses, or something
like that.


svn:r17514
 2008-12-08 00:04:29 +00:00
Roger Dingledine
f31c16d993 Directory mirrors no longer fetch the v1 directory or 
running-routers files. They are obsolete, and nobody asks for them
anymore. This is the first step to making v1 authorities obsolete.


svn:r17513
 2008-12-07 23:53:39 +00:00
Jacob Appelbaum
48aca3c999 Small whitespace fix to properly format if () {} statement. 
svn:r17503
 2008-12-07 01:51:56 +00:00
Jacob Appelbaum
f70146ca91 This helps return a better error message when the file supplied to DirPortFrontPage is missing. 
svn:r17502
 2008-12-07 01:48:30 +00:00
Roger Dingledine
21892d8a9c cleanups on r17500 
svn:r17501
 2008-12-07 01:34:45 +00:00
Jacob Appelbaum
6b178b46ef New DirPortFrontPage option that takes an html file and publishes it as "/" on the DirPort. Now relay operators can provide a disclaimer without needin to set up a separate webserver. There's a sample disclaimer in contrib/tor-exit-notice.html. 
svn:r17500
 2008-12-07 01:21:19 +00:00
Jacob Appelbaum
cf75162a0c Add comment clarifying OpenSSL usage. 
svn:r17498
 2008-12-07 01:14:49 +00:00
Nick Mathewson
6fb06f334a Try to fix windows mmap code. 
svn:r17493
 2008-12-05 19:36:35 +00:00
Nick Mathewson
af03faa1a6 Fix more leaks in test_util_memarea(). 
svn:r17491
 2008-12-05 02:25:39 +00:00
Nick Mathewson
7f793fa733 Simplify mmap object layout to avoid confusing static analysis tools, and us too. 
svn:r17490
 2008-12-05 02:17:41 +00:00
Nick Mathewson
475fbbbccc Fix a resource leak in test_dir_formats() 
svn:r17488
 2008-12-05 02:05:39 +00:00
Nick Mathewson
1affbd3464 Split test_util_smartlist into manageable chunks; make them free memory properly. 
svn:r17487
 2008-12-05 01:58:35 +00:00
Nick Mathewson
30377823c3 Add a few more tests to our tests so that our tests make sense to coverity. CIDs 139, 138, 137. 
svn:r17486
 2008-12-05 01:49:15 +00:00
Nick Mathewson
e06442b648 Add a couple of sanity-checks for return values that coverity thinks we ought to have. CIDs 337, 335. 
svn:r17485
 2008-12-05 01:35:49 +00:00
Nick Mathewson
2be5215181 Fix a hard-to-trigger memory leak in log_credential status. Found by Coverity scan. CID 349. 
svn:r17484
 2008-12-05 01:29:59 +00:00
Nick Mathewson
a26188cee9 fix bug 880: find the end of an authority cert by looking for the first ----END SIGNATURE----- after the first dir-key-certification, not for the first ----END SIGNATURE. Harmless bug, but it made us non-spec-compliant. 
svn:r17470
 2008-12-03 03:42:19 +00:00
Nick Mathewson
37bd9181f0 Do not use O_APPEND on fd-based operations that do not really want it; have them just lseek instead. 
svn:r17460
 2008-12-02 23:49:40 +00:00
Roger Dingledine
96a185d9b7 style cleanup 
svn:r17457
 2008-12-02 23:42:21 +00:00
Nick Mathewson
bd6b3072f9 Change logging code to use fds instead of stdio. Fixes bug 861, and probably makes logging slightly faster. Not a backport candidate: bug 861 is too obscure and harmless. 
svn:r17456
 2008-12-02 23:36:58 +00:00
Nick Mathewson
6221bdd294 Add two lseek wrappers to compat.[ch]: one to return current fd position, and one to move the fd to the end of the file. 
svn:r17454
 2008-12-02 23:26:04 +00:00
Roger Dingledine
330218c7f7 #include "orconfig.h" in tor-checkkey.c to see if we can resolve 
an obscure compile warning on solaris


svn:r17453
 2008-12-02 23:13:40 +00:00
Nick Mathewson
9c65195449 Apply rovv's patch for bug 864: avoid null error on detached signature handling failure. 
svn:r17446
 2008-12-02 19:13:23 +00:00
Nick Mathewson
60738daf85 Define socklen_t before using it in compat.h 
svn:r17444
 2008-12-02 18:54:47 +00:00
Roger Dingledine
2d8f7a4ff6 clarify that 'resolve' relay cells nul-terminate the hostname, just 
like 'begin' relay cells.


svn:r17442
 2008-12-02 17:35:05 +00:00
Roger Dingledine
984dc51f26 clean up some log messages 
svn:r17406
 2008-11-29 11:55:30 +00:00
Nick Mathewson
191197eff7 Revert my older supposed gcc-4.4 warning workaround. GCC was not being needlessly prissy; it was hinting at the wrongly pure smartlist_bsearch_idx. 
svn:r17396
 2008-11-26 17:14:59 +00:00
Nick Mathewson
651a0a2fb5 Stop marking bsearch_idx as pure; it is not. 
svn:r17393
 2008-11-26 16:57:46 +00:00
Nick Mathewson
4cddcf8873 Cast uid_t and gid_t to unsigned before passing to printf %u. 
svn:r17392
 2008-11-26 16:13:12 +00:00
Nick Mathewson
bc597758dc Use fcntl for file locking when flock() is not available. 
svn:r17391
 2008-11-26 16:10:56 +00:00
Roger Dingledine
a53ebd20f0 whitespace fix 
svn:r17379
 2008-11-24 02:02:48 +00:00
Nick Mathewson
c7910c3bc9 Consider GetNetworkParams() nameserver parsing to have suceeded if even one nameserver can be added. Log more useful info about what exactly is failing when we fail to add a nameserver. 
svn:r17368
 2008-11-22 21:46:34 +00:00
Nick Mathewson
07a08d933d Resolve a warning under gcc 4.4 trunk. 
svn:r17357
 2008-11-22 02:19:14 +00:00
Roger Dingledine
0b7a2a505e prepare_for_poll() -- plus its mysterious cousin, prepare_for_pool() -- 
are long gone.


svn:r17351
 2008-11-21 14:07:57 +00:00
Nick Mathewson
bdc0aec00a Update _log_global_min_severity after switch_logs_debug(), so that USR2 will work again. Bugfix on 0.1.2.8-beta. Spotted by Geoff Down. 
svn:r17317
 2008-11-17 19:58:51 +00:00
Nick Mathewson
0fa698d84f apply sebastian's bug 867 fix: make routerset_equal() work as documented with NULL arguments 
svn:r17287
 2008-11-16 18:25:20 +00:00
Karsten Loesing
6d7951c022 Fix a possible segfault when establishing an exit connection. Bugfix on 0.2.1.5-alpha. 
svn:r17275
 2008-11-16 01:52:44 +00:00
Nick Mathewson
c36ddcbabf Apparently sparc64 is way more strict about uint16_t access alignment than I had thought: it gave bus errors when messing with var-cell headers. Maybe this patch will fix bug 862. 
svn:r17262
 2008-11-12 14:41:44 +00:00
Nick Mathewson
a790a13705 define get_uint8 and set_uint8 macros to make code cleaner. 
svn:r17261
 2008-11-12 14:39:25 +00:00
Nick Mathewson
8f1952bf11 Be even _more_ careful when signatures are bogus. 
svn:r17252
 2008-11-11 17:14:12 +00:00
Nick Mathewson
3970c34f10 Only replace the detached signatures object when we actually added or replaced at least one signature. 
svn:r17250
 2008-11-11 16:52:07 +00:00
Nick Mathewson
997aea74dc Fix from rovv: when adding a detached signature, do not automatically assume it is good just because we are adding it. We might also be adding it because it was the first signature we saw for a given voter. 
svn:r17248
 2008-11-11 16:35:46 +00:00
Nick Mathewson
00a90177fa oops, remove debugging log message. 
svn:r17247
 2008-11-11 16:02:23 +00:00
Nick Mathewson
8157b8b766 be less aggressive about deleting expired certs. based on patch from rovv. partial fix for bug 854. 
svn:r17246
 2008-11-11 16:01:57 +00:00
Nick Mathewson
e08cbe2029 Add PURPOSE= field to getinfo circuit-status. With luck, controllers are ignoring extra fields (like they are supposed to) and this will not break any controllers. 
svn:r17245
 2008-11-11 15:59:24 +00:00
Nick Mathewson
a95e0e7355 apply sebastian's fix for bug 859. Apparently on win32 one must lock at least one byte when locking, but locking a nonexistant byte is okay. ) 
svn:r17244
 2008-11-11 15:29:40 +00:00
Nick Mathewson
6c50ab6e61 Document a couple of functions. 
svn:r17239
 2008-11-10 20:40:01 +00:00
Roger Dingledine
c62d5f6a5c beg nick for some documentation on the locking functions 
svn:r17233
 2008-11-10 00:48:13 +00:00
Roger Dingledine
0554e87f58 better error message when you set User but start tor as non-root. 
hopefully will address bug 857.


svn:r17232
 2008-11-10 00:41:07 +00:00
Roger Dingledine
4d8799b987 we missed a case when printing circuit purposes in circ events. 
svn:r17230
 2008-11-09 23:56:29 +00:00
Roger Dingledine
3dc433cc45 bump to 0.2.1.7-alpha-dev 
svn:r17229
 2008-11-09 23:32:38 +00:00
Nick Mathewson
13e079f9ec Log a little more when credential-switching fails. 
svn:r17228
 2008-11-09 16:54:54 +00:00
Roger Dingledine
5d19fe5124 bump to 0.2.1.7-alpha 
svn:r17217
 2008-11-08 06:43:32 +00:00
Nick Mathewson
9f1e06bd0e but to not attempt to download a specific certificate we already have. 
svn:r17214
 2008-11-07 15:01:49 +00:00
Nick Mathewson
bda4ca065c Aaaaand, do not reset the download count just because we have a certificate that is listed in a consensus. 
svn:r17212
 2008-11-07 14:57:14 +00:00
Nick Mathewson
aa405f29e6 fix up signs in r17208 
svn:r17211
 2008-11-07 14:17:46 +00:00
Nick Mathewson
5e2cdc1666 When we get a duplicated certificate, treat it as a failure and increment the download count. Do not claim to be downloading certificates that we merely want. 
svn:r17209
 2008-11-07 14:01:44 +00:00
Nick Mathewson
a15bdd3edd patch from karsten to not use or accept expired certs. fixes bug 851. 
svn:r17208
 2008-11-07 13:38:49 +00:00
Roger Dingledine
bc128c0b03 vidalia asks us for the value of the Group config option. but now 
it's obsolete. which causes us to inform the user every time, even
though the user can't do anything about it other than get confused.

now it's an info-level log by default.


svn:r17206
 2008-11-07 04:38:58 +00:00
Roger Dingledine
b32e600d50 while we're cleaning code, get rid of some unreachable code at 
the bottom of switch_id


svn:r17205
 2008-11-07 04:35:41 +00:00
Roger Dingledine
14773f42a7 now that we drop privs more thoroughly, switch_id() is no longer 
idempotent. so now we remember if we've succeeded, and if so we
don't even try.


svn:r17204
 2008-11-07 04:34:47 +00:00
Roger Dingledine
7c65792500 remove more redundant code from r17200 
svn:r17203
 2008-11-07 04:11:03 +00:00
Roger Dingledine
d27337bf17 i needed a piece of the 'patching patches' action too 
svn:r17202
 2008-11-07 03:39:19 +00:00
Nick Mathewson
1b98f45b3d Developers should usually configure with --enable-gcc-warnings, and should regularly make check-spaces. Also, int fn() does not mean the same in C as it does in C++ or Java. 
svn:r17201
 2008-11-07 02:53:46 +00:00
Steven Murdoch
9d68ed08e9 Patch from Jacob Appelbaum and me to make User option more robust, properly set supplementary groups, deprecated the Group option, and log more information on credential switching 
svn:r17200
 2008-11-07 02:06:12 +00:00
Nick Mathewson
6e3de8530e Remove bug 811/845 debugging code 
svn:r17199
 2008-11-07 01:50:37 +00:00
Nick Mathewson
a38026bb06 fix wide lines 
svn:r17198
 2008-11-07 01:48:55 +00:00
Nick Mathewson
3ebd1ebeca The chunk_size field in memarea_t was never actually set. Remove the whole thing. 
svn:r17195
 2008-11-05 20:34:22 +00:00
Nick Mathewson
35bef7fefd make read_all and write_all return ssize_t. 
svn:r17194
 2008-11-05 19:29:17 +00:00
Nick Mathewson
3f858b5b26 Fix a compile error found under pcc. It wants single-quites to be escaped in strings, it seems. 
svn:r17191
 2008-11-05 18:03:14 +00:00
Nick Mathewson
b56d1545db Fix freebsd 7 compile by adding malloc_np.h header. Fix bug 850. 
svn:r17190
 2008-11-05 15:56:53 +00:00
Karsten Loesing
b31e2c2491 (a - b) / 2 != a - (b / 2); this is the reason why tunneled directory requests and client-side introduction circuits don't time out after the intended 30 seconds (task #847). Bugfix on r17106. Found by miner. 
svn:r17189
 2008-11-05 10:40:29 +00:00
Nick Mathewson
73c6cb8353 Fix unit test failure related to intro point parsing. 
svn:r17188
 2008-11-03 16:36:15 +00:00
Nick Mathewson
3f84ed3d46 Add a new memcmpstart to use instead of strcmpstart when the thing we are comparing is not nul-terminated. 
svn:r17187
 2008-11-03 16:35:48 +00:00
Nick Mathewson
7b45d530b0 Add some debugging logs for bug 811/845. 
svn:r17186
 2008-11-03 15:46:05 +00:00
Roger Dingledine
ebe4ef12b9 when building preemptive circuits, ignore streams that have a 
chosen exit node in mind already. otherwise we get tricked into
trying to build a new circuit that will handle them.


svn:r17184
 2008-11-03 07:00:56 +00:00
Roger Dingledine
3e5a584d37 fix the other half of r17091. now that best_support can be -1, 
we were complaining about no support for our one-hop streams,
when in fact choose_good_exit_server_general() has no business
caring about one-hop streams. patch from miner.


svn:r17181
 2008-11-01 23:49:14 +00:00
Nick Mathewson
c534b96e58 Fix an assertion failure on double-marked circuits, and a double-mark. 
svn:r17179
 2008-11-01 20:27:41 +00:00
Nick Mathewson
0c9dfffe5a Implement the 0x20-hack to make DNS poisoning harder against us, especially when resolving large names. Add a cfg option to disable it, since apparently 3/10 of a percent of servers get it wrong. 
svn:r17171
 2008-10-29 19:20:02 +00:00
Nick Mathewson
c8a5e2d588 Work better with tools that resist DNS poisoning by using the 0x20 hack: make DNSPort replies perserve case. 
svn:r17170
 2008-10-29 15:31:26 +00:00
Nick Mathewson
361086005c Fix a possible negative shift in address comparison. May fix bug 845 and bug 811 
svn:r17169
 2008-10-29 13:29:54 +00:00
Nick Mathewson
accb4a680f make layer_hint check a little stricter. 
svn:r17164
 2008-10-27 16:57:18 +00:00
Nick Mathewson
ee31e0829e Verify cpath_layer match on rendezvous cells too. Fixes another case of bug 446. Based on patch from rovv. 
svn:r17162
 2008-10-27 16:46:45 +00:00
Nick Mathewson
0ab45fee73 Document some dmalloc stuff and some stupid C tricks. 
svn:r17161
 2008-10-27 16:30:52 +00:00
Karsten Loesing
c53f1f83e7 gabelmoo has a new IP address. 
svn:r17160
 2008-10-27 15:04:45 +00:00
Jacob Appelbaum
7873d324df This patch changes some of the code in util.c to refactor calls to 
dmalloc_malloc, dmalloc_realloc and dmalloc_strdup. It only calls those
functions if we're using the magic USE_DMALLOC macro. If we're not doing
that, we call the normal malloc, realloc and strdup. This is my first
night at malloc disambiguation club, so I had to disambiguate. Also, first commit, I have my commit bit now. Huzzzah!!!


svn:r17157
 2008-10-26 22:56:53 +00:00
Nick Mathewson
b166a43cb6 Fix another case of refusing to use a chosen exit node because we think it will reject _mostly_ everything. Based on patch from rovv. See bug 752. 
svn:r17139
 2008-10-21 17:09:04 +00:00
Nick Mathewson
5e762e6a5c Fix the rest of bug 619: reject *:* servers should not do DNS lookups, even if broken clients send them RELAY_BEGIN cells. Patch from rovv. 
svn:r17138
 2008-10-21 16:51:59 +00:00
Nick Mathewson
b593fd5c20 Patch from rovv: send back END cell in response to connect attempts to nonexistent hidden service port. 
svn:r17137
 2008-10-21 16:41:20 +00:00
Roger Dingledine
bca46cc628 backport candidate: 
The "ClientDNSRejectInternalAddresses" config option wasn't being
consistently obeyed: if an exit relay refuses a stream because its
exit policy doesn't allow it, we would remember what IP address
the relay said the destination address resolves to, even if it's
an internal IP address. Bugfix on 0.2.0.7-alpha; patch by rovv.


svn:r17135
 2008-10-17 22:08:49 +00:00
Roger Dingledine
e3127e874e fix grammar in a log message 
svn:r17131
 2008-10-16 17:13:28 +00:00
Roger Dingledine
bbf0f5a266 explain patch4 better. whee. 
svn:r17111
 2008-10-15 21:12:51 +00:00
Roger Dingledine
a5769eefa4 patch4 from proposal 155: 
Hidden services start out building five intro circuits rather
than three, and when the first three finish they publish a service
descriptor using those. Now we publish our service descriptor much
faster after restart.


svn:r17110
 2008-10-15 20:59:48 +00:00
Roger Dingledine
d06182f0bd add patch2 from proposal 155: 
Launch a second client-side introduction circuit in parallel
after a delay of 15 seconds (based on work by Christian Wilms).


svn:r17108
 2008-10-15 18:52:06 +00:00
Roger Dingledine
4520500cde put in karsten's patch #1 for proposal 155, modified 
svn:r17106
 2008-10-15 00:36:09 +00:00
Nick Mathewson
846e40d193 Patch from rovv: when we have no pending streams, choose exits with choose_good_exit_server_general() rather than with circuit_get_unhandled_ports() and friends. Bugfix on 0.1.1.x, at least. 
svn:r17091
 2008-10-14 17:05:52 +00:00
Roger Dingledine
d7cfa1f56c Minor fix in the warning messages when you're having problems 
bootstrapping; also, be more forgiving of bootstrap problems when
we're still making incremental progress on a given bootstrap phase.


svn:r17066
 2008-10-13 03:34:29 +00:00
Roger Dingledine
c9bddb24b2 another coverity-found memory leak 
svn:r17062
 2008-10-12 03:21:05 +00:00
Roger Dingledine
95aace5aae minor memory leak found by coverity 
svn:r17061
 2008-10-12 03:19:17 +00:00
Roger Dingledine
bb1f488dbe fix typo in log entry 
svn:r17050
 2008-10-08 10:47:23 +00:00
Roger Dingledine
e7f5a07ff4 Make rend_cache_store() use the same return error codes as its v2 
equivalent: I got a lonely "Failed to fetch rendezvous descriptor."
in my log file, even when the connection worked.


svn:r17028
 2008-10-02 07:32:13 +00:00
Roger Dingledine
e24b812a32 time for another alpha-dev cycle 
svn:r17023
 2008-10-01 08:26:57 +00:00
Roger Dingledine
c7af43a624 Now NodeFamily and MyFamily config options allow spaces in 
identity fingerprints, so it's easier to paste them in.
Suggested by Lucky Green.


svn:r17021
 2008-10-01 03:41:33 +00:00
Nick Mathewson
ccede03cc0 Switch a should-benee-dless check for an assert. 
svn:r17018
 2008-09-30 13:59:12 +00:00
Roger Dingledine
a04baf14b6 bump to 0.2.1.6-alpha, and note that the exclude*nodes config 
discussion hasn't finished.


svn:r17011
 2008-09-30 09:37:18 +00:00
Roger Dingledine
f2708dd40f a few more tweaks 
svn:r17010
 2008-09-30 09:32:26 +00:00
Roger Dingledine
49a250b208 i *think* this is equivalent. somebody should check me on it though. 
svn:r17009
 2008-09-30 08:45:40 +00:00
Roger Dingledine
7247838a25 v3 authorities write down all the votes they used for the consensus 
to the datadir, for debugging.


svn:r17008
 2008-09-29 23:13:43 +00:00
Nick Mathewson
25f8335528 Include circuit purposes in circuit events. Now all circuit events are extended; this makes the code simpler. 
svn:r17007
 2008-09-29 22:34:22 +00:00
Nick Mathewson
9d950f7d25 Nobody calls circuit_launch_by_nickname; remove it. 
svn:r17006
 2008-09-29 20:44:29 +00:00
Roger Dingledine
26aa741169 Remove the old v2 directory authority 'lefkada' from the default 
list. It has been gone for many months.


svn:r17005
 2008-09-29 19:27:20 +00:00
Nick Mathewson
ae3ce7b387 Patch from mwenge: update TrackHostExits mapping expiry times when the mappings are used, so that they expire a while after their last use, not a while after their creation. 
svn:r17004
 2008-09-29 14:53:53 +00:00
Nick Mathewson
57db1c1a7d Tweak the dbg-stability.txt code to log everything else that influences router stability calculations. 
svn:r17003
 2008-09-29 14:40:34 +00:00
Nick Mathewson
ee0078ead4 Make tor-resolve take a -p port option in addition to the current host:port syntax. 
svn:r17002
 2008-09-29 14:18:47 +00:00
Roger Dingledine
9678f166a8 If we have correct permissions on $datadir, we complain to stdout 
and fail to start. But dangerous permissions on
$datadir/cached-status/ would cause us to open a log and complain
there. Now complain to stdout and fail to start in both cases. Fixes
bug 820, reported by seeess.


svn:r16998
 2008-09-29 10:09:05 +00:00
Roger Dingledine
c846979ab7 Fix a bug where an unreachable relay would establish enough 
reachability testing circuits to do a bandwidth test -- if
we already have a connection to the middle hop of the testing
circuit, then it could establish the last hop by using the existing
connection. Bugfix on 0.1.2.2-alpha, exposed when we made testing
circuits no longer use entry guards in 0.2.1.3-alpha.


svn:r16997
 2008-09-29 09:36:42 +00:00
Nick Mathewson
99755f374d Fix 0/0 calculation in get_weighted_fractional_uptime(). 
svn:r16994
 2008-09-28 15:48:36 +00:00
Nick Mathewson
bb1685318c Commit fix for bug 807 from mwenge: send CLOSED controller event for reverse dns resolve, not FAILED. 
svn:r16985
 2008-09-26 20:25:35 +00:00
Nick Mathewson
745e5b0e22 Make sure ExcludeSingleHopRelays works for an exit. 
svn:r16984
 2008-09-26 19:09:12 +00:00
Nick Mathewson
e147e867be Proposal 152 implementation from Josh Albrecht, with tweaks. 
svn:r16983
 2008-09-26 18:58:45 +00:00
Nick Mathewson
87eb230c01 Put the start-of-downtime value in the start-of-downtime buffer so that we do not put junk in the dbg-stability.txt file 
svn:r16982
 2008-09-26 18:31:22 +00:00
Nick Mathewson
e7e12236ac Code to serve a current stability calculations from /tor/dbg-stability.txt. Untested: somebody please run this on an authority and let me know if it is broken. 
svn:r16981
 2008-09-26 18:02:48 +00:00
Nick Mathewson
283b95e463 Make tests pass again by adding an opt hidden-service-dir to the example routerinfo output. 
svn:r16980
 2008-09-26 17:58:35 +00:00
Nick Mathewson
ae33d3ead7 Apply rovv's fix for bug 824. 
svn:r16975
 2008-09-26 15:30:26 +00:00
Nick Mathewson
02c71a7eb4 Widen the conditions under which we whine about not having a geoip file to include "a country code was configured in a node list." 
svn:r16968
 2008-09-25 21:06:32 +00:00
Nick Mathewson
e06f140f97 Whitespace fixes. 
svn:r16967
 2008-09-25 20:22:17 +00:00
Nick Mathewson
8bbbbaf87b Add country-code support to configured node lists to implement the ever-popular "no exits in Monaco" feature (ExcludeExitNodes {MC}). Also allow country codes and IP ranges in ExitNodes. (EntryNodes needs more work.) Based on code by Robert Hogan. Needs more testing. 
svn:r16966
 2008-09-25 20:21:35 +00:00
Nick Mathewson
b2c7090da6 Make it easier for dmalloc to see if keys are leaking; remove a test-only key leak. 
svn:r16965
 2008-09-25 17:37:00 +00:00
Nick Mathewson
06f96363fd Remove now-needless _tor_dmalloc_free helper. 
svn:r16964
 2008-09-25 17:36:09 +00:00
Nick Mathewson
a7e383af19 More test memory-management fixes 
svn:r16963
 2008-09-25 15:20:38 +00:00
Karsten Loesing
f2ff3e74ae All relays now store and serve v2 hidden service descriptors by default (not only directory mirrors). 
svn:r16961
 2008-09-24 22:33:47 +00:00
Karsten Loesing
9a7098487b If we are not using BEGIN_DIR cells, don't attempt to contact hidden service directories with non-open dir port. 
svn:r16960
 2008-09-24 22:29:22 +00:00
Nick Mathewson
7f805aca2b Split test_crypto() into manageable pieces. 
svn:r16959
 2008-09-24 20:55:38 +00:00
Karsten Loesing
5f457e4fa6 Minor correction of commentation. 
svn:r16958
 2008-09-24 17:33:07 +00:00
Nick Mathewson
8bc1536a9e Add patch 4 from Karsten for proposal 121, slightly modified. Karsten should definitely re-review the bits I changed. 
svn:r16955
 2008-09-24 14:44:29 +00:00
Roger Dingledine
982a22a121 fix typo 
svn:r16949
 2008-09-24 00:49:29 +00:00
Nick Mathewson
75977fd79b Patch from roger for 752, but with more comments: When we get an A.B.exit:P address, and B would reject most connections to P, but we do not know whether it would allow A, then allow the connection to procede. Bugfix, amusingly, on 0.0.9rc5. 
svn:r16944
 2008-09-23 20:25:01 +00:00
Nick Mathewson
545b317e1f Fix for bug 797 (by arma, with tweaks): always use create_fast for circuits where we do not know an onion key. 
svn:r16942
 2008-09-23 20:13:23 +00:00
Nick Mathewson
f28fc83ea5 More logging for mtbf/wfu calculations. 
svn:r16941
 2008-09-23 18:24:20 +00:00
Roger Dingledine
29abfab8bf Update to the "September 1 2008" ip-to-country file. 
svn:r16940
 2008-09-23 09:51:05 +00:00
Karsten Loesing
e4942e809e Exclude v0 rendezvous descriptors when considering republication. 
svn:r16939
 2008-09-23 09:30:57 +00:00
Roger Dingledine
6a7abbd25d ok, but inaccurate error strings worse 
svn:r16938
 2008-09-23 08:57:30 +00:00
Roger Dingledine
0fc0d5266c identical error strings in different contexts bad 
svn:r16937
 2008-09-23 08:54:03 +00:00
Nick Mathewson
b0c48d8e45 Oops; we need to make sure that DNS request names are matched in the _questions_ section of the replies. Rejecting answers whether the _answers_ section did not match made us reject A records waiting at the end of a CNAME record. Bug 823. 
svn:r16933
 2008-09-22 20:06:25 +00:00
Roger Dingledine
4fd9880540 give rend_client_desc_here a slightly more accurate name 
svn:r16916
 2008-09-16 10:26:15 +00:00
Roger Dingledine
38f2272d5d patch from karsten for bug 814. whew. 
svn:r16915
 2008-09-16 10:17:04 +00:00
Nick Mathewson
3db8c15287 Add a circuit_conforms_to_options() function for use in debugging paths [and inother stuff too]. Untested, and so far unused. 
svn:r16914
 2008-09-15 22:29:47 +00:00
Roger Dingledine
2bde30efa6 read_to_buf should take an int *error_socket and return it. 
svn:r16909
 2008-09-14 08:35:41 +00:00
Roger Dingledine
7f2fd34645 stop telling us every time we fetch a consensus. that's not really news. 
svn:r16908
 2008-09-14 07:17:44 +00:00
Roger Dingledine
dbb481c169 Serve the latest v3 networkstatus consensus via the control 
port. Use "getinfo dir/status-vote/current/consensus" to fetch it.


svn:r16907
 2008-09-14 04:07:29 +00:00
Roger Dingledine
4045ef72f5 make it explicit that the uncompressed cached dir items are nul-terminated 
(they are, but now we should keep them that way)


svn:r16906
 2008-09-14 03:36:54 +00:00
Roger Dingledine
2d95accc75 Allow ports 465 and 587 in the default exit policy again. We had 
rejected them in 0.1.0.15, because back in 2005 they were commonly
misconfigured and ended up as spam targets. We hear they are better
locked down these days.


svn:r16898
 2008-09-13 10:04:42 +00:00
Karsten Loesing
f0a5ef804f Directory mirrors store and serve v2 hidden service descriptors by default. 
svn:r16858
 2008-09-11 20:06:04 +00:00
Nick Mathewson
b322348e8a Fix more actual test leaks 
svn:r16831
 2008-09-10 05:34:03 +00:00
Nick Mathewson
45205126fe Fix some apparent leaks in voting. If authorities suddenly start segfaulting, this could be a patch to look harder at. 
svn:r16830
 2008-09-10 05:33:49 +00:00
Nick Mathewson
aa69d586ea Make buffer unit tests handle resource leaks properly. 
svn:r16823
 2008-09-10 00:16:32 +00:00
Nick Mathewson
38f56608d9 Make more unit tests handle resource leaks properly. 
svn:r16822
 2008-09-10 00:11:53 +00:00
Karsten Loesing
52fbfc5d45 Correct indentation. 
svn:r16819
 2008-09-09 22:19:41 +00:00
Roger Dingledine
659f1651e0 tweak karsten's patch 
svn:r16818
 2008-09-09 21:09:15 +00:00
Roger Dingledine
2c14705a4d patch from karsten to fix more of bug 767 
svn:r16817
 2008-09-09 21:08:02 +00:00
Nick Mathewson
f95d7c189b Refactor unit test macros and tor_free_all() logic a bit so as to make it easier to free memory on failing tests, in order to suppress scanner warnings and to make dmalloc() usable with tests. 
svn:r16816
 2008-09-09 20:43:31 +00:00
Nick Mathewson
6c432a5565 Replace the dummy-use var in SMARTLIST_FOREACH_END() with one that is less likely to confuse analysis tools into thinking we do use after free. Arguably, (void)x should count as use in suppressing unused variable warnings, but not in generating hey-you-used-a-variable warnings. Arguably, though, it shouldn't. 
svn:r16815
 2008-09-09 19:29:33 +00:00
Roger Dingledine
fa64d8041f minor cleanups on karsten's patch 
svn:r16810
 2008-09-09 09:21:21 +00:00
Roger Dingledine
ef7af1d61e karsten's patch for bug 767. 
svn:r16808
 2008-09-09 08:41:58 +00:00
Roger Dingledine
d37fae2f4e Catch and report a few more bootstrapping failure cases when Tor 
fails to establish a TCP connection. Cleanup on 0.2.1.x.


svn:r16803
 2008-09-09 06:25:39 +00:00
Nick Mathewson
aacda9cd8e We should not alter an addr_policy_t that has been canonicalized. 
svn:r16802
 2008-09-09 03:48:01 +00:00
Nick Mathewson
baeb260ad1 Refactor use of connection_new so that we get more verifiable typesafety. 
svn:r16785
 2008-09-05 22:09:44 +00:00
Nick Mathewson
339f094056 Refactor some code and add some asserts based on scanner results. 
svn:r16783
 2008-09-05 21:19:53 +00:00
Nick Mathewson
a345506672 Add an assert to make tools happier. 
svn:r16782
 2008-09-05 20:59:09 +00:00
Nick Mathewson
d5b2dab31d Fix a malloc that should have been a tor_malloc 
svn:r16780
 2008-09-05 20:53:39 +00:00
Nick Mathewson
0b8117a5c0 Fix numerous memory leaks: some were almost impossible to trigger, and some almost inevitable. 
svn:r16779
 2008-09-05 20:52:15 +00:00
Nick Mathewson
4d94e061c7 Clean up some redundant stuff in crypto_dh_new(). 
svn:r16778
 2008-09-05 20:18:22 +00:00
Nick Mathewson
a56a072f29 It is probably some kind of misdeed to say for (i=0;i<2;++i) { A=i?x:y; foo(bar(A)); } rather than foo(bar(x)); foo(bar(y)); . Also, it can confuse tools. 
svn:r16777
 2008-09-05 20:04:27 +00:00
Nick Mathewson
a6ea2b056a Fix a memory leak in tor-gencert.c 
svn:r16776
 2008-09-05 19:55:04 +00:00
Nick Mathewson
8ea780632f Make severity args to add_*_log() functions be const 
svn:r16775
 2008-09-05 19:52:44 +00:00