Nick Mathewson
5126bc2ebd
Extra tests for tor_memeq and memcmp
...
(Patch from teor; part of 13104)
2014-09-10 23:58:02 -04:00
Nick Mathewson
d2463c0cfe
Avoid overflows and underflows in sscanf and friends
...
(Patch from teor on 13104)
2014-09-10 23:57:31 -04:00
Nick Mathewson
73ee161d8a
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-10 23:48:59 -04:00
Nick Mathewson
3c2c6a6116
In routerlist_assert_ok(), check r2 before taking &(r2->cache_info)
...
Technically, we're not allowed to take the address of a member can't
exist relative to the null pointer. That makes me wonder how any sane
compliant system implements the offsetof macro, but let's let sleeping
balrogs lie.
Fixes 13096; patch on 0.1.1.9-alpha; patch from "teor", who was using
clang -fsanitize=undefined-trap -fsanitize-undefined-trap-on-error -ftrapv
2014-09-10 23:48:11 -04:00
Nick Mathewson
e07206afea
Merge remote-tracking branch 'yawning/bug_8402'
2014-09-10 23:41:55 -04:00
Nick Mathewson
5474d8ae05
Merge remote-tracking branch 'public/torrc_minimal'
2014-09-10 23:36:27 -04:00
Nick Mathewson
93dfb12037
Remember log messages that happen before logs are configured
...
(And replay them once we know our first real logs.)
This is an implementation for issue 6938. It solves the problem of
early log mesages not getting sent to log files, but not the issue of
early log messages not getting sent to controllers.
2014-09-10 23:34:43 -04:00
Nick Mathewson
6e2ef4bc5e
Refactor the 'deliver a log message' logic to its own function.
2014-09-10 22:58:36 -04:00
Nick Mathewson
de114587f0
Turn log loop into a for loop, and "Does this lf want this" into a fn
2014-09-10 22:39:55 -04:00
Nick Mathewson
15a318b49a
Refactor pending_cb_message_t into a type with proper functions
...
Also, rename it.
2014-09-10 22:35:16 -04:00
Nick Mathewson
a9b2e5eac6
Merge remote-tracking branch 'public/bug12908_025' into maint-0.2.5
2014-09-10 22:12:47 -04:00
Nick Mathewson
916d53d6ce
Mark StrictE{ntry,xit}Nodes as obsolete.
2014-09-10 07:10:10 -04:00
Yawning Angel
cae44838fe
Fix issues brought up in nickm's review.
...
* Update pt_get_proxy_uri() documentation.
* proxy_supported is now unsigned.
* Added a changes file.
2014-09-09 18:21:19 +00:00
George Kadianakis
01800ea1e4
Add unittests for finding the third quartile of a set.
2014-09-09 12:28:15 -04:00
Nick Mathewson
8e39395199
Merge remote-tracking branch 'asn/bug13064'
2014-09-09 12:26:16 -04:00
Nick Mathewson
40b7dfaed2
Remove now-pointless SIZE_MAX stanza from OpenBSD_malloc_linux
2014-09-09 12:09:18 -04:00
Nick Mathewson
1eea7a68ed
Use S?SIZE_MAX, not S?SIZE_T_MAX
...
This fixes bug 13102 (not on any released Tor) where using the
standard SSIZE_MAX name broke mingw64, and we didn't realize.
I did this with
perl -i -pe 's/SIZE_T_MAX/SIZE_MAX/' src/*/*.[ch] src/*/*/*.[ch]
2014-09-09 12:08:03 -04:00
Sebastian Hahn
409a56281e
Remove client-side bad directory logic
...
Implements the second half of #13060 .
2014-09-09 11:54:20 -04:00
Sebastian Hahn
8099dee992
Remove dirauth support for the BadDirectory flag
...
Implements the first half of #13060 . The second half will be to remove
client support, too.
2014-09-09 11:54:15 -04:00
Nick Mathewson
59f3cce0dc
Merge branch 'bug12899_squashed'
2014-09-09 11:51:18 -04:00
Sebastian Hahn
607724c696
Remove support for naming directory authorities
...
This implements the meat of #12899 . This commit should simply remove the
parts of Tor dirauths used to check whether a relay was supposed to be
named or not, it doesn't yet convert to a new mechanism for
reject/invalid/baddir/badexiting relays.
2014-09-09 11:50:21 -04:00
Nick Mathewson
4af88d68b4
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-09 11:05:28 -04:00
Nick Mathewson
8eed82b3d4
Merge remote-tracking branch 'andrea/bug12160_025' into maint-0.2.5
2014-09-09 11:04:54 -04:00
Nick Mathewson
619bd43a5e
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-09 10:57:09 -04:00
Nick Mathewson
dd22ab519a
Merge remote-tracking branch 'public/bug12700_024' into maint-0.2.5
2014-09-09 10:51:39 -04:00
Nick Mathewson
a9d24f3304
Updated building-tor-msvc.txt
2014-09-09 10:33:45 -04:00
Nick Mathewson
4e98ec8149
Add instructions for building Tor with MSVC.
...
Written by "NewEraCracker" on ticket 13081; I've added a note that
this is not our preferred or supported build method.
2014-09-09 10:30:57 -04:00
Nick Mathewson
2997908228
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-09 10:27:41 -04:00
Nick Mathewson
8391c96091
Clean up the MVSC nmake files so they work again.
...
Fixes bug 13081; bugfix on 0.2.5.1-alpha. Patch from "NewEraCracker."
2014-09-09 10:27:05 -04:00
Nick Mathewson
ad0ae89b3c
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-09 10:22:42 -04:00
Nick Mathewson
a3c49ca79a
Add more escaped() calls in directory.c
...
Patch from teor to fix 13071.
2014-09-09 10:22:01 -04:00
Nick Mathewson
2ecaa59bd7
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-08 15:16:45 -04:00
Nick Mathewson
d229025fef
Expand the event_mask field in controller conns to 64 bits
...
Back in 078d6bcd
, we added an event number 0x20, but we didn't make
the event_mask field big enough to compensate.
Patch by "teor". Fixes 13085; bugfix on 0.2.5.1-alpha.
2014-09-08 15:16:02 -04:00
Nick Mathewson
781b477bc8
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-08 15:08:51 -04:00
Nick Mathewson
f551a053e3
Add cscope generated files to .gitignore.
...
Closes #13092 ; patch from dgoulet.
2014-09-08 15:07:54 -04:00
George Kadianakis
0f50f5f373
Evaluate TestingDirAuthVoteGuard only after filling all rs elements.
2014-09-06 14:37:41 +03:00
Andrea Shepard
39a017809b
Correctly update channel local mark when address of incoming connection changes after handshake; fixes bug #12160
2014-09-05 11:12:08 -07:00
David Stainton
b59fd2efb6
Fix permissions logic
2014-09-04 22:21:30 +00:00
Sebastian Hahn
8356721662
Fix add_fingerprint_to_dir() doc and signature
...
This function never returns non-null, but its usage doesn't reflect
that. Let's make it explicit. This will be mostly overridden by later
commits, so no changes file here.
2014-09-04 22:22:56 +02:00
Sebastian Hahn
10fe5bad9a
Remove the AuthDirRejectUnlisted config option
...
This is in preparation for a big patch series removing the entire Naming
system from Tor. In its wake, the approved-routers file is being
deprecated, and a replacement option to allow only pre-approved routers
is not being implemented.
2014-09-04 06:25:38 +02:00
Nick Mathewson
7573e66b99
Treat Z_BUF_ERROR as TOR_ZLIB_BUF_FULL when finalizing a zlib buffer
...
Otherwise, when we're out of input *and* finalizing, we might report
TOR_ZLIB_OK erroneously and not finalize the buffer.
(I don't believe this can happen in practice, with our code today:
write_to_buf_zlib ensures that we are never trying to write into a
completely empty buffer, and zlib says "Z_OK" if you give it even
one byte to write into.)
Fixes bug 11824; bugfix on 0.1.1.23 (06e09cdd47
).
2014-09-03 13:42:46 -04:00
Nick Mathewson
54348201f7
Merge remote-tracking branch 'intrigeri/bug12939-systemd-no-new-privileges'
...
Conflicts:
contrib/dist/tor.service.in
2014-09-03 13:29:43 -04:00
Nick Mathewson
f58cdb3be7
Merge remote-tracking branch 'intrigeri/bug12751-systemd-filesystem-sandbox'
2014-09-03 13:28:46 -04:00
David Stainton
59e052b896
Remove HiddenServiceDirGroupReadable from or_options_t
...
...and also fix whitespace.
2014-09-03 17:22:15 +00:00
Nick Mathewson
ed8f020e20
Fix a couple of small memory leaks on failure cases.
...
[CID 1234702, 1234703]
2014-09-03 10:59:39 -04:00
Nick Mathewson
c4d0d30bf3
Fix some 'dereference-before-null-check' warnings in test_circuitlist.c
...
Found by Coverity Scan.
[CID 1234704, 1234705, 1234706]
2014-09-03 10:59:10 -04:00
Nick Mathewson
0e66edb254
Fix the leaks that valgrind found in the new routerset tests.
...
(We have a tests-shouldn't-leak policy so that we won't accidentally
ignore true-positives.)
2014-09-03 09:51:14 -04:00
David Stainton
7203040835
Fix regression nickm pointed out
2014-09-03 03:53:32 +00:00
Nick Mathewson
9ab35b0a2e
Use 'Bytes', not 'B', in torrc.sample.
...
Also put this change into torrc.minimal.in-staging
Closes ticket 10343
2014-09-02 19:18:21 -04:00
Magnus Nord
d0113a0c2a
Fix: typo in torrc.sample.in
2014-09-02 19:16:16 -04:00