Nick Mathewson
6a27dd8284
r12595@catbus: nickm | 2007-04-30 18:32:34 -0400
...
Move private function declarations from crypto.c into a new #ifdef CRYPTO_PRIVATE block in crypto.h
svn:r10074
2007-04-30 22:42:50 +00:00
Nick Mathewson
22f2f30a33
r12591@catbus: nickm | 2007-04-30 16:50:03 -0400
...
Minimize the libraries that we link things against: there is no reason to link tor-resolve against zlib, openssl, or libevent, for example.
svn:r10072
2007-04-30 20:50:09 +00:00
Nick Mathewson
e97a6dd01f
r12587@catbus: nickm | 2007-04-30 15:47:39 -0400
...
Backport candidate: correctly set the purpose of routers that are inserted by the controller with purpose=controller.
svn:r10071
2007-04-30 19:48:45 +00:00
Nick Mathewson
0390a0499c
r12586@catbus: nickm | 2007-04-30 15:43:05 -0400
...
More work for proposal 104: actually cache extrainfo documents to disk, and reload the cache properly.
svn:r10070
2007-04-30 19:48:39 +00:00
Nick Mathewson
ae40e7f633
r12585@catbus: nickm | 2007-04-30 14:38:37 -0400
...
(Needs review.) Allow directory authorities to accept multiple router descriptors and extra info documents in a single POST. This will make implementing the client side of proposal 104 a lot simpler.
svn:r10069
2007-04-30 19:48:33 +00:00
Nick Mathewson
b27b09ae1e
r12581@catbus: nickm | 2007-04-30 13:39:21 -0400
...
Minor cleanups on hidden service usage patch from Karsten: tidy documentation; make free_all idempotent (and safe to call even if we have not yet initialized rephist); and stop using "l" as a variable name (it is too easy to confuse with "1").
svn:r10068
2007-04-30 17:46:19 +00:00
Nick Mathewson
18ba9fe81f
r12580@catbus: nickm | 2007-04-30 13:29:05 -0400
...
Initial version of patch from Karsten Loesing: Add an HSAuthorityRecordStats option to track statistics of overall hidden service usage without logging information that would be useful to an attacker.
svn:r10067
2007-04-30 17:46:13 +00:00
Nick Mathewson
6875559c49
r12579@catbus: nickm | 2007-04-30 13:26:53 -0400
...
Oops. Routerlist_check_bug_417 should work even if we are not on a server.
svn:r10066
2007-04-30 17:46:11 +00:00
Nick Mathewson
f2db099fc0
r12571@catbus: nickm | 2007-04-30 10:51:52 -0400
...
Check for more HAVE_* header defines when building eventdns.c
svn:r10063
2007-04-30 14:52:07 +00:00
Nick Mathewson
ee5a378665
r12570@catbus: nickm | 2007-04-30 10:49:50 -0400
...
Add an extra lock to try to get unit tessts passing reliably again.
svn:r10062
2007-04-30 14:52:05 +00:00
Nick Mathewson
566cdcd0c2
r12569@catbus: nickm | 2007-04-30 10:48:51 -0400
...
Do not use micro-revision.i on MSVC; it will only be useful to people who have make.
svn:r10061
2007-04-30 14:52:02 +00:00
Nick Mathewson
5b26a076c6
Oops; the "not in the routerlist" value for routerinfo_t.routerlist_index is -1, not 0.
...
svn:r10060
2007-04-30 14:32:22 +00:00
Nick Mathewson
65daa191fe
r12567@catbus: nickm | 2007-04-30 10:26:35 -0400
...
Suggested by weasel: Add a fast function to check for the common failure mode for bug 417/404, and call it a lot.
svn:r10059
2007-04-30 14:26:38 +00:00
Nick Mathewson
43385b9bc9
r12565@catbus: nickm | 2007-04-30 10:09:07 -0400
...
Misc cleanup and bulletproofing on r10056.
svn:r10058
2007-04-30 14:09:11 +00:00
Nick Mathewson
420df2ce15
r12559@catbus: nickm | 2007-04-30 09:17:54 -0400
...
Fix bug 421: Only set the revision number from SVK if we have a runnable svk _and_ a ~/.svk directory.
svn:r10057
2007-04-30 13:17:57 +00:00
Roger Dingledine
5ba4eaba1c
Let the controller specify HOP=%d as an argument to ATTACHSTREAM,
...
so we can exit from the middle of the circuit.
svn:r10056
2007-04-30 11:10:45 +00:00
Roger Dingledine
7fb4365cd3
Add a new config option __DisablePredictedCircuits designed for
...
use by the controller, when we don't want Tor to build any circuits
preemptively.
svn:r10054
2007-04-30 09:18:48 +00:00
Nick Mathewson
313ac313be
r12557@catbus: nickm | 2007-04-30 01:36:39 -0400
...
Oops; the rest of the last patch. If that one gets backported, this should too.
svn:r10053
2007-04-30 05:36:41 +00:00
Nick Mathewson
f7acc3cfa0
r12553@catbus: nickm | 2007-04-30 01:32:54 -0400
...
Backport candidate: Add asserts to dirserv_remove_invalid, and fix a bug in dirserv_remove_invalid that could mess with pointers in a freed routerinfo right after it was freed.
svn:r10052
2007-04-30 05:32:57 +00:00
Roger Dingledine
2d56d883c2
minor cleanups
...
svn:r10050
2007-04-30 04:00:06 +00:00
Nick Mathewson
105d782109
r12546@catbus: nickm | 2007-04-29 21:27:43 -0400
...
Correctly report win98se and win95osr2 versions.
svn:r10047
2007-04-30 01:27:47 +00:00
Nick Mathewson
e0b0c2a4d2
r12544@catbus: nickm | 2007-04-29 21:08:58 -0400
...
Fix an assertion when we call tor_free_all before calling do_main_loop(). Discovered by weasel.
svn:r10046
2007-04-30 01:09:03 +00:00
Roger Dingledine
397afcc3f6
Make PreferTunneledDirConns and TunnelDirConns work even when
...
we have no cached directory info. This means Tor clients can now
do all of their connections protected by TLS.
svn:r10035
2007-04-27 10:26:09 +00:00
Roger Dingledine
3d00738ec7
simplify connection_watch_events()
...
hope this doesn't break it
svn:r10025
2007-04-25 07:20:04 +00:00
Roger Dingledine
7c5f65c226
fix an assert error in r9995 (unlikely to happen, but still)
...
svn:r10024
2007-04-25 07:04:53 +00:00
Roger Dingledine
7b11f2c843
stop generating a 6-gig info-level log file after a day of running
...
svn:r10023
2007-04-25 06:10:16 +00:00
Roger Dingledine
5bdb138d11
cleanups, and note a bug
...
svn:r10022
2007-04-25 06:05:46 +00:00
Nick Mathewson
94eef608ae
r12784@Kushana: nickm | 2007-04-23 19:24:09 -0400
...
Avoid another assert failure in the new buffer memory code. (This time, it hit when freeing a 4k buffer with some data on it.)
svn:r10011
2007-04-23 23:24:53 +00:00
Nick Mathewson
3831d77dba
r12782@Kushana: nickm | 2007-04-23 18:20:19 -0400
...
Avoid a segfault when freeing a buffer with size 0.
svn:r10010
2007-04-23 22:20:45 +00:00
Nick Mathewson
2f4784cbd8
r12499@catbus: nickm | 2007-04-23 10:42:23 -0400
...
Keep a freelist of unused 4k buffer chunks, rather than wasting 8k for every inactive connection_t.
svn:r10006
2007-04-23 14:42:27 +00:00
Nick Mathewson
473c266fc2
r12496@catbus: nickm | 2007-04-22 23:04:05 -0400
...
When logging memory usage, break down memory used in buffers by buffer type.
svn:r10004
2007-04-23 03:04:46 +00:00
Nick Mathewson
5cf600b57a
r12492@catbus: nickm | 2007-04-22 20:24:02 -0400
...
Even more asserts to try to catch bug 404/417.
svn:r10003
2007-04-23 00:24:06 +00:00
Nick Mathewson
87b5928202
r12485@catbus: nickm | 2007-04-21 13:46:14 -0400
...
Document some fields in or.h
svn:r9998
2007-04-21 17:46:22 +00:00
Nick Mathewson
fb065724f7
r12484@catbus: nickm | 2007-04-21 13:45:58 -0400
...
Suppress display of version-detection junk in Makefile.am
svn:r9997
2007-04-21 17:46:17 +00:00
Nick Mathewson
bbd63a9ae0
r12482@catbus: nickm | 2007-04-21 13:30:24 -0400
...
Rename a couple of confusing fields
svn:r9996
2007-04-21 17:30:42 +00:00
Nick Mathewson
648065fcb4
r12763@Kushana: nickm | 2007-04-20 18:42:58 -0400
...
Initial version of code to stop using socket pairs for linked connections. Superficially, it seems to work, but it probably needs a lot more testing and attention.
svn:r9995
2007-04-21 17:26:12 +00:00
Nick Mathewson
227b2e0226
r12759@Kushana: nickm | 2007-04-20 08:47:20 -0400
...
Track the number of connection_t separately from the number of open sockets. It is already possible to have connections that do not count: resolving conns, for one. Once we move from socketpairs to linked conns, and once we do dns proxying, there will be lots of such connections.
svn:r9994
2007-04-21 17:24:18 +00:00
Nick Mathewson
6ee5bef092
r12458@catbus: nickm | 2007-04-19 15:52:23 -0400
...
Fix a bug in displaying memory pool usage. Also dump cell allocation, and track padded_cell_ts as they are allocated and freed, to make sure we are not leaking cells.
svn:r9992
2007-04-19 19:52:30 +00:00
Nick Mathewson
7392464b88
r12456@catbus: nickm | 2007-04-19 14:47:01 -0400
...
Make dumpmemusage() dump cell pool usage information.
svn:r9991
2007-04-19 18:47:04 +00:00
Nick Mathewson
bf4f0539cf
r12434@catbus: nickm | 2007-04-19 11:23:35 -0400
...
When advancing a string pointer, make sure we do not later free the altered pointer. Fixes bug 416, introduced in r9971.
svn:r9990
2007-04-19 15:23:38 +00:00
Nick Mathewson
addf2987c5
r12429@catbus: nickm | 2007-04-18 15:28:41 -0400
...
Make svn revision number visible in version even if building from a .tar.gz. This was remarkably painless.
svn:r9988
2007-04-18 19:28:47 +00:00
Nick Mathewson
a973611834
r12425@catbus: nickm | 2007-04-17 17:16:38 -0400
...
Detect the svn version correctly when building from an svk checkout too. Whee, fun with bash and make.
svn:r9985
2007-04-17 21:16:40 +00:00
Nick Mathewson
00941b0171
r12418@catbus: nickm | 2007-04-16 20:58:25 -0400
...
Twiddle tor_version_as_new_as() so we can check for particular svn revisions. With unit tests, for added freshness.
svn:r9977
2007-04-17 00:58:30 +00:00
Nick Mathewson
bfac679cd4
A hack I've been wanting for a while: when building a -dev version
...
from an SVN repository, use the current svn revision in the platform
string and in the output of --version.
svn:r9976
2007-04-16 23:56:31 +00:00
Nick Mathewson
362fbc79d2
r12414@catbus: nickm | 2007-04-16 17:37:17 -0400
...
More proposal-104 stuff: actually remember extra-info stuff.
svn:r9975
2007-04-16 21:37:21 +00:00
Nick Mathewson
17e83a408f
Fix some proposal-104 bugs.
...
svn:r9972
2007-04-16 18:54:56 +00:00
Nick Mathewson
6d32d9cb2d
r12406@catbus: nickm | 2007-04-16 14:39:33 -0400
...
More proposal-104 stuff: add most of the code for authorities to accept and serve extra-info documents. The back-end to store the things is missing.
svn:r9971
2007-04-16 18:39:39 +00:00
Nick Mathewson
2bb5e64289
r12403@catbus: nickm | 2007-04-16 13:55:03 -0400
...
Code to generate extrainfo whenever routerdesc is regenerated; code to check extrainfo against routerdesc.
svn:r9970
2007-04-16 17:55:08 +00:00
Nick Mathewson
7fb7658a45
r12401@catbus: nickm | 2007-04-16 12:28:01 -0400
...
Enforce checks for number of arguments to items in directory objects more uniformly.
svn:r9968
2007-04-16 16:28:06 +00:00
Nick Mathewson
a67f8a3787
r12388@catbus: nickm | 2007-04-16 00:17:29 -0400
...
Now that the directory parser checks for missing items, the rest of the code can just assert that they are there, rather than checking a second time.
svn:r9966
2007-04-16 04:18:29 +00:00
Nick Mathewson
cf02ab6d39
r12387@catbus: nickm | 2007-04-16 00:06:40 -0400
...
Refactor router/directory parsing backend: use a separate token table for everything that we parse, and enforce the correct count of each item.
svn:r9965
2007-04-16 04:18:21 +00:00
Nick Mathewson
5b220f65c8
r12385@catbus: nickm | 2007-04-15 22:55:58 -0400
...
Initial code to parse extra-info documents as described in proposal 104. This is making me realize that the parsing code in routerparse.c is a little daft.
svn:r9963
2007-04-16 04:17:58 +00:00
Nick Mathewson
7467c35249
r12353@catbus: nickm | 2007-04-11 15:58:46 -0400
...
Apparently some compilers think that anonymous unions are bad C. Technically, they're right, so let's name the union in mempool.c.
svn:r9946
2007-04-11 19:58:51 +00:00
Nick Mathewson
795aa1a196
r12351@catbus: nickm | 2007-04-11 12:09:46 -0400
...
More autoconf hacking: use same machinery to find zlib as for openssl and libevent. Have unified library finder include setup for --with variable. Start trying to suggest to the user what packages they should install if finding the library fails.
svn:r9945
2007-04-11 16:28:44 +00:00
Nick Mathewson
38a5f09502
r12349@catbus: nickm | 2007-04-11 09:18:15 -0400
...
Add code to shrink the cell memory pool by discarding empty chunks that have been empty for the last 60 seconds. Also, instead of having test.c duplicate declarations for exposed functions, put them inside #ifdef foo_PRIVATE blocks in the headers. This prevents bugs where test.c gets out of sync.
svn:r9944
2007-04-11 13:18:25 +00:00
Nick Mathewson
1c8f9b319b
r12344@catbus: nickm | 2007-04-10 21:27:25 -0400
...
Fix documentation and usage of 2nd argument to mp_pool_new.
svn:r9942
2007-04-11 01:27:33 +00:00
Nick Mathewson
51e4b8d706
r12338@catbus: nickm | 2007-04-10 20:29:05 -0400
...
Document memory pool implementation, and tweak it even mor. See? Programming is fun.
svn:r9940
2007-04-11 00:30:34 +00:00
Nick Mathewson
28de06b8e6
r12337@catbus: nickm | 2007-04-10 17:55:26 -0400
...
Add support for using memory pools to allocate queued cell; pass --disable-cell-pool to configure to disable this.
svn:r9939
2007-04-11 00:30:29 +00:00
Nick Mathewson
6ba0b0e9f4
r12336@catbus: nickm | 2007-04-10 17:34:25 -0400
...
Unit tests and debugging for memory pool implementation.
svn:r9938
2007-04-11 00:30:25 +00:00
Nick Mathewson
d7359eb996
r12335@catbus: nickm | 2007-04-10 16:53:48 -0400
...
Initial version of memory pool logic. Needs unit tests. Made to be easily separable from Tor.
svn:r9937
2007-04-11 00:30:22 +00:00
Nick Mathewson
f95d232483
r12332@catbus: nickm | 2007-04-10 12:24:45 -0400
...
Yet another attempted Bug 411 fix: Under some circumstances, a circuit can have cells without being active. The likeliest is that it has been unlinked from all connections in preparation for closing. Therefore, stop enforcing this non-invariant.
svn:r9936
2007-04-10 16:24:50 +00:00
Nick Mathewson
58a6761056
r12330@catbus: nickm | 2007-04-09 19:15:42 -0400
...
Split type of "packed cell" from "parsed cell"; pack cells before queueing them on circuits. This will help us avoid dumb errors when we confuse the two types.
svn:r9935
2007-04-09 23:15:46 +00:00
Nick Mathewson
7529c8f548
r12328@catbus: nickm | 2007-04-09 18:16:31 -0400
...
Argh, missed another 9030 bogon.
svn:r9934
2007-04-09 22:16:33 +00:00
Nick Mathewson
2a07919198
r12326@catbus: nickm | 2007-04-09 17:36:41 -0400
...
Clean up crap from 9930. I can hardly wait till I trust SVK 2.x enough to upgrade.
svn:r9933
2007-04-09 21:36:45 +00:00
Nick Mathewson
2dc6019edb
r12688@Kushana: nickm | 2007-04-09 17:29:12 -0400
...
Simplify dns_resolve: use a helper function so that we handle the error/answer/pending cases uniformly in dns_resolve, and everything else in dns_resolve_impl.
svn:r9932
2007-04-09 21:34:13 +00:00
Nick Mathewson
9c3df07b56
r12687@Kushana: nickm | 2007-04-09 17:05:57 -0400
...
Try to fix bug 410: move responsibility for attaching/detaching initial streams from circuits into dns_resolve. Needs refactoring a little.
svn:r9931
2007-04-09 21:34:03 +00:00
Nick Mathewson
32506ad282
svn:r9930
2007-04-09 21:33:49 +00:00
Nick Mathewson
98e5d10761
r12318@catbus: nickm | 2007-04-09 16:08:20 -0400
...
Fix the first half of bug 411: when we make a circuit active inactive on a connection, it _must_ actually be on that connection.
svn:r9929
2007-04-09 20:09:28 +00:00
Nick Mathewson
eb95ff9ba9
r12317@catbus: nickm | 2007-04-09 15:50:51 -0400
...
Fix second part of bug 411 (which was actually a separate bug): it isnt safe to clear a cell queue while the circuit is active.
svn:r9928
2007-04-09 20:09:26 +00:00
Roger Dingledine
f36c613dbc
fix a memory leak when we ask for "all" networkstatuses and
...
we get one we don't recognize.
backport candidate.
backbackport candidate.
svn:r9918
2007-03-29 07:02:12 +00:00
Nick Mathewson
6589ea2a2f
Fix a crash bug in cell queues: It is possible for a connection_write_to_buf to close the connection or otherwise unlink the circuit, which makes the circuit nonactive, which invalidates the pointer from the circuit to the next circuit on the active ring. Also add a bunch of asserts, most #ifdefed out.
...
svn:r9915
2007-03-29 02:41:36 +00:00
Nick Mathewson
d1ad950ca8
Turn bool_neq and bool_eq into macros.
...
svn:r9914
2007-03-29 02:37:06 +00:00
Nick Mathewson
98ae4bbd0f
Comment out the "clear queue when sending a destroy" logic: it seems potentially dangerous. (see comment for details)
...
svn:r9913
2007-03-29 02:32:00 +00:00
Nick Mathewson
a25c5d6994
r12654@Kushana: nickm | 2007-03-25 19:03:44 -0400
...
Add documentation for cell queue functions; make destroy cells result in cell queues getting cleared before the destroy gets sent.
svn:r9907
2007-03-26 14:08:35 +00:00
Nick Mathewson
83b2208ea4
r12653@Kushana: nickm | 2007-03-25 18:21:38 -0400
...
Add documentation for make_old argument to routerlist functions.
svn:r9906
2007-03-26 14:08:29 +00:00
Nick Mathewson
d1381aef82
r12652@Kushana: nickm | 2007-03-25 15:01:48 -0400
...
A surprisingly simple patch to stop reading on edge connections when their circuits get too full, and start again when they empty out. This lets us remove the logic to block begin_dir conns when the corresponding or conns get full: it was already broken by cell queues anyway.
svn:r9905
2007-03-26 14:08:18 +00:00
Nick Mathewson
38c0bb3a99
r12651@Kushana: nickm | 2007-03-24 18:26:42 -0400
...
Initial version of circuit-based cell queues. Instead of hammering or_conns with piles of cells, queue cells on their corresponding circuits, and append them to the or_conn as needed. This seems to work so far, but needs a bit more work. This will break the memory-use-limitation patch for begin_dir conns: the solution will be a fun but fiddly.
svn:r9904
2007-03-26 14:07:59 +00:00
Nick Mathewson
6e51bdd5e4
r12274@catbus: nickm | 2007-03-26 09:29:18 -0400
...
Possibly resolve bug reported by xiando.
svn:r9903
2007-03-26 13:30:17 +00:00
Nick Mathewson
da6bd21b72
r12644@0-41-wifi: nickm | 2007-03-23 16:02:23 -0400
...
Eliminate more redundant circuit_t arguments when edge_connection_t is already supplied and the circuit is already attached.
svn:r9900
2007-03-24 15:58:11 +00:00
Nick Mathewson
306d5400c3
r12643@0-41-wifi: nickm | 2007-03-23 14:56:35 -0400
...
Refactor a bunch of functions that take edge_connection_t not to also take a crypt_path_t; the cpath is implicit.
svn:r9899
2007-03-24 15:57:51 +00:00
Roger Dingledine
2cf63f8a62
Don't save non-general-purpose router descriptors to the disk cache,
...
because we have no way of remembering what their purpose was when
we restart.
svn:r9894
2007-03-21 15:37:30 +00:00
Roger Dingledine
c36a6210a2
put the stopgap on whether we've sent a create cell, not
...
whether we've attached a stream.
svn:r9883
2007-03-20 03:26:51 +00:00
Roger Dingledine
93e7627694
a stopgap measure while we wait for proposal 111: apply the
...
stricter rate limiting to all OR conns except those that have
been touched by local circuits.
svn:r9882
2007-03-20 03:21:51 +00:00
Roger Dingledine
b4f743562f
Add a separate set of token buckets for relayed traffic. Right
...
now that's just defined as answers to directory requests.
svn:r9881
2007-03-20 02:55:31 +00:00
Roger Dingledine
4ab0b979b2
temporary hack to solve bug 384, so i can get on with debugging
...
other stuff.
svn:r9880
2007-03-20 02:10:18 +00:00
Roger Dingledine
0724bc113f
correct a function comment that's become wrong
...
svn:r9879
2007-03-19 23:32:30 +00:00
Nick Mathewson
141efb86ff
r12230@catbus: nickm | 2007-03-17 17:34:32 -0400
...
Remove some duplicated code in control.c: unify the "parse space-separated arguments and warn if there are too few" logic into a single helper function.
svn:r9866
2007-03-17 21:34:41 +00:00
Nick Mathewson
d787ef906a
r12229@catbus: nickm | 2007-03-17 17:20:28 -0400
...
Add a warning when using obsolete "GUARDS" event. Also, remove obsolete "if (1) {}"s from control.c: big patch, mostly just dedenting block contents.
svn:r9865
2007-03-17 21:34:37 +00:00
Nick Mathewson
f8f5ea10de
r12191@catbus: nickm | 2007-03-15 15:33:37 -0400
...
Check return values from pthread_mutex functions.
svn:r9862
2007-03-17 21:09:49 +00:00
Roger Dingledine
75754b4d8e
other minor fixes lurking in my sandbox
...
svn:r9854
2007-03-17 04:34:31 +00:00
Roger Dingledine
9d7dc1b37b
forward-port r9850 and the changelogs
...
(it's a band)
svn:r9853
2007-03-17 04:32:04 +00:00
Roger Dingledine
4813ff04e8
Fix an infinite loop introduced in 0.1.2.7-alpha when we serve
...
directory information requested inside Tor connections (i.e. via
begin_dir cells). It only triggered when the same connection was
serving other data at the same time. Reported by seeess.
Backport candidate.
svn:r9841
2007-03-16 06:55:09 +00:00
Roger Dingledine
d374616301
clean up some minor typos and log confusions
...
svn:r9832
2007-03-15 22:47:21 +00:00
Nick Mathewson
e50e6b4e3c
r12182@catbus: nickm | 2007-03-15 10:58:12 -0400
...
Clarify section of dir-spec.txt that explains how "v" resolution happens.
svn:r9829
2007-03-15 16:27:57 +00:00
Roger Dingledine
ad304a5cbb
change my mind -- correct the spec to match the code's
...
behavior for getinfo addr-mappings/*. this is because
the code and spec have been mismatched since at least
0.1.1.x, so i would be surprised if nobody at all is
relying on the current behavior.
backport candidate.
backbackport candidate.
svn:r9823
2007-03-15 06:25:00 +00:00
Roger Dingledine
8ca31c8195
Make the response to 'getinfo addr-mappings/*' follow the spec.
...
svn:r9822
2007-03-15 06:10:58 +00:00
Roger Dingledine
c995a36972
typo in error message led to breaking the protocol. also
...
pointed out by daejees.
svn:r9819
2007-03-15 03:15:34 +00:00
Roger Dingledine
5b8adc7c9b
Make 'getinfo fingerprint' return a 551 error if we're not a
...
server, so we match what the control spec claims we do. Reported
by daejees.
svn:r9818
2007-03-15 03:11:53 +00:00
Roger Dingledine
5740071674
the spec called it a GUARDS event, but the code called
...
it a GUARD event. standardize on GUARD, but support people
asking for GUARDS too. reported by daejees.
backport candidate.
svn:r9817
2007-03-14 23:50:41 +00:00
Roger Dingledine
bf3b3a44f3
Stop allowing hibernating servers to be "stable" or "fast".
...
This is what I meant to do in r9690 but didn't actually do.
svn:r9808
2007-03-13 01:59:09 +00:00
Nick Mathewson
6363a7ccf5
r12538@Kushana: nickm | 2007-03-11 17:10:22 -0400
...
Fix a lame assert, I hope.
svn:r9801
2007-03-11 21:10:54 +00:00
Roger Dingledine
7fedd6ab4e
best not to introduce new technical terms if we don't need to
...
svn:r9800
2007-03-11 20:52:07 +00:00
Nick Mathewson
98c3403ce7
r12535@Kushana: nickm | 2007-03-11 16:34:40 -0400
...
Fix a comment and add a couple of assert to try to track down another assert in routerlist_assert_ok()
svn:r9799
2007-03-11 20:34:44 +00:00
Nick Mathewson
f25e2167f5
r12533@Kushana: nickm | 2007-03-11 05:01:15 -0400
...
Oh. Tor was supposed to compile?
svn:r9797
2007-03-11 09:05:17 +00:00
Nick Mathewson
97b61b9889
r12519@Kushana: nickm | 2007-03-10 00:57:01 -0500
...
Remove a redundant check for event.h; add some comments, and reformat.
svn:r9790
2007-03-10 07:38:42 +00:00
Roger Dingledine
4ca75ecc49
holy cow, those windows unames are long. don't distract so
...
much from the important part of this log message.
svn:r9789
2007-03-10 06:33:44 +00:00
Roger Dingledine
a247792169
Directory authorities now call routers stable if they have an
...
uptime of at least 30 days, even if that's not the median uptime
in the network. Implements proposal 1xx, suggested by Kevin Bauer
and Damon McCoy.
svn:r9788
2007-03-10 05:43:35 +00:00
Nick Mathewson
02ce8e6b12
r12474@Kushana: nickm | 2007-03-06 16:10:05 -0500
...
We have a PATH_SEPARATOR macro. How about we use it?
svn:r9782
2007-03-09 21:39:30 +00:00
Nick Mathewson
d62e37b4a9
r12473@Kushana: nickm | 2007-03-06 15:49:45 -0500
...
Excise PREDICT and PREDICT_FALSE in favor of PREDICT_LIKELY and PREDICT_UNLIKELY.
svn:r9781
2007-03-09 21:39:19 +00:00
Roger Dingledine
fe94914b98
Put a platform string (e.g. "Linux i686") in the startup log
...
message, so when people paste just their logs, we know if it's
openbsd or windows or what.
svn:r9775
2007-03-09 08:56:39 +00:00
Roger Dingledine
b97dca4510
forward-port the bugfix from juliusz
...
svn:r9772
2007-03-09 08:48:53 +00:00
Roger Dingledine
064ff7b33d
get rid of an info-level log message that occurs many times a
...
minute when we haven't needed circuits lately.
svn:r9771
2007-03-09 08:48:21 +00:00
Nick Mathewson
2036470b62
r12098@catbus: nickm | 2007-03-06 18:48:50 -0500
...
Try to make unit tests happier on 64-bit platforms.
svn:r9752
2007-03-06 23:48:55 +00:00
Nick Mathewson
5d1bee87ff
r12468@Kushana: nickm | 2007-03-06 15:24:00 -0500
...
More unit tests: gcov is fun.
svn:r9748
2007-03-06 20:25:44 +00:00
Nick Mathewson
c9e2766e75
r12461@Kushana: nickm | 2007-03-06 13:26:17 -0500
...
More autoconf fixes and updates. Maybe the bsd buildbots will be happy again.
svn:r9747
2007-03-06 20:25:32 +00:00
Roger Dingledine
78cbfcf651
and one more not-really-an-error case
...
svn:r9743
2007-03-06 19:37:18 +00:00
Roger Dingledine
5217d3680e
clean up a log message, and stop calling it an error when
...
we exit cleanly
svn:r9742
2007-03-06 19:33:43 +00:00
Nick Mathewson
52713788b4
r12080@catbus: nickm | 2007-03-04 21:40:55 -0500
...
Remove dnsworkers and related code. there goes another 550 lines of code.
svn:r9736
2007-03-05 02:40:58 +00:00
Nick Mathewson
92f62b3684
r12077@catbus: nickm | 2007-03-04 16:08:23 -0500
...
Remove support for v0 control protocol from 0.2.0.x trunk; send back error when we receive a v0 control message. (Leave "if(v1){...}"blocks indented for now so this patch is easier to read.) ((Finally, the linecount goes _down_ a little.))
svn:r9735
2007-03-04 21:08:28 +00:00
Nick Mathewson
4a6e29b029
r12076@catbus: nickm | 2007-03-04 15:41:04 -0500
...
oops; remove spurious argument from _log_prefix.
svn:r9734
2007-03-04 21:08:26 +00:00
Nick Mathewson
7fcceb2c25
r12074@catbus: nickm | 2007-03-04 15:11:43 -0500
...
Make all LD_BUG log messsages get prefixed with "Bug: ". Remove manually-generated "Bug: "s from log-messages. (Apparently, we remembered to add them about 40% of the time.)
svn:r9733
2007-03-04 20:11:46 +00:00
Nick Mathewson
6b79e252f6
r12063@catbus: nickm | 2007-03-04 14:46:22 -0500
...
Bump trunk version to 0.2.0.0-alpha-dev
svn:r9730
2007-03-04 19:49:06 +00:00
Nick Mathewson
70e5a83a77
r12057@catbus: nickm | 2007-03-04 13:58:32 -0500
...
Clarify some log messages; note others that could be improved later.
svn:r9724
2007-03-04 18:58:38 +00:00
Nick Mathewson
5f9f62daa2
r12053@catbus: nickm | 2007-03-03 16:45:38 -0500
...
Remove some XXX012s: leave a check in connection_or_set_identity_digest it costs basically nothing to do on average. Forget about reinstating the user check on NT Service creation. Note that a notice message in main.c ("Is something wrong with your network connection?") is really useless.
svn:r9721
2007-03-03 21:55:31 +00:00
Nick Mathewson
25508347ec
r12051@catbus: nickm | 2007-03-03 16:15:52 -0500
...
nt_service_is_stopping should not load the NT service library calls: if they are not loaded, we cannot possibly be a service trying to shut own. Bug found by "norvid" on or-talk. Also, rename function to something slightly less error-prone.
svn:r9720
2007-03-03 21:16:07 +00:00
Nick Mathewson
bd9289cf2b
svn:r9719
2007-03-03 20:09:15 +00:00
Nick Mathewson
275f39603b
r12420@Kushana: nickm | 2007-03-03 15:06:53 -0500
...
Bump version to 0.1.2.9-rc-dev
svn:r9718
2007-03-03 20:09:07 +00:00
Roger Dingledine
629930ad16
bump to 0.1.2.9-rc
...
svn:r9705
2007-03-02 05:18:52 +00:00
Roger Dingledine
6b191f854c
resolve another xxx012
...
svn:r9701
2007-03-01 04:40:43 +00:00
Roger Dingledine
dba4e040fc
Disable encrypted directory connections when we don't have a server
...
descriptor for the destination. We'll get this working again in
the 0.2.0 branch.
svn:r9700
2007-03-01 04:26:30 +00:00
Roger Dingledine
a46bd9942d
bonus points if it builds on 64 bit
...
svn:r9698
2007-03-01 03:59:28 +00:00
Roger Dingledine
b0aaa88433
make the prefertunnel stuff less obviously broken
...
svn:r9697
2007-03-01 03:56:21 +00:00
Nick Mathewson
2780bb74c8
r12014@catbus: nickm | 2007-02-28 19:41:20 -0500
...
Niels has accepted the patch from Scott Lamb to implement better signal handling: I can take "get the pthread_sigprocmask situation under control" off my plate.
svn:r9696
2007-03-01 00:41:35 +00:00
Nick Mathewson
df5a8aa931
r12013@catbus: nickm | 2007-02-28 18:26:13 -0500
...
Note a piece of code that needs to get resolved, before we forget it.
svn:r9695
2007-03-01 00:41:33 +00:00
Nick Mathewson
11d89141ac
r12012@catbus: nickm | 2007-02-28 18:25:18 -0500
...
Twiddle constants wrt uploading hidden service descriptors.
svn:r9694
2007-03-01 00:41:28 +00:00
Nick Mathewson
dec9e4f0d8
r12011@catbus: nickm | 2007-02-28 18:13:32 -0500
...
Back out insufficiently evidenced FULL_UNROLL in aes.c
svn:r9693
2007-03-01 00:41:25 +00:00
Nick Mathewson
e2b1a77c3e
r12006@catbus: nickm | 2007-02-28 16:06:24 -0500
...
On mingw, use "%I64u" to printf/scanf 64-bit integers, instead of the usual GCC "%llu". This prevents a bug when saving 64-bit int configuration values on mingw; the high-order 32 bits would get truncated. If the value was then reloaded, disaster would occur. (Fixes bug 400 and maybe also bug 397.) Backport candidate.
svn:r9691
2007-02-28 21:07:19 +00:00
Roger Dingledine
b78f67dbf5
- Stop calling servers that have been hibernating for a long time
...
"stable". Also, stop letting hibernating or obsolete servers affect
uptime and bandwidth cutoffs.
- Stop listing hibernating servers in the v1 directory.
svn:r9690
2007-02-28 21:06:05 +00:00
Roger Dingledine
9fd669c339
note another wishlist item for the arma
...
svn:r9689
2007-02-28 20:49:09 +00:00
Nick Mathewson
f38240435a
r12001@catbus: nickm | 2007-02-28 15:24:12 -0500
...
Try to build without warnings on mingw with verbose warnings on. First attempt.
svn:r9688
2007-02-28 20:24:27 +00:00
Nick Mathewson
3008c3b768
r12000@catbus: nickm | 2007-02-28 15:12:21 -0500
...
Try to fix eventdns bug 326 again, this time by noting that rcode 2 (serverfailed) does not really mean "The server is useless."
svn:r9687
2007-02-28 20:24:23 +00:00
Roger Dingledine
08c75f4349
avoid a few headaches
...
svn:r9686
2007-02-28 20:24:09 +00:00
Nick Mathewson
dfbced7499
r11998@catbus: nickm | 2007-02-28 13:56:55 -0500
...
Correct an MSC_VER check.
svn:r9685
2007-02-28 18:57:03 +00:00
Nick Mathewson
2ee2e63631
r11996@catbus: nickm | 2007-02-28 13:52:48 -0500
...
Add an MSC_VER check I missed.
svn:r9684
2007-02-28 18:52:57 +00:00
Nick Mathewson
e1176ece5a
r11992@catbus: nickm | 2007-02-28 12:46:32 -0500
...
compile fix on mingw: mingw does not define _MSC_VER.
svn:r9682
2007-02-28 17:46:36 +00:00
Nick Mathewson
deef370a1c
r11987@catbus: nickm | 2007-02-28 12:34:04 -0500
...
add another u64-related unit test.
svn:r9681
2007-02-28 17:34:07 +00:00
Nick Mathewson
c8659db28d
r11982@catbus: nickm | 2007-02-28 11:55:41 -0500
...
Add unit tests for tor_parse_uint64
svn:r9678
2007-02-28 16:56:28 +00:00
Nick Mathewson
dae5fc7982
r11981@catbus: nickm | 2007-02-28 11:55:27 -0500
...
Clamp declarable bandwidth at INT32_MAX, not INT_MAX.
svn:r9677
2007-02-28 16:56:07 +00:00
Nick Mathewson
d6368fd075
r11976@catbus: nickm | 2007-02-27 19:35:59 -0500
...
Add some missing (redundant but helpful in most cases) static declarations, and remove a function nobody was calling.
svn:r9672
2007-02-28 00:36:03 +00:00
Nick Mathewson
1a3e1c5510
r11970@catbus: nickm | 2007-02-27 19:17:27 -0500
...
Fix a bug found by Udo van den Heuvel: avoid an assertion failure when a controller sets and clears EntryNodes before the next call to choose_random_entry(). Also make a function static.
svn:r9669
2007-02-28 00:23:05 +00:00
Nick Mathewson
16f1008d01
Add a missing paren, and the results of an experiment.
...
svn:r9664
2007-02-27 06:00:11 +00:00
Nick Mathewson
9d714e6258
r11959@catbus: nickm | 2007-02-26 22:53:36 -0500
...
try to make aes encryption of cells about 30-40% faster where applicable. offer not available for all architectures or all versions of openssl.
svn:r9663
2007-02-27 03:53:45 +00:00
Nick Mathewson
4d127acb53
r11958@catbus: nickm | 2007-02-26 22:28:03 -0500
...
Add a missing set to onion_key_set_at to avoid premature rotates.
svn:r9662
2007-02-27 03:53:40 +00:00
Nick Mathewson
230fbd95c0
r11956@catbus: nickm | 2007-02-26 13:33:49 -0500
...
Add a quick-and-dirty AES benchmark function to the bottom of aes.c so I can go collecting data.
svn:r9660
2007-02-26 18:33:55 +00:00
Nick Mathewson
82e2d6001a
r11954@catbus: nickm | 2007-02-26 13:01:19 -0500
...
Note some optimizations that are probably not worth it for 0.1.2.x based on preliminary profiling.
svn:r9659
2007-02-26 18:01:23 +00:00
Nick Mathewson
a5b18f8a65
r11952@catbus: nickm | 2007-02-26 12:37:06 -0500
...
Bump version to 0.1.2.8-beta-dev
svn:r9658
2007-02-26 17:37:09 +00:00
Roger Dingledine
38f5fac846
let us call it a beta. perhaps it will break then.
...
svn:r9656
2007-02-26 06:53:19 +00:00
Roger Dingledine
522a97098b
more cleanups; getting closer
...
svn:r9655
2007-02-26 05:36:02 +00:00
Roger Dingledine
9e44449946
fix a bug in our logic, but point out that maybe it's moot
...
svn:r9654
2007-02-26 05:33:17 +00:00
Nick Mathewson
333bf44471
r11944@catbus: nickm | 2007-02-25 14:43:18 -0500
...
Add a lower-bound on MaxAdvertisedBandwidth.
svn:r9652
2007-02-25 19:43:23 +00:00
Nick Mathewson
938de88e3b
r11942@catbus: nickm | 2007-02-25 11:22:12 -0500
...
Fix connection_get_by_type_state_rendquery(): This has been bogus for most of 0.1.2.x. Thanks to Karsten Loesing for finding the bug; fixes bug 399.
svn:r9651
2007-02-25 16:22:36 +00:00
Roger Dingledine
5fd4f7c131
the other half of r9572, suggested by seeess: when we receive
...
a v1 dir or rr that is too old, don't even cache it.
svn:r9649
2007-02-25 03:43:00 +00:00
Nick Mathewson
dde4bc1fd3
r11933@catbus: nickm | 2007-02-24 18:55:33 -0500
...
Fix a bug in 9572: after we decref a defunct v1 directory, drop the main reference to it. Should fix bug 396. Many thanks to seeess for tracking this one down.
svn:r9648
2007-02-24 23:55:36 +00:00
Roger Dingledine
d6c21ab8a7
tell the user if we're delaying his newnym request. also, pick
...
a different set of fenceposts.
svn:r9647
2007-02-24 21:21:38 +00:00
Nick Mathewson
af57074f08
r11931@catbus: nickm | 2007-02-24 15:28:34 -0500
...
crank up the length of the maximum allowed control message.
svn:r9644
2007-02-24 20:28:41 +00:00
Nick Mathewson
b4243d7dfa
r11929@catbus: nickm | 2007-02-24 15:02:43 -0500
...
Split possibly long log line.
svn:r9643
2007-02-24 20:02:47 +00:00
Nick Mathewson
501659e67c
r11927@catbus: nickm | 2007-02-24 14:49:31 -0500
...
Make sure every error case of router_dump_router_to_string warns about what actually went wrong.
svn:r9642
2007-02-24 19:49:35 +00:00
Roger Dingledine
fc81b71055
if we can't read bandwidthrate, at least tell us what it was.
...
svn:r9640
2007-02-24 19:29:42 +00:00
Nick Mathewson
cc64d1f111
r11917@catbus: nickm | 2007-02-24 03:18:52 -0500
...
Fix another XXX012 in eventdns.c: tell the DNS request about malformed DNS replies.
svn:r9637
2007-02-24 08:18:59 +00:00
Roger Dingledine
50f22e858a
doc pedant
...
svn:r9634
2007-02-24 07:50:38 +00:00
Nick Mathewson
f599adf40a
r11909@catbus: nickm | 2007-02-24 02:37:40 -0500
...
Move tricky "delete the member of the smartlist currently under iteration" logic into its own happyfun macro.
svn:r9633
2007-02-24 07:37:45 +00:00
Roger Dingledine
2015479b5a
fix crash introduced in r9622
...
svn:r9632
2007-02-24 06:44:40 +00:00
Roger Dingledine
748c502e3a
fix a log message that was broken long ago and never noticed
...
svn:r9630
2007-02-24 05:36:45 +00:00
Roger Dingledine
d63c58249e
make it stop crashing when i exercise the new entrynodes behavior in
...
r9574. this hack is getting pretty darn hackish; perhaps it's time to
not use SMARTLIST_FOREACH in this situation.
svn:r9629
2007-02-24 04:17:29 +00:00
Roger Dingledine
33430d3a9e
bugfix on r9568: we were throwing around an uninitialized
...
nickname array, and only treating a server as reachable if
the array magically has the right nickname in it. this was
causing the authorities to label only themselves as running,
and clients were "mysteriously" failing.
svn:r9628
2007-02-24 01:26:09 +00:00
Roger Dingledine
9946bb7fbd
cosmetic, comment, and todo fixes
...
svn:r9627
2007-02-24 01:12:53 +00:00
Nick Mathewson
4e05ccb289
r11900@catbus: nickm | 2007-02-23 18:11:04 -0500
...
Fix null-pointer access on update_router_descriptor_cache_downloads.
svn:r9626
2007-02-23 23:11:08 +00:00
Nick Mathewson
ddc34f6037
r11898@catbus: nickm | 2007-02-23 16:55:43 -0500
...
Two XXX012 comments turned out to be bogus; remove them and document why.
svn:r9625
2007-02-23 21:56:10 +00:00
Nick Mathewson
55cbbdf9bf
r11895@catbus: nickm | 2007-02-23 15:12:58 -0500
...
Make remap stream events have a souce; make them generated every time we get a successful connected or resolved cell. Also change reported stream target address to IP consistently when we get the IP from an exit node.
svn:r9624
2007-02-23 20:13:02 +00:00
Nick Mathewson
f1d207b29a
r11885@catbus: nickm | 2007-02-23 13:34:24 -0500
...
Fix an XXXX012: make entry guards _really_ get retried when the network comes back online.
svn:r9622
2007-02-23 18:34:35 +00:00
Nick Mathewson
a98efbf285
r11877@catbus: nickm | 2007-02-22 02:24:50 -0500
...
Fix doc about when circuit_build_needed_circs() is called. Resolves another xxxx012.
svn:r9617
2007-02-22 07:41:14 +00:00
Nick Mathewson
a2a52b4d5f
r11876@catbus: nickm | 2007-02-22 02:23:13 -0500
...
Fix two XXXX012 issues in routerlist.c: a possible performance issue hasnt shown up on any profiles, so unflag it. Stop warning when we get a router descriptor that we asked for but no longer want: just drop it (if we are not a cache) or cache if (if we are).
svn:r9616
2007-02-22 07:41:10 +00:00
Nick Mathewson
b3392559d4
r11873@catbus: nickm | 2007-02-22 01:21:14 -0500
...
twiddle signewnym rate-limiting patch so every signal gets handled eventually. document it in control-spec. add a changelog.
svn:r9615
2007-02-22 06:21:19 +00:00
Nick Mathewson
fe9224dabc
r11872@catbus: nickm | 2007-02-22 01:08:46 -0500
...
patch from mwenge: rate-limit newnym.
svn:r9614
2007-02-22 06:21:16 +00:00
Nick Mathewson
0fb179aa2e
r11860@catbus: nickm | 2007-02-21 00:56:15 -0500
...
Another optimization suggested by Shark output: shave off >90% of uses of logv by cutting down on calls to log_debug when log actually debugging. This is showing up in some profiles bug not others, and might be as much as 2.5%.
svn:r9612
2007-02-21 05:57:12 +00:00
Nick Mathewson
809a4daa52
r11859@catbus: nickm | 2007-02-21 00:53:27 -0500
...
Fix use of predict. this should get refactored, but now now.
svn:r9611
2007-02-21 05:57:08 +00:00
Nick Mathewson
2a4fc8533c
r11858@catbus: nickm | 2007-02-21 00:27:44 -0500
...
As a trivial optimization, remove a redundant call to router_have_minimum_dir_info. This might shave 2% on some systems by according to some profilers.
svn:r9610
2007-02-21 05:56:53 +00:00
Nick Mathewson
275ce1d2a4
r11852@catbus: nickm | 2007-02-20 17:25:17 -0500
...
Reverse arguments in memset() call in no-mmap version of tor_munmap_file(). Resolves bug 392. Spotted by "fookoowa"--thanks!
svn:r9604
2007-02-20 22:25:20 +00:00
Nick Mathewson
b6e6b7101b
r11850@catbus: nickm | 2007-02-20 13:34:13 -0500
...
Apply patch from coderman: have posix subthreads mask out signals. This could prevent some kinds of crashes when subthreads try to handle SIGPIPEs and die in the attempt. Backport candidate.
svn:r9603
2007-02-20 18:34:18 +00:00
Nick Mathewson
aade1b9204
r11844@catbus: nickm | 2007-02-17 16:53:42 -0500
...
Note a problematic warning.
svn:r9599
2007-02-17 23:49:50 +00:00
Nick Mathewson
d2893398f6
r11832@catbus: nickm | 2007-02-16 15:31:59 -0500
...
Fix 35 remaining DOCDOC comments. Yowza.
svn:r9596
2007-02-16 20:39:37 +00:00
Nick Mathewson
a3ec172e1a
r11827@catbus: nickm | 2007-02-16 15:00:39 -0500
...
Try to fix VC++ int conversion warning.
svn:r9595
2007-02-16 20:01:21 +00:00
Nick Mathewson
11e5656ab7
r11826@catbus: nickm | 2007-02-16 14:58:38 -0500
...
Resolve 56 DOCDOC comments.
svn:r9594
2007-02-16 20:01:02 +00:00
Nick Mathewson
ae7576a19e
r11825@catbus: nickm | 2007-02-16 14:04:36 -0500
...
Fix DOCDOC items in or.h; rename a couple of macros to be more sensible.
svn:r9593
2007-02-16 20:00:50 +00:00
Nick Mathewson
d4aaffc6e7
r11824@catbus: nickm | 2007-02-16 13:16:47 -0500
...
Move all struct-offset-manipulation macros into util.h, and use them consistently. Because there are days when "SUBTYPE_P(handle, subtype, _base)" is just easier to read and write than "(basetp*)(((handle) - STRUCT_OFFSET(subtype, _base))".
svn:r9592
2007-02-16 20:00:43 +00:00
Nick Mathewson
e5d3269b10
r11822@catbus: nickm | 2007-02-16 12:49:20 -0500
...
Tech config.c about libevent 1.3, and resolve all docdoc elements in config.c
svn:r9591
2007-02-16 18:12:47 +00:00
Nick Mathewson
6e35b11851
r11813@catbus: nickm | 2007-02-14 11:42:58 -0500
...
Tweak stream_bw patch: Remove a couple of redundant checks, save 8 bytes per edge connection, fix spelling in the changelog; expand spec.
svn:r9586
2007-02-14 16:46:55 +00:00
Nick Mathewson
4a74812c70
r11812@catbus: nickm | 2007-02-14 11:22:08 -0500
...
Apply stream_bw patch from Robert Hogan.
svn:r9585
2007-02-14 16:46:49 +00:00
Nick Mathewson
a10ccac9cb
r11797@catbus: nickm | 2007-02-13 16:17:40 -0500
...
Fix a longstanding dnsworker-related bug: when we decide to kill a DNS worker for having been in use too long, and we independently decide to close one of the exit connections waiting for that DNS worker (perhaps because we got an END relay cell), it was possible for us to try to double-free the connection. We were smart enough to detect this and assert, but not smart enough to fix this bug before now. This should resolve bug 390. Backport candidate.
svn:r9581
2007-02-13 21:18:56 +00:00
Nick Mathewson
1c8a9d37b6
r11791@catbus: nickm | 2007-02-13 11:36:07 -0500
...
Try to fix mingw compile error reported by Li-Hui Zhou.
svn:r9578
2007-02-13 16:36:14 +00:00