Roger Dingledine
|
51f47d746e
|
clean up smartlist_string_isin so callers don't have to manage bufs
themselves
svn:r3338
|
2005-01-12 04:53:53 +00:00 |
|
Roger Dingledine
|
74bc4e5af0
|
help avoid overflow from len_in + (len_in/n)*len_ins
nick, do you think this does it? if so, we should maybe backport too.
svn:r3334
|
2005-01-10 16:30:51 +00:00 |
|
Roger Dingledine
|
1f3e77bf92
|
make the initial temp log only notice-err, not info-err
svn:r3274
|
2005-01-04 02:25:18 +00:00 |
|
Roger Dingledine
|
9e6d6c6096
|
Bugfix: we've been using openssl's BIO_get_mem_data incorrectly.
We assumed the pem-encoded data written by PEM_write_bio_RSAPrivateKey
is nul-terminated, and at least sometimes, it's not.
svn:r3263
|
2005-01-03 22:35:40 +00:00 |
|
Nick Mathewson
|
b50263f740
|
More work on task #43: fix race conditions on multithreaded (win32) servers.
svn:r3251
|
2005-01-03 19:07:25 +00:00 |
|
Nick Mathewson
|
ead52e0bdc
|
Possible fix for task #43: when running on a multithreaded environment (currently only windows), threads should not close opposite sides of their socketpairs, and workers should not call connection_free_all(). This may fix win32 servers.
svn:r3247
|
2005-01-03 18:06:51 +00:00 |
|
Nick Mathewson
|
fca7ba9777
|
Resolve task 42: find where 19-char nicknames were getting truncated when read from certs, and fix it. Also audit use of MAX_NICKNAME_LEN; no other badness found, but some docs/code cleaned up a touch.
svn:r3244
|
2005-01-03 17:53:20 +00:00 |
|
Roger Dingledine
|
c3189c2573
|
fix an assert on startup when the disk is full and you're logging to a file
svn:r3204
|
2004-12-22 08:16:42 +00:00 |
|
Roger Dingledine
|
cf17d0d29c
|
move network_init from or/main to common/compat
call network_init in tor-resolve.c too
move tor_lookup_hostname from common/util to common/compat
svn:r3203
|
2004-12-22 05:29:06 +00:00 |
|
Nick Mathewson
|
c79c4200f4
|
Fix a bug in last patch; and keep my name out of the assert() call too.
svn:r3200
|
2004-12-22 02:46:28 +00:00 |
|
Nick Mathewson
|
32978afa54
|
Workaround for brain-damaged __FILE__ handling on MSVC: keep Nick's name out
of the warning messages.
svn:r3199
|
2004-12-22 02:32:26 +00:00 |
|
Nick Mathewson
|
bbc10c2ea1
|
Make split(..., NULL) split on horizontal space; fix bug with tabs in config file.
svn:r3155
|
2004-12-16 21:10:51 +00:00 |
|
Nick Mathewson
|
8c85c0bef8
|
Note that length checking on base64_decode is kinda conservative
svn:r3144
|
2004-12-13 18:38:19 +00:00 |
|
Nick Mathewson
|
fd4c624677
|
Belt *or* suspenders will be sufficient when casting things to unsigned char.
svn:r3122
|
2004-12-08 07:20:21 +00:00 |
|
Nick Mathewson
|
fe6eb34a10
|
Solaris CC freaks out if isspace and friends get anything other than an int. We learned that, so we casted. But it is also a bad idea to cast a signed char to an int and expect things to work on win32. Now we cast to unsigned char, then to int, then pass to isspace. Ug
svn:r3120
|
2004-12-08 00:42:50 +00:00 |
|
Roger Dingledine
|
bd5524bfc7
|
fix comment
svn:r3110
|
2004-12-07 15:37:35 +00:00 |
|
Nick Mathewson
|
a6aa5eebd6
|
Fix some memory leaks and unlikely segfaults
svn:r3103
|
2004-12-07 07:48:16 +00:00 |
|
Roger Dingledine
|
2297c57ba5
|
note an improvement on our uname we might want to make one day
svn:r3101
|
2004-12-07 07:35:32 +00:00 |
|
Nick Mathewson
|
0f49fd3bcd
|
Fix leakable rsa key
svn:r3099
|
2004-12-07 06:48:02 +00:00 |
|
Nick Mathewson
|
249a36586f
|
Fix parse_iso_time on platforms without strptime.
svn:r3091
|
2004-12-06 22:39:10 +00:00 |
|
Roger Dingledine
|
50a314c931
|
int is not necessarily the same size as size_t
svn:r3079
|
2004-12-05 11:58:30 +00:00 |
|
Roger Dingledine
|
32e74d3525
|
fix comment
svn:r3077
|
2004-12-04 13:58:34 +00:00 |
|
Nick Mathewson
|
a980446d0c
|
Be more proactive about noticing underflows: size_t values greater than 0x800...00 are likely to be trouble.
svn:r3064
|
2004-12-02 04:33:01 +00:00 |
|
Nick Mathewson
|
41ba4575b3
|
Fix windows build.
svn:r3053
|
2004-12-01 03:51:59 +00:00 |
|
Nick Mathewson
|
b457cfb5eb
|
Spell-check strings and comments
svn:r3052
|
2004-12-01 03:48:14 +00:00 |
|
Nick Mathewson
|
6e88abf418
|
If we are using select, make sure we stay within FD_SETSIZE.
svn:r3051
|
2004-12-01 03:15:59 +00:00 |
|
Roger Dingledine
|
7a8c1ca1e4
|
a few minor tweaks
svn:r3041
|
2004-11-30 08:54:08 +00:00 |
|
Nick Mathewson
|
f19e9b8577
|
doxygen uses backslashes, not forward-slashes
svn:r3033
|
2004-11-30 06:17:35 +00:00 |
|
Nick Mathewson
|
a3477223de
|
clarify why strlcpy is safe in truncated log messages
svn:r3032
|
2004-11-30 06:15:06 +00:00 |
|
Nick Mathewson
|
ad7db5e43a
|
Add casei versions of strcmpstart/strcmpend
svn:r3026
|
2004-11-30 03:10:56 +00:00 |
|
Nick Mathewson
|
7fbd297532
|
Suggestion from weasel: Make tor --version --version dump the cvs Id of every file.
svn:r3019
|
2004-11-29 22:25:31 +00:00 |
|
Nick Mathewson
|
b6b07d1d98
|
Remove needless -2 in log code. This was not an underflow risk, sinze we only call format_msg from one place, where buf_len==10024
svn:r3017
|
2004-11-29 20:39:55 +00:00 |
|
Roger Dingledine
|
671a2de762
|
clean up the previous underflow check, and also point out
yet another one that may be a problem. nick?
svn:r3016
|
2004-11-29 08:40:24 +00:00 |
|
Nick Mathewson
|
eccfe23a21
|
Disallow NDEBUG. It is very stupid.
svn:r3012
|
2004-11-29 07:22:57 +00:00 |
|
Roger Dingledine
|
531c060b36
|
fix integer underflow in tor_vsnprintf()
(probably exploitable)
svn:r3011
|
2004-11-29 06:49:04 +00:00 |
|
Roger Dingledine
|
185f047450
|
prevent integer underflow
(not currently exploitable, ilja and i think)
svn:r3010
|
2004-11-29 06:43:21 +00:00 |
|
Roger Dingledine
|
22727b4edc
|
wrong is ok, and right is fine, but in between is apparently
totally unacceptable to me.
svn:r3005
|
2004-11-28 11:39:53 +00:00 |
|
Nick Mathewson
|
f7c6ad065e
|
correct multiple internal spaces
svn:r3004
|
2004-11-28 09:14:07 +00:00 |
|
Nick Mathewson
|
6f5dbefa7e
|
Normalize space: add one between every control keyword and control clause.
svn:r3003
|
2004-11-28 09:05:49 +00:00 |
|
Nick Mathewson
|
32651dd108
|
connect() on win32 can do more things than we thought?
svn:r2999
|
2004-11-28 05:58:55 +00:00 |
|
Nick Mathewson
|
0702179d28
|
Very oops. make windows nonblocking sockets nonblocking
svn:r2998
|
2004-11-28 05:57:18 +00:00 |
|
Nick Mathewson
|
f77ff938b7
|
remember; tor_socket_errno has side effects!
svn:r2997
|
2004-11-28 05:48:02 +00:00 |
|
Roger Dingledine
|
7c9a707900
|
remove emacs droppings, since nick says he doesn't need them anymore
svn:r2989
|
2004-11-26 04:00:55 +00:00 |
|
Peter Palfrader
|
f2a96ce1fe
|
Flush the logfd after we print "Tor opening log file", so we don't see those messages days later
svn:r2980
|
2004-11-24 08:42:06 +00:00 |
|
Nick Mathewson
|
cd70264377
|
Clean up some logging and interfaces
svn:r2945
|
2004-11-23 00:08:26 +00:00 |
|
Nick Mathewson
|
22dba27d8d
|
Normalize a few more kinds of whitespace. We now dislike:
- func (args)
- if (x){
This doesn't normalize if(x), for(x); while(x), and friends.
svn:r2943
|
2004-11-22 23:28:26 +00:00 |
|
Nick Mathewson
|
55df2620c6
|
Add function to format local time in ISO format
svn:r2935
|
2004-11-22 21:38:44 +00:00 |
|
Roger Dingledine
|
d4ac7300d6
|
and a comment so i don't try to 'fix' it again later
svn:r2919
|
2004-11-20 12:17:19 +00:00 |
|
Roger Dingledine
|
246b14d8e9
|
yes, in fact, i broke it. putting back.
svn:r2918
|
2004-11-20 12:16:47 +00:00 |
|
Roger Dingledine
|
dd19cf6ba3
|
kill -USR2 now moves all logs to loglevel debug
plus fix some typos
svn:r2914
|
2004-11-20 07:33:55 +00:00 |
|
Roger Dingledine
|
a30a5bce0f
|
simplify close_temp_logs()
(nick, did i break this?)
svn:r2913
|
2004-11-20 07:08:00 +00:00 |
|
Roger Dingledine
|
a8840db4ac
|
remove another possible sigpipe cause
svn:r2912
|
2004-11-20 06:52:13 +00:00 |
|
Nick Mathewson
|
8acaf8e187
|
Add "MEMUNIT" and "INTERVAL" types to configuration. Also tweak Accounting setup. More docs needed
svn:r2911
|
2004-11-20 00:37:00 +00:00 |
|
Nick Mathewson
|
89a456a1d4
|
Fix a fun bug in read_all that was corrupting config files on windows, and probably doing other bad stuff too.
svn:r2898
|
2004-11-16 00:08:56 +00:00 |
|
Nick Mathewson
|
6143c515cd
|
Make log_fn not fail so miserably on VC6
svn:r2896
|
2004-11-15 23:30:26 +00:00 |
|
Nick Mathewson
|
d63d5cb139
|
Whitespace normalization
svn:r2895
|
2004-11-15 23:29:24 +00:00 |
|
Nick Mathewson
|
5b668d8557
|
ugly macros to make log_fn play nice on non-GCC compilers.
svn:r2894
|
2004-11-15 21:18:07 +00:00 |
|
Nick Mathewson
|
ffe9b01ad7
|
Split X509 certificate liveness checks into a separate function
svn:r2873
|
2004-11-14 22:07:48 +00:00 |
|
Nick Mathewson
|
783bbcf471
|
Fix "implicit declaration of ftello" warning: add AC_FUNC_FSEEKO in configure.in and always include orconfig.h before anything else
svn:r2854
|
2004-11-14 17:21:32 +00:00 |
|
Roger Dingledine
|
14c7ad409f
|
remove redundant stdio.h
i guess that wasn't the fix
svn:r2849
|
2004-11-14 09:49:27 +00:00 |
|
Roger Dingledine
|
bd4d99b3fe
|
clean up the ftello call a little bit.
but i'm still getting:
log.c:94: warning: implicit declaration of function `ftello'
svn:r2848
|
2004-11-14 09:48:54 +00:00 |
|
Nick Mathewson
|
a3788d5c9d
|
Fix argument to strncpy.
svn:r2824
|
2004-11-12 21:14:51 +00:00 |
|
Nick Mathewson
|
a8f9ba91db
|
Nobody was using the return values from smartlist_(set|del|del_keeporder), so remove them.
svn:r2823
|
2004-11-12 21:14:06 +00:00 |
|
Nick Mathewson
|
238a895e69
|
Add a FAST_SMARTLIST define to optionally inline smartlist_get and smartlist_len, which are two major profiling offenders.
svn:r2822
|
2004-11-12 20:41:52 +00:00 |
|
Nick Mathewson
|
c466b7e72f
|
Speed up tor_strndup a lot: profiling suggests that our use of strlcpy here was a bad idea.
svn:r2821
|
2004-11-12 20:41:03 +00:00 |
|
Nick Mathewson
|
60880cda84
|
Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs.
svn:r2808
|
2004-11-12 16:39:03 +00:00 |
|
Nick Mathewson
|
5d92fbe30e
|
Use autoconf to enable largefile support where necessary. Use ftello where available, since ftell can fail at 2GB.
svn:r2806
|
2004-11-12 05:05:41 +00:00 |
|
Nick Mathewson
|
8de9cfe184
|
Resolve FIXME items: make expand_filename handle ~ and ~username
svn:r2789
|
2004-11-10 14:23:31 +00:00 |
|
Roger Dingledine
|
987cb2b93a
|
when you cast MAX_UINT to an int it confuses the users
svn:r2788
|
2004-11-10 09:09:15 +00:00 |
|
Nick Mathewson
|
5a5be93f80
|
Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c
svn:r2758
|
2004-11-09 20:04:00 +00:00 |
|
Nick Mathewson
|
d9d053d70b
|
Clean windows a little
svn:r2757
|
2004-11-09 19:30:50 +00:00 |
|
Nick Mathewson
|
7daab4034d
|
Fix windows build for VC6; centralize newline-fiasco-damage-control logic
svn:r2756
|
2004-11-09 19:13:08 +00:00 |
|
Nick Mathewson
|
cd753df7bf
|
Resolve many XXXs and all DOCDOCs
svn:r2755
|
2004-11-09 18:22:17 +00:00 |
|
Nick Mathewson
|
180e0a9326
|
Make check_private_dir trimodal (check/create/ignore), not bimodal (create/ignore).
svn:r2733
|
2004-11-09 07:12:31 +00:00 |
|
Roger Dingledine
|
8c7b2ff7ed
|
various fixes
svn:r2712
|
2004-11-09 01:24:10 +00:00 |
|
Roger Dingledine
|
865f341708
|
parse_line_from_file is obsolete.
svn:r2693
|
2004-11-06 05:18:29 +00:00 |
|
Nick Mathewson
|
38ed0ce5e6
|
Unify tor_parse_(numeric); make sure MAX_UINT32 and MAX_UINT64 are defined
svn:r2688
|
2004-11-05 17:54:50 +00:00 |
|
Nick Mathewson
|
2e8353e2f4
|
Use new log format; convert old format to new format.
svn:r2684
|
2004-11-05 05:50:35 +00:00 |
|
Nick Mathewson
|
b56ef496d9
|
Twiddle header order to compile on OS X again
svn:r2681
|
2004-11-04 22:33:20 +00:00 |
|
Nick Mathewson
|
9d604ec615
|
Add code to read configuration lines from a string as well as a file
svn:r2676
|
2004-11-04 22:29:45 +00:00 |
|
Nick Mathewson
|
b74b72a5ce
|
Fix windows build
svn:r2670
|
2004-11-04 04:01:19 +00:00 |
|
Nick Mathewson
|
70f7e32ec6
|
fix typos
svn:r2666
|
2004-11-03 21:53:12 +00:00 |
|
Nick Mathewson
|
cea9125d71
|
Implement two flavors of authentication for control connections: one for trusted FS, one for untrusted FS.
svn:r2664
|
2004-11-03 19:49:03 +00:00 |
|
Nick Mathewson
|
871bf904ae
|
Remove extraneous local
svn:r2663
|
2004-11-03 19:15:38 +00:00 |
|
Nick Mathewson
|
d5244e3872
|
Add a write_bytes_to_file so we can have files with NULs in them.
svn:r2662
|
2004-11-03 19:02:48 +00:00 |
|
Nick Mathewson
|
11de62aa60
|
Add a slightly trickier string-join interface for making NUL-terminated string messages
svn:r2659
|
2004-11-03 18:28:00 +00:00 |
|
Nick Mathewson
|
11979dc1f5
|
Add a callback log handler type
svn:r2658
|
2004-11-03 18:27:19 +00:00 |
|
Roger Dingledine
|
e761cc9750
|
my assert.h takes extra pains to be certain to _re-include_
itself if you include it twice. this is dumb, but hey.
svn:r2653
|
2004-11-03 07:29:03 +00:00 |
|
Nick Mathewson
|
3e16515343
|
The spelling is "d-e-f-i-n-e".
svn:r2650
|
2004-11-03 00:02:17 +00:00 |
|
Nick Mathewson
|
a2f6210b3e
|
Add compatibility macros for printf and scanf-ing 64-bit unsigned ints
svn:r2648
|
2004-11-02 22:14:34 +00:00 |
|
Nick Mathewson
|
67f14032b1
|
Handle strlcat/strlcpy correctly on platforms that have them.
svn:r2647
|
2004-11-02 19:25:52 +00:00 |
|
Nick Mathewson
|
ad4dc74482
|
Use a stricter set of warnings; make them all pass.
svn:r2645
|
2004-11-02 03:02:17 +00:00 |
|
Roger Dingledine
|
85c79ffbc7
|
canonicalize "src" and "dest" arg order in crypto.c (and others)
svn:r2644
|
2004-11-02 02:28:51 +00:00 |
|
Nick Mathewson
|
1433a0b26f
|
Fix signed/unsigned comparison warning
svn:r2643
|
2004-11-01 22:41:32 +00:00 |
|
Roger Dingledine
|
037fba7595
|
util.c needs ctype.h for tolower and isspace
svn:r2642
|
2004-11-01 21:54:12 +00:00 |
|
Nick Mathewson
|
ce79bab7f1
|
Split util into util (general utilities), container (smartlist and strmap), and compat (cross-platform compatability).
svn:r2640
|
2004-11-01 20:41:47 +00:00 |
|
Roger Dingledine
|
4689243242
|
make sure options.MaxConn can be reached
svn:r2638
|
2004-11-01 08:24:34 +00:00 |
|
Nick Mathewson
|
ae7495dd55
|
Only tor and test binaries need to link against openssl and zlib; tor-resolve can be smaller.
svn:r2629
|
2004-10-30 19:27:06 +00:00 |
|
Nick Mathewson
|
5bc0dba933
|
Move all util functions that need openssl into crypto.c; make non-openssl functions that util needs into util. Now openssl can be separated.
svn:r2628
|
2004-10-30 19:26:31 +00:00 |
|
Nick Mathewson
|
2fbf31533b
|
Tricksy compiler warnings! We hates them, hates them forever, my precious!
svn:r2615
|
2004-10-27 21:14:11 +00:00 |
|