Nick Mathewson
718252b253
Check return value in fmt_addr
...
Previously, if tor_addr_to_str() returned NULL, we would reuse the
last value returned by fmt_addr(). (This could happen if we were
erroneously asked to format an AF_UNSPEC address.) Now instead we
return "???".
2011-07-20 13:17:48 -04:00
Nick Mathewson
3e3aac5fd5
Untangle first sentence of changes/bug3607
2011-07-19 11:14:01 -04:00
Robert Ransom
f021df5824
Specify text or binary mode in every start_writing_to_stdio_file call
2011-07-19 11:11:34 -04:00
Nick Mathewson
866a2828bd
Merge branch 'bug3577' into maint-0.2.2
2011-07-14 17:20:01 -04:00
Nick Mathewson
5000e59b5f
Change GETINFO fingerprint to look at server_mode, not my_descriptor
...
It's possible for us to be a server and have a fingerprint without
having yet generated a descriptor.
Fixes bug 3577; bugfix on 0.2.0.1-alpha
2011-07-13 12:45:18 -04:00
Roger Dingledine
8e3830352f
Merge branch 'maint-0.2.1' into maint-0.2.2
2011-07-07 13:29:02 -04:00
Roger Dingledine
51d6e95023
update to the july 2011 geoip db
2011-07-07 13:28:36 -04:00
Sebastian Hahn
3ab09763ce
Correctly send a SUCCEEDED event for rdns requests
...
The issue was that we overlooked the possibility of reverse DNS success
at the end of connection_ap_handshake_socks_resolved(). Issue discovered
by katmagic, thanks!
2011-07-07 05:38:38 +02:00
Nick Mathewson
335ff915c7
Merge remote-tracking branch 'rransom-tor/bug3465-022' into maint-0.2.2
2011-07-05 15:52:11 -04:00
Nick Mathewson
5cf725e3c6
Merge branch 'cid30_changelog' into maint-0.2.2
2011-07-01 12:55:27 -04:00
Nick Mathewson
2ba19f9b4a
Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2
2011-07-01 12:55:23 -04:00
Nick Mathewson
021cf3f052
Merge branches 'cov217_021' and 'cid_450' into maint-0.2.1
2011-07-01 12:54:51 -04:00
Nick Mathewson
959da6b7f2
Use strlcpy in create_unix_sockaddr()
...
Using strncpy meant that if listenaddress were ever >=
sizeof(sockaddr_un.sun_path), we would fail to nul-terminate
sun_path. This isn't a big deal: we never read sun_path, and the
kernel is smart enough to reject the sockaddr_un if it isn't
nul-terminated. Nonetheless, it's a dumb failure mode. Instead, we
should reject addresses that don't fit in sockaddr_un.sun_path.
Coverity found this; it's CID 428. Bugfix on 0.2.0.3-alpha.
2011-07-01 12:54:24 -04:00
Nick Mathewson
359a30d52e
Add a changelog entry for cid30 fix.
2011-07-01 12:46:26 -04:00
Nick Mathewson
d25feadebb
Fix insanely large stack_allocation in log_credential_status
...
I'm not one to insist on C's miserly stack limits, but allocating a
256K array on the stack is too much even for me.
Bugfix on 0.2.1.7-alpha. Found by coverity. Fixes CID # 450.
2011-07-01 12:38:05 -04:00
Robert Ransom
93d52f6739
Add BUILDTIMEOUT_SET to the result of GETINFO events/names
2011-06-25 15:02:11 -07:00
Nick Mathewson
8e5dfe42a0
Tweak bug2355_revert at suggestion from Roger
2011-06-19 20:58:46 -04:00
Nick Mathewson
1811bef666
Add changes file for bug2355 revert
2011-06-17 16:54:31 -04:00
Nick Mathewson
85d4c290d7
Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2
2011-06-17 15:24:23 -04:00
Robert Ransom
010b8dd4f6
Abandon rendezvous circuits on SIGNAL NEWNYM
2011-06-17 15:22:23 -04:00
Nick Mathewson
209229f100
Merge branch 'bug3407' into maint-0.2.2
2011-06-17 14:59:39 -04:00
Robert Ransom
227896e447
Make send_control_event_impl's behaviour sane
2011-06-17 13:57:25 -04:00
Robert Ransom
68cd0a9abe
Make connection_printf_to_buf's behaviour sane
2011-06-17 13:57:25 -04:00
Nick Mathewson
a25c0a5bf8
Merge remote-tracking branch 'public/bug3369' into maint-0.2.2
2011-06-14 13:46:10 -04:00
Nick Mathewson
e70e8367c9
Add changes file for bug3393
2011-06-14 13:45:12 -04:00
Nick Mathewson
e470f6a886
changelog entry for bug3369
2011-06-13 13:42:00 -04:00
Sebastian Hahn
f303274490
Fix a rare memleak during stats writing
...
If rep_hist_buffer_stats_write() was called unitinitalized, we'd leak
memory.
2011-06-08 21:35:26 +02:00
Sebastian Hahn
680646e0de
Don't use signed 1-bit bitfields
...
This was harmless, we never compared it to anything but itself or 0.
But Coverity complained, and it had a point.
2011-06-08 21:30:41 +02:00
Sebastian Hahn
e6fff7235e
Remove a few dead assignments during router parsing
2011-06-08 21:30:40 +02:00
Sebastian Hahn
ff75e8b02d
Check some more return values in unit tests
2011-06-08 21:08:56 +02:00
Sebastian Hahn
db7dd3ee7a
remove some dead code, found by coverity
2011-06-08 21:07:54 +02:00
Nick Mathewson
9e3fc5f616
Merge branch 'bug3306_nm_squashed' into maint-0.2.2
2011-06-06 16:18:24 -04:00
Nick Mathewson
42e4e156d9
Detect insanely large circuit build state; don't give its length to rand_int
2011-06-06 16:18:06 -04:00
Nick Mathewson
5afab5ca19
Check maximum properly in crypto_rand_int()
...
George Kadianakis notes that if you give crypto_rand_int() a value
above INT_MAX, it can return a negative number, which is not what
the documentation would imply.
The simple solution is to assert that the input is in [1,INT_MAX+1].
If in the future we need a random-value function that can return
values up to UINT_MAX, we can add one.
Fixes bug 3306; bugfix on 0.2.2pre14.
2011-06-06 16:18:06 -04:00
Roger Dingledine
83e3975c8b
Merge branch 'maint-0.2.1' into maint-0.2.2
2011-06-05 11:13:50 -04:00
Roger Dingledine
bf4b819aae
move to the june 1 2011 maxmind geoip db
2011-06-05 11:12:28 -04:00
Nick Mathewson
7aa20b20bf
Merge branch 'bug3318c' into maint-0.2.2
2011-06-03 11:34:32 -04:00
Nick Mathewson
bbf2fee8ff
Reject 128-byte keys that are not 1024-bit
...
When we added the check for key size, we required that the keys be
128 bytes. But RSA_size (which defers to BN_num_bytes) will return
128 for keys of length 1017..1024. This patch adds a new
crypto_pk_num_bits() that returns the actual number of significant
bits in the modulus, and uses that to enforce key sizes.
Also, credit the original bug3318 in the changes file.
2011-06-03 11:31:19 -04:00
Nick Mathewson
de069f5ea7
Merge remote-tracking branch 'rransom/bug2748-v2' into maint-0.2.2
2011-06-03 11:16:48 -04:00
Nick Mathewson
b79d50dfcc
Changes file for bug2355.
2011-06-02 15:11:21 -04:00
Nick Mathewson
80038b5453
Merge remote-tracking branch 'rransom-tor/bug3309' into maint-0.2.2
2011-06-02 15:06:04 -04:00
Nick Mathewson
385c59798a
Merge remote-tracking branch 'arma/bug3321' into maint-0.2.2
2011-06-02 12:55:56 -04:00
Robert Ransom
fc4158dad7
Add info-level log messages during HS-client-state purge
...
I hope these will never be useful, but having them and not needing them is
better than needing them and not having them.
2011-06-02 03:07:09 -07:00
Robert Ransom
b0e7925c02
Clear last_hid_serv_requests on SIGNAL NEWNYM
...
Fixes bug #3309 .
2011-06-02 02:52:40 -07:00
Nick Mathewson
0fd3ad75da
Report wrong key sizes correctly
...
When we introduced NEED_KEY_1024 in routerparse.c back in
0.2.0.1-alpha, I forgot to add a *8 when logging the length of a
bad-length key.
Bugfix for 3318 on 0.2.0.1-alpha.
2011-06-01 11:07:17 -04:00
Roger Dingledine
7039c34519
fix a bridge edge case similar to 2511
...
If you had configured a bridge but then switched to a different bridge
via the controller, you would still be willing to use the old one.
2011-05-31 20:43:55 -04:00
Nick Mathewson
e035cea031
Merge branch 'bug3216_v2' into maint-0.2.2
2011-05-30 16:12:53 -04:00
Sebastian Hahn
ca538290af
Warn when two hs use the same directory
...
This simple implementation has a few issues, but it should do for
0.2.2.x. We will want to revisit this later and make it smarter.
2011-05-30 15:47:06 -04:00
Nick Mathewson
7e67a24038
Merge branch 'bug3045' into maint-0.2.2
...
Conflicts:
src/or/circuitbuild.c
2011-05-30 15:18:59 -04:00
Nick Mathewson
da7c60dcf3
Merge remote-tracking branch 'public/bug3270' into maint-0.2.2
2011-05-30 14:49:49 -04:00