nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-14 07:03:44 +01:00
Code Issues Packages Projects Releases Wiki Activity
20,727 Commits 53 Branches 630 Tags 125 MiB
7153cd5094
Commit Graph

468 Commits

Author SHA1 Message Date
Sebastian Hahn
10fdb9ee0a Add option to not warn when getting an IP instead of hostname 2010-06-07 12:44:25 +02:00
Nick Mathewson
b006e3279f Merge remote branch 'origin/maint-0.2.1' 
Conflicts:
	src/common/test.h
	src/or/test.c
 2010-02-27 17:16:31 -05:00
Nick Mathewson
c3e63483b2 Update Tor Project copyright years 2010-02-27 17:14:21 -05:00
Nick Mathewson
350181529e Merge branch 'safelogging2' 
Conflicts:
	ChangeLog
 2009-12-15 17:26:09 -05:00
Nick Mathewson
fcbd65b45c Refactor the safe_str_*() API to make more sense. 
The new rule is: safe_str_X() means "this string is a piece of X
information; make it safe to log."  safe_str() on its own means
"this string is a piece of who-knows-what; make it safe to log".
 2009-12-15 17:25:34 -05:00
Sebastian Hahn
3807db001d *_free functions now accept NULL 
Some *_free functions threw asserts when passed NULL. Now all of them
accept NULL as input and perform no action when called that way.

This gains us consistence for our free functions, and allows some
code simplifications where an explicit null check is no longer necessary.
 2009-12-12 03:29:44 +01:00
Sebastian Hahn
f258647433 Allow SafeLogging to exclude client related information 2009-12-12 02:26:11 +01:00
Nathan Freitas
8c585cce39 Include util.h and log.h as relative paths. 
This shouldn't be necessary, but apparently the Android cross-compiler
doesn't respect -I as well as it should.  (-I is supposed to add to the
*front* of the search path.  Android's gcc wrapper apparently likes to add to
the end.  This is broken, but we need to work around it.)
 2009-09-29 00:52:52 -04:00
Nick Mathewson
707a6bd659 Merge commit 'public/socks-client' 
Resolved conflict in:
	src/or/or.h
 2009-08-26 11:27:19 -04:00
Roger Dingledine
9ece0955f7 fix comments and other typos 2009-07-13 17:34:46 -04:00
Nick Mathewson
015189b5df Move SOCKS reason-decoding switches into reasons.c 2009-06-19 12:40:23 -04:00
Christopher Davis
75472c19c3 Enable Tor to connect through SOCKS 4/5 proxies 
Added a sanity check in config.c and a check in directory.c
directory_initiate_command_rend() to catch any direct connection attempts
when a socks proxy is configured.
 2009-06-19 12:16:15 -04:00
Nick Mathewson
ec7e054668 Spell-check Tor. 2009-05-27 17:55:51 -04:00
Nick Mathewson
88d81ead83 Better debugging output for bug 977 case. 
(Don't crash immediately if we have leftover chunks to free after
freeing chunks in a buffer freelist; instead log a debugging message
that might help.)
 2009-05-12 13:54:21 -04:00
Karsten Loesing
9b32e8c141 Update copyright to 2009. 2009-05-04 11:28:27 -04:00
Nick Mathewson
c4b8fef362 Remove svn $Id$s from our source, and remove tor --version --version. 
The subversion $Id$ fields made every commit force a rebuild of
whatever file got committed.  They were not actually useful for
telling the version of Tor files in the wild.

svn:r17867
 2009-01-04 00:35:51 +00:00
Nick Mathewson
52932d6f1a Remove some code that is #ifdefed out, and that we no longer seem to use, if we ever did. 
svn:r17827
 2008-12-30 04:16:49 +00:00
Nick Mathewson
1e5f457461 Fix most DOCDOCs remaining and/or added by redox. 
svn:r17734
 2008-12-22 17:53:04 +00:00
Nick Mathewson
122170c1d3 Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this patch. 
svn:r17686
 2008-12-18 16:11:24 +00:00
Nick Mathewson
ecaee1d927 Remove fixed xxx020s; downgrade unfixed ones. 
(The unfixed ones are being downgraded to regular XXXs mainly on the rationale that they don't seem to be exploding Tor, and they were apparently not showstoppers for 0.2.0.x-final.)

svn:r17682
 2008-12-18 16:11:03 +00:00
Nick Mathewson
f43bcdc063 Use ctags and a python script to find identifiers that are never used anywhere, and remove the ones that we really want gone. 
svn:r17651
 2008-12-17 17:20:42 +00:00
Nick Mathewson
c36ddcbabf Apparently sparc64 is way more strict about uint16_t access alignment than I had thought: it gave bus errors when messing with var-cell headers. Maybe this patch will fix bug 862. 
svn:r17262
 2008-11-12 14:41:44 +00:00
Nick Mathewson
ae3ce7b387 Patch from mwenge: update TrackHostExits mapping expiry times when the mappings are used, so that they expire a while after their last use, not a while after their creation. 
svn:r17004
 2008-09-29 14:53:53 +00:00
Roger Dingledine
2bde30efa6 read_to_buf should take an int *error_socket and return it. 
svn:r16909
 2008-09-14 08:35:41 +00:00
Nick Mathewson
f95d7c189b Refactor unit test macros and tor_free_all() logic a bit so as to make it easier to free memory on failing tests, in order to suppress scanner warnings and to make dmalloc() usable with tests. 
svn:r16816
 2008-09-09 20:43:31 +00:00
Nick Mathewson
a8ddac96d8 handle ipv6 in socks5 requests. 
svn:r16476
 2008-08-08 16:41:59 +00:00
Nick Mathewson
1a76cd179a When a struct ends with char a[1], the size of all earlier members of the struct is _not_ sizeof(st)-1; compilers add alignment. Problem spotted by rovv. Backport candidate. 
svn:r16302
 2008-07-31 12:18:14 +00:00
Nick Mathewson
4630f0453d Explain how my emacs setup works in the HACKING file. Someone else may care too. 
svn:r15228
 2008-06-13 19:57:52 +00:00
Nick Mathewson
a886e86cbd r16171@tombo: nickm | 2008-06-11 13:47:41 -0400 
Lower number of syscalls used to write data to ordinary sockets through use of writev.  Disabled till I have time to test it.


svn:r15133
 2008-06-11 17:56:52 +00:00
Roger Dingledine
755cbe5d44 cosmetic patch by Bernhard M. Wiedemann, so our comments follow 
the socks5 protocol better


svn:r14552
 2008-05-04 09:36:48 +00:00
Roger Dingledine
5bf0a01011 forward-port r13799 and the 0.2.0.21-rc changelog 
svn:r13808
 2008-03-02 22:29:04 +00:00
Nick Mathewson
e68760ac0f r14388@tombo: nickm | 2008-02-21 22:44:28 -0500 
More 64-to-32 fixes.


svn:r13672
 2008-02-22 03:44:36 +00:00
Nick Mathewson
daefbfe691 r14371@tombo: nickm | 2008-02-21 16:13:18 -0500 
Fix all -Wshorten-64-to-32 warnings that appear on my macbook.


svn:r13662
 2008-02-21 21:15:31 +00:00
Nick Mathewson
0e9dcfab97 r18286@catbus: nickm | 2008-02-20 21:10:33 -0500 
Fix a bug that kept buf_find_string_offset from finding a string at the very end of the buffer.  Add a unit test for this. Also, do not save a pointer to a chunk that might get reallocated by buf_pullup().


svn:r13635
 2008-02-21 02:10:38 +00:00
Nick Mathewson
3b58f9929f r18283@catbus: nickm | 2008-02-20 18:58:31 -0500 
Fix assertion when searching for a string in an empty chunk.


svn:r13634
 2008-02-20 23:58:48 +00:00
Nick Mathewson
304bdfdc6b r18279@catbus: nickm | 2008-02-20 18:38:48 -0500 
Log message to try to detect error in buffers.c


svn:r13633
 2008-02-20 23:38:57 +00:00
Nick Mathewson
f0e523c6ef r18272@catbus: nickm | 2008-02-20 18:20:33 -0500 
add a flag to suppress overwriting the certificates file with new certificates, so we do not overwrite all certs when starting as an authority.


svn:r13630
 2008-02-20 23:20:36 +00:00
Nick Mathewson
384a8ab777 r18267@catbus: nickm | 2008-02-20 16:57:45 -0500 
Suppress signed/unsigned comparison warnings in buffers.c


svn:r13624
 2008-02-20 21:57:48 +00:00
Nick Mathewson
7521ef9a00 r18264@catbus: nickm | 2008-02-20 12:48:21 -0500 
fix bufs in buf_pos_t implementation.


svn:r13623
 2008-02-20 17:48:39 +00:00
Nick Mathewson
cefe0a1959 r18255@catbus: nickm | 2008-02-20 11:44:55 -0500 
Add asserts and refactor some comparisons in order to fix some veracode-identified issues. Note a bug in buffers.c


svn:r13618
 2008-02-20 16:57:39 +00:00
Roger Dingledine
d1a195d3cb call a "number of characters" a size_t, not an int 
svn:r13594
 2008-02-19 22:52:50 +00:00
Nick Mathewson
418c2e1b6b r14181@tombo: nickm | 2008-02-15 16:48:17 -0500 
Fix all but 2 DOCDOC items; defer many XXX020s (particularly those where fixing them would fix no bugs at the risk of introducing some bugs).


svn:r13529
 2008-02-15 23:39:04 +00:00
Nick Mathewson
f3eaeb99a3 r18051@catbus: nickm | 2008-02-12 15:20:43 -0500 
Re-tune mempool parametes based on testing on peacetime: use smaller chuncks, free them a little more aggressively, and try very hard to concentrate allocations on fuller chunks.  Also, lots of new documentation.


svn:r13484
 2008-02-12 20:20:52 +00:00
Nick Mathewson
141a5877f3 r14063@tombo: nickm | 2008-02-08 15:48:32 -0500 
Add a bunch more code documentation; change the interface of fetch_var_cell_from_buf() so it takes the current link protocol into account and can't get confused by weird command bytes on v1 connections.


svn:r13430
 2008-02-08 21:13:15 +00:00
Nick Mathewson
842a33ff20 Update some copyright notices: it is now 2008. 
svn:r13412
 2008-02-07 05:31:47 +00:00
Nick Mathewson
4d70094b6e r17951@catbus: nickm | 2008-02-06 14:34:13 -0500 
Add more documentation; change the behavior of read_to_buf_tls to be more consistent.  Note a longstanding problem with current read/write interfaces.


svn:r13407
 2008-02-06 19:34:32 +00:00
Nick Mathewson
a869574c56 r17947@catbus: nickm | 2008-02-06 11:57:53 -0500 
Fix a bunch of DOCDOC items; document the --quiet flag; refactor a couple of XXXX020 items.


svn:r13405
 2008-02-06 16:58:05 +00:00
Nick Mathewson
ec6c131da6 r17936@catbus: nickm | 2008-02-06 00:31:11 -0500 
Fix/downgrade some more XXX020s.


svn:r13397
 2008-02-06 05:31:21 +00:00
Nick Mathewson
ae6df065ed r15890@tombo: nickm | 2008-01-12 17:19:51 -0500 
Add a --disable-buffer-freelists configure argument to build without buffer RAM chunk freelists, so we can benchmark the impact of this.


svn:r13121
 2008-01-13 00:20:44 +00:00
Nick Mathewson
614dc52623 r17467@catbus: nickm | 2008-01-05 19:54:20 -0500 
fix whitespace


svn:r13035
 2008-01-06 00:54:22 +00:00
Nick Mathewson
46a27c2f93 r15750@tombo: nickm | 2007-12-29 19:12:51 -0500 
Make HTTP-processing code in buffers.c faster: do not pull up 50K of text into the first chunk if the headers end earlier than that.


svn:r13006
 2007-12-30 00:13:07 +00:00
Nick Mathewson
cd85eac0d3 r17433@catbus: nickm | 2007-12-29 12:35:57 -0500 
Incomplete code to avoid doing needless pull-ups on HTTP.  Also, use memstr instead of strstr to find the content-length header.


svn:r13005
 2007-12-29 17:36:03 +00:00
Nick Mathewson
f4f5dc4aca r15745@tombo: nickm | 2007-12-29 00:15:17 -0500 
Try even harder not to allocate chunks bigger than MAX_CHUNK_ALLOC.


svn:r13003
 2007-12-29 05:16:30 +00:00
Nick Mathewson
bd32982c77 r17426@catbus: nickm | 2007-12-28 21:12:29 -0500 
Remove need for buf_pullup in fetch_line_from_buf().


svn:r13002
 2007-12-29 02:33:42 +00:00
Nick Mathewson
d7f5a73173 r17410@catbus: nickm | 2007-12-27 09:20:27 -0500 
Exciting new entries in buf_dump_freelist_sizes() to make sure our freelist sizes are reasonable.


svn:r12996
 2007-12-27 14:20:30 +00:00
Nick Mathewson
1a2b6c2ae3 r17407@catbus: nickm | 2007-12-27 00:18:31 -0500 
Fix windows compile error


svn:r12995
 2007-12-27 05:18:36 +00:00
Nick Mathewson
119b4e1edf r17405@catbus: nickm | 2007-12-26 22:27:37 -0500 
And clean up an assertion failure.


svn:r12993
 2007-12-27 03:27:48 +00:00
Nick Mathewson
148e2e1c48 r17403@catbus: nickm | 2007-12-26 22:23:50 -0500 
Apparently loops work better when you actually increment/decrement the loop variable.  Who knew?


svn:r12992
 2007-12-27 03:23:57 +00:00
Nick Mathewson
1503021ee5 r15723@tombo: nickm | 2007-12-26 19:25:51 -0500 
Actually trim freelists.


svn:r12991
 2007-12-27 00:25:54 +00:00
Nick Mathewson
3a5bee150f r15721@tombo: nickm | 2007-12-26 17:07:10 -0500 
Fix a nasty infinite loop in flush_buf[_tls].


svn:r12990
 2007-12-26 22:07:14 +00:00
Nick Mathewson
27220fb395 r15719@tombo: nickm | 2007-12-26 14:02:12 -0500 
More tweaks on 0-byte TLS writes.


svn:r12989
 2007-12-26 19:02:15 +00:00
Nick Mathewson
80151b42df r15717@tombo: nickm | 2007-12-26 13:55:53 -0500 
Oops.  flush_buf_tls can request more than the requested number of bytes.  When that happens, do not let the size_t sz wrap around.


svn:r12988
 2007-12-26 18:55:56 +00:00
Nick Mathewson
84b6e26c50 r15715@tombo: nickm | 2007-12-26 13:09:27 -0500 
Peacetime managed to run overnight in paranoia mode.  Disabling paranoia, so that buffers.c can be a little speedy again.


svn:r12987
 2007-12-26 18:09:36 +00:00
Nick Mathewson
fb8cbc8642 r15710@tombo: nickm | 2007-12-25 19:36:03 -0500 
Fix in flush_buf_tls: it is okay to flush an empty buffer, since we may have a partial TLS record pending.


svn:r12984
 2007-12-26 00:36:05 +00:00
Nick Mathewson
a7ef07b4bd r15693@tombo: nickm | 2007-12-25 19:11:29 -0500 
Here, have some terribly clever new buffer code.  It uses a mbuf-like strategy rather than a ring buffer strategy, so it should require far far less extra memory to hold any given amount of data.  Also, it avoids access patterns like x=malloc(1024);x=realloc(x,1048576);x=realloc(x,1024);append_to_freelist(x) that might have been contributing to memory fragmentation.  I've  tested it out a little on peacetime, and it seems to work so far.  If you want to benchmark it for speed, make sure to remove the #define PARANOIA; #define NOINLINE macros at the head of the module.


svn:r12983
 2007-12-26 00:12:08 +00:00
Roger Dingledine
1d8a8063b9 clean up copyrights, and assign 2007 copyrights to The Tor Project, Inc 
svn:r12786
 2007-12-12 21:09:01 +00:00
Roger Dingledine
2b8ca7b4a4 patch from karsten to clean up documentation and to integrate 
more fixes into rend-spec.txt.


svn:r12715
 2007-12-07 21:27:58 +00:00
Nick Mathewson
2e378295d6 r16997@catbus: nickm | 2007-12-06 18:56:33 -0500 
Make http://torproject urls into https://torproject urls.  Patch from steve.


svn:r12708
 2007-12-06 23:56:36 +00:00
Nick Mathewson
92372b156a r16995@catbus: nickm | 2007-12-06 18:42:53 -0500 
patch from steve: replace more tor.eff.org instances with torproject.org


svn:r12707
 2007-12-06 23:42:59 +00:00
Roger Dingledine
8ac5f24c33 easy tweaks on r12607 
svn:r12608
 2007-11-29 15:30:32 +00:00
Roger Dingledine
aaf35cccf7 karsten's second refactoring patch 
svn:r12607
 2007-11-29 15:25:04 +00:00
Nick Mathewson
6fcda5299f r14727@31-33-67: nickm | 2007-11-05 18:34:35 -0500 
Make VERSIONS variable-length.


svn:r12391
 2007-11-05 23:34:39 +00:00
Nick Mathewson
9a20a64b62 r16438@catbus: nickm | 2007-11-05 16:45:45 -0500 
Initial code for variable-length cells. CERT and VERSIONS  need to use them.


svn:r12390
 2007-11-05 21:46:35 +00:00
Roger Dingledine
e5885deab5 Separate "SOCKS_COMMAND_CONNECT_DIR" into two flags in 
edge_connection_t: want_onehop if it must attach to a circuit with
only one hop (e.g. for the current tunnelled connections that use
begin_dir), and use_begindir if we mean to use a BEGIN_DIR relay
command to establish the stream rather than the normal BEGIN. Now
we can make anonymized begin_dir connections for (e.g.) more secure
hidden service posting and fetching.


svn:r12244
 2007-10-28 08:16:19 +00:00
Peter Palfrader
1a94e84661 Say "using socksX _to_ port y" instead of "socksX _on_ port y". it confuses weasel less 
svn:r11834
 2007-10-10 15:44:34 +00:00
Nick Mathewson
91f83cfc2d r14830@catbus: nickm | 2007-08-29 13:50:10 -0400 
Make controllers accept LF as well as CRLF.  Update spec to reflect this.  Remove now-dead code.  Make controller warning about v0 protocol more accurate.


svn:r11299
 2007-08-29 19:02:33 +00:00
Nick Mathewson
480db0f00a r14034@catbus: nickm | 2007-07-31 05:22:56 -0400 
possible fix for bug 473: always set buf->cur on buf_remove_from_front.


svn:r11004
 2007-07-31 09:31:15 +00:00
Nick Mathewson
9fb77a6479 Disable SENTINELS in buffers: it may be responsible for making platform mallocs() be inefficient, and we havent needed it in a long long time. 
svn:r10994
 2007-07-30 17:51:14 +00:00
Nick Mathewson
9260a824ef Yet another buffer RAM patch: tNever ever ever keep a buffer memory chunk around for an empty buffer that could go on the freelist. This wants profiling to make sure that performance doesnt suffer. 
svn:r10993
 2007-07-30 17:47:43 +00:00
Nick Mathewson
0d274e1db1 r13952@catbus: nickm | 2007-07-27 19:18:46 -0400 
Weasel noticed that many buffers spend their time with empty 4k, 8k, and 16k memory chunks.  Thus, be more aggressive about putting empty chunks on the freelist, regardless of their high water marks.  (Also, run buffer_shrink_freelist on the 8k-chunk freelist.)


svn:r10953
 2007-07-27 23:19:02 +00:00
Nick Mathewson
a5477c7bb9 r13944@catbus: nickm | 2007-07-27 15:52:35 -0400 
Fix warnings on platforms where rlim values can be signed.
 Add an 8k buffer freelist.
 


svn:r10948
 2007-07-27 19:53:29 +00:00
Nick Mathewson
bc9a7be943 r13939@catbus: nickm | 2007-07-27 14:33:22 -0400 
When dumping memory usage, list bytes used in buffer memory free-lists.


svn:r10947
 2007-07-27 18:33:37 +00:00
Roger Dingledine
a1ab2c8087 free bridge list on exit; try harder to free buffer freelists on exit. 
svn:r10854
 2007-07-17 11:33:38 +00:00
Roger Dingledine
fcbb817db5 free another string, and the buffer freelists, on exit. 
svn:r10851
 2007-07-17 09:26:45 +00:00
Nick Mathewson
5adfa09fce r13477@catbus: nickm | 2007-06-17 14:22:03 -0400 
Sun CC likes to give warnings for the do { } while(0) construction for making statement-like macros.  Define STMT_BEGIN/STMT_END macros that do the right thing, and use them everywhere.


svn:r10645
 2007-06-17 18:22:39 +00:00
Nick Mathewson
1866ad3506 r13274@catbus: nickm | 2007-06-05 19:06:30 -0400 
Remove some deadcode that seems unlikely to return


svn:r10509
 2007-06-06 04:51:25 +00:00
Nick Mathewson
9aaf3d182f r12934@catbus: nickm | 2007-05-24 14:11:18 -0400 
When freeing slack buffers, free the buffers at the end of the freelist first.


svn:r10313
 2007-05-24 18:12:41 +00:00
Nick Mathewson
e043b86f47 r12764@catbus: nickm | 2007-05-15 17:17:39 -0400 
Enable (and cope with) more GCC 4.2 warnings.


svn:r10196
 2007-05-15 21:17:48 +00:00
Nick Mathewson
e3b2a7b53b r12935@Kushana: nickm | 2007-05-10 11:25:09 -0400 
Make buffer unit tests pass again


svn:r10158
 2007-05-10 15:25:40 +00:00
Roger Dingledine
8e8144cd58 fix a printf size_t/int mismatch from r10150 
svn:r10152
 2007-05-10 04:04:44 +00:00
Nick Mathewson
34a09c24b5 r12706@catbus: nickm | 2007-05-09 18:39:46 -0400 
Keep two freelists for buffer ram chunks: one of 4k chunks, and one of 16k chunks.  Also, document the whole business.


svn:r10150
 2007-05-09 22:39:49 +00:00
Nick Mathewson
b248ed620f r12704@catbus: nickm | 2007-05-09 17:43:34 -0400 
Periodically clean the freelist of buffer memory chunks.


svn:r10149
 2007-05-09 21:43:41 +00:00
Roger Dingledine
3d00738ec7 simplify connection_watch_events() 
hope this doesn't break it


svn:r10025
 2007-04-25 07:20:04 +00:00
Nick Mathewson
94eef608ae r12784@Kushana: nickm | 2007-04-23 19:24:09 -0400 
Avoid another assert failure in the new buffer memory code.  (This time, it hit when freeing a 4k buffer with some data on it.)


svn:r10011
 2007-04-23 23:24:53 +00:00
Nick Mathewson
3831d77dba r12782@Kushana: nickm | 2007-04-23 18:20:19 -0400 
Avoid a segfault when freeing a buffer with size 0.


svn:r10010
 2007-04-23 22:20:45 +00:00
Nick Mathewson
2f4784cbd8 r12499@catbus: nickm | 2007-04-23 10:42:23 -0400 
Keep a freelist of unused 4k buffer chunks, rather than wasting 8k for every inactive connection_t.


svn:r10006
 2007-04-23 14:42:27 +00:00
Nick Mathewson
473c266fc2 r12496@catbus: nickm | 2007-04-22 23:04:05 -0400 
When logging memory usage, break down memory used in buffers by buffer type.


svn:r10004
 2007-04-23 03:04:46 +00:00
Nick Mathewson
648065fcb4 r12763@Kushana: nickm | 2007-04-20 18:42:58 -0400 
Initial version of code to stop using socket pairs for linked connections.  Superficially, it seems to work, but it probably needs a lot more testing and attention.


svn:r9995
 2007-04-21 17:26:12 +00:00
Nick Mathewson
92f62b3684 r12077@catbus: nickm | 2007-03-04 16:08:23 -0500 
Remove support for v0 control protocol from 0.2.0.x trunk; send back error when we receive a v0 control message.  (Leave "if(v1){...}"blocks indented for now so this patch is easier to read.)  ((Finally, the linecount goes _down_ a little.))


svn:r9735
 2007-03-04 21:08:28 +00:00
Roger Dingledine
50f22e858a doc pedant 
svn:r9634
 2007-02-24 07:50:38 +00:00
Nick Mathewson
11e5656ab7 r11826@catbus: nickm | 2007-02-16 14:58:38 -0500 
Resolve 56 DOCDOC comments.


svn:r9594
 2007-02-16 20:01:02 +00:00
Nick Mathewson
759c58151e r11775@catbus: nickm | 2007-02-12 16:39:09 -0500 
Update copyright dates.


svn:r9570
 2007-02-12 21:39:53 +00:00
Nick Mathewson
fefba95363 r11629@catbus: nickm | 2007-02-02 15:06:17 -0500 
Removing the last DOCDOC comment hurt so much that I had to use Doxygen to identify undocumented macros and comments, and add 150 more DOCDOCs to point out where they were.  Oops.  Hey, kids!  Fixing some of these could be your first Tor patch!


svn:r9477
 2007-02-02 20:06:43 +00:00
Nick Mathewson
ead35ef944 r11957@Kushana: nickm | 2007-01-15 15:25:57 -0500 
Patch from Mike Perry: Track reasons for OR connection failure; display them in control events. Needs review and revision.


svn:r9354
 2007-01-15 21:13:37 +00:00
Nick Mathewson
c8466c5919 r11824@Kushana: nickm | 2007-01-03 17:15:28 -0500 
control-spec: upcase arguments in status events; note unimplemented events individually
 r11825@Kushana:  nickm | 2007-01-03 17:41:43 -0500
 Implement EXTERNAL IP server status event.
 r11826@Kushana:  nickm | 2007-01-03 17:47:10 -0500
 Implement BAD_SERVER_DESCRIPTOR server status event.
 r11827@Kushana:  nickm | 2007-01-03 18:01:56 -0500
 Implement SOCKS_UNKNOWN_PROTOCOL and DANGEROUS_SOCKS client events.
 r11828@Kushana:  nickm | 2007-01-03 18:23:22 -0500
 Implement BUG controller events. Also, flush ERR-level status events just like ERR-level log messages.
 r11829@Kushana:  nickm | 2007-01-03 23:37:27 -0500
 Yet more status events: CLOCK_SKEW, GOOD/ACCEPTED_SERVER_DESCRIPTOR, {CHECKING_}REACHABILITY_{SUCCEEDED|FAILED}
 r11833@Kushana:  nickm | 2007-01-05 16:56:37 -0500
 Note some unimplementedness in control-spec.txt


svn:r9279
 2007-01-06 05:42:31 +00:00
Roger Dingledine
30e4f4f6ce when we're doing a write split over the end of a circular 
buffer, make sure our tls_get_forced_write_size doesn't
make it write whatever's after the buffer.

this hasn't triggered yet, but it would be rare, so let's
leave it in.


svn:r9107
 2006-12-14 03:26:42 +00:00
Nick Mathewson
c9c8072bd3 r11569@Kushana: nickm | 2006-12-13 17:59:58 -0500 
fix last fix


svn:r9106
 2006-12-13 23:00:05 +00:00
Nick Mathewson
43e06eba8b r11566@Kushana: nickm | 2006-12-13 17:46:24 -0500 
Try to fix an assert failure in new write limiting code: make buffers.c aware of previous "forced" write sizes from tortls.


svn:r9105
 2006-12-13 22:46:42 +00:00
Roger Dingledine
0dbf725927 Infrastructure to test BEGIN_DIR cells. 
New socks command CONNECT_DIR. New config option TunnelDirConns that
builds a circ ending at the directory server and delivers a BEGIN_DIR
cell if it's running 0.1.2.2-alpha or later. We still need to make
one-hop circs when appropriate, while making other conns avoid them.


svn:r9098
 2006-12-13 00:28:56 +00:00
Nick Mathewson
ad1f019110 r9317@totoro: nickm | 2006-11-13 22:45:33 -0500 
Fix some more mipspro warnings.  Nothing should remain excecpt "conversion from pointer to same-sized integral type."


svn:r8950
 2006-11-14 03:45:48 +00:00
Nick Mathewson
1913cb915e r9308@totoro: nickm | 2006-11-13 18:41:23 -0500 
Add support for (Free?)BSD's natd, which was an old way to let you
 have your firewall automatically redirect traffic.  (Original patch
 from Zajcev Evgeny, updated for 0.1.2.x by tup.)
 


svn:r8946
 2006-11-14 00:06:31 +00:00
Roger Dingledine
8f7940348f Avoid an infinite loop on evil controlport input. Fixes bug 350, 
unless it doesn't. (Nick, please confirm.)

Backport candidate.


svn:r8844
 2006-10-28 08:17:02 +00:00
Roger Dingledine
7d33c4b904 clean up and downgrade some log messages 
svn:r8727
 2006-10-15 07:42:51 +00:00
Nick Mathewson
213658f117 r8894@Kushana: nickm | 2006-09-21 18:30:42 -0400 
Specify and implement SOCKS5 interface for reverse hostname lookup.


svn:r8451
 2006-09-22 00:43:55 +00:00
Nick Mathewson
93beeac01d Merge in some bsockets calls, all wrapped inside #if defined(USE_BSOCKETS) 
svn:r8427
 2006-09-19 20:41:31 +00:00
Nick Mathewson
dbe0c6f6ef r8609@Kushana: nickm | 2006-08-27 17:24:27 -0400 
Add some doxygen, concentrated in dns.c


svn:r8256
 2006-08-28 03:16:02 +00:00
Nick Mathewson
fd36eb0788 r8576@Kushana: nickm | 2006-08-25 17:16:01 -0400 
Fix bug 314: Instead of checking address_in_virtualrange, check addressmap_have_mapping().  This should be more accurate.  [Rename to addressmap_have_mapping() from addressmap_already_mapped().]


svn:r8226
 2006-08-25 21:16:22 +00:00
Roger Dingledine
0649fa14c1 make our socks5 handling more robust to broken socks clients: 
throw out everything waiting on the buffer in between socks
handshake phases, since they can't possibly (so the theory
goes) have predicted what we plan to respond to them.


svn:r8223
 2006-08-24 04:51:55 +00:00
Roger Dingledine
3d79eb52ab stick to nick's nul/null convention 
svn:r6763
 2006-07-15 19:21:30 +00:00
Nick Mathewson
b4b8da5d23 Turn a while into a do/while; save a redundant test 
svn:r6683
 2006-06-24 02:10:21 +00:00
Nick Mathewson
5c0d7fb016 Resolve control flow warning. 
svn:r6658
 2006-06-18 20:39:46 +00:00
Nick Mathewson
0932f463ff Ah. That seems to work. 
svn:r6657
 2006-06-18 16:39:26 +00:00
Nick Mathewson
5ba72d0ae5 another write_to_buf_zlib fix. 
svn:r6656
 2006-06-18 16:20:38 +00:00
Nick Mathewson
a9cffd2ff0 Re-enable buffer RAM guard values. 
svn:r6653
 2006-06-18 15:53:54 +00:00
Nick Mathewson
11c2e97d51 Another _zlib fix. 
svn:r6652
 2006-06-18 09:03:48 +00:00
Nick Mathewson
10b7b57616 Temporarily disable sentinels on buffers 
svn:r6649
 2006-06-18 08:44:34 +00:00
Nick Mathewson
9376d901ed make zlib buffer function set buf_highwater properly 
svn:r6648
 2006-06-18 08:21:27 +00:00
Nick Mathewson
cd38511a1e Part of incremental encryption logic for buffers: there is a subtle yucky point documented in a comment. 
svn:r6637
 2006-06-18 07:27:47 +00:00
Roger Dingledine
fab1feee26 complain when we hit wsaenobufs on recv or write too. 
perhaps this will help us hunt the bug.


svn:r6321
 2006-04-08 07:54:11 +00:00
Roger Dingledine
d8195e4128 Implement Jason Holt's SafeSocks config option. 
Also put a URL in the warning message for unsafe socks4 use --
previously we'd only had the URL for unsafe socks5 use. Oops.


svn:r6190
 2006-03-19 01:44:53 +00:00
Roger Dingledine
9a5df4cef5 resume being printist: if the hostname contains non-printable 
characters, then fail. this time don't even bother telling the
server operator about these cases, because what's he going to do?

if it turns out that some significant population somewhere in the
world uses non-printable hostnames and wants to use tor, then i
hereby assume that they will contact us.


svn:r6171
 2006-03-15 23:36:57 +00:00
Roger Dingledine
e8fd871d8b Stop being printist: just because our local platform doesn't 
consider an alleged destination to be printable doesn't mean
nobody in the world will want to use it.


svn:r6167
 2006-03-15 19:17:34 +00:00
Nick Mathewson
bd8ffccae7 More cleanups noticed by weasel; also, remove macros that nobody uses. 
svn:r6143
 2006-03-12 23:31:16 +00:00
Nick Mathewson
5777ee0e1a Add some functions to escape values from the network before sending them to the log. Use them everywhere except for routerinfo->plaftorm, routerinfo->contact_info, and rend*.c. (need sleep now) 
svn:r6087
 2006-03-05 09:50:26 +00:00
Roger Dingledine
36484f873a convert some more source files to the new log convention 
svn:r6002
 2006-02-13 08:28:42 +00:00
Roger Dingledine
5f051574d5 Happy new year! 
svn:r5949
 2006-02-09 05:46:49 +00:00
Nick Mathewson
1af630d32c Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. 
svn:r5582
 2005-12-14 20:40:40 +00:00
Roger Dingledine
58366ffd24 when we changed from log_fn to debug/info/notice/warn/err, 
we screwed up the formatting in wild and unpredictable ways.

fix it before it becomes convention to format logs in wild and
unpredictable ways.

still need to do src/common/ someday.


svn:r5551
 2005-12-10 09:36:26 +00:00
Nick Mathewson
39265dd72e In my private little universe, terminals are still 80 columns. Impose a 160-character-per-line limit; this will creep down. 
svn:r5548
 2005-12-09 05:37:26 +00:00
Nick Mathewson
fea19528a1 assert_buf_ok was showing up in the profile; remove it from critical-path functions, since it hasnt triggered for ages. 
svn:r5479
 2005-11-30 22:48:58 +00:00
Roger Dingledine
c4aa9e7941 Add a new config option TestSocks so people can see if their 
applications are using socks4, socks4a, socks5-with-ip, or
socks5-with-hostname. This way they don't have to keep mucking
with tcpdump and wondering if something got cached somewhere.


svn:r5399
 2005-11-16 23:37:35 +00:00
Roger Dingledine
bf2be9abd7 Do round-robin writes of at most 16 kB per write. This might 
be more fair on loaded Tor servers, and it might resolve our
Windows crash bug. It might also slow things down.


svn:r5332
 2005-10-29 18:19:37 +00:00
Nick Mathewson
5d85560d9e Remove last vestiges of old logging interface. 
svn:r5317
 2005-10-25 18:01:01 +00:00
Nick Mathewson
f9b0be526e Use LD_BUG as appropriate; convert rend* and router* to new logging interface; use new circ_log_path interface 
svn:r5302
 2005-10-24 19:39:45 +00:00
Nick Mathewson
55f2ab9cc3 Migrate a few more files to domained logging 
svn:r5285
 2005-10-18 22:21:29 +00:00
Nick Mathewson
998cf8d622 Try to extract as many descriptors as possible from truncated http responses. (when DIR_PURPOSE_FETCH_ROUTERDESC) 
svn:r5249
 2005-10-14 02:26:13 +00:00
Nick Mathewson
ba24193ab5 Make doxygen marginally happier 
svn:r5208
 2005-10-06 04:33:40 +00:00
Nick Mathewson
de198d800b Never call free() on tor_malloc()d memory. This is unlikely to be our current leak, but it may help dmalloc work. 
svn:r5168
 2005-09-30 20:47:58 +00:00
Nick Mathewson
92451f74a8 Reformat inconsistent function declarations. 
svn:r5160
 2005-09-30 01:09:52 +00:00
Roger Dingledine
fba01c3cc0 bugfix: we were whining about using socks4 or socks5-with-local-lookup 
even when they used an IP in the "virtual" range we designed exactly
for this case.


svn:r5142
 2005-09-24 21:56:04 +00:00
Roger Dingledine
6a52aa52fe fix a pair of hard-coded urls 
svn:r4887
 2005-08-30 07:01:30 +00:00
Nick Mathewson
4870877231 Add SOCKSAndDNS link to appropriate log message, since we wind up pointing everybody to it anyway 
svn:r4695
 2005-08-04 20:12:44 +00:00
Nick Mathewson
0828feaf7c Add belt-and-suspenders fix to coredump from yesterday; document more functions in buffers.c 
svn:r4532
 2005-07-12 18:19:30 +00:00
Roger Dingledine
8f9790a023 fix a seg fault with autodetecting which controller version is being used 
svn:r4531
 2005-07-12 05:48:15 +00:00
Roger Dingledine
9c67ae34f1 overall cleanup and streamlining and doccing 
also fix a DoS avenue on dirservers


svn:r4468
 2005-06-20 23:04:13 +00:00
Nick Mathewson
9b4aa8d2ab Implement all the easy bits of the new control protocol 
svn:r4449
 2005-06-17 20:37:21 +00:00
Nick Mathewson
f9f09f1c5e Start implementing framework for revised control spec. 
svn:r4447
 2005-06-17 18:49:55 +00:00
Roger Dingledine
91b1fb7ff7 some more cleaning and docing 
svn:r4415
 2005-06-11 21:17:38 +00:00
Nick Mathewson
232861ba42 Docment or add DOCDOC comments to undocumented functions in src/or. Make function definition format uniform. 
svn:r4411
 2005-06-11 18:52:12 +00:00
Roger Dingledine
2587fa09f9 move more docs into our code 
svn:r4406
 2005-06-11 06:07:22 +00:00
Roger Dingledine
fcd0fc3364 flesh out the source file descriptions for doxygen 
svn:r4404
 2005-06-11 05:31:17 +00:00
Nick Mathewson
0831823763 Change end-of-file NLNL convention. It turns out arma I and I agree. 
svn:r4382
 2005-06-09 19:03:31 +00:00
Roger Dingledine
d922fa7b10 fix another underflow in keeping stats 
these size_ts are subtle buggers


svn:r4364
 2005-06-09 03:57:54 +00:00
Nick Mathewson
87caad5445 Fix an underflow in buffer use conting. 
svn:r4360
 2005-06-08 21:55:02 +00:00
Nick Mathewson
b0538591c7 Reset buf->highwater every time buf_shrink is called, not just on suffessful shrink. 
svn:r4353
 2005-06-08 20:17:32 +00:00
Roger Dingledine
4c43789435 Some play code to throw away old buffers sometimes rather 
than constantly reallocing them; just in case this is our memory
problem. It looks for now like it isn't, so disabled.


svn:r4349
 2005-06-08 17:27:11 +00:00
Nick Mathewson
baa10cbbfa Instrument buffers.c and rephist.c memory usage 
svn:r4317
 2005-06-06 17:03:21 +00:00
Roger Dingledine
5265bbd2b8 first iteration of scrubbing sensitive strings from logs. 
also generally clean up log messages.


svn:r4174
 2005-05-03 10:04:08 +00:00
Nick Mathewson
8b9ae25224 Change some >=s to >s in buf_resize, so that we do not denormalize buffers on resize. 
svn:r4172
 2005-05-03 03:25:04 +00:00
Nick Mathewson
14bac4dad4 Elaborate on buf_shrink comment. 
svn:r4169
 2005-05-02 23:41:39 +00:00
Roger Dingledine
aa6bcd50ca comment buf_shrink 
svn:r4168
 2005-05-02 23:39:09 +00:00
Nick Mathewson
ad547cbb8c Correct and simplify buf_shrink logic 
svn:r4167
 2005-05-02 23:36:13 +00:00
Nick Mathewson
d6a6c8785b When removing all bytes from a buffer, reset buf->cur=buf->mem 
svn:r4166
 2005-05-02 23:32:23 +00:00
Nick Mathewson
a312ce1d3b Change buffer shrinking strategy: only try to shrink once every 3 minutes. Do not try to read over buffer size unless buffer is nearly empty. 
svn:r4165
 2005-05-02 23:17:08 +00:00
Nick Mathewson
9c683c7613 Make buffer shrinking algorithm a little smarter. 
svn:r4164
 2005-05-02 22:49:24 +00:00
Nick Mathewson
fe65e57ca1 Re-do fragmented control message handling to work with new buf_t system. 
svn:r4144
 2005-04-27 22:01:34 +00:00
Nick Mathewson
d0a9a8bdd3 Appease VC7. It has a strangely puritanical attitude about what programmers are allowed to do a consenting void*. 
svn:r4140
 2005-04-27 20:02:52 +00:00
Nick Mathewson
53607d3bb3 Turn SENTINELS back on; give NOINLINE a name and turn it off. 
svn:r4139
 2005-04-27 19:40:31 +00:00
Roger Dingledine
4c4a14e3cb turn off the mongo debugging stuff, for performance tests 
svn:r4137
 2005-04-27 17:21:42 +00:00
Nick Mathewson
52376dc9e8 Rename buf->start to buf->cur; fix bug in read_to_buf; still debug with paranoia. 
svn:r4130
 2005-04-27 02:55:21 +00:00
Nick Mathewson
746768df5d Add even more debugging code; temporarily disable inlines in buffers.c 
svn:r4129
 2005-04-27 00:53:44 +00:00
Roger Dingledine
2a7aec0ffd fix function prototype, fix typo 
svn:r4126
 2005-04-26 21:29:20 +00:00
Nick Mathewson
ecc76d8245 Avoid overflow on wrapping a TLS read. 
svn:r4125
 2005-04-26 21:20:22 +00:00
Nick Mathewson
9ba2dd7ea1 Clean/renormalize whitespace 
svn:r4122
 2005-04-26 20:55:32 +00:00
Nick Mathewson
ef2409e4ed Change the implementation of buf_t a lot: make it a ring buffer to minimize memmove on flush. This may break the universe, but it is probably Necessary For Perfomance. 
svn:r4121
 2005-04-26 20:53:22 +00:00
Roger Dingledine
12ea3a26b2 bugfix: make a debug log stop lying 
svn:r4110
 2005-04-25 15:43:05 +00:00
Nick Mathewson
5827e2e216 Fix "JAP-client" hideous ASN1 bug, twice. (Fix1: check more thoroughly for TLS errors when handling certs. Fix2: stop assert(0)ing on uncaught TLS errors.) 
svn:r4085
 2005-04-23 14:26:02 +00:00
Roger Dingledine
97637549bb tie MAX_DIR_SIZE to MAX_BUF_SIZE 
resolve bug 80


svn:r4052
 2005-04-07 22:13:17 +00:00
Nick Mathewson
0e81265359 update copyright notices. 
svn:r3982
 2005-04-01 20:15:56 +00:00
Nick Mathewson
97dad670ea Renormalize whitespace 
svn:r3757
 2005-03-14 03:18:35 +00:00
Nick Mathewson
aaf70df3bd Fix signed/unsigned warning 
svn:r3736
 2005-03-10 18:45:42 +00:00
Nick Mathewson
b494c2223d Specify and implement fragmented control messages to allow for (among other things) long GETINFO replies. Otherwise we could hit the 64K barrier on questions like "please dump your client-side DNS cache." 
svn:r3726
 2005-03-02 20:22:10 +00:00
Nick Mathewson
4ddf768a4f Forward-port new reasons; clean up code more; add code to convert new reasons to SOCKS5 reply codes; add code to convert errnos to reasons. New code still needs to get invoked. 
svn:r3719
 2005-03-01 22:16:15 +00:00
Nick Mathewson
6e6d95b3db Change from inet_ntoa to a threadproof tor_inet_ntoa. 
svn:r3656
 2005-02-22 08:18:36 +00:00
Roger Dingledine
a005509c9d update url for when users try to use socksport as an http proxy 
svn:r3265
 2005-01-03 23:19:15 +00:00
Roger Dingledine
f50b785c3b and forward port the cleanup 
svn:r3211
 2004-12-22 10:04:50 +00:00
Roger Dingledine
18320557a1 fix a crash: if you do socks4 with an IP of 0.0.0.x then we get tricked 
into thinking you're doing socks4a, and we look for the next byte.

thanks to aphex for finding this.


svn:r3207
 2004-12-22 09:52:29 +00:00
Roger Dingledine
ad4f440e10 rearrange debug logs to make more sense 
svn:r3116
 2004-12-07 21:57:10 +00:00
Nick Mathewson
b457cfb5eb Spell-check strings and comments 
svn:r3052
 2004-12-01 03:48:14 +00:00
Nick Mathewson
7fbd297532 Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. 
svn:r3019
 2004-11-29 22:25:31 +00:00