Nick Mathewson
6a1e0c2373
r18356@catbus: nickm | 2008-02-21 21:54:55 -0500
...
Remove redundant check from container.c that gcc 4.2 didnt like
svn:r13668
2008-02-22 02:55:02 +00:00
Nick Mathewson
b21a122ef6
r14379@tombo: nickm | 2008-02-21 17:14:24 -0500
...
Enable v2 handshakes.
svn:r13666
2008-02-21 22:14:32 +00:00
Nick Mathewson
69300eb606
r14374@tombo: nickm | 2008-02-21 16:57:39 -0500
...
Fix all remaining shorten-64-to-32 errors in src/common. Some were genuine problems. Many were compatibility errors with libraries (openssl, zlib) that like predate size_t. Partial backport candidate.
svn:r13665
2008-02-21 21:57:47 +00:00
Nick Mathewson
b375472d14
r14373@tombo: nickm | 2008-02-21 16:29:18 -0500
...
Apply warnings about implicit 64-to-32 conversions; some from Sebastian Hahn; some not.
svn:r13664
2008-02-21 21:57:42 +00:00
Roger Dingledine
1cd90948ab
maybe appease the overflow detectors more
...
svn:r13663
2008-02-21 21:56:04 +00:00
Nick Mathewson
daefbfe691
r14371@tombo: nickm | 2008-02-21 16:13:18 -0500
...
Fix all -Wshorten-64-to-32 warnings that appear on my macbook.
svn:r13662
2008-02-21 21:15:31 +00:00
Nick Mathewson
5c03f82a65
r18345@catbus: nickm | 2008-02-21 13:45:04 -0500
...
Do the last part of arma's fix for bug 437: Track the origin of every addrmap, and use this info so we can remove all the trackhostexits-originated mappings for a given exit.
svn:r13660
2008-02-21 18:45:11 +00:00
Nick Mathewson
0ba2bfeef6
r14363@31-33-219: nickm | 2008-02-21 11:11:33 -0500
...
Answer the next-to-last XXX020rc item.
svn:r13658
2008-02-21 16:12:01 +00:00
Nick Mathewson
e2f25558b9
r14362@31-33-219: nickm | 2008-02-21 11:01:10 -0500
...
Change some of our log messages related to closed TLS connections in order to better reflect reality.
svn:r13657
2008-02-21 16:11:58 +00:00
Nick Mathewson
e18ee2a2ab
r14357@31-33-219: nickm | 2008-02-21 10:39:11 -0500
...
Fix bug-handling code for unhandled write errors, so that it does not try to flush any data on the failed connection. Bugfix on 0.1.2.x.
svn:r13655
2008-02-21 15:39:26 +00:00
Nick Mathewson
41eca067a1
r14356@31-33-219: nickm | 2008-02-21 10:38:26 -0500
...
Defer a couple of XXX020rc items, based on recommendation from arma.
svn:r13654
2008-02-21 15:39:24 +00:00
Nick Mathewson
8b1789c71f
r18336@catbus: nickm | 2008-02-21 09:33:15 -0500
...
Patch from Sebastian Hahn: remove obsolete timeval manipulation functions.
svn:r13653
2008-02-21 14:33:20 +00:00
Roger Dingledine
b3c0d066e5
other cleanups that have been sitting in my sandbox
...
svn:r13649
2008-02-21 09:01:32 +00:00
Roger Dingledine
a60f7caa54
start allowing clients to give up on trackhostexits targets if
...
five circuit attempts fail for a given stream. part of the fix
for bug 437. still an XXX020rc remaining.
svn:r13648
2008-02-21 09:00:54 +00:00
Roger Dingledine
18a209ffe6
Even though the man page said that "TrackHostExits ." should
...
work, nobody had ever implemented it. Bugfix on 0.1.0.x.
svn:r13647
2008-02-21 08:08:13 +00:00
Roger Dingledine
828c707812
Change the behavior of "getinfo status/good-server-descriptor"
...
so it doesn't return failure when any authority disappears.
svn:r13645
2008-02-21 06:06:45 +00:00
Roger Dingledine
b28a342e35
resolve one more, and leave two for nick.
...
svn:r13644
2008-02-21 05:53:50 +00:00
Roger Dingledine
1812a22a60
If we're trying to flush the last bytes on a connection (for
...
example, when answering a directory request), reset the
time-to-give-up timeout every time we manage to write something
on the socket. Bugfix on 0.1.2.x.
svn:r13643
2008-02-21 05:51:09 +00:00
Roger Dingledine
8889229407
and another useful answer
...
svn:r13642
2008-02-21 05:42:12 +00:00
Roger Dingledine
0ddc9d5707
answer one of nick's XXX020rc's usefully
...
svn:r13641
2008-02-21 05:38:19 +00:00
Nick Mathewson
063ced8903
r18296@catbus: nickm | 2008-02-20 23:30:11 -0500
...
Answer one xxx020 item; move 7 other ones to a new "XXX020rc" category: they should get fixed before we cut a release candidate. arma: please review these to see whether you have fixes/answers for any. Please check out the other 14 XXX020s to see if any look critical for the release candidate.
svn:r13640
2008-02-21 04:30:14 +00:00
Nick Mathewson
47e6247673
r18294@catbus: nickm | 2008-02-20 22:42:44 -0500
...
Fix a spelling error and clean up a recent veracode-induced integer overflow check. Both spotted by Chris Palmer.
svn:r13639
2008-02-21 03:42:56 +00:00
Nick Mathewson
1df0647c66
r18291@catbus: nickm | 2008-02-20 22:35:32 -0500
...
Resolve all DOCDOC issues, and document some other undocumented code, and fix a changelog entry.
svn:r13638
2008-02-21 03:38:46 +00:00
Nick Mathewson
7b022eda9c
r18290@catbus: nickm | 2008-02-20 22:34:59 -0500
...
Correct handling of nested MAP_FOREACH loops. There are none of those ATM, but isn't it nice that now they'll be correct?
svn:r13637
2008-02-21 03:38:44 +00:00
Nick Mathewson
ae507a61cc
r18288@catbus: nickm | 2008-02-20 21:18:38 -0500
...
Recover from bad tracked-since value in mtbf history file. This may finally close bug 537.
svn:r13636
2008-02-21 02:18:41 +00:00
Nick Mathewson
0e9dcfab97
r18286@catbus: nickm | 2008-02-20 21:10:33 -0500
...
Fix a bug that kept buf_find_string_offset from finding a string at the very end of the buffer. Add a unit test for this. Also, do not save a pointer to a chunk that might get reallocated by buf_pullup().
svn:r13635
2008-02-21 02:10:38 +00:00
Nick Mathewson
3b58f9929f
r18283@catbus: nickm | 2008-02-20 18:58:31 -0500
...
Fix assertion when searching for a string in an empty chunk.
svn:r13634
2008-02-20 23:58:48 +00:00
Nick Mathewson
304bdfdc6b
r18279@catbus: nickm | 2008-02-20 18:38:48 -0500
...
Log message to try to detect error in buffers.c
svn:r13633
2008-02-20 23:38:57 +00:00
Nick Mathewson
8b8d38162b
r18278@catbus: nickm | 2008-02-20 18:29:07 -0500
...
Unit tests for buf_find_string_offset()
svn:r13632
2008-02-20 23:38:55 +00:00
Nick Mathewson
f0e523c6ef
r18272@catbus: nickm | 2008-02-20 18:20:33 -0500
...
add a flag to suppress overwriting the certificates file with new certificates, so we do not overwrite all certs when starting as an authority.
svn:r13630
2008-02-20 23:20:36 +00:00
Nick Mathewson
93aa335516
r18269@catbus: nickm | 2008-02-20 17:28:24 -0500
...
Apply patch from Sebastian Hahn: stop imposing an arbitrary maximum on the number of file descriptors used for busy servers. Bug reported by Olaf Selke.
svn:r13626
2008-02-20 22:28:26 +00:00
Nick Mathewson
384a8ab777
r18267@catbus: nickm | 2008-02-20 16:57:45 -0500
...
Suppress signed/unsigned comparison warnings in buffers.c
svn:r13624
2008-02-20 21:57:48 +00:00
Nick Mathewson
7521ef9a00
r18264@catbus: nickm | 2008-02-20 12:48:21 -0500
...
fix bufs in buf_pos_t implementation.
svn:r13623
2008-02-20 17:48:39 +00:00
Nick Mathewson
5dd9d16b94
r18263@catbus: nickm | 2008-02-20 12:45:15 -0500
...
Oops. not supposed to use tor_assert() in eventdns.c
svn:r13622
2008-02-20 17:48:37 +00:00
Nick Mathewson
b30c1637bd
One last tweak on debugging code.
...
svn:r13621
2008-02-20 17:30:00 +00:00
Nick Mathewson
dc949b846a
r18259@catbus: nickm | 2008-02-20 12:03:15 -0500
...
Make the last of the veracode warning issues get fixed.
svn:r13620
2008-02-20 17:03:16 +00:00
Nick Mathewson
88efec10a2
r18256@catbus: nickm | 2008-02-20 11:57:31 -0500
...
Simplify rounding logic in bitarray; fix a bug in bitarray_expand().
svn:r13619
2008-02-20 16:57:41 +00:00
Nick Mathewson
cefe0a1959
r18255@catbus: nickm | 2008-02-20 11:44:55 -0500
...
Add asserts and refactor some comparisons in order to fix some veracode-identified issues. Note a bug in buffers.c
svn:r13618
2008-02-20 16:57:39 +00:00
Roger Dingledine
1c8bd320be
pass bucket sizes num_read and num_written around as size_ts
...
rather than ints
svn:r13610
2008-02-20 02:17:41 +00:00
Roger Dingledine
f2ed011813
We were comparing the raw BridgePassword entry with a base64'ed
...
version of it, when handling a "/tor/networkstatus-bridges"
directory request. Now compare correctly. Noticed by Veracode.
svn:r13609
2008-02-20 02:05:28 +00:00
Roger Dingledine
f34d46e7dd
similarly, don't throw around an int for the uint8_t circ->state
...
svn:r13608
2008-02-20 01:01:09 +00:00
Roger Dingledine
7427cf5d56
don't throw around an int for relay_command if we're going to
...
squeeze it into a uint8_t later. also reported by veracode.
svn:r13607
2008-02-20 00:57:37 +00:00
Roger Dingledine
0977c29196
notice an integer overflow if we ever get source files with more
...
than 65k lines in them. also pointed out by veracode.
svn:r13606
2008-02-20 00:46:09 +00:00
Roger Dingledine
e9474ed28e
if you thought r13604 was a kludge, how about this.
...
svn:r13605
2008-02-20 00:30:41 +00:00
Roger Dingledine
56a7c9238e
be more clear about a possible integer underflow problem. this
...
should probably be fixed better somehow.
svn:r13604
2008-02-20 00:11:52 +00:00
Roger Dingledine
e0beb6cc5e
check return value for crypto_pk_asn1_encode here too. thanks veracode.
...
svn:r13603
2008-02-19 23:59:16 +00:00
Nick Mathewson
260c37c14c
r18236@catbus: nickm | 2008-02-19 18:55:21 -0500
...
Explain why I am right and veracode is wrong in routerparse.c line 1141. Using math!
svn:r13602
2008-02-19 23:57:06 +00:00
Roger Dingledine
913f66278c
rearrange our assert so we don't possibly overflow rh.length before
...
triggering the assert. reported by veracode.
svn:r13601
2008-02-19 23:54:17 +00:00
Nick Mathewson
0399538b90
r18233@catbus: nickm | 2008-02-19 18:46:07 -0500
...
Count sockets returned from socketpair() too. This is probably not the socket counting bug.
svn:r13600
2008-02-19 23:46:08 +00:00
Roger Dingledine
707da4f73f
start checking the return value of crypto_pk_asn1_encode() while
...
we're trying to establish an introduction point. bug reported
by veracode.
svn:r13599
2008-02-19 23:33:02 +00:00
