Roger Dingledine
283c61e5d5
If the socks handshake hasn't started, don't send a
...
"DNS resolve socks failed" handshake reply; just close it.
svn:r9437
2007-01-27 18:56:13 +00:00
Roger Dingledine
baeeadb6eb
avoid messy crashes (bugfix by nick)
...
svn:r9435
2007-01-27 18:33:33 +00:00
Roger Dingledine
c6fd3c7158
the other half of my patch. more coming later.
...
svn:r9434
2007-01-27 09:24:23 +00:00
Roger Dingledine
9057af692a
Weight directory requests by advertised bandwidth. Now we can
...
let servers enable write limiting but still allow most clients to
succeed at their directory requests.
svn:r9433
2007-01-27 09:13:19 +00:00
Nick Mathewson
9984cad6e8
r11552@catbus: nickm | 2007-01-27 03:55:02 -0500
...
This one is a little tricky. Our BEGIN_DIR implementation has a
problem: the dirserv conns will decide they can flush all their data
immediately, since the edge_conns will read greedily.
For our 0.1.2 workaround, we track which or_conn a bridged dirserv
conn is attached to, and stop writing when its outbuf is too full, and
start writing again when the or_conn's outbuf empties out a little.
This requires a bit of pointer management. Let's hope it works.
svn:r9432
2007-01-27 08:55:06 +00:00
Nick Mathewson
152547be49
r11548@catbus: nickm | 2007-01-27 00:15:47 -0500
...
Fix two assert bugs encountered when trying ipv6 lookups with eventdns code.
svn:r9430
2007-01-27 05:15:53 +00:00
Roger Dingledine
e9f6456b2c
Bugfix: If we're not marking exits as guards, ignore exit bandwidth
...
when we're deciding the required bandwidth to become a guard.
svn:r9423
2007-01-26 09:03:20 +00:00
Roger Dingledine
75a5fde460
Stop saying !is_internal_IP() when we really meant
...
connection_is_rate_limited(). One day this will be useful.
svn:r9422
2007-01-26 08:13:53 +00:00
Roger Dingledine
99c1771432
never refuse directory requests from local addresses
...
svn:r9421
2007-01-26 08:01:29 +00:00
Roger Dingledine
9d5449c52e
Inform the server operator when we decide not to advertise a
...
DirPort due to AccountingMax enabled or a low BandwidthRate. It
was confusing Zax, so now we're hopefully more helpful.
svn:r9404
2007-01-25 19:41:15 +00:00
Nick Mathewson
75db2a61cb
r11500@catbus: nickm | 2007-01-25 10:37:11 -0500
...
Fix argument types in printf: try to make buildbot happier.
svn:r9403
2007-01-25 15:37:14 +00:00
Roger Dingledine
bf9baa85a8
more hints as arma tracks down a polipo bug
...
svn:r9400
2007-01-24 23:58:41 +00:00
Nick Mathewson
71f47320f8
r11493@catbus: nickm | 2007-01-24 18:41:52 -0500
...
Use set_uint16/32 instead of raw assignments in order to make gcc happier.
svn:r9399
2007-01-24 23:42:00 +00:00
Nick Mathewson
5cd1f0680e
r11287@catbus: nickm | 2007-01-23 20:30:04 -0500
...
Yet more documentation. (Again, trying to see whether I have buildbot working).
svn:r9396
2007-01-24 01:30:07 +00:00
Roger Dingledine
c716eefbca
start tracking down a funny-looking log message
...
svn:r9395
2007-01-24 01:18:45 +00:00
Nick Mathewson
792f819212
r11285@catbus: nickm | 2007-01-23 19:43:50 -0500
...
More documentation. (Again, trying to see whether I have buildbot working).
svn:r9394
2007-01-24 00:43:52 +00:00
Nick Mathewson
2522c392bd
r11283@catbus: nickm | 2007-01-23 19:20:47 -0500
...
Add documentation to dns.c (mainly to test new buildbot version)
svn:r9393
2007-01-24 00:20:49 +00:00
Nick Mathewson
79dd306527
r11278@catbus: nickm | 2007-01-23 14:22:27 -0500
...
More doxygen comments: this time mainly around spooling and storing directory information.
svn:r9392
2007-01-23 19:22:52 +00:00
Nick Mathewson
ba53e0029f
r11277@catbus: nickm | 2007-01-23 14:08:08 -0500
...
When logging TLS certificate and identity-related errors, scrub IP addresses for incoming connections, and distinguish between incoming and outgoing connections in log messages. Backport candidate.
svn:r9391
2007-01-23 19:22:49 +00:00
Nick Mathewson
c0c67d28f5
r9727@catbus: nickm | 2007-01-22 16:12:39 -0500
...
Remove redundant check for whether _connection_write_to_buf_impl is called with a zlib and a non-directory connection: TO_DIR_CONN will already assert if it gets a non-dir connection.
svn:r9390
2007-01-23 19:22:46 +00:00
Nick Mathewson
adc5bb4d04
r9723@catbus: nickm | 2007-01-22 15:47:17 -0500
...
Fix an XXXX012 in routerlist.c: when we do not have enough networkstatuses to launch router requests, do not launch router requests. Backport candidate.
svn:r9388
2007-01-22 20:57:26 +00:00
Roger Dingledine
9f733c31cc
minor cleanups
...
svn:r9387
2007-01-22 19:20:33 +00:00
Nick Mathewson
36620ca056
r9718@catbus: nickm | 2007-01-22 14:13:00 -0500
...
Free CACHE_STATE_DONE cached_router_t items on dns_free_all().
svn:r9386
2007-01-22 19:13:02 +00:00
Nick Mathewson
84790d059f
r9715@catbus: nickm | 2007-01-22 02:51:04 -0500
...
Document a few undocumented functions and arguments.
svn:r9385
2007-01-22 07:51:06 +00:00
Roger Dingledine
ab838bddb8
Flush local controller connection buffers periodically as we're
...
writing to them, so we avoid queueing 4+ megabytes of data before
trying to flush.
Also add a new XXX012.
svn:r9382
2007-01-22 06:07:51 +00:00
Roger Dingledine
7b5f9887fa
resolve an XXX, add a new XXX, simplify some code
...
svn:r9381
2007-01-22 05:59:59 +00:00
Nick Mathewson
033e20ca0b
r9709@catbus: nickm | 2007-01-21 21:34:03 -0500
...
Fix memory leak on networkstatus 503.
svn:r9380
2007-01-22 02:34:50 +00:00
Nick Mathewson
e0ae28d0cd
r9701@catbus: nickm | 2007-01-21 13:21:25 -0500
...
Detect and reject another (harmless) class of DNS replies. Also, fix a couple of IPv6 bugs in evendns.c
svn:r9379
2007-01-21 18:21:39 +00:00
Nick Mathewson
ff62a4d91b
r9692@catbus: nickm | 2007-01-21 12:04:22 -0500
...
Detect pointer loops in DNS requests and replies; avoid infinite loop on such malformed replies. Fixes bug 380.
svn:r9378
2007-01-21 17:05:10 +00:00
Roger Dingledine
bcbd289af5
If our system clock jumps back in time, don't publish a negative
...
uptime in the descriptor. Also, don't let the global rate limiting
buckets go absurdly negative.
svn:r9377
2007-01-21 06:24:05 +00:00
Nick Mathewson
ef0720f909
r9689@catbus: nickm | 2007-01-19 22:34:20 -0500
...
And remove another strcpy.
svn:r9375
2007-01-20 03:35:03 +00:00
Nick Mathewson
c57ef84fc5
r11987@Kushana: nickm | 2007-01-19 14:57:28 -0500
...
Implement SOCKS_BAD_HOSTNAME status event. Defer remaining status events. Clean up control-spec.txt a little, and fill in recommendations for events.
svn:r9374
2007-01-19 21:25:32 +00:00
Nick Mathewson
39e50cbb48
r9776@totoro: nickm | 2007-01-18 14:37:01 -0500
...
Yes, apparently saying strcpy in front of openbsd is like saying "intellectual property" in front of RMS. They both have a point, I guess, even though they extend it to contexts where it is completely irrelevant.
svn:r9370
2007-01-18 19:37:23 +00:00
Roger Dingledine
060be4c62b
man, i could have sworn that compiled
...
svn:r9369
2007-01-18 03:42:45 +00:00
Roger Dingledine
a3eaabfeb2
Be willing to read or write on local connections (e.g. controller
...
connections) even when the global rate limiting buckets are empty.
svn:r9368
2007-01-18 03:38:24 +00:00
Roger Dingledine
cb472fc550
break out the big guns: reject dir requests much more
...
aggressively. my vidalia bandwidth graph, when rate limiting
to 32kB/s, has the "write" line constantly at 32kB. I can't
imagine what's going on with the relay latency but it can't
be good.
svn:r9366
2007-01-17 01:29:54 +00:00
Roger Dingledine
8662f18102
boots and suspenders, or whatever the idiom is
...
svn:r9365
2007-01-17 00:14:43 +00:00
Nick Mathewson
a36ec61fd7
r11983@Kushana: nickm | 2007-01-16 10:28:47 -0500
...
Be even more clever about severity of messages from eventdns: NOTICE when the first nameserver comes up; INFO on subsequent ones.
svn:r9364
2007-01-16 17:39:08 +00:00
Nick Mathewson
093d71762c
r11978@Kushana: nickm | 2007-01-15 18:54:25 -0500
...
Apparently, the OpenBSD linker thinks it knows C better than I do, and gets to call me names for having strcat and strcpy and sprintf in my code--whether I use them safely or not. All right, OpenBSD. You win... this round.
svn:r9360
2007-01-15 23:56:38 +00:00
Nick Mathewson
11ed4500de
r11975@Kushana: nickm | 2007-01-15 17:11:15 -0500
...
set or_conn->tls_error to 0 on non-error to avoid looking at stale errors.
svn:r9359
2007-01-15 22:11:21 +00:00
Nick Mathewson
db6f0f3617
r11973@Kushana: nickm | 2007-01-15 16:43:25 -0500
...
Answer questions from r9348.
svn:r9358
2007-01-15 21:44:59 +00:00
Nick Mathewson
23c18f1dc2
svn:r9357
2007-01-15 21:21:21 +00:00
Nick Mathewson
af857f2da5
r11967@Kushana: nickm | 2007-01-15 16:13:15 -0500
...
tidy up more whitespace issues
svn:r9356
2007-01-15 21:21:14 +00:00
Nick Mathewson
380f8983c7
r11966@Kushana: nickm | 2007-01-15 16:12:17 -0500
...
Tidy up ORCONN reason patch from Mike Perry. Changes: make some of the handling of TLS error codes less error prone. Enforce house style wrt spaces. Make it compile with --enable-gcc-warnings. Only set or_conn->tls_error in the case of an actual error. Add a changelog entry.
svn:r9355
2007-01-15 21:21:05 +00:00
Nick Mathewson
ead35ef944
r11957@Kushana: nickm | 2007-01-15 15:25:57 -0500
...
Patch from Mike Perry: Track reasons for OR connection failure; display them in control events. Needs review and revision.
svn:r9354
2007-01-15 21:13:37 +00:00
Roger Dingledine
37b5132ad8
Expire socks connections if they spend too long waiting for the
...
handshake to finish. Previously we would let them sit around for
days, if the connecting application didn't close them either.
Also take this opportunity to refactor a duplicate bit of circuituse.c.
And change the semantics of SocksTimeout slightly, but I think it'll
be ok.
svn:r9350
2007-01-15 09:09:03 +00:00
Roger Dingledine
a9c250837e
patch from edmanm to make "-nt-service" command-line work too
...
svn:r9349
2007-01-15 08:52:01 +00:00
Roger Dingledine
cf7069fca4
two more todo items, to make eventdns log messages less loud
...
svn:r9348
2007-01-15 08:40:50 +00:00
Andrew Lewman
930e12920d
Update copyright in config.c while I'm there. Update man page to
...
reflect all available options to tor binary.
svn:r9341
2007-01-13 05:09:09 +00:00
Nick Mathewson
c1b5f53679
r11938@Kushana: nickm | 2007-01-11 11:02:28 -0500
...
Check addresses for rfc953-saneness at exit too, and give a PROTOCOL_WARN when they fail. Also provide a mechanism to override this, so blossom can have its @@##$$^.whatever.exit hostnames if it wants.
svn:r9336
2007-01-11 16:02:39 +00:00
Nick Mathewson
3dfeaaaf6e
r11931@Kushana: nickm | 2007-01-11 09:12:49 -0500
...
Fix a crash bug in the presence of DNS hijacking.
svn:r9333
2007-01-11 14:13:13 +00:00
Nick Mathewson
0c77ae2fcb
r11930@Kushana: nickm | 2007-01-11 09:05:27 -0500
...
fix recently-introduced segfault when not running as a dirserver
svn:r9332
2007-01-11 14:13:04 +00:00
Roger Dingledine
7beb0fd5dd
Make the unit tests work again.
...
The foo_init() funcs need to happen before we call
options_act() and friends.
svn:r9331
2007-01-11 01:41:07 +00:00
Roger Dingledine
35bd6caa1a
Fix crash with "tor --list-fingerprint" (reported by seeess).
...
svn:r9328
2007-01-10 23:48:24 +00:00
Nick Mathewson
8835bb844e
r11922@Kushana: nickm | 2007-01-10 15:43:18 -0500
...
Clear untrusted networkstatuses after 10 days too. (This is not a terribly awful bug, since we would only ever retain 16 of them, but it still might be nice to backport.) Resolves part A of bug 372.
svn:r9324
2007-01-10 20:43:40 +00:00
Nick Mathewson
9937695598
r11919@Kushana: nickm | 2007-01-10 13:32:48 -0500
...
Add some defensive programming to eventdns.c in an attempt to catch possible memory stomping bugs.
svn:r9322
2007-01-10 19:49:21 +00:00
Nick Mathewson
ceefc1e9a7
r11914@dhcp-18-188-69-59: nickm | 2007-01-10 11:20:59 -0500
...
Base skew calculation on conn->timestamp_lastwritten, not on now.
svn:r9319
2007-01-10 16:33:40 +00:00
Roger Dingledine
da7f0b5366
bump to 0.1.2.6-alpha-dev so we're ready for tomorrow's
...
surprise release too
svn:r9314
2007-01-09 05:47:23 +00:00
Roger Dingledine
ca66074106
bump to 0.1.2.6-alpha
...
svn:r9311
2007-01-09 05:24:42 +00:00
Roger Dingledine
794fedb0ad
some cleanups. more probably remain, but hey, it's an alpha.
...
time to put out the bugfix release.
svn:r9309
2007-01-09 05:14:34 +00:00
Roger Dingledine
254005fc1b
apparently i think of comments with no whitespace around them as
...
"read this if you don't understand the code and want some help."
which is not the same as "hey, you think you understand this code,
but you don't."
svn:r9307
2007-01-09 00:57:36 +00:00
Roger Dingledine
1d8a4cb989
Fix an assert error introduced in 0.1.2.5-alpha: if a single TLS
...
connection handles more than 4 gigs in either direction, we assert.
svn:r9306
2007-01-09 00:50:50 +00:00
Roger Dingledine
c85ff4d6ab
Fix an assert error introduced in 0.1.2.5-alpha: if you're an
...
advertised exit node, somebody might try to exit from you when
you're bootstrapping and before you've built your descriptor yet.
svn:r9305
2007-01-09 00:37:13 +00:00
Nick Mathewson
5239602dbc
r11873@Kushana: nickm | 2007-01-06 02:32:18 -0500
...
Implement DNS-related status events.
svn:r9285
2007-01-06 07:34:07 +00:00
Nick Mathewson
bc14afe064
r11872@Kushana: nickm | 2007-01-06 02:14:12 -0500
...
Implement a control status event for bad libevent version/method combos. Warn that libevent <1.1 with select() is needlessly slow. Reply to comment.
svn:r9284
2007-01-06 07:34:02 +00:00
Nick Mathewson
03d6e98111
r11868@Kushana: nickm | 2007-01-06 01:32:55 -0500
...
Document how we set Guard a little better.
svn:r9283
2007-01-06 06:32:59 +00:00
Nick Mathewson
d6073cc7fa
r11864@Kushana: nickm | 2007-01-06 01:25:59 -0500
...
Fix an XXXX012 in connection.c: prevent overflows on unfeasibly-high-bandwidth servers on 32-bit architectures.
svn:r9282
2007-01-06 06:27:15 +00:00
Nick Mathewson
aa7b72c97d
r11863@Kushana: nickm | 2007-01-06 01:12:24 -0500
...
Fix computation of total_exit_bandwidth; this will cause exits not to get recommended as guards if the total exit bandwidth if they constitute less than a third of total available bandwidth. There may be problems here with flapping; lets see if they occur in practice.
svn:r9281
2007-01-06 06:26:53 +00:00
Nick Mathewson
336624ce8f
r11862@Kushana: nickm | 2007-01-06 01:05:15 -0500
...
Re-enable warning when we resolve an already resolved address. We only warn here now if the address is not a testing address. Also, refactor out a function to check whether an address is used for testing.
svn:r9280
2007-01-06 06:26:46 +00:00
Nick Mathewson
c8466c5919
r11824@Kushana: nickm | 2007-01-03 17:15:28 -0500
...
control-spec: upcase arguments in status events; note unimplemented events individually
r11825@Kushana: nickm | 2007-01-03 17:41:43 -0500
Implement EXTERNAL IP server status event.
r11826@Kushana: nickm | 2007-01-03 17:47:10 -0500
Implement BAD_SERVER_DESCRIPTOR server status event.
r11827@Kushana: nickm | 2007-01-03 18:01:56 -0500
Implement SOCKS_UNKNOWN_PROTOCOL and DANGEROUS_SOCKS client events.
r11828@Kushana: nickm | 2007-01-03 18:23:22 -0500
Implement BUG controller events. Also, flush ERR-level status events just like ERR-level log messages.
r11829@Kushana: nickm | 2007-01-03 23:37:27 -0500
Yet more status events: CLOCK_SKEW, GOOD/ACCEPTED_SERVER_DESCRIPTOR, {CHECKING_}REACHABILITY_{SUCCEEDED|FAILED}
r11833@Kushana: nickm | 2007-01-05 16:56:37 -0500
Note some unimplementedness in control-spec.txt
svn:r9279
2007-01-06 05:42:31 +00:00
Roger Dingledine
6b126ea040
bump to 0.1.2.5-alpha-dev
...
svn:r9278
2007-01-06 05:41:01 +00:00
Roger Dingledine
71ed0314f6
make tor-resolve -x work on intel-endian platforms too
...
svn:r9274
2007-01-06 04:48:34 +00:00
Nick Mathewson
135aed5670
r11850@Kushana: nickm | 2007-01-05 17:12:08 -0500
...
Look in netinet/in6.h header when looking for struct in6_addr. (Issue found by saeftl.)
svn:r9272
2007-01-05 22:12:15 +00:00
Roger Dingledine
48a9fe4bbd
be a bit less eager to reject v1 dir requests due to load
...
svn:r9271
2007-01-05 06:59:36 +00:00
Roger Dingledine
ee0d2d486d
fix a bug, defer a bug, bump to 0.1.2.5-alpha
...
svn:r9270
2007-01-05 06:30:31 +00:00
Roger Dingledine
658c09c06f
more progress and cleanups
...
svn:r9269
2007-01-05 06:03:10 +00:00
Roger Dingledine
466650aa14
when we added orport= to the dirserver line, we started
...
freeing the string in the middle. this was probably xiando's
crash bug.
svn:r9265
2007-01-05 01:23:34 +00:00
Roger Dingledine
7b88380690
Avoid a double-free when parsing malformed DirServer lines.
...
svn:r9264
2007-01-05 01:12:10 +00:00
Roger Dingledine
5e89bc9b4b
fix a bug i introduced in r9249; and more cleanups.
...
svn:r9263
2007-01-04 09:12:23 +00:00
Roger Dingledine
a66d86149b
avoid a crash-all-the-clients segfault if a rogue dir
...
authority leaves a "v" line blank.
svn:r9262
2007-01-04 06:36:43 +00:00
Roger Dingledine
da2ff14839
Set orport= for 4 of the 5 dir authorities; Fix getinfo ns/all; Fix seg
...
fault when starting a server without a fingerprint file present.
svn:r9261
2007-01-04 05:41:24 +00:00
Roger Dingledine
50f0e36094
man page entries for TunnelDirConns and PreferTunneledDirConns
...
and add a todo item for nick in case he gets bored :)
svn:r9260
2007-01-04 04:35:18 +00:00
Roger Dingledine
88c3c84bda
be slightly less eager to yell at a server for being unreachable
...
svn:r9259
2007-01-03 23:58:03 +00:00
Nick Mathewson
2963d4acc2
r11820@Kushana: nickm | 2007-01-03 14:54:05 -0500
...
Add (and specify) a BadDirectory flag to networkstatuses, so authorities can tell clients that some caches are broken. Also, implement an as-yet-unused function to estimate how many bytes will be sent on a directory connection.
svn:r9255
2007-01-03 19:58:00 +00:00
Nick Mathewson
931e555ef9
r11818@Kushana: nickm | 2007-01-03 08:29:17 -0500
...
Fix compile error with warnings enabled: connection_dir_supports_tunnels was redeclared as static.
svn:r9254
2007-01-03 13:29:30 +00:00
Roger Dingledine
50e36dc11b
more cleanups, including a shiny new XXX012
...
svn:r9250
2007-01-03 10:30:26 +00:00
Roger Dingledine
d677332a83
checkpoint as we add PreferTunneledDirConns config option
...
svn:r9249
2007-01-03 06:33:03 +00:00
Nick Mathewson
eebbfbc854
r11806@Kushana: nickm | 2007-01-03 00:12:21 -0500
...
Fix unit test broken by r9239.
svn:r9248
2007-01-03 05:12:26 +00:00
Roger Dingledine
9545bbf57f
- When the user uses bad syntax in the Log config line, stop
...
suggesting other bad syntax as a replacement.
svn:r9247
2007-01-03 03:56:17 +00:00
Roger Dingledine
7396b8eecf
interim tweaks
...
svn:r9246
2007-01-03 03:45:53 +00:00
Nick Mathewson
f5b984a36f
r11800@Kushana: nickm | 2007-01-02 16:46:45 -0500
...
Remove an XXXX012 for which the answer is "not really."
svn:r9244
2007-01-02 21:47:28 +00:00
Nick Mathewson
cbdd21cbf5
r11799@Kushana: nickm | 2007-01-02 16:38:34 -0500
...
Simplify and remove most of dirserv_orconn_tls_cone
svn:r9243
2007-01-02 21:47:21 +00:00
Nick Mathewson
2caeaf4e2f
r11787@Kushana: nickm | 2007-01-02 14:40:14 -0500
...
Stop polluting new descriptors with the defaults-to-1 "opt eventdns" entry.
svn:r9239
2007-01-02 20:08:03 +00:00
Nick Mathewson
75eca91459
r11786@Kushana: nickm | 2007-01-02 14:32:54 -0500
...
Add a comment about a possible refactoring in main.c
svn:r9238
2007-01-02 20:07:54 +00:00
Andrew Lewman
4f565b73ef
Fix formatting in eventdns.c. Remove the rest of the osx binary
...
uninstaller.
svn:r9235
2007-01-02 06:26:42 +00:00
Nick Mathewson
722a3ab544
r11784@Kushana: nickm | 2007-01-02 01:13:04 -0500
...
Spec-conformance on r9181: make "opt v" strings start with "Tor".
svn:r9233
2007-01-02 06:13:10 +00:00
Nick Mathewson
6ae3ba9b2d
r11777@Kushana: nickm | 2007-01-01 21:01:10 -0500
...
Fix an idiot bug in r9181: snprintf returns <0 on error, not !=0.
svn:r9232
2007-01-02 02:01:15 +00:00
Nick Mathewson
46092f8163
r11765@Kushana: nickm | 2006-12-29 16:04:22 -0500
...
Remove duplicated code in dirserv_get_networkstatus_v2; document dirserv_get_networkstatus_v2_fingerprints. Down to 13 XXXX012 items.
svn:r9220
2006-12-30 02:41:14 +00:00
Nick Mathewson
c54b7c4d56
r11761@Kushana: nickm | 2006-12-29 15:45:56 -0500
...
Another cleanup: expand_exit_policy_aliases was totally redundant with respect to router_parse_[private_]addr_policy_private.
svn:r9219
2006-12-29 20:50:24 +00:00
Nick Mathewson
7ee99ba342
r11759@Kushana: nickm | 2006-12-29 15:21:14 -0500
...
Actually, handle_getinfo_helper supports 552 results just fine: just leave *answer unset.
svn:r9217
2006-12-29 20:49:47 +00:00