613 Commits

Author	SHA1	Message	Date
teor	b0f1b760ae	practracker: document !advisory in includes.py	2019-12-04 12:15:22 -05:00
teor	19324ff0ba	practracker: Test for bad ".c" includes in the unit tests ... Part of 32522.	2019-12-04 12:15:22 -05:00
Nick Mathewson	8a10a74870	Have checkSpaceTest.sh exit as skipped when on Windows ... Managing line-ending issues for this one isn't worth it.	2019-12-03 12:56:50 +10:00
Nick Mathewson	bd61a4e848	Add a simple test for checkSpace.pl ... This script is not expected to work on windows due to line-ending issues, so I'm not making it get run on an automated basis. We should use it when editing checkSpace.pl. Closes ticket 32613.	2019-12-03 12:56:46 +10:00
Nick Mathewson	2aaa7ae6e2	checkSpace.pl: make output more uniform. ... There were lots of slight differences in indentation and formatting among the in-file error messages.	2019-11-26 12:58:25 -05:00
teor	fadd292bf0	practracker/includes.py: Don't read editor temp files ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-26 17:52:18 +10:00
teor	0ce11433c0	check-spaces: Fix an outdated comment	2019-11-26 11:02:28 +10:00
teor	ab70c315bd	practracker: Fix a typo in a logging function call ... Obviously correct changes to already-reviewed code.	2019-11-26 11:01:34 +10:00
Nick Mathewson	31f8b4fa65	Merge branch 'stream-socks-auth' into bug19859_merged	2019-11-25 07:58:02 -05:00
Nick Mathewson	d9d75d4ae1	rename_c_identifier: don't crash when doing only one replacement.	2019-11-23 15:30:18 -05:00
Nick Mathewson	5060007f4b	Split log configuration out of options_act_reversible().	2019-11-19 16:03:32 -05:00
George Kadianakis	53ac9a9a91	Add changes file for #30381.	2019-11-18 19:21:10 +02:00
teor	3b4a360ed0	practracker: Don't read editor temp files, attempt 2 ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-14 16:12:19 +10:00
teor	f7b45975bf	Merge branch 'bug32402_042' into bug32402_master ... Merge changes from master with shellcheck fixes.	2019-11-06 16:14:06 +10:00
teor	57baea701f	shellcheck: Start checking most scripts for errors ... This check was accidentally disabled by a bad find command. Fixes bug 32402; bugfix on 0.4.2.1-alpha. Obviously correct changes to already reviewed code.	2019-11-06 15:49:50 +10:00
teor	60d5ff303d	practracker: Preserve improvements	2019-11-05 14:28:02 +10:00
teor	bcb38d984d	practracker: Update the exceptions file with improvements ... Regenerate the exceptions file, but only commit the improvements. Includes changes from 32213 and other tickets.	2019-11-05 12:50:08 +10:00
teor	81972353cb	scripts: Fix update_versions.py for out-of-tree builds ... Fixes bug 32371; bugfix on 0.4.0.1-alpha.	2019-11-05 12:00:59 +10:00
teor	c065ad3e3d	practracker: Rename functions modified by a previous commit ... Part of 32213.	2019-11-05 11:36:26 +10:00
JeremyRand	736322ce61	Bug #19859: Increase function-size exception to 124	2019-11-03 07:11:08 +00:00
teor	18e09913bf	practracker: Don't read editor temp files ... (Or any dot files.) Obviously correct changes to already-reviewed code.	2019-10-28 13:09:58 +10:00
Nick Mathewson	e7993dc046	Merge branch 'ticket31241_v3'	2019-10-25 08:10:39 -04:00
teor	00c3fba61c	scripts/maint: Stop assuming that python3 is in /usr/bin ... Obviously correct fix to rename_c_identifier.py. Bugfix on 32237; not in any released version of tor.	2019-10-25 16:46:54 +10:00
Nick Mathewson	dc6d7f072d	Make foo_validate() functions call config_validate(). ... The former foo_validate() functions are now toplevel legacy_validate_fn callbacks. The new foo_validate() functions now call them. This change lets us remove the old shared_random disk state validation callback entirely.	2019-10-24 20:30:32 -04:00
Nick Mathewson	fcdb66acd3	Add a script to rename C identifiers, and optionally add a commit message ... This script should "pay for itself" if it prevents one bug caused by careless search-replace-commit loops.	2019-10-24 08:20:31 -04:00
Nick Mathewson	264c5312eb	Merge branch 'maint-0.4.2'	2019-10-18 12:32:49 -04:00
Alexander Færøy	95e3527df0	Bump practracker exception limit for process_win32_exec(). ... I have added a larger comment there and one line of code, so I think this bump is reasonable. See: https://bugs.torproject.org/31810	2019-10-17 21:12:51 +02:00
Nick Mathewson	2c97cf3add	Merge remote-tracking branch 'tor-github/pr/1329'	2019-10-16 12:31:47 -04:00
Nick Mathewson	08fd551e9f	Regenerate practracker exceptions file for 0.4.3 progress.	2019-10-16 09:15:00 -04:00
Nick Mathewson	8ce17e0b35	practracker: add a missing #.	2019-10-16 09:15:00 -04:00
Nick Mathewson	a4790e7d4b	maint-0.4.2: remove ".enable_practracker_in_hooks".	2019-10-11 17:18:55 -04:00
Nick Mathewson	5fd137c482	Merge remote-tracking branch 'tor-github/pr/1358'	2019-10-03 09:11:49 -04:00
teor	3d17fafa04	control/control: Refactor some error handling code ... Split some protocol error handling out of connection_control_process_inbuf(). This refactor reduces the size of a practracker exception. Closes 31840.	2019-10-03 11:35:42 +10:00
George Kadianakis	4673cb8168	Merge branch 'tor-github/pr/1339'	2019-09-30 13:44:59 +03:00
Nick Mathewson	fc1134e3e5	annotate_ifdef_directives: test edge-case of 80-char line ... An 80-character line (79 characters if you don't count the newline) should not be truncated, and should not have a "..." insterted.	2019-09-27 21:04:22 -04:00
Nick Mathewson	21c9f7c85e	Annotate_ifdef_directives: doctest for 80-column lines.	2019-09-27 21:04:22 -04:00
Nick Mathewson	f1e0665c93	Rename annotate_ifdef_directives to end with .py. ... This allows the python doctest module to process it correctly when invoked as: python -m doctest -v annotate_ifdef_directives.py	2019-09-27 21:04:22 -04:00
Nick Mathewson	d229399e77	annotate_ifdef_directives: Allow it to be imported as a module.	2019-09-27 21:04:22 -04:00
Nick Mathewson	6f0e697e41	Use Doctests to test the behavior of annotate_ifdef_directives.	2019-09-27 21:04:22 -04:00
Nick Mathewson	195aa2f5f7	annotate_ifdef_directives: generate paren-balanced expressions ... This algorithm is not fully general, but it strikes a balance between efficiency, simplicity, and correctness.	2019-09-27 21:04:22 -04:00
Nick Mathewson	21cc9d13f3	annotate_ifdef_directives: clarify situation with newlines ... Our line limit is 80 characters, assuming that there is a single terminating newline character that counts towards the limit. On Windows, this might go as high as 81 characters, if we count CRLF as two characters.	2019-09-26 15:52:45 -04:00
Nick Mathewson	65e63e7461	annotate_ifdef_directives: remove some cases of double negation ... This change should reduce the number of cases where we say "/* !(!defined(foo)) */" . This only does cases where we can use a regex to make sure that the simplification is guaranteed to be correct. Full boolean simplification would require this script to parse C, and nobody wants that.	2019-09-26 15:52:45 -04:00
Nick Mathewson	ffd857bbe1	Merge remote-tracking branch 'tor-github/pr/1308'	2019-09-26 14:36:37 -04:00
George Kadianakis	7157d80c6f	Merge branch 'tor-github/pr/1337'	2019-09-25 14:19:49 +03:00
George Kadianakis	6677eae579	Merge branch 'tor-github/pr/1355'	2019-09-25 14:17:03 +03:00
George Kadianakis	99f75373de	Merge branch 'tor-github/pr/1309'	2019-09-25 14:12:42 +03:00
teor	22c33ea7f7	practracker: Fix a typo in the usage message ... Fixes bug 31828; bugfix on 0.4.2.1-alpha.	2019-09-24 14:37:43 +10:00
AmreshVenugopal	3e45260594	fix: Ticket #31589 ... - The function `decrypt_desc_layer` has a cleaner interface. - `is_superencrypted_layer` changed from `int` -> `bool` [ticket details](https://trac.torproject.org/projects/tor/ticket/31589) add(changes/*): changes file fix(src/features/hs): is_superencrypted changed from `int` -> `bool` fix(changes/ticket31589): header add(changes/ticket31589): subsystem(onion services) to change	2019-09-23 23:52:01 +05:30
Nick Mathewson	16890839d3	annotate_ifdef_directives: obey an 80-column line-limit ... If we would add a comment making a line longer than 80 columns, instead truncate the variable portion of the comment until it just fits into 80 columns, with an ellipsis.	2019-09-23 08:48:53 -04:00
Nick Mathewson	f36e743e5d	annotate_ifdef_directives: introduce a function to make commented lines ... No functional change in this commit.	2019-09-23 08:48:53 -04:00
Nick Mathewson	0b367f3386	Add comments to annotate_ifdef_directives	2019-09-23 08:48:53 -04:00
Nick Mathewson	2e1989dacc	Remove practracker exception for microdesc parsing function	2019-09-19 14:37:24 -04:00
Nick Mathewson	1c67d261d5	practracker: Integration test for --list-overbroad ... Make sure that we list overbroad exceptions, and nothing else	2019-09-18 10:28:33 -04:00
Nick Mathewson	d1ffac3f8a	practracker: An exception is "used" even when it is violated. ... The purpose of tracking whether an exception is used is so that we can tell whether it is overbroad. This means that an _underbroad_ exception is still a used one. Fixes bug 31338.	2019-09-18 10:28:33 -04:00
Nick Mathewson	25d55fa01e	Practracker: do not list problems when told to --list-overbroad.	2019-09-18 10:28:33 -04:00
Daniel Pinto	619178bb3a	Fix add_c_file.py script to support paths starting with ./ #31336	2019-09-16 22:57:20 +01:00
George Kadianakis	8f2ab45229	Merge branch 'tor-github/pr/1313'	2019-09-16 19:45:20 +03:00
Nick Mathewson	e7565855c0	Merge branch 'ticket31578' into ticket31578_merged	2019-09-11 08:59:29 -04:00
teor	af12b6fd29	scripts: Make checkShellScripts.sh error exit if it can't find src ... Closes 31679.	2019-09-10 12:24:08 +10:00
teor	8c37bf738d	scripts: Allow checkShellScripts.sh to be run from its parent directory ... ... on systems that don't have realpath. Part of 31679.	2019-09-10 12:23:12 +10:00
David Goulet	796a9b37ea	Merge branch 'tor-github/pr/1264'	2019-09-09 14:53:12 -04:00
Nick Mathewson	a642a4cbd7	Merge branch 'ticket30924_042_04_squashed' into ticket30924_042_04_squashed_merged	2019-09-09 11:10:53 -04:00
David Goulet	a8a1ea4e0e	practracker: Make you happy funny script ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-09-09 11:06:51 -04:00
Nick Mathewson	bc4ddbf4ac	New practracker exceptions for dependency violations in headers ... I've done this manually, since I don't want to override the existing exceptions in this branch.	2019-09-05 16:17:50 -04:00
Nick Mathewson	318de94e49	Fix a bug in practracker's handling of .may_include in headers ... I was expecting our filter code to work in a way it didn't. I thought that saying that DependencyViolation applied to "*" would hit all of the files -- but actually, "*" wasn't implemented. I had to say "*.c" and "*.h"	2019-09-05 16:16:20 -04:00
teor	5c2941e69f	shellcheck: Add shellcheck to the pre-commit hook ... * Move the shellcheck script from the Makefile to its own script file * Reformat the shellcheck script so it's easier to read and modify * Call the shellcheck script from the pre-commit hook Fixes bug 30967; not in any released version of Tor.	2019-09-05 11:15:26 +10:00
David Goulet	6210c75076	Merge branch 'tor-github/pr/1246'	2019-09-04 08:27:36 -04:00
Nick Mathewson	03040903e6	practracker: handle empty files. ... Previously practracker would fail on a file with no lines.	2019-09-02 15:40:35 -04:00
Nick Mathewson	3a2964577e	practracker: Fix indentation in util.py ... This commit only changes whitespace and removes a temporary comment.	2019-09-02 15:40:35 -04:00
Nick Mathewson	651bbe8a0d	Practracker: only consider files under "src/"	2019-09-02 15:40:35 -04:00
Nick Mathewson	e3f7e5e65e	practracker: make filename terminology uniform ... Previously we often referred to "C files" and "H files", which is more ambiguous than ".c files" and ".h files".	2019-08-29 09:20:27 -04:00
Nick Mathewson	c710518825	Add integration tests for new practracker features ... These tests check our .may_include checking, and our header file checking. They do not pass yet: we have a bug in our filtering code.	2019-08-26 12:28:46 -04:00
Nick Mathewson	2780cbb9cb	Merge branch 'ticket30935' into ticket30935_merged	2019-08-22 17:25:35 -04:00
David Goulet	d475d7c2fb	Merge branch 'tor-github/pr/1244'	2019-08-22 17:10:22 -04:00
Nick Mathewson	5b3741e05a	Document new practracker violation types, and add a practracker readme ... Closes ticket 31476.	2019-08-21 10:17:26 -04:00
Nick Mathewson	cc48eff2d3	Merge branch 'ticket31176' into ticket31176_merged	2019-08-21 09:46:20 -04:00
Nick Mathewson	edf5a327c5	Merge branch 'ticket30914' into ticket30914_merged	2019-08-20 13:57:05 -04:00
Nick Mathewson	29bd43ab03	Merge remote-tracking branch 'tor-github/pr/1224'	2019-08-19 11:26:58 -04:00
Nick Mathewson	e7aabfce61	Merge remote-tracking branch 'tor-github/pr/1235'	2019-08-19 11:10:21 -04:00
George Kadianakis	e411fcabd7	Merge branch 'tor-github/pr/1220'	2019-08-19 18:02:44 +03:00
George Kadianakis	b257e8e553	Merge remote-tracking branch 'mike/bug31356+logs-rebased2' into bug31356_final	2019-08-19 17:53:00 +03:00
David Goulet	81e37b81f1	practracker: Make exceptions.txt happy ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-08-19 09:47:52 -04:00
Mike Perry	6deba34fee	Practracker	2019-08-12 14:06:08 -05:00
Neel	64d2133a61	Move the connection_edge_process_relay_cell() assignments out of if statements in circuit_receive_relay_cell()	2019-08-08 13:05:46 -04:00
Nick Mathewson	71e5af0221	pre-push hook: Only run practracker when a special file is present ... Closes ticket 30979.	2019-08-08 11:36:05 -04:00
Nick Mathewson	35cfe2e776	Merge remote-tracking branch 'tor-github/pr/1208'	2019-08-07 09:49:49 -04:00
David Goulet	2b225aaa77	practracker: Make it happy after rebase ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-08-06 08:01:26 -04:00
David Goulet	c5b00c5a51	hs-v3: Add consensus parameters for DoS defenses ... Part of #15516 Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-08-06 07:58:14 -04:00
George Kadianakis	d7afdb3b0f	Merge branch 'tor-github/pr/1195'	2019-08-06 14:51:47 +03:00
Nick Mathewson	0f4b245b20	update exceptions file for depencency violations	2019-08-05 17:48:06 -04:00
Nick Mathewson	a5971d732e	Move include-violation checking into its own function.	2019-08-05 17:48:06 -04:00
Nick Mathewson	2a3c727dfe	Make includes interface more like the rest of practracker ... Everything else assumes that somebody else will open the file for it.	2019-08-05 17:48:06 -04:00
Nick Mathewson	6b26281b50	practracker: a violation of a .may_include rule is now a problem. ... We treat "0" as the expected number, and warn about everything else. The problem type is "dependency-violation".	2019-08-05 17:48:06 -04:00
Nick Mathewson	720951f056	Teach include-checker about advisory rules ... A .may_includes file can be "advisory", which means that some violations of the rules are expected. We will track these violations with practracker, not as automatic errors.	2019-08-05 17:04:00 -04:00
Nick Mathewson	9abbde2c24	Update pre-commit hook to find checkIncludes in its new location ... Also add a temporary script to redirect the hook, if people don't upgrade for a bit.	2019-08-05 14:12:39 -04:00
Nick Mathewson	6fb74753c2	Move checkIncludes inside practracker ... Update the makefile accordingly.	2019-08-05 14:10:40 -04:00
Nick Mathewson	9eb12dde18	checkIncludes: add a real main function and CLI	2019-08-05 13:40:59 -04:00
Nick Mathewson	3f4e89a7ab	checkIncludes: refactor to use error-iteration style ... This makes checkIncludes match practracker more closely, and lets us eliminate a global.	2019-08-05 13:40:59 -04:00
Nick Mathewson	47d9bcfef8	checkIncludes: Separate file-handling from rule-handling ... This is our shift from directory-at-a-time processing to file-at-a-time processing.	2019-08-05 13:40:59 -04:00
Nick Mathewson	65a69f861e	checkIncludes.py: extract topological sort code ... Our topological sort code really deserves a function of its own. Additionally, don't print from inside the topological sort code: instead, return a result, and let the caller print it.	2019-08-05 13:40:59 -04:00
Nick Mathewson	3f35ac772b	checkIncludes: introduce rules-file caching. ... We'll want this so that we can have each file evaluated independently, rather than a directory at a time.	2019-08-05 11:35:13 -04:00
Nick Mathewson	475749351d	Move the executable part of checkIncludes.py inside an if block. ... I'll want to make this block into a series of functions in a subsequent commit, but I'm doing this separately to get the indentation change out of the way. This branch will end up with making checkIncludes.py an integrated part of practracker, for ticket 31176.	2019-08-05 11:30:22 -04:00
George Kadianakis	ce477da8a7	Ignore regular cells in padding circuits. ... Padding circuits were regular cells that got closed before their padding machine could finish. This means that they can still receive regular cells from their past life, but they have no way or reason to answer them anymore. Hence let's ignore them before they even get to the proper subsystems.	2019-08-05 18:03:23 +03:00
Nick Mathewson	d5ccd0fa84	Add exceptions for current .h practracker problems.	2019-08-05 10:32:39 -04:00
Nick Mathewson	9a1e9b1d6c	Teach practracker about .h files ... I'm using 500 as a file size limit, and 15 as an include limit. This affects comparatively few files, but I think they are the worst ones. Closes ticket 31175.	2019-08-05 10:31:02 -04:00
Nick Mathewson	1440c2cb34	Adjust test_practracker.sh to work on windows ... The required change is to ignore trailing CRs when diffing files.	2019-08-01 15:43:54 -04:00
Nick Mathewson	fa60fee8d5	practracker: Add unit tests to test script, and test script to makefile ... This makes all of the practracker tests get run by make check, and hence by our CI. Closes ticket 31304.	2019-08-01 14:01:43 -04:00
Nick Mathewson	5d98b54725	Port practracker unit tests to python 3	2019-08-01 14:00:48 -04:00
Nick Mathewson	e57209dc32	Regenerate the practracker exceptions.txt file	2019-08-01 10:25:42 -04:00
Nick Mathewson	a4e4896e66	practracker: restore exceptions.txt header when running --regen	2019-08-01 10:25:20 -04:00
David Goulet	c4864de573	Merge branch 'tor-github/pr/1177'	2019-08-01 10:18:10 -04:00
Nick Mathewson	19536fd18d	practracker: replaces "overstrict" with "overbroad" ... I had the logic reversed here.	2019-08-01 09:35:33 -04:00
Nick Mathewson	3221dc1b32	Lower check of TOR_DISABLE_PRACTRACKER ... Since we sometimes call practracker directly, that's where we should check the TOR_DISABLE_PRACTRACKER envvar.	2019-08-01 08:40:56 -04:00
Nick Mathewson	8d3f3e5d30	Practracker: add an integration test. ... This test runs practracker with a set of 0 thresholds, to make sure that it enumerates all its values right. It tries running with an empty exceptions file, and with an exceptions file that covers _some_ of the data, and it makes sure that the outputs are as expected.	2019-07-30 12:14:46 -04:00
Nick Mathewson	a79e2c2975	practracker: better warning/regen handling ... Now that there is only one toplevel place where we print problems, we can redirect just that one print to a file when we are regenerating the exceptions.txt file. Previously we redirected sys.stdout, which is naughty, and forced us to send warnings (and warnings alone) to stderr.	2019-07-30 11:54:05 -04:00
Nick Mathewson	3f303c102a	Practracker: new flags to control output. ... These flags let you suppress the message about the number of problems and warnings, and let you control the thresholds above which something counts as a problem. I need this for testing.	2019-07-30 11:49:50 -04:00
Nick Mathewson	31a0b81854	practracker: Remove problemvault global.	2019-07-30 10:17:56 -04:00
Nick Mathewson	65cb4fead5	practracker: Move the warning/error distinction to a higher level. ... Previously warnings were generated by magic inside ProblemVault; now they're printed on demand.	2019-07-30 10:17:47 -04:00
Nick Mathewson	bcef6a5802	practracker: Refactor flow to use generators ... Instead of having "consider" functions that have to call a global ProblemVault, we can now generate all the metrics for the code separately from the decision about what to do for them.	2019-07-30 09:24:41 -04:00
Nick Mathewson	ec13a727b0	practracker: Rename "Problem" to "Item". ... I'm about to refactor the code into a set of iterators that yield *all* the metrics for the code, and then add a filter on top of that to return the problems.	2019-07-30 09:03:58 -04:00
David Goulet	57f955a38b	practracker: Make it happing for circuitpadding.c ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-07-25 10:28:38 -04:00
Nick Mathewson	f306d12b58	Refactor handling of TestingTorNetwork ... Previously, when TestingTorNetwork was set, we would manually adjust the initvalue members of a bunch of other config_var_t, and then re-run the early parts or parsing the options. Now we treat the initvalue fields as immutable, but instead assign to them in options_init(), as early as possible. Rather than re-running the early parts of options, we just re-call the options_init_from_string() function. This patch de-kludges some of our code pretty handily. I think it could later handle authorities and fallbacks, but for now I think we should leave those alone.	2019-07-24 15:21:56 -04:00
Nick Mathewson	f6db290e5a	Merge remote-tracking branch 'tor-github/pr/1186'	2019-07-23 12:30:19 -04:00
David Goulet	ef2dd1ba96	Merge branch 'tor-github/pr/1116'	2019-07-23 09:46:29 -04:00
George Kadianakis	fdfee3d06f	Changes file for #31113.	2019-07-23 12:44:43 +03:00
Nick Mathewson	d6a3636cdc	Add a TOR_DISABLE_PRACTRACKER envvar for use by folks who don't care ... Fixes part of bug 30752	2019-07-18 09:28:08 -04:00
Nick Mathewson	6303c9aa26	Practracker: add tolerances for exceptions ... When an exception is present, we can now violate the limit by a little bit and only produce a warning. The strict flag overrides this behavior. I've given file sizes a 2% tolerances and function sizes/include counts a 10% tolerance. Part of 30752	2019-07-18 09:28:08 -04:00
Nick Mathewson	a5e1fa3a03	Practracker: add a --list-overstrict option ... This option lists every exception that is stricter than it needs to be. Part of 30752	2019-07-18 09:28:08 -04:00
Nick Mathewson	43f163de80	Practracker: improve exclude-directory logic ... Instead of excluding directories at the last minute if they happen to appear in our filenames, we exclude them early, before recursing into all their subdirectories. Part of 29746.	2019-07-17 14:33:49 +02:00
Nick Mathewson	f93057fc0a	Pracktracker: give the number of new errors found. ... Part of 29746.	2019-07-17 14:33:49 +02:00
Nick Mathewson	86d3d310f5	Practracker: allow tabs in include lines ... This isn't actually something that Tor does, but it's cleaner to do it this way. Part of 29746.	2019-07-17 14:33:49 +02:00
Nick Mathewson	4c09532996	Fix practracker_tests.py and practracker line counting. ... The practracker_tests.py unit test file called a function by its old name. Also, practracker counted functions as starting one line after the function name, and ending with the closing brace. Now they start with the open brace and end with the closing brace.	2019-07-17 14:33:49 +02:00
George Kadianakis	5303dbe624	Merge branch 'tor-github/pr/1152'	2019-07-04 17:14:06 +03:00
Nick Mathewson	fdbd139495	Merge remote-tracking branch 'tor-github/pr/1136'	2019-07-02 13:33:50 -04:00
Nick Mathewson	0fa3dc3228	begin_cell_parse(): Add an assertion to please coverity. ... Coverity doesn't understand that if begin_cell_parse() returns 0 and sets is_begindir to 0, its address field will always be set. Fixes bug 30126; bugfix on 0.2.4.7-alpha; Fixes CID 1447296.	2019-06-28 11:29:51 -04:00
Nick Mathewson	089ef46063	Merge branch 'bug30721_squashed'	2019-06-26 09:57:20 -04:00
teor	fb93646c1c	resolve: split sub-functions out of tor_addr_lookup() ... And remove the practracker exception for tor_addr_lookup(). Cleanup after 30721.	2019-06-26 09:55:37 -04:00
Nick Mathewson	0fe9657c8c	Merge remote-tracking branch 'tor-github/pr/1119'	2019-06-26 09:50:00 -04:00
Nick Mathewson	a91ed23403	Use structvar to find the types for config vars.	2019-06-25 12:51:25 -04:00
teor	c131b0763e	stats: add comments about the required chunk structure in extra info files ... These comments should prevent future instances of 30958. And allow a larger file in practracker. Follow up after 30958.	2019-06-25 12:30:59 +10:00
Nick Mathewson	c60a85d22a	Add a "typed_var" abstraction to implement lvalue access in C. ... Right now, this has been done at a high level by confparse.c, but it makes more sense to lower it. This API is radically un-typesafe as it stands; we'll be wrapping it in a safer API as we do #30914 and lower the struct manipulation code as well. Closes ticket 30864.	2019-06-24 17:50:43 -04:00
Nick Mathewson	81d16d8d0c	checkSpace.pl: Allow 'bool' before a space and an open-paren ... We need this so we can declare function pointers returning bool without upsetting our style checker. :/	2019-06-24 15:11:57 -04:00
teor	45be44ed9c	stats: Split extrainfo_dump_to_string() into smaller functions. ... Closes ticket 30956.	2019-06-24 20:47:44 +10:00
David Goulet	9644f3462a	Make the great grand practracker happy... ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-06-19 07:42:30 -04:00
David Goulet	05b6f73f12	Make the great grand practracker happy... ... Signed-off-by: David Goulet <dgoulet@torproject.org>	2019-06-19 07:41:45 -04:00
Nick Mathewson	52d386c9b0	Merge remote-tracking branch 'tor-github/pr/1100'	2019-06-17 08:54:12 -04:00
teor	16e71c7fb0	practracker: accept an extra line in nt_service_install() ... Part of 30799.	2019-06-13 18:23:50 +10:00
David Goulet	e9d99d2e15	Merge branch 'tor-github/pr/1083'	2019-06-11 11:43:15 -04:00
teor	6be9d3aed8	practracker: accept one extra line in routerlist.c ... practracker exception for 30780.	2019-06-06 18:24:17 +10:00
teor	b07b1a4f6d	practracker: accept 3 extra lines in router_parse_entry_from_string() ... practracker exception for bug 30781.	2019-06-06 13:42:30 +10:00