Nick Mathewson
c4be6dfeab
Permit the nanosleep system call in the seccomp2 callbox
...
Fixes bug 24969; bugfix on 0.2.5.1-alpha when the sandbox was introduced.
2018-04-23 09:15:40 -04:00
Nick Mathewson
cd3fc2aa48
Merge remote-tracking branch 'neel/b25511-r4'
2018-04-23 09:13:24 -04:00
Nick Mathewson
8c01aee2e3
Document default for ControlSocket.
...
Closes 25897.
2018-04-23 07:47:50 -04:00
Nick Mathewson
915791bc48
Merge branch 'ticket25024_squashed'
2018-04-22 20:53:04 -04:00
Nick Mathewson
fa21ac1de6
Tweak changes file for 25024 to mention "check-typos"
2018-04-22 20:52:55 -04:00
Deepesh Pathak
72bfcb37f1
add changes file and update check-typos in makefile
2018-04-22 20:48:48 -04:00
Deepesh Pathak
48092540d0
Add spell check to makefile to check for typos ticket#25024
...
- Use misspell to check for typos in codebase
- Add `make check-typos` to run the checks
- Add `check-typos` to `make check`
2018-04-22 20:48:44 -04:00
Nick Mathewson
1ba9b7e013
Merge remote-tracking branch 'mikeperry/bug25400_squashed'
2018-04-22 20:39:35 -04:00
Nick Mathewson
0e8ae82a87
Merge branch 'remove_old_consensus_methods_2018_squashed'
2018-04-22 20:01:09 -04:00
Nick Mathewson
ade3c74007
Add a changes file for removing old consensus methods
...
(Ticket 24378; proposal 290.)
2018-04-22 20:00:47 -04:00
Nick Mathewson
2609a8be81
Require MIN_METHOD_FOR_RECOMMENDED_PROTOCOLS
...
(Remove support for running without this method.)
2018-04-22 20:00:47 -04:00
Nick Mathewson
5f90d28c01
Remove MIN_METHOD_FOR_{SHARED_RANDOM,EXCLUDING_INVALID_NODES}
...
Also remove client detection for pre-EXCLUDING_INVALID_NODES
consensuses, and a test for that detection.
2018-04-22 20:00:47 -04:00
Nick Mathewson
73c9c16faa
Remove MIN_METHOD_FOR_ED25519_ID_VOTING
...
This also lets us remove the old rsa-based routerstatus collator.
2018-04-22 20:00:47 -04:00
Nick Mathewson
4d6f21bb6b
Remove MIN_METHOD_FOR_{PACKAGE_LINES,GUARDFRACTION,ED25519_ID_IN_MD}
...
Also remove a rest for pre-19 microdesc versions.
2018-04-22 20:00:47 -04:00
Nick Mathewson
caf766991d
Remove MIN_METHOD_FOR_ID_HASH_IN_MD and a test for running without it.
2018-04-22 20:00:47 -04:00
Nick Mathewson
93380db833
Remove MIN_METHOD_{FOR_P6_LINES,FOR_NTOR_KEY,TO_CLIP_UNMEASURED_BW}
...
Also remove a unit test for pre-MIN_METHOD_FOR_NTOR_KEY consensuses.
2018-04-22 20:00:47 -04:00
Nick Mathewson
08373467b1
Remove MIN_METHOD_FOR and MIN_METHOD_FOR_A_LINES
...
Also, in networkstatus.c, remove client code for recognizing pre-
MIN_METHOD_FOR_A_LINES consensuses, and corresponding unit tests in
test_dir.c.
2018-04-22 20:00:47 -04:00
Nick Mathewson
69347f48e0
Disable consensus methods before 25.
...
Consensus method 25 is the oldest one supported by any stable
version of 0.2.9, which is our current most-recent LTS. Thus, by
proposal 290, they should be removed.
This commit does not actually remove the code to implement these
methods: it only makes it so authorities will no longer support
them. I'll remove the backend code for them in later commits.
2018-04-22 20:00:47 -04:00
Nick Mathewson
6773102c92
Merge branch 'bug25691_033_again_squashed'
2018-04-22 19:44:27 -04:00
Nick Mathewson
0941c8bfe6
control EXTENDCIRCUIT: check node_has_preferred_descriptor().
...
Suggested by teor during code review for 25691.
2018-04-22 19:43:27 -04:00
Nick Mathewson
f1c1328f85
Repair the legacy_hs/pick_tor2web_rendezvous_node unit test
...
It tried to pick nodes for which only routerinfo_t items are set,
but without setting UseMicroDescriptors to 0. This won't work any
more, now that we're strict about using the right descriptor types
due to 25691/25692/25213.
2018-04-22 19:43:07 -04:00
Nick Mathewson
47163780c3
Rename node_has_descriptor() to node_has_any_descriptor()
...
Changing the name of this function should help keep us from misusing
it when node_has_preferred_descriptor() would be more appropriate.
2018-04-22 19:43:07 -04:00
Nick Mathewson
0f3d73a2d0
Add a changes file for 25691/25692
2018-04-22 19:42:28 -04:00
Nick Mathewson
7915efd1b8
Use router_crn_flags in more places, to pass direct-connect flag
...
In order to fix 25691 and 25692, we need to pass the "direct_conn"
flag to more places -- particularly when choosing single-hop
tunnels. The right way to do this involves having a couple more
functions accept router_crn_flags_t, rather than a big list of
boolean arguments.
This commit also makes sure that choose_good_exit_server_general()
honors the direct_conn flag, to fix 25691 and 25692.
2018-04-22 19:42:28 -04:00
Nick Mathewson
388d217c40
Use node_has_preferred_descriptor() in another case
...
In router_add_running_nodes_to_smartlist(), we had an inline
implementation of the logic from node_has_descriptor(), which should
be changed to node_has_preferred_descriptor().
2018-04-22 19:42:28 -04:00
Nick Mathewson
948dd2c79e
Check for "the right descriptor", not just "any descriptor".
...
This patch adds a new node_has_preferred_descriptor() function, and
replaces most users of node_has_descriptor() with it. That's an
important change, since as of d1874b4339
(our fix for #25213 ),
we are willing to say that a node has _some_ descriptor, but not the
_right_ descriptor for a particular use case.
Part of a fix for 25691 and 25692.
2018-04-22 19:42:26 -04:00
Nick Mathewson
c3e40a8361
Allow cpuworkers to exist without onion keys
...
Now that we allow cpuworkers for dirport-only hosts (to fix 23693),
we need to allow dup_onion_keys() to succeed for them.
The change to construct_ntor_key_map() is for correctness,
but is not strictly necessary.
2018-04-22 17:17:07 -04:00
Nick Mathewson
71d503201e
Changes file for ticket 23354 (remove old download schedules)
2018-04-22 15:56:28 -04:00
Nick Mathewson
3b2ed849c8
Clean up the documentation for *DownloadInitialDelay
2018-04-22 15:55:09 -04:00
Nick Mathewson
5102208447
Improve documentation for CONFIG_TYPE_CSV_INTERVAL.
2018-04-22 15:55:09 -04:00
Nick Mathewson
8b6fc47cc3
Fix an absurdly wide line.
2018-04-22 15:55:09 -04:00
Nick Mathewson
ff6f49f033
Rename find_dl_schedule to find_dl_min_delay.
...
(We no longer need two separate functions here.)
2018-04-22 15:55:09 -04:00
Nick Mathewson
82d1d8b071
Remove extra values from InitialDelay defaults
...
These options are now ignored.
2018-04-22 15:55:09 -04:00
Nick Mathewson
2f792c041a
Add aliases for the old DownloadSchedule options
...
These will produce a warning, but still work fine.
2018-04-22 15:55:09 -04:00
Nick Mathewson
2d7b5c6fe5
Change the type of "download schedule" from smartlist to int.
...
This is done as follows:
* Only one function (find_dl_schedule()) actually returned a
smartlist. Now it returns an int.
* The CSV_INTERVAL type has been altered to ignore everything
after the first comma, and to store the value before the first
comma in an int.
2018-04-22 15:55:09 -04:00
Nick Mathewson
9aaed729c1
Rename *DownloadSchedule to *DownloadInitialDelay; make them ints
...
This commit won't compile. It was made with the following perl
scripts:
s/smartlist_t \*(.*)DownloadSchedule;/int $1DownloadInitialDelay;/;
s/\b(\w*)DownloadSchedule\b/$1DownloadInitialDelay/;
2018-04-22 15:55:09 -04:00
Isis Lovecruft
b5013e841c
rust: Remove mirrored PRNG implementation.
...
Once we need a PRNG, we'll likely want to change the dev-dependency on the rand
crate to be a real dependency, and use rand::SmallRng as our PRNG.
2018-04-20 23:54:48 +00:00
Isis Lovecruft
49639b2826
rust: Expose our (P)RNGs in Rust and provide safe wrappers.
...
* FIXES #24660 : https://bugs.torproject.org/24660
2018-04-20 23:54:47 +00:00
Nick Mathewson
d8ac7d557c
Merge branch 'maint-0.3.3'
2018-04-20 14:40:09 -04:00
Nick Mathewson
cb813a352c
Fix documentation bug 25857: the universe is ::/0, not ::/128
...
Patch from CTassisF.
2018-04-20 14:35:33 -04:00
Nick Mathewson
d5d312884f
Merge branch 'travis_distcheck_031' into travis_distcheck_033
2018-04-18 18:37:59 -04:00
Nick Mathewson
f32ac2aaf5
Test the with-rust and without-rust distcheck variants
2018-04-18 18:37:37 -04:00
Nick Mathewson
bf466f5503
Merge branch 'travis_distcheck_029' into travis_distcheck_033
2018-04-18 18:34:28 -04:00
Nick Mathewson
96bc96ceeb
Merge branch 'travis_distcheck_029' into travis_distcheck_031
2018-04-18 17:35:41 -04:00
Nick Mathewson
6125133715
Add distcheck support to travis configuration.
...
Implements 25814.
2018-04-18 17:33:19 -04:00
Isis Lovecruft
f17ace1460
crypto: Move declaration of crypto_init_siphash_key() into crypto.h.
...
On second thought, this is a global initialisation function and
doesn't conceptually have much to do with getting/using randomnesses.
2018-04-18 19:16:35 +00:00
Nick Mathewson
32181cbaa2
mention 19429 in changes file
2018-04-18 13:03:31 -04:00
Nick Mathewson
c296f00254
Changes file for openssl no-deprecated work.
2018-04-18 12:35:36 -04:00
Nick Mathewson
9d27e3f014
Make test_tortls.c build with openssl no_deprecated.
...
Also for 19981.
2018-04-18 12:32:39 -04:00
Nick Mathewson
a15b2c57e1
Add support for openssl built with "no-deprecated".
...
Patch from Andrew John Hughes; partial fix for 19981.
2018-04-18 12:31:24 -04:00