219 Commits

Author	SHA1	Message	Date
teor	bb3df5f322	practracker: Disable practracker in git hooks ... Disable our coding standards best practices tracker in our git hooks. 0.4.3 branches only. Closes ticket 33678.	2020-03-20 17:32:57 +10:00
Nick Mathewson	7b42502869	Merge remote-tracking branch 'tor-github/pr/1757/head' into maint-0.4.3	2020-02-20 10:44:36 -05:00
teor	57ff8d4a53	practracker: Read unicode files when using Python 2 ... Allow the "practracker" coding best practices checking script to read unicode files, when using Python 2. We made the script use unicode literals in 0.4.3.1-alpha, but didn't change the codec for opening files. Fixes bug 33374; bugfix on 0.4.3.1-alpha.	2020-02-19 08:22:01 +10:00
David Goulet	f0964628e6	Merge branch 'ticket33029_042_01' into ticket33029_043_03 ... Conflicts: doc/tor.1.txt src/app/config/config.c src/app/config/or_options_st.h src/core/mainloop/connection.h Between 042 and 043, the dirauth options were modularized so this merge commit address this by moving the AuthDirRejectUncompressedRequests to the module along with a series of accessors. Signed-off-by: David Goulet <dgoulet@torproject.org>	2020-02-11 10:30:29 -05:00
Nick Mathewson	5e963f97b1	practracker: use shutil.move so --regen will work on windows ... On windows you can't os.rename() a file if the target filename already exists.	2020-02-03 13:36:56 -05:00
Nick Mathewson	ec965ba98b	practracker: integration tests for --regen and --regen-overbroad	2020-02-03 13:11:58 -05:00
Nick Mathewson	2542a24b63	practracker: add a --regen-overbroad option to remove overbroad exceptions. ... Closes ticket 32372.	2020-02-03 13:02:12 -05:00
teor	b7cfca1dee	Merge branch 'pr1599_squashed'	2020-01-15 22:31:01 +10:00
teor	b910ae8cd1	practracker: Wrap long lines in the test script	2020-01-15 22:29:52 +10:00
teor	fa038e5617	practracker: Test practracker exit status ... Part of 32705.	2020-01-15 22:29:48 +10:00
teor	eb55d85e75	practracker: Fail tests if any process exits unexpectedly ... Part of 32705.	2020-01-15 22:29:44 +10:00
teor	cda2ff1965	practracker: Capture stderr output in test_practracker.sh ... And canonicalise file paths, so that output is consistent, even in out-of-tree builds. Capturing stderr output produces better diagnostics. Diagnostics for 32705.	2020-01-15 22:29:22 +10:00
teor	8095c785f1	Merge branch 'maint-0.4.2'	2020-01-14 17:41:44 +10:00
teor	7e111d0eaa	practracker: print a notice to stderr when disabled ... When TOR_DISABLE_PRACTRACKER is set, print a message to stderr when skipping practracker checks. Part of 32705.	2020-01-14 17:41:00 +10:00
Nick Mathewson	6b1592b564	test_practracker.sh: never disable practracker ... When practracker is disabled, its output will be empty. We don't want that happening during our tests. Fixes bug 32705; bugfix on 0.4.2.1-alpha, when test_practracker.sh was introduced.	2020-01-13 16:17:51 -05:00
teor	1619f14a04	python: Add __future__ imports for python 3 compatibility ... Except for src/ext, which we may not want to modify. Closes ticket 32732.	2019-12-12 15:58:51 +10:00
Nick Mathewson	fcb5656128	Merge branch 'ticket32609_squashed'	2019-12-04 12:15:28 -05:00
teor	b0f1b760ae	practracker: document !advisory in includes.py	2019-12-04 12:15:22 -05:00
teor	19324ff0ba	practracker: Test for bad ".c" includes in the unit tests ... Part of 32522.	2019-12-04 12:15:22 -05:00
teor	fadd292bf0	practracker/includes.py: Don't read editor temp files ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-26 17:52:18 +10:00
teor	ab70c315bd	practracker: Fix a typo in a logging function call ... Obviously correct changes to already-reviewed code.	2019-11-26 11:01:34 +10:00
Nick Mathewson	31f8b4fa65	Merge branch 'stream-socks-auth' into bug19859_merged	2019-11-25 07:58:02 -05:00
Nick Mathewson	5060007f4b	Split log configuration out of options_act_reversible().	2019-11-19 16:03:32 -05:00
George Kadianakis	53ac9a9a91	Add changes file for #30381.	2019-11-18 19:21:10 +02:00
teor	3b4a360ed0	practracker: Don't read editor temp files, attempt 2 ... (Or any files that start with "." or "#".) Obviously correct changes to already-reviewed code.	2019-11-14 16:12:19 +10:00
teor	60d5ff303d	practracker: Preserve improvements	2019-11-05 14:28:02 +10:00
teor	bcb38d984d	practracker: Update the exceptions file with improvements ... Regenerate the exceptions file, but only commit the improvements. Includes changes from 32213 and other tickets.	2019-11-05 12:50:08 +10:00
teor	c065ad3e3d	practracker: Rename functions modified by a previous commit ... Part of 32213.	2019-11-05 11:36:26 +10:00
JeremyRand	736322ce61	Bug #19859: Increase function-size exception to 124	2019-11-03 07:11:08 +00:00
teor	18e09913bf	practracker: Don't read editor temp files ... (Or any dot files.) Obviously correct changes to already-reviewed code.	2019-10-28 13:09:58 +10:00
Nick Mathewson	dc6d7f072d	Make foo_validate() functions call config_validate(). ... The former foo_validate() functions are now toplevel legacy_validate_fn callbacks. The new foo_validate() functions now call them. This change lets us remove the old shared_random disk state validation callback entirely.	2019-10-24 20:30:32 -04:00
Nick Mathewson	264c5312eb	Merge branch 'maint-0.4.2'	2019-10-18 12:32:49 -04:00
Alexander Færøy	95e3527df0	Bump practracker exception limit for process_win32_exec(). ... I have added a larger comment there and one line of code, so I think this bump is reasonable. See: https://bugs.torproject.org/31810	2019-10-17 21:12:51 +02:00
Nick Mathewson	08fd551e9f	Regenerate practracker exceptions file for 0.4.3 progress.	2019-10-16 09:15:00 -04:00
Nick Mathewson	8ce17e0b35	practracker: add a missing #.	2019-10-16 09:15:00 -04:00
Nick Mathewson	a4790e7d4b	maint-0.4.2: remove ".enable_practracker_in_hooks".	2019-10-11 17:18:55 -04:00
Nick Mathewson	5fd137c482	Merge remote-tracking branch 'tor-github/pr/1358'	2019-10-03 09:11:49 -04:00
teor	3d17fafa04	control/control: Refactor some error handling code ... Split some protocol error handling out of connection_control_process_inbuf(). This refactor reduces the size of a practracker exception. Closes 31840.	2019-10-03 11:35:42 +10:00
Nick Mathewson	ffd857bbe1	Merge remote-tracking branch 'tor-github/pr/1308'	2019-09-26 14:36:37 -04:00
George Kadianakis	7157d80c6f	Merge branch 'tor-github/pr/1337'	2019-09-25 14:19:49 +03:00
George Kadianakis	6677eae579	Merge branch 'tor-github/pr/1355'	2019-09-25 14:17:03 +03:00
George Kadianakis	99f75373de	Merge branch 'tor-github/pr/1309'	2019-09-25 14:12:42 +03:00
teor	22c33ea7f7	practracker: Fix a typo in the usage message ... Fixes bug 31828; bugfix on 0.4.2.1-alpha.	2019-09-24 14:37:43 +10:00
AmreshVenugopal	3e45260594	fix: Ticket #31589 ... - The function `decrypt_desc_layer` has a cleaner interface. - `is_superencrypted_layer` changed from `int` -> `bool` [ticket details](https://trac.torproject.org/projects/tor/ticket/31589) add(changes/*): changes file fix(src/features/hs): is_superencrypted changed from `int` -> `bool` fix(changes/ticket31589): header add(changes/ticket31589): subsystem(onion services) to change	2019-09-23 23:52:01 +05:30
Nick Mathewson	2e1989dacc	Remove practracker exception for microdesc parsing function	2019-09-19 14:37:24 -04:00
Nick Mathewson	1c67d261d5	practracker: Integration test for --list-overbroad ... Make sure that we list overbroad exceptions, and nothing else	2019-09-18 10:28:33 -04:00
Nick Mathewson	d1ffac3f8a	practracker: An exception is "used" even when it is violated. ... The purpose of tracking whether an exception is used is so that we can tell whether it is overbroad. This means that an _underbroad_ exception is still a used one. Fixes bug 31338.	2019-09-18 10:28:33 -04:00
Nick Mathewson	25d55fa01e	Practracker: do not list problems when told to --list-overbroad.	2019-09-18 10:28:33 -04:00
Nick Mathewson	e7565855c0	Merge branch 'ticket31578' into ticket31578_merged	2019-09-11 08:59:29 -04:00
David Goulet	796a9b37ea	Merge branch 'tor-github/pr/1264'	2019-09-09 14:53:12 -04:00