Nick Mathewson
06d977b569
hs_circuitmap.h: use a struct declaration
...
This fixes a case where our compilation would depend on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
887bf05c24
routerparse.h: include parsecommon.h when exposing token table.
...
Without this include, our compilation depends more on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
774d1092fd
process.h: add a struct declaration for buf_t.
...
This lets us avoid a dependency on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
dd5dda78f6
timers.h: add declaration for timeval.
...
This frees us from some dependencies on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
25354171b5
lib/conf: include torint.h in files that use it.
...
This frees us from some dependencies on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
8d4b4aa932
control_hs.h: use a couple of struct delcarations
...
Doing this frees us from some assumptions about include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
8b7eeea39d
connection.h: new includes and struct declarations
...
Using these frees us from several dependencies on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
c4ac5adc4a
siphash.h: include stdint.
...
Doing this gives us a valid uint64_t type, freeing us from
dependencies on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
6a6486a7bf
hs_circuit: use struct declaration.
...
This frees us from a dependency on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
d7b8377c28
or_options_st.h: Add an include and a struct declaration.
...
This frees us from some dependencies on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
8bb686d8a0
Include x509.h in tortls_internal.h.
...
This gives us the definition of tor_x509_cert_impl_t, and makes us
less dependent on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
b1dceeca5a
Include sys/types.h in fdio.h, for "off_t".
...
Otherwise our compilation depends on include order.
2020-01-09 07:30:35 -05:00
Nick Mathewson
7b0d8834f2
Use raw_assert in ht.h
...
Also, include torerr.h from ht.h if we are using raw_assert.
Otherwise, our includes need to be ordered so that ht.h comes after
util_log.h.
2020-01-09 07:30:35 -05:00
Nick Mathewson
73b83b8f1a
Remove extra ; from tt_assert() macro definition.
...
We were actually omitting the semicolon in a few places, leading to
confusing indentation and some cocci failures.
2020-01-09 07:30:35 -05:00
Nick Mathewson
3ce2304c6d
Use new ENABLE/DISABLE_GCC_WARNING
...
This is an automated commit, generated by:
perl -i -pe 'next if /define/; s/((?:ENABLE|DISABLE)_GCC_WARNING)\(([A-Za-z0-9_\-]+)\)/$1(\"-W$2\")/' src/*/*/*.[ch] src/*/*.[ch]
2020-01-09 07:30:35 -05:00
Nick Mathewson
792e5b2403
Replace DISABLE/ENABLE_GCC_WARNING with something that will confuse clang-format less
2020-01-09 07:30:35 -05:00
Nick Mathewson
a48cb9fa43
core/include.am: spelling fix
2020-01-08 20:50:02 -05:00
Nick Mathewson
4f02812242
It's 2020. Update the copyright dates with "make update-copyright"
2020-01-08 18:39:17 -05:00
Nick Mathewson
2d27a3ecc0
Run "make autostyle"; add an endif comment
2020-01-08 18:38:24 -05:00
teor
a58cffe195
router: Improve port search function comments
2020-01-08 17:47:08 +10:00
Roger Dingledine
81fd8aad24
speaking of utf-8, remove strange char from comment
2020-01-07 18:25:17 -05:00
Nick Mathewson
e231cd5b61
Merge branch 'ticket32845_squashed'
2020-01-07 10:16:15 -05:00
teor
1fd27155d4
changes: file for 32845
2020-01-07 10:16:08 -05:00
teor
0e3fd4df99
string: Check UTF-8 string pointer and length
...
If they are inconsistent, output a raw bug log.
Part of 32845.
2020-01-07 10:16:08 -05:00
Nick Mathewson
17a1ae025a
Merge remote-tracking branch 'tor-github/pr/1640'
2020-01-07 08:59:31 -05:00
Nick Mathewson
c48068ece3
test_helpers: add a missing free for CID 1457527.
2020-01-07 08:22:02 -05:00
Nick Mathewson
f2aeaaf71d
Add new state to connection_proxy_state_to_string()
...
Also, add a CTASSERT() to make sure that we don't let this array get
out-of-sync again.
Found by coverity; this is CID 1457528.
2020-01-07 08:09:27 -05:00
teor
d62dbb6762
string: Add extra UTF-8 test cases
...
These test cases are validated differently by some
programming languages, because those languages have
incorrect UTF-8 implementations.
We want to make sure that tor validates them correctly.
Closes ticket 32845.
2020-01-07 17:05:48 +10:00
Neel Chauhan
ee015d36f8
Space the a-d unsigned ints in tor_inet_aton()
2020-01-06 20:20:38 -08:00
Nick Mathewson
1b63eea66c
Merge branch 'haxxpop/tcp_proxy_squashed' into tcp_proxy_squshed_and_merged
2020-01-06 13:41:20 -05:00
Suphanat Chunhapanya
14d781fff6
circuit: Add change file
2020-01-06 13:39:10 -05:00
Suphanat Chunhapanya
4264717ca3
test: HTTP CONNECT protocol
2020-01-06 13:39:10 -05:00
Suphanat Chunhapanya
de58a49a2d
test: HAPRoxy protocol
2020-01-06 13:39:10 -05:00
Suphanat Chunhapanya
41b9dca07b
test: Implement haproxy
2020-01-06 13:39:10 -05:00
Suphanat Chunhapanya
119004e87d
circuit: Implement haproxy
2020-01-06 13:39:10 -05:00
Nick Mathewson
9276c07a91
Merge remote-tracking branch 'tor-github/pr/1615'
2020-01-06 13:32:33 -05:00
Nick Mathewson
e08d07692f
Add documentation about building a TAGS file.
...
Patch from opara. Closes ticket 32779.
2020-01-06 13:31:30 -05:00
Nick Mathewson
1f498220bd
Merge remote-tracking branch 'tor-github/pr/1620'
2020-01-06 13:28:10 -05:00
Nick Mathewson
48f7341783
Merge branch 'maint-0.4.2'
2020-01-06 13:24:01 -05:00
Nick Mathewson
6da989cfe8
Merge remote-tracking branch 'tor-github/pr/1612' into maint-0.4.2
2020-01-06 13:20:57 -05:00
Nick Mathewson
4f6901d7cc
When initializing pthreads, always set the main thread.
...
Fixes bug 32884. This is a bugfix on 0.3.3.1-alpha, when we started
allowing restart-in-process with tor_api.h.
2020-01-06 09:37:12 -05:00
Nick Mathewson
b6f099672b
Make ntmain.h functions stubs when NT_SERVICE not enabled.
...
This lets us simplify main.c a little, and avoid a practracker
exception.
Followup from #32883 .
2020-01-06 09:25:23 -05:00
Nick Mathewson
5c240db0bf
Restore feature where nt-services detect non-"run_tor" modes.
...
Followup for #32883 .
2020-01-06 09:25:23 -05:00
Nick Mathewson
dca2629480
Use tor_api.h entry points in ntmain.c.
...
When we updated main.c to use the same entry points as tor_api.h, we
didn't update ntmain.c. This led to bugs as the two got out of
sync.
There are two calls that we drop in this patch: first, I drop the
call to set_main_thread(), since that's redundant with the init
function in compat_winthreads.c (but see #32884 ). Second, I drop
the check for CMD_RUN_TOR: I'll add that back with a subsequent
commit.
Closes ticket 32883.
2020-01-06 09:24:15 -05:00
Nick Mathewson
54eec5342d
Initialize publish/subscribe code when running as an NT service.
...
Fixes bug 32778; bugfix on 0.4.1.1-alpha.
2020-01-06 09:22:57 -05:00
Nick Mathewson
13216f848a
Merge branch 'maint-0.4.2'
2020-01-06 08:08:59 -05:00
Nick Mathewson
2d8d6d1ebf
Merge branch 'maint-0.4.1' into maint-0.4.2
2020-01-06 08:08:59 -05:00
Nick Mathewson
f5461a4bdf
update changes file to pass "make check-changes"
2020-01-06 08:08:48 -05:00
Nick Mathewson
16e94dc7a7
Merge branch 'maint-0.4.1' into maint-0.4.2
2020-01-06 08:06:54 -05:00
Peter Gerber
b9d81282e0
Fix sandbox crash during reload of logging configuration
...
Allow calls to dup() which was introduced in commit a22fbab986
.
From a security perspective, I don't think this should impact the
security of the sandbox significantly. As far as I can tell, there
is nothing an adversary can do with a duplicated FD that can't be
done with the original.
2020-01-05 15:24:45 +00:00