Nick Mathewson
5f8f498207
r15968@catbus: nickm | 2007-10-19 14:39:51 -0400
...
Implement code to compute which method to use to compute a consensus. Also, fix leak in consensus calculation.
svn:r12054
2007-10-19 18:56:30 +00:00
Nick Mathewson
b0a18d1bfa
r15967@catbus: nickm | 2007-10-19 14:14:47 -0400
...
Change meaning of "freefn" argument to smartlist_uniq so that we can remove duplicates from a list without freeing them.
svn:r12053
2007-10-19 18:56:28 +00:00
Nick Mathewson
6ca4eebb57
r15966@catbus: nickm | 2007-10-19 13:56:28 -0400
...
Voting side of proposal 122
svn:r12052
2007-10-19 18:56:26 +00:00
Nick Mathewson
7bb202fd19
r15965@catbus: nickm | 2007-10-19 13:32:11 -0400
...
Client-side implementation for proposal 122.
svn:r12051
2007-10-19 18:56:24 +00:00
Nick Mathewson
ee2b770dee
r15964@catbus: nickm | 2007-10-19 12:43:49 -0400
...
Sort out that need_to_mirror is for routerstatuses in v2 networkstatuses only.
svn:r12050
2007-10-19 18:56:21 +00:00
Nick Mathewson
24317c75a9
r15961@catbus: nickm | 2007-10-19 12:40:15 -0400
...
Learn the difference between "mismatched vote digest" and "mismatched vote times": the latter is more informative.
svn:r12049
2007-10-19 16:41:32 +00:00
Nick Mathewson
53f9fe7dc5
r15960@catbus: nickm | 2007-10-19 12:30:17 -0400
...
Make authority_certs_fetch_missing() honor should_delay_dir_fetches()
svn:r12048
2007-10-19 16:41:30 +00:00
Nick Mathewson
140ef7d0f8
r15957@catbus: nickm | 2007-10-19 12:22:18 -0400
...
Report our IP address in our vote if it turns out that our hostname isn't a fqdn.
svn:r12047
2007-10-19 16:28:13 +00:00
Nick Mathewson
106e01db3d
r15956@catbus: nickm | 2007-10-19 11:18:14 -0400
...
Encode address in certificates. Also, make it possible to create certs reusing an old key.
svn:r12046
2007-10-19 16:28:10 +00:00
Nick Mathewson
29dfdac923
r15939@catbus: nickm | 2007-10-18 22:14:15 -0400
...
Remember the valid-until time of the most recent consensus that listed
a router, and (if we are a cache) never delete the routerdesc until
that conensus is expired. This is way easier than retaining multiple
consensuses. (Of course, the info isn't retained across restarts,
but that only affects a few caches at a time.)
svn:r12041
2007-10-19 02:15:47 +00:00
Peter Palfrader
829801c476
Call routers_update_all_from_networkstatus() from router_reload_consensus_networkstatus() so that we warn about old versions when we startup Tor, not when we fetch the next consensus document
...
svn:r12038
2007-10-19 00:29:16 +00:00
Roger Dingledine
85e746d060
revert a tiny bit of r12035
...
svn:r12037
2007-10-18 23:18:28 +00:00
Roger Dingledine
0a865bc277
various fixes from reading or-cvs the past few days
...
svn:r12035
2007-10-18 23:14:58 +00:00
Nick Mathewson
5bfb422157
r15934@catbus: nickm | 2007-10-18 15:32:56 -0400
...
When we have plenty of directory information, don't try to launch descriptor downloads quite so eagerly.
svn:r12033
2007-10-18 19:51:14 +00:00
Nick Mathewson
db2c5132c9
r15919@catbus: nickm | 2007-10-18 10:57:47 -0400
...
Add a log message to router_remove_old_routers to try to figure out why peacetime has such a big cache.
svn:r12024
2007-10-18 14:58:45 +00:00
Nick Mathewson
5ff0e4ed56
r15917@catbus: nickm | 2007-10-18 10:50:01 -0400
...
Better log messages about extrainfo downloads.
svn:r12023
2007-10-18 14:50:59 +00:00
Nick Mathewson
192e3d71d4
r15915@catbus: nickm | 2007-10-18 10:26:44 -0400
...
Stop incessant notices about when we think the expected valid-after time should be, if we are not an authority.
svn:r12022
2007-10-18 14:27:42 +00:00
Nick Mathewson
959c4963b2
r15913@catbus: nickm | 2007-10-18 10:22:19 -0400
...
Fix segfault in init_keys()
svn:r12021
2007-10-18 14:23:19 +00:00
Nick Mathewson
8f21a0a0b7
r15907@catbus: nickm | 2007-10-18 10:18:53 -0400
...
Fix up logic for choosing the time at which to download a consensus: Never attempt it when the current consensus is still the most recent.
svn:r12020
2007-10-18 14:19:56 +00:00
Nick Mathewson
c96167a6bd
r15906@catbus: nickm | 2007-10-18 10:00:08 -0400
...
Remove the obsolete warned_conflicts field: a v3 consensus cannot conflict with itself.
svn:r12019
2007-10-18 14:19:53 +00:00
Nick Mathewson
59b1b08753
r15905@catbus: nickm | 2007-10-18 09:58:54 -0400
...
Document some functions while I can still rememberf what they do. Fix up some whitespace.
svn:r12018
2007-10-18 14:19:51 +00:00
Nick Mathewson
35abfa1f77
r15899@catbus: nickm | 2007-10-18 07:49:15 -0400
...
"if (!router_get_trusted_dirservers())" is a bad test: router_get_trusted_dirservers() always returns a list. Instead, check for whether the list is empty.
svn:r12013
2007-10-18 11:50:20 +00:00
Nick Mathewson
54ac72f6b0
r15887@catbus: nickm | 2007-10-17 17:25:32 -0400
...
When a networkstatus consensus download fails, do not wait 60 seconds to decide whether to retry. (Also, log the time at which we'll try to replace the current networkstatus.)
svn:r12005
2007-10-17 21:26:22 +00:00
Nick Mathewson
088c1fac39
r15886@catbus: nickm | 2007-10-17 17:21:10 -0400
...
Treat it as an error when a v3 authority cant load its keys or certificates
svn:r12004
2007-10-17 21:26:19 +00:00
Nick Mathewson
e3113502ad
r15882@catbus: nickm | 2007-10-17 15:23:05 -0400
...
oprofile was telling me that a fair bit of our time in openssl was spent in base64_decode, so replace base64_decode with an all-at-once fairly optimized implementation. For decoding keys and digests, it seems 3-3.5x faster than calling out to openssl. (Yes, I wrote it from scratch.)
svn:r12002
2007-10-17 19:23:56 +00:00
Nick Mathewson
e8bd32b347
r15880@catbus: nickm | 2007-10-17 14:56:51 -0400
...
Patch from robert hogan: do not reset trusted dir server list when we get a config option.
svn:r12001
2007-10-17 19:23:52 +00:00
Nick Mathewson
f988f93b1a
r15877@catbus: nickm | 2007-10-17 12:54:56 -0400
...
Make unverified-consensus get removed when it is accepted or rejected. Make a new get_datadir_fname*() set of functions to eliminate the common code of "get the options, get the datadir, append some stuff".
svn:r12000
2007-10-17 16:55:44 +00:00
Nick Mathewson
4088a90d55
r15876@catbus: nickm | 2007-10-17 12:39:05 -0400
...
Treat certificates as reason to note directory info as arrived
svn:r11999
2007-10-17 16:55:41 +00:00
Nick Mathewson
c23409080e
r15871@catbus: nickm | 2007-10-16 14:47:00 -0400
...
Add a debugging info msg to routerlist
svn:r11995
2007-10-16 18:47:32 +00:00
Nick Mathewson
9d7eba6ecc
r15868@catbus: nickm | 2007-10-16 14:18:29 -0400
...
Remove nearly all calls to routerlist_remove_old(). Backport candidate.
svn:r11994
2007-10-16 18:19:02 +00:00
Nick Mathewson
29173560b8
r15862@catbus: nickm | 2007-10-16 13:19:29 -0400
...
Correct mismatches between DirServer lines and authority configuration.
svn:r11992
2007-10-16 17:22:37 +00:00
Nick Mathewson
0dab1a14a5
r15860@catbus: nickm | 2007-10-16 13:09:57 -0400
...
Avoid an infinite loop in networkstatus_reset_download_failures().
svn:r11990
2007-10-16 17:21:03 +00:00
Nick Mathewson
58ecc39141
r15859@catbus: nickm | 2007-10-16 13:09:28 -0400
...
Reset the is_named flag only on non-naming directories.
svn:r11989
2007-10-16 17:21:01 +00:00
Nick Mathewson
0d26b623ee
r15853@catbus: nickm | 2007-10-16 11:32:55 -0400
...
Fix "Error adding vote: OK" message.
svn:r11986
2007-10-16 15:34:14 +00:00
Nick Mathewson
c5fb1c19eb
r15849@catbus: nickm | 2007-10-16 10:24:38 -0400
...
Correct and additional fix to bug 529.
svn:r11985
2007-10-16 14:25:16 +00:00
Nick Mathewson
03ce9d3ee7
r15848@catbus: nickm | 2007-10-16 10:17:02 -0400
...
Only drop routers for not appearing in the consensus if their purpose is GENERAL.
svn:r11984
2007-10-16 14:25:14 +00:00
Nick Mathewson
9ca2625833
r15847@catbus: nickm | 2007-10-16 10:15:07 -0400
...
Fix the simpler bit of bug 529: update routerinfo_t.is_named from the consensus.
svn:r11983
2007-10-16 14:25:13 +00:00
Nick Mathewson
f3c7eeb4a0
r15843@catbus: nickm | 2007-10-16 09:58:49 -0400
...
Clean up our code to fix a warning under gcc 4.2
svn:r11982
2007-10-16 13:59:37 +00:00
Roger Dingledine
5aa76cdaa8
Correctly check for bad options to the "PublishServerDescriptor"
...
config option. Bugfix on 0.2.0.1-alpha; reported by Matt Edman.
svn:r11968
2007-10-16 03:26:39 +00:00
Nick Mathewson
dbdaa610ee
r15814@catbus: nickm | 2007-10-15 22:15:19 -0400
...
Fix last patch.
svn:r11961
2007-10-16 02:15:41 +00:00
Roger Dingledine
e477a3860a
two ugly hacks to make my tor client start again. nick, these
...
are for you.
svn:r11960
2007-10-16 02:06:30 +00:00
Nick Mathewson
9b3957e755
r15809@catbus: nickm | 2007-10-15 19:44:13 -0400
...
Do not call the more interesting parts of routers_update_all_from_networkstatus if there is no live networkstatus.
svn:r11958
2007-10-15 23:44:32 +00:00
Nick Mathewson
3ad6dc0e2e
r15806@catbus: nickm | 2007-10-15 19:14:57 -0400
...
Implement v3 networkstatus client code. Remove v2 networkstatus client code, except as needed for caches to fetch and serve v2 networkstatues and the routers they list.
svn:r11957
2007-10-15 23:15:24 +00:00
Nick Mathewson
738d178f77
Make last commit compile
...
svn:r11953
2007-10-15 20:39:58 +00:00
Nick Mathewson
da955df111
Add some debugging logs related to dir vote timing.
...
svn:r11952
2007-10-15 20:37:59 +00:00
Nick Mathewson
516b913d5c
r15793@catbus: nickm | 2007-10-15 15:50:52 -0400
...
Do not set "have published consensus" to 1 after we recalculate timing.
svn:r11951
2007-10-15 19:51:14 +00:00
Nick Mathewson
7f9e9c816c
r15790@catbus: nickm | 2007-10-15 11:38:28 -0400
...
Fix bug 528: fix memory leak in base32_decode(). While there, also make base32_decode() accept upper-case inputs.
svn:r11946
2007-10-15 15:38:44 +00:00
Nick Mathewson
161b85d588
r15781@catbus: nickm | 2007-10-15 10:59:26 -0400
...
Make discard_old_votes part of the consensus publishing process, so we conform to spec, and so we avoid a weird bugs where publishing sets the consensus, setting the consensus makes us reschedule, and rescheduling makes us delay vote-discarding.
svn:r11944
2007-10-15 14:59:48 +00:00
Nick Mathewson
c8ad4f58ee
r15780@catbus: nickm | 2007-10-15 10:35:16 -0400
...
Fix the implementation of "download votes by digest".
svn:r11943
2007-10-15 14:59:44 +00:00
Nick Mathewson
09dfe31ff4
r15750@catbus: nickm | 2007-10-13 20:06:47 -0400
...
Eventually delete the obsolete cached-routers and cached-routers.new files, so they don't sit around on disk forever.
svn:r11918
2007-10-14 00:13:06 +00:00
Nick Mathewson
1b45314775
r15749@catbus: nickm | 2007-10-13 20:06:06 -0400
...
Remove support for long-obsolete bw_accounting file.
svn:r11917
2007-10-14 00:13:04 +00:00
Roger Dingledine
39902e93f7
Stop publishing a new server descriptor just because we HUP or
...
when we find our DirPort to be reachable but won't actually publish
it. Extra descriptors without any real changes are dropped by the
authorities, and can screw up our "publish every 18 hours" schedule.
svn:r11915
2007-10-13 22:31:35 +00:00
Roger Dingledine
d9ba4d3e8b
note a bug in directories_have_accepted_server_descriptor() pointed
...
out by weasel
svn:r11914
2007-10-13 22:01:24 +00:00
Roger Dingledine
e269feea77
stop handling 403 responses from directory authorities/mirrors. we
...
haven't issued those in years.
svn:r11913
2007-10-13 21:57:02 +00:00
Nick Mathewson
29fc92ef86
r15732@catbus: nickm | 2007-10-12 17:28:24 -0400
...
Start roughing out the functions that we'll use to replace the old ugly v2 networkstatus manipulation code".
svn:r11904
2007-10-12 21:33:39 +00:00
Nick Mathewson
783402f63a
r15731@catbus: nickm | 2007-10-12 17:27:48 -0400
...
Move "sort a list of routerinfo_t" into its own function in routerlist.c
svn:r11903
2007-10-12 21:33:37 +00:00
Nick Mathewson
a009014eb3
r15730@catbus: nickm | 2007-10-12 16:47:47 -0400
...
Note a way to make routerlist_remove_old_routrs get called way less.
svn:r11902
2007-10-12 21:33:35 +00:00
Nick Mathewson
de08405bdb
r15721@catbus: nickm | 2007-10-12 13:30:48 -0400
...
Base vote timing only on a currently live consensus.
svn:r11896
2007-10-12 17:43:09 +00:00
Nick Mathewson
8fdfdc5bbb
r15719@catbus: nickm | 2007-10-12 13:07:45 -0400
...
Add the routers in the latest consensus to the list of routers to retain when removing old ones.
svn:r11895
2007-10-12 17:13:09 +00:00
Roger Dingledine
b60e138586
fix two instances of double-frees. may fix bug 527.
...
svn:r11893
2007-10-12 09:09:46 +00:00
Roger Dingledine
3977ccbc80
Controllers should now specify cache=no or cache=yes when using
...
the +POSTDESCRIPTOR command.
svn:r11892
2007-10-12 07:57:29 +00:00
Roger Dingledine
ad8757fbeb
Disable the SETROUTERPURPOSE controller command: it is now obsolete.
...
svn:r11891
2007-10-11 22:19:47 +00:00
Roger Dingledine
5c4a00e796
minor cleanups
...
svn:r11890
2007-10-11 22:19:18 +00:00
Roger Dingledine
3d9bf8c912
note a design flaw that i should fix somehow
...
svn:r11889
2007-10-11 22:16:05 +00:00
Nick Mathewson
3100712c34
r15703@catbus: nickm | 2007-10-11 17:30:34 -0400
...
Fix for the reported case of bug 438: check families as well as identities in circuit_find_to_cannibalize(). Code audit still pending. ;)
svn:r11886
2007-10-11 21:40:35 +00:00
Nick Mathewson
b62d379f92
r15689@catbus: nickm | 2007-10-11 16:40:25 -0400
...
Fix bug 451. This was a nasty bug, so let's fix it twice: first, by banning recursive calls to connection_handle_write from connection_flushed_some; and second, by not calling connection_finished_flushing() on a closed connection. Backport candidate.
svn:r11882
2007-10-11 20:45:26 +00:00
Nick Mathewson
ff2820c1ba
r14892@Kushana: nickm | 2007-10-11 14:00:33 -0400
...
Fix a bunch of XXX020s: treat some 403s as INFO severity; remove some dead code; share the retry path for consensus routerdescs that are also listed in the v2 networkstatus; check even more aspects of votes when parsing them.
svn:r11871
2007-10-11 18:01:12 +00:00
Nick Mathewson
007d76543d
r14887@Kushana: nickm | 2007-10-11 11:19:39 -0400
...
Fix some XXX020s in dirserv.c
svn:r11870
2007-10-11 16:06:51 +00:00
Nick Mathewson
52ca3a7610
r14886@Kushana: nickm | 2007-10-11 11:02:53 -0400
...
Move prototypes around in or.h so that the functions from routerlist.c which moved to networkstatus.c are all grouped in the right section.
svn:r11869
2007-10-11 16:06:47 +00:00
Nick Mathewson
6670122619
r14885@Kushana: nickm | 2007-10-11 10:36:16 -0400
...
Document minimal values for voting times. Use a macro instead of a magic number. Remove an "enforce this" xxxx020 that was already enforced.
svn:r11868
2007-10-11 16:06:42 +00:00
Nick Mathewson
0a1dd92d3e
r14884@Kushana: nickm | 2007-10-11 10:30:58 -0400
...
More fixes for cacheing bridge descs:Remove obsolete EXTRAINFO_PURPOSE_GENERAL; remove purpose argument from signed_desc_append_to_journal.
svn:r11867
2007-10-11 16:06:37 +00:00
Nick Mathewson
9a56b17c54
r15679@catbus: nickm | 2007-10-11 09:51:33 -0400
...
Remove code to generate v1 directories.
svn:r11866
2007-10-11 13:56:33 +00:00
Roger Dingledine
541aa72155
Bugfix on r11138:
...
Fix a minor memory leak whenever a controller sends the PROTOCOLINFO
command. Bugfix on 0.2.0.5-alpha.
Backport candidate.
svn:r11864
2007-10-11 03:27:47 +00:00
Roger Dingledine
900ddcb8fd
bugfix on r11298:
...
Fix a minor memory leak whenever we parse guards from our state
file. Bugfix on 0.2.0.7-alpha.
svn:r11862
2007-10-11 02:03:53 +00:00
Nick Mathewson
487f985f5b
r15670@catbus: nickm | 2007-10-10 20:08:14 -0400
...
Restore a removed assert.
svn:r11861
2007-10-11 00:13:06 +00:00
Nick Mathewson
a718fcb1c0
r15663@catbus: nickm | 2007-10-10 16:35:58 -0400
...
Resolve some more voting-related XXXXs.
svn:r11860
2007-10-11 00:13:03 +00:00
Nick Mathewson
0452a965da
r15662@catbus: nickm | 2007-10-10 16:27:58 -0400
...
Removee a misleading log message.
svn:r11859
2007-10-11 00:13:00 +00:00
Roger Dingledine
8e8d2defe3
bugfix on r11480:
...
Stop calling tor_strlower() on uninitialized memory in some cases.
svn:r11858
2007-10-10 23:44:10 +00:00
Roger Dingledine
dd920354c2
let bridge authorities write bridge descriptors to their
...
cached-descriptors* files.
nick, did i get this right?
svn:r11855
2007-10-10 23:11:53 +00:00
Roger Dingledine
919f421c6c
get rid of the spurious "Freeing linked %s connection" complaints.
...
they happen whenever we fail to establish a connection.
svn:r11854
2007-10-10 22:59:34 +00:00
Nick Mathewson
17f3d2807d
r15660@catbus: nickm | 2007-10-10 16:25:09 -0400
...
Fix compilation on last patch.
svn:r11853
2007-10-10 20:29:52 +00:00
Nick Mathewson
dace37aee8
r15656@catbus: nickm | 2007-10-10 16:23:18 -0400
...
Fix the implementation of if-modified-since for certificates so that it applies to all types of certificate requests. Note that the kind of consensus that matters already has a working if-modified-since.
svn:r11852
2007-10-10 20:28:01 +00:00
Roger Dingledine
d9a99b9ba6
get r11842 closer to what i want
...
svn:r11851
2007-10-10 20:13:52 +00:00
Nick Mathewson
976c8f8a71
r15646@catbus: nickm | 2007-10-10 16:01:54 -0400
...
Fix some memory leaks when serving v3 networkstatus documents and v3 certs. Generate 503 correctly when serving v3 networkstatus documents and v3 certs.
svn:r11850
2007-10-10 20:06:38 +00:00
Roger Dingledine
f6b25613b8
Tweak the implementation of proposal 109 slightly: allow at most
...
two Tor servers on the same IP address, except if it's the location
of a directory authority, in which case allow five.
svn:r11842
2007-10-10 19:53:08 +00:00
Nick Mathewson
55520a2d95
r15636@catbus: nickm | 2007-10-10 15:28:12 -0400
...
Retry consensus and certificate downloads properly. Do not fail when there are no certificates to download. Do not download certificates we already have when retrying.
svn:r11841
2007-10-10 19:33:19 +00:00
Nick Mathewson
f05685a8eb
r15635@catbus: nickm | 2007-10-10 15:27:07 -0400
...
Remove extraneous whitespace
svn:r11840
2007-10-10 19:33:14 +00:00
Nick Mathewson
b5301d81db
r15634@catbus: nickm | 2007-10-10 14:26:49 -0400
...
Resolve/ignore some XXXXs, and be even more careful about listing a server as a v3 authority.
svn:r11839
2007-10-10 19:33:11 +00:00
Nick Mathewson
b599d4264f
r15633@catbus: nickm | 2007-10-10 14:16:54 -0400
...
Fix a spelling mistake.
svn:r11838
2007-10-10 19:33:06 +00:00
Nick Mathewson
45b987d891
r15632@catbus: nickm | 2007-10-10 13:48:44 -0400
...
Merge networkstatus_add_signatures_impl into the only function that calls it.
svn:r11837
2007-10-10 19:33:01 +00:00
Nick Mathewson
daf4c11f1a
r15630@catbus: nickm | 2007-10-10 13:39:44 -0400
...
Save weighted-fractional-uptime to disk as well as MTBF. Bump the version on rouer-stability: downgrading to versions earlier than this one will lose your WFU data.
svn:r11835
2007-10-10 17:48:58 +00:00
Peter Palfrader
1a94e84661
Say "using socksX _to_ port y" instead of "socksX _on_ port y". it confuses weasel less
...
svn:r11834
2007-10-10 15:44:34 +00:00
Nick Mathewson
9ed39643fa
r15626@catbus: nickm | 2007-10-10 11:02:32 -0400
...
Resolve bug 516: Never report our bandwidth-history as over RelayBandwidthRate*NUM_SECS_BW_SUM_INTERVAL.
svn:r11833
2007-10-10 15:07:19 +00:00
Nick Mathewson
cb0dbbcfa5
r15621@catbus: nickm | 2007-10-10 00:37:25 -0400
...
Turns out, Bug 463 was just another "warn about something that is no big deal" thing. Downgrade, comment, and resolve.
svn:r11829
2007-10-10 04:37:38 +00:00
Nick Mathewson
1f4eafdb91
r15619@catbus: nickm | 2007-10-10 00:23:45 -0400
...
Fix bug 483: downgrade a harmless "Hey your accept() implementation sucks" warning to an info.
svn:r11828
2007-10-10 04:24:02 +00:00
Nick Mathewson
72f352880c
r15608@catbus: nickm | 2007-10-09 19:01:50 -0400
...
Give better messages and return values from signature uploads and downlaods; also, log actual errors when we screw up.
svn:r11823
2007-10-09 23:02:02 +00:00
Roger Dingledine
4f23045e58
back out a little bit of r11817 to preserve current behavior.
...
some other behavior changes left in.
svn:r11821
2007-10-09 21:12:48 +00:00
Roger Dingledine
a5851939c0
i heard that users know the phrase 'system clock' better than 'clock'. hm.
...
svn:r11820
2007-10-09 21:11:16 +00:00
Nick Mathewson
97fa3fdf16
r15599@catbus: nickm | 2007-10-09 16:44:36 -0400
...
Fix the bug that was making moria1 set valid-after wrong in its votes: we were looking at the preferred timing when we should have been looking at the consensus timing.
svn:r11818
2007-10-09 20:44:51 +00:00
Nick Mathewson
8b71a76dd3
r15598@catbus: nickm | 2007-10-09 16:37:35 -0400
...
Turn all "Is DirPort nonzero? Because if it is, we must be a directory" logic into calls to dirserver_mode().
svn:r11817
2007-10-09 20:44:47 +00:00