Nick Mathewson
7df7908905
Merge branch 'maint-0.2.8' into maint-0.3.0
...
This is an "ours" merge to avoid the conflict from the 0.2.8 version
of the fix for TROVE-2017-008.
2017-09-18 09:40:09 -04:00
Nick Mathewson
314652dc16
Merge branch 'maint-0.2.8' into maint-0.2.9
2017-09-18 09:39:46 -04:00
Nick Mathewson
0ec72b0308
Merge branch 'trove-2017-008_028' into maint-0.2.8
2017-09-18 09:39:35 -04:00
Nick Mathewson
09ea89764a
Fix log-uninitialized-stack bug in rend_service_intro_established.
...
Fixes bug 23490; bugfix on 0.2.7.2-alpha.
TROVE-2017-008
CVE-2017-0380
2017-09-18 09:32:41 -04:00
Nick Mathewson
4a2cbea6ce
Fix log-uninitialized-stack bug in rend_service_intro_established.
...
Fixes bug 23490; bugfix on 0.2.7.2-alpha.
TROVE-2017-008
CVE-2017-0380
2017-09-18 09:27:07 -04:00
Edmund Wong
f0e87ff9eb
Add check for double-semi-colons at the end of a line
2017-09-18 15:33:24 +08:00
Nick Mathewson
dd8eeabfd1
Fix memory leak in tor-gencert.c
...
This was introduced in 4ff170d7b1
, and is probably
unreachable, but coverity complained about it (CID 1417761). Bug not
in any released Tor, so no changes file.
2017-09-17 20:42:28 -04:00
Nick Mathewson
faf1242bed
add frebsd ports maintainer to releasingtor list
2017-09-17 20:32:27 -04:00
Nick Mathewson
4519b7b469
kist_no_kernel_support is unused when we didn't detect it.
...
So, remove it.
2017-09-15 16:44:05 -04:00
Nick Mathewson
f4af1919ab
Replace accumulated C ;;s with ;s
...
I don't know where these came from.
2017-09-15 16:43:17 -04:00
Nick Mathewson
76c33f7ff4
Merge branch 'scan-build-032'
2017-09-15 16:40:11 -04:00
Nick Mathewson
c1deabd3b0
Run our #else/#endif annotator on our source code.
2017-09-15 16:24:44 -04:00
Nick Mathewson
7a597718bb
Split some long #if lines to make the #endif annotator happy
2017-09-15 16:24:21 -04:00
Nick Mathewson
40ce9819dd
update script to use /* */ comments
2017-09-15 16:11:48 -04:00
Nick Mathewson
5d06bbc66f
Merge branch 'annotate_ifdefs'
2017-09-15 16:07:37 -04:00
Nick Mathewson
639766dbc3
Merge branch 'maint-0.3.1'
...
Resolve conflict with 23532 code.
2017-09-15 14:40:35 -04:00
Nick Mathewson
49b5ad6b75
Merge branch 'bug23533_031' into maint-0.3.1
2017-09-15 14:39:23 -04:00
Nick Mathewson
a01e4a1a95
kist: Cast, then do operations on int32.
...
Otherwise integer overflows can happen. Remember, doing a i32xi32
multiply doesn't actually produce a 64-bit output. You need to do
i64xi32 or i64xi64.
Coverity found this as CID 1417753
2017-09-15 14:30:19 -04:00
Nick Mathewson
9201e4c74b
Merge branch 'bug23487_029'
2017-09-15 14:27:58 -04:00
Nick Mathewson
75659fd548
Use different variable names for pw_uid usages
...
Catalyst points out that using pw_uid for two different purposes
here is likely to be confusing.
2017-09-15 14:26:59 -04:00
Nick Mathewson
03e102c1bb
Make netinet/tcp include conditional too: windows lacks it.
2017-09-15 14:08:51 -04:00
Nick Mathewson
44fa866621
fix some 32-bit warnings about printf arguments
2017-09-15 14:02:08 -04:00
Nick Mathewson
a1c495b4b9
Try to improve formatting on the Schedulers option
2017-09-15 13:57:57 -04:00
Nick Mathewson
37302e64a4
Merge branch 'remove_allow_dotexit_v2'
2017-09-15 12:10:47 -04:00
Nick Mathewson
f02fd6c3af
Remove AllowDotExit.
...
It's been deprecated since 0.2.9.2-alpha. Closes ticket 23426.
2017-09-15 12:09:33 -04:00
Nick Mathewson
fea2d84ce3
wrap a wide comment
2017-09-15 12:03:08 -04:00
Nick Mathewson
0f4f40b70f
Merge remote-tracking branch 'dgoulet/ticket12541_032_02'
2017-09-15 12:00:50 -04:00
David Goulet
0650017143
doc: Man page entries for KIST
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:58:04 -04:00
Nick Mathewson
962b0b849b
Merge remote-tracking branch 'dgoulet/ticket19254_032_01'
2017-09-15 11:52:10 -04:00
Matt Traudt
ae9e6b547d
sched: add comment about how we determine if a socket should write
2017-09-15 11:40:59 -04:00
Matt Traudt
47390d1c9e
fixup! sched: add changes file (spaces)
2017-09-15 11:40:59 -04:00
Matt Traudt
63204be48f
sched: add changes file
2017-09-15 11:40:59 -04:00
Matt Traudt
501c58187d
sched: add more per-socket limit documentation; int fix
2017-09-15 11:40:59 -04:00
David Goulet
513d642a66
sched: Revert IF_BUG_ONCE() to tor_assert()
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
1033e14a69
sched: Define SCHEDULER_KIST_PRIVATE for more encapsulation
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
c910610701
sched: Improve logging if KIST is disabled
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
0d0b677b64
test: Fix unit tests with latest scheduler changes
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
734dbfa590
sched: Make the scheduler object static
...
Each type of scheduler implements its own static scheduler_t object and
returns a reference to it.
This commit also makes it a const pointer that is it can only change inside
the scheduler type subsystem but not outside for extra protection.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
bd34a0d30f
sched: Compare channel pointer in the socket table
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
e0984b8a51
sched: Make the outbuf table local to run()
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
ba08f8a4ed
sched: Make check-spaces happy
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
3d2d8d6841
sched: Extra careful in channel_outbuf_length()
...
In case we don't have a connection object in the channel, just be careful and
recover.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
14cd8bdd4b
sched: Don't expose the global scheduler libevent object
...
Instead, add wrappers to do the needed action the different scheduler needs
with the libevent object.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
84d18f70f3
sched: Always call on_channel_free() regardless of state
...
A channel can bounce in the scheduler and bounce out with the IDLE state which
means that if it came in the scheduler once, it has socket information that
needs to be freed from the global hash table.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
David Goulet
7cc9621d11
sched: Add Schedulers torrc option
...
This option is a list of possible scheduler type tor can use ordered by
priority. Its default value is "KIST,KISTLite,Vanilla" which means that KIST
will be used first and if unavailable will fallback to KISTLite and so on.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-09-15 11:40:59 -04:00
Matt Traudt
6ff8c86ac6
sched: change most asserts to non-fatal BUGs
2017-09-15 11:40:59 -04:00
Matt Traudt
4bc97c6431
sched: revisist compatibility on non-linux systems
...
Wrap things in HAVE_KIST_SUPPORT until Tor compiles and tests cleanly on
my OS X machine.
2017-09-15 11:40:59 -04:00
Matt Traudt
8ccb2c106a
sched: rename scheduler to the_scheduler
2017-09-15 11:40:59 -04:00
Matt Traudt
7f1d643083
sched: validate KIST sched options
2017-09-15 11:40:59 -04:00
Matt Traudt
61fc9c41ad
sched: switch to monotonic time; add/fix comments, style, and logs msgs
2017-09-15 11:40:59 -04:00