33352 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Nick Mathewson	3db56aeeb8	Document warn_deprecated_option().	2019-09-04 14:23:19 -04:00
Nick Mathewson	39316da9b6	Document return value of config_mgr_add_format().	2019-09-04 14:23:19 -04:00
Nick Mathewson	39dd2e2aa8	Document validate_fn_t as it stands. ... Also document that it will be changed in a later branch.	2019-09-04 14:23:19 -04:00
Nick Mathewson	aeda598fd5	config_assign: Document CAL_* options. ... These were sort of described in config_assign() documentation, but not so well.	2019-09-04 14:23:19 -04:00
Nick Mathewson	577ea20b3a	Document configuration and abbreviation types.	2019-09-04 14:23:19 -04:00
Nick Mathewson	106b75aa53	changes file for 31532	2019-09-04 12:06:27 -04:00
Nick Mathewson	3aba13f779	buffers: use ptrdiff_t to indicate offsets. ... Previously we used int in some places and off_t for others. Neither is correct: ptrdiff_t is right for differences between pointers. (off_t is only for offsets and sizes on the filesystem.)	2019-09-04 12:06:27 -04:00
Nick Mathewson	ec724fe8c8	rendclient: use ptrdiff, not off_t, for offset of DH field. ... The off_t type is only useful for offsets on the filesystem. For in-memory offsets, use ptrdiff_t.	2019-09-04 12:06:27 -04:00
Nick Mathewson	b39ee42904	compat_compiler: fix documentation for STRUCT_VAR_P ... Previously we had said that off_t was a reasonable type to hold the result of offsetof(). That isn't so: ptrdiff_t is correct.	2019-09-04 12:06:27 -04:00
Nick Mathewson	dc199f40fb	smartlist_pqueue: use ptrdiff_t instead of int for offsets. ... This is technically correct, but should not matter in practice, since we don't use this on any structs whose size exceeds INT_MAX.	2019-09-04 12:06:27 -04:00
Nick Mathewson	03ce67d378	config: explain CONFIG_TYPE_EXTENDED ... Also add an explanation of a possible future refactoring where we might remove the config_type_t enumeration entierly. Fixes ticket 31624. No changes file, since this is a comment-only change.	2019-09-04 11:54:42 -04:00
Nick Mathewson	870874fec8	config: Make CLEAR with a nonempty value into a nonfatal assertion. ... When we parse a CLEAR line (e.g., "/OrPort" or /OrPort blah blah"), we always suppress the value, even if one exists. That means that the block of code was meant to handle CLEAR lines didn't actually do anything, since we previously handled them the same way as with other empty values. Closes ticket 31529.	2019-09-04 11:28:21 -04:00
Nick Mathewson	539158f2be	config: use ptrdiff_t for all field-offset members. ... Previously we used int here, but it is more correct to use ptrdiff_t. (This never actually matters for our code in practice, since the structure we are managing here never exceed INT_MAX in size.)	2019-09-04 10:50:09 -04:00
David Goulet	34f3fcef40	Merge branch 'tor-github/pr/1290'	2019-09-04 10:33:49 -04:00
Nick Mathewson	4bcfa286f6	changes file for 31240	2019-09-04 10:31:45 -04:00
Nick Mathewson	46a3820652	Merge remote-tracking branch 'tor-github/pr/1270'	2019-09-04 09:52:35 -04:00
Nick Mathewson	c683896b7c	Update routerset reset test to use new mgr API.	2019-09-04 08:42:34 -04:00
Nick Mathewson	17a870a64b	Merge branch 'ticket31240v2_merged_2' into ticket31240v2_merged_2_merged	2019-09-04 08:41:42 -04:00
David Goulet	f5fa283a04	Merge branch 'tor-github/pr/1288'	2019-09-04 08:34:26 -04:00
David Goulet	a816742f37	Merge branch 'maint-0.4.1'	2019-09-04 08:33:28 -04:00
David Goulet	630bb113a0	Merge branch 'tor-github/pr/1271' into maint-0.4.1	2019-09-04 08:33:10 -04:00
David Goulet	6210c75076	Merge branch 'tor-github/pr/1246'	2019-09-04 08:27:36 -04:00
teor	9c798dd5a5	torerr: Fix a comment typo and update the comment for format_number_sigsafe() ... Closes 31612.	2019-09-04 14:06:58 +10:00
teor	193c74faf9	Merge branch 'bug31571_041' into bug31571_master	2019-09-04 13:57:39 +10:00
teor	abe1f4f23e	Merge branch 'bug31571_040' into bug31571_041	2019-09-04 13:57:36 +10:00
teor	0cee6f498c	Merge branch 'bug31571_035' into bug31571_040	2019-09-04 13:57:31 +10:00
teor	a836dd2530	Merge branch 'maint-0.3.5' into bug31571_035	2019-09-04 13:57:15 +10:00
teor	f311d0676c	backtrace: Check the return values of snprintf() and strncpy() ... We can't use strlcat() or strlcpy() in torerr, because they are defined in string/compat_string.h on some platforms, and string uses torerr. Part of 31571.	2019-09-04 13:51:22 +10:00
George Kadianakis	7fa624537c	Merge branch 'tor-github/pr/1269'	2019-09-03 17:11:25 +03:00
Nick Mathewson	a617001fd4	Merge remote-tracking branch 'tor-github/pr/1279'	2019-09-03 09:47:25 -04:00
Nick Mathewson	03040903e6	practracker: handle empty files. ... Previously practracker would fail on a file with no lines.	2019-09-02 15:40:35 -04:00
Nick Mathewson	3a2964577e	practracker: Fix indentation in util.py ... This commit only changes whitespace and removes a temporary comment.	2019-09-02 15:40:35 -04:00
Nick Mathewson	651bbe8a0d	Practracker: only consider files under "src/"	2019-09-02 15:40:35 -04:00
Nick Mathewson	52342327c7	madvise: tolerate EINVAL and ENOSYS ... These errors can occur if we are built on a system with support for madvise(MADV_NOFORK) but then we are run on a system whose kernel does not support that flag. If the error is something that we don't tolerate at all, we now log it before crashing. Fixes bug 31570. I am calling this a bugfix on 0.4.1.1-alpha, where we actually started using the map_anon code.	2019-09-02 14:49:53 -04:00
Nick Mathewson	78307ed186	Merge remote-tracking branch 'tor-github/pr/1272'	2019-09-02 14:13:32 -04:00
Nick Mathewson	01bda9bed1	Merge branch 'maint-0.4.1'	2019-09-02 14:11:32 -04:00
Nick Mathewson	e3a458e441	Merge branch 'ticket12399_035' into maint-0.4.1	2019-09-02 14:11:18 -04:00
rl1987	05fa1689eb	Change loglevel of message 'Hash of session info was not as expected'	2019-09-02 14:09:39 -04:00
teor	f538e23986	ChangeLog/ReleaseNotes: fix some incorrect bugfix versions ... Closes 31461.	2019-09-02 13:29:17 -04:00
teor	a3fad4d057	ChangeLog/ReleaseNotes: fix a typo in the 0.4.1 changes entries ... Part of 31461.	2019-09-02 13:29:12 -04:00
Neel Chauhan	d22ed05dc0	Space out the arguments to the cell functions in rend_process_relay_cell()	2019-08-30 18:58:00 -04:00
teor	340698ba10	Merge branch 'maint-0.4.1'	2019-08-30 23:33:18 +10:00
teor	25e7fc5b7a	Merge branch 'maint-0.4.0' into maint-0.4.1	2019-08-30 23:33:10 +10:00
teor	a52a5e0099	Merge branch 'maint-0.3.5' into maint-0.4.0	2019-08-30 23:33:01 +10:00
teor	1132dc9f75	Merge remote-tracking branch 'tor-github/pr/1181' into maint-0.3.5	2019-08-30 23:24:05 +10:00
teor	b66712d85b	Merge remote-tracking branch 'tor-github/pr/1117' into maint-0.3.5	2019-08-30 23:22:18 +10:00
teor	4662cbec7b	Merge remote-tracking branch 'tor-github/pr/1114' into maint-0.3.5	2019-08-30 23:20:59 +10:00
teor	c55591825f	torerr: Try harder to flush raw assert messages before process termination ... Some platforms (macOS, maybe others?) can swallow the last write before an abort. This issue is probably caused by a race condition between write buffer cache flushing, and process termination. So we write an extra newline, to make sure that the message always gets through. Fixes bug 31571; bugfix on 0.3.5.1-alpha.	2019-08-30 21:51:11 +10:00
teor	65a1d86491	torerr: Log the Tor backtrace version when a raw assertion fails ... Part of 31571.	2019-08-30 21:51:07 +10:00
teor	743bc0028b	backtrace: Log the Tor backtrace version whenever we log a backtrace ... Previously, we just logged it in the crash handler. Part of 31571.	2019-08-30 21:51:03 +10:00