Nick Mathewson
42c4670e27
r18230@catbus: nickm | 2008-02-19 18:29:43 -0500
...
Add a few asserts to catch possible errors found by veracode.
svn:r13598
2008-02-19 23:29:45 +00:00
Roger Dingledine
319c0d8933
is_reverse in our struct is uint8_t. don't make it be an int
...
elsewhere. bug reported by veracode.
svn:r13597
2008-02-19 23:14:34 +00:00
Nick Mathewson
dbcf29d301
r18228@catbus: nickm | 2008-02-19 18:05:53 -0500
...
Chris Palmer notes that almost nobody is using smartlist_set_capacity(). Chris Palmer is right. Remove this basically pointless function.
svn:r13596
2008-02-19 23:05:56 +00:00
Nick Mathewson
9479dd3768
r18226@catbus: nickm | 2008-02-19 18:01:01 -0500
...
Brown-paper-bag time. We were failing to count all the sockets from accept().
svn:r13595
2008-02-19 23:01:07 +00:00
Roger Dingledine
d1a195d3cb
call a "number of characters" a size_t, not an int
...
svn:r13594
2008-02-19 22:52:50 +00:00
Roger Dingledine
c126b79f07
be more explicit about a harmless thing that freaked veracode out
...
svn:r13592
2008-02-19 22:32:32 +00:00
Nick Mathewson
4ccffd7aea
r18218@catbus: nickm | 2008-02-19 17:27:40 -0500
...
When SafeLogging is off, have TLS errors and messages logged with their associated addresses.
svn:r13591
2008-02-19 22:27:44 +00:00
Roger Dingledine
810bfe970c
make explicit that we don't care if a rename() call fails.
...
potential bug reported by veracode.
svn:r13590
2008-02-19 22:25:20 +00:00
Roger Dingledine
23e4c849c9
resolve another edge case in staying dormant
...
svn:r13586
2008-02-19 22:01:45 +00:00
Roger Dingledine
da7f0315e6
maybe it should compile too.
...
svn:r13585
2008-02-19 21:41:43 +00:00
Roger Dingledine
d964beac16
If we only ever used Tor for hidden service lookups or posts, we
...
would stop building circuits and start refusing connections after
24 hours, since we false believed that Tor was dormant. Reported
by nwf; bugfix on 0.1.2.x.
svn:r13583
2008-02-19 21:30:24 +00:00
Roger Dingledine
33c754315b
clear up another connlimit lie
...
svn:r13582
2008-02-19 21:08:27 +00:00
Nick Mathewson
b98c437fcc
r18195@catbus: nickm | 2008-02-19 14:11:15 -0500
...
TOR_PERF has not not been a sane thing for ages. Remove it.
svn:r13579
2008-02-19 19:30:37 +00:00
Roger Dingledine
be8a85dc1c
document that if you enable TOR_PERF, you won't be compatible with the
...
main Tor network.
svn:r13577
2008-02-19 18:54:44 +00:00
Nick Mathewson
8c6b5d6640
r14246@tombo: nickm | 2008-02-17 19:33:02 -0500
...
Fix a wide line in control.c; make the check-spaces target ignore the openbsd malloc file.
svn:r13566
2008-02-19 05:08:27 +00:00
Nick Mathewson
3277e2a8ca
r18142@catbus: nickm | 2008-02-18 14:24:31 -0500
...
Our preferred spelling for a bitfield is "unsigned int", not "unsigned" or "uint8_t".
svn:r13560
2008-02-18 19:24:33 +00:00
Nick Mathewson
08f7842384
r18139@catbus: nickm | 2008-02-18 13:14:05 -0500
...
Clarify logic in trusted_dirs_load_certs_from_string(); avoid a maybe-impossible maybe-not double-free spotted by lodger.
svn:r13558
2008-02-18 18:14:34 +00:00
Nick Mathewson
9e9b447b87
r14243@tombo: nickm | 2008-02-17 14:51:26 -0500
...
Better debugging to track down bug 606. Also remove a break; that may have been the possible culprit
svn:r13547
2008-02-17 19:51:33 +00:00
Nick Mathewson
faa56a500b
r14236@tombo: nickm | 2008-02-17 13:44:55 -0500
...
Partial fix for bug 586: Add an ephemeral __HashedControlSessionPassword.
svn:r13543
2008-02-17 18:45:07 +00:00
Roger Dingledine
4c1e516a09
cleanups and changelog entry for r13540
...
svn:r13542
2008-02-17 16:52:24 +00:00
Roger Dingledine
bd959adcb7
patch from karsten:
...
Resolved problems with (re-)fetching hidden service descriptors.
Before, v0 descriptors were not fetched at all (fix on 0.2.0.18-alpha),
re-fetching of v2 descriptors did not stop when a v0 descriptor was
received (fix on 0.2.0.18-alpha), and re-fetching of v2 descriptors did
not work in all cases (fix on 0.2.0.19-alpha).
svn:r13540
2008-02-17 16:47:47 +00:00
Nick Mathewson
6366dcd8ee
r14186@tombo: nickm | 2008-02-15 18:38:52 -0500
...
Add an XXXX021 item so we eventually stop calling setuid() and setgid() unnecessarily.
svn:r13533
2008-02-15 23:39:17 +00:00
Nick Mathewson
24e8e1fb36
r14185@tombo: nickm | 2008-02-15 18:05:54 -0500
...
Replace the hefty tor_strpartition with a simple function to replace its only (trivial) use.
svn:r13532
2008-02-15 23:39:14 +00:00
Nick Mathewson
f5ed1f8469
r14183@tombo: nickm | 2008-02-15 17:37:53 -0500
...
Add initial unit tests for test_addr_compare_masked
svn:r13531
2008-02-15 23:39:10 +00:00
Nick Mathewson
ca4eb987c8
r14182@tombo: nickm | 2008-02-15 17:20:51 -0500
...
Defer, downgrade, or address more XXX020s. The remaining ones are all ones we should deal with before release.
svn:r13530
2008-02-15 23:39:08 +00:00
Nick Mathewson
418c2e1b6b
r14181@tombo: nickm | 2008-02-15 16:48:17 -0500
...
Fix all but 2 DOCDOC items; defer many XXX020s (particularly those where fixing them would fix no bugs at the risk of introducing some bugs).
svn:r13529
2008-02-15 23:39:04 +00:00
Nick Mathewson
ff64e78b20
r14170@tombo: nickm | 2008-02-15 11:50:38 -0500
...
Fix or downgrade a bunch of xxx020 items.
svn:r13527
2008-02-15 19:20:53 +00:00
Nick Mathewson
275bb57a77
r18068@catbus: nickm | 2008-02-13 11:33:19 -0500
...
Patch from karsten: make hidden service code respect SafeLogging.
svn:r13493
2008-02-13 16:34:00 +00:00
Nick Mathewson
d48f6425e5
r18066@catbus: nickm | 2008-02-13 11:22:19 -0500
...
Bugfix from Karsten: "Reversed r13439; v2 rendezvous descriptors were only re-fetched when a directory connection did not finish, not when a directory correctly replied with an error code like 404; bug found by nwf.
svn:r13492
2008-02-13 16:23:28 +00:00
Nick Mathewson
7ae3f6a491
r18056@catbus: nickm | 2008-02-12 17:21:10 -0500
...
Add roger's responses from IRC to some XXX020 items.
svn:r13487
2008-02-12 22:21:20 +00:00
Roger Dingledine
3abafccd0e
Start choosing which bridge to use proportional to its advertised
...
bandwidth, rather than uniformly at random. This should speed up Tor
for bridge users. Also do this for people who set StrictEntryNodes.
svn:r13486
2008-02-12 22:02:47 +00:00
Nick Mathewson
f3eaeb99a3
r18051@catbus: nickm | 2008-02-12 15:20:43 -0500
...
Re-tune mempool parametes based on testing on peacetime: use smaller chuncks, free them a little more aggressively, and try very hard to concentrate allocations on fuller chunks. Also, lots of new documentation.
svn:r13484
2008-02-12 20:20:52 +00:00
Nick Mathewson
aace52320c
r18041@catbus: nickm | 2008-02-11 23:43:18 -0500
...
Make version negotiation and handshaking messages more useful and accurate.
svn:r13477
2008-02-12 04:43:25 +00:00
Nick Mathewson
8682293388
r18029@catbus: nickm | 2008-02-11 12:36:39 -0500
...
Fix command.c compilation with gcc 4.2 warnings enabled.
svn:r13475
2008-02-12 04:37:00 +00:00
Roger Dingledine
a89e523f19
note a simplification for the future
...
svn:r13466
2008-02-11 06:34:10 +00:00
Roger Dingledine
28483467d0
Directory mirrors no longer include a guess at the client's IP
...
address if the connection appears to be coming from the same /24
network; it was producing too many wrong guesses.
svn:r13464
2008-02-11 05:31:56 +00:00
Nick Mathewson
65ee9dc585
r14108@tombo: nickm | 2008-02-10 20:09:10 -0500
...
add some documentation
svn:r13462
2008-02-11 01:09:24 +00:00
Nick Mathewson
ab0c85eea6
r14103@tombo: nickm | 2008-02-10 13:40:09 -0500
...
Fix some XXX020s in command.c, and make it not-allowed to negotiate v1 using the v2 connection protocol: it is too hard to test, and pointless to support.
svn:r13460
2008-02-10 18:40:29 +00:00
Nick Mathewson
b5c03f05d8
r14102@tombo: nickm | 2008-02-10 13:30:04 -0500
...
Remove some deadcode.
svn:r13459
2008-02-10 18:40:27 +00:00
Nick Mathewson
a4db22f675
r14101@tombo: nickm | 2008-02-10 13:24:27 -0500
...
Merge connection_or_act_on_netinfo into command.c; remove some fields from or_handshake_state().
svn:r13458
2008-02-10 18:40:23 +00:00
Roger Dingledine
5a0f214908
patch from tup to fix bug 605
...
svn:r13453
2008-02-09 22:52:29 +00:00
Roger Dingledine
d2528e6b48
"fix" the unit tests on openbsd/netbsd
...
svn:r13450
2008-02-09 21:41:49 +00:00
Roger Dingledine
965afb4970
cleanups on r13442.
...
oh, and this should be backported too.
svn:r13444
2008-02-09 10:46:22 +00:00
Roger Dingledine
b42c9d69f0
Patch from "Andrew S. Lists" to catch when we contact a directory mirror
...
at IP address X and he says we look like we're coming from IP address X.
svn:r13442
2008-02-09 10:36:49 +00:00
Roger Dingledine
509d2912dc
doxygen and other cleanups
...
svn:r13440
2008-02-09 03:11:10 +00:00
Nick Mathewson
be1e577d5e
Re-fetch v2 rendezvous descriptor only when first try failed. Patch from karsten.
...
svn:r13439
2008-02-09 02:51:20 +00:00
Roger Dingledine
1f034cc5c7
note a question for nick
...
svn:r13437
2008-02-09 02:34:00 +00:00
Nick Mathewson
8f7fcdd64e
r17991@catbus: nickm | 2008-02-08 18:41:26 -0500
...
More protocol negotiation work. Make the negotiation actually complete and set the state to open. Fix a crash bug that occured when we forcibly stopped the connection from writing.
svn:r13434
2008-02-08 23:41:29 +00:00
Nick Mathewson
272d37deb3
r17989@catbus: nickm | 2008-02-08 18:09:23 -0500
...
Fix a new segfault when poisoning a non-present socks request.
svn:r13433
2008-02-08 23:09:26 +00:00
Nick Mathewson
a378bb5f5a
r17985@catbus: nickm | 2008-02-08 16:30:02 -0500
...
Bugfix from Karsten Loesing: Retry v2 rend descriptors on intro point failure.
svn:r13431
2008-02-08 21:30:07 +00:00