Nick Mathewson
e57f26c135
Have correct_tm set tm_wday as well.
...
The tm_wday field had been left uninitialized, which was causing
some assertions to fail on Windows unit tests.
Fixes bug 18977.
2016-05-12 14:37:27 -04:00
Nick Mathewson
6bc052365a
Use a much less clever scan_signed no-overflow hack
2016-05-12 14:33:26 -04:00
Nick Mathewson
a7207329a8
Run tor_sscanf test in subprocess, in hopes of coaxing more info from jenkins
2016-05-12 13:37:05 -04:00
Nick Mathewson
445e05a015
Fix inconsistent tab/space mixing in include.am files.
...
This is a whitespace only, cosmetic fix.
There is still some inconsistency between lists, but less
inconsistency inside individual lists.
2016-05-12 13:06:58 -04:00
Nick Mathewson
607a9056d4
Merge branch 'ftrapv_v3'
...
There were some conflicts here, and some breakage to fix concerning
library link order in newer targets.
2016-05-12 13:00:45 -04:00
Nick Mathewson
fb999abea6
Document why we build memwipe that way.
2016-05-12 12:56:47 -04:00
Nick Mathewson
a3615a988e
Prefer builtin true.
2016-05-12 12:54:15 -04:00
Nick Mathewson
b1dce55b82
Do not apply bugtrapping flags to test-memwipe, since testing memwipe requires bugs.
...
Fixes bug 18901.
2016-05-12 11:22:10 -04:00
Nick Mathewson
ef01109932
Rename SOURCES to SRC for things in include.am
2016-05-12 11:21:28 -04:00
Nick Mathewson
e40cfc4425
Move the ctime part of choose_array_element_by_weight into di_ops
...
This way it gets the ctime options.
2016-05-12 11:21:28 -04:00
Nick Mathewson
20432fc541
Refactor out u64_dbl_t
...
This type saved a tiny amount of allocation, but not enough to be
worth keeping.
(This is in preparation for moving choose_array_element_by_weight)
2016-05-12 11:21:28 -04:00
Nick Mathewson
ce854a8d22
Add -ftrapv to gcc-hardening ... mostly!
...
We know there are overflows in curve25519-donna-c32, so we'll have
to have that one be fwrapv.
Only apply the asan, ubsan, and trapv options to the code that does
not need to run in constant time. Those options introduce branches
to the code they instrument.
(These introduced branches should never actually be taken, so it
might _still_ be constant time after all, but branch predictors are
complicated enough that I'm not really confident here. Let's aim for
safety.)
Closes 17983.
2016-05-12 11:21:28 -04:00
Nick Mathewson
58e0e587a6
Merge branch 'maint-0.2.8'
2016-05-12 11:09:40 -04:00
Nick Mathewson
ce6f2d1c4d
Merge remote-tracking branch 'arma/bug19003-try2' into maint-0.2.8
2016-05-12 11:09:33 -04:00
Nick Mathewson
f936f186b2
Use tor_queue.h, not sys/queue.h, in timeouts.[ch].
...
Closes 19041.
2016-05-12 10:10:59 -04:00
Nick Mathewson
6294eb2846
Merge branch 'maint-0.2.8'
2016-05-12 10:03:26 -04:00
Nick Mathewson
d00d3f1c28
Merge remote-tracking branch 'arma/bug17621-try2' into maint-0.2.8
2016-05-12 10:03:00 -04:00
Nick Mathewson
99c0e1bd5b
Fix bad allocation in pubsub.c
...
Closes 19038. Bug not in any released Tor.
2016-05-12 09:56:42 -04:00
Roger Dingledine
5a83122961
Authorities now sort the "package" lines in their votes
...
(They are already sorted in the consensus documents)
Fixes bug 18840; bugfix on 0.2.6.3-alpha.
2016-05-11 19:04:13 -04:00
Roger Dingledine
694f1fe808
write v3-status-votes file earlier in consensus voting
...
Make directory authorities write the v3-status-votes file out
to disk earlier in the consensus process, so we have the votes
even if we abort the consensus process later on.
Resolves ticket 19036.
2016-05-11 17:34:38 -04:00
Roger Dingledine
4a62d7aabc
minor touchups on nick's ticket 17621 changes
2016-05-11 16:35:36 -04:00
Roger Dingledine
9e44273a4a
fix 'make dist' which was broken by ticket 18365's merge
2016-05-11 16:15:37 -04:00
Nick Mathewson
e3a4511049
Merge remote-tracking branch 'public/bug18815'
2016-05-11 14:12:39 -04:00
Nick Mathewson
af4b7d0405
Document the contents of $datadir/keys
...
Ticket 17621.
2016-05-11 14:03:34 -04:00
Nick Mathewson
48b7db3559
Add changes file for ticket 16698
2016-05-11 13:43:28 -04:00
Roger Dingledine
ad8b9dcd47
Merge branch 'maint-0.2.8'
2016-05-11 13:43:06 -04:00
Roger Dingledine
163cee1b64
Merge branch 'maint-0.2.7' into maint-0.2.8
2016-05-11 13:42:40 -04:00
Roger Dingledine
d40e8695f4
unbreak the build (when warnings are enabled)
2016-05-11 13:42:00 -04:00
Nick Mathewson
60e9e48448
Merge branch 'ticket16698_v2'
2016-05-11 13:39:38 -04:00
Nick Mathewson
03ae44a9e8
Fix comment for directory_handle_command_get
2016-05-11 13:39:11 -04:00
teor (Tim Wilson-Brown)
cdb528d841
Fetch certificates from the same directory as previous certificates
...
Improves the fix to #18963 .
2016-05-11 13:30:30 -04:00
teor (Tim Wilson-Brown)
730cfeb6bd
Fetch certificates from the same directory as the consensus
...
Resolves ticket 18963; fix on #4483 in 0.2.8.1-alpha.
2016-05-11 13:30:08 -04:00
Nick Mathewson
00ee62b8a5
Merge branch 'pubsub_squashed'
2016-05-11 13:26:29 -04:00
Nick Mathewson
80a6c8caa3
Basic work on a publish/subscribe abstraction
...
The goal here is to provide a way to decouple pieces of the code
that want to learn "when something happens" from those that realize
that it has happened.
The implementation here consists of a generic backend, plus a set of
macros to define and implement a set of type-safe frontends.
2016-05-11 13:25:11 -04:00
Nick Mathewson
3c6f059e6a
Merge remote-tracking branch 'arma/feature18760'
2016-05-11 13:22:31 -04:00
Nick Mathewson
e9e6a1f547
Merge branch 'maint-0.2.8'
2016-05-11 13:20:57 -04:00
Nick Mathewson
8d962233f6
Merge remote-tracking branch 'teor/bug18816_simplify' into maint-0.2.8
2016-05-11 13:20:51 -04:00
Nick Mathewson
022d32252a
Merge branch 'maint-0.2.8'
2016-05-11 13:17:02 -04:00
Nick Mathewson
24fbb9a81b
Merge branch 'maint-0.2.7' into maint-0.2.8
2016-05-11 13:15:17 -04:00
Nick Mathewson
4e94580591
Merge remote-tracking branch 'special/bug19032-027' into maint-0.2.7
2016-05-11 13:13:23 -04:00
John Brooks
bf3e32a452
Fix out-of-bounds write during voting with duplicate ed25519 keys
...
In dirserv_compute_performance_thresholds, we allocate arrays based
on the length of 'routers', a list of routerinfo_t, but loop over
the nodelist. The 'routers' list may be shorter when relays were
filtered by routers_make_ed_keys_unique, leading to an out-of-bounds
write on directory authorities.
This bug was originally introduced in 26e89742
, but it doesn't look
possible to trigger until routers_make_ed_keys_unique was introduced
in 13a31e72
.
Fixes bug 19032; bugfix on tor 0.2.8.2-alpha.
2016-05-11 13:11:03 -04:00
teor (Tim Wilson-Brown)
797ece042d
Confim we want certificates from fallbacks
...
Comment-only change
2016-05-11 13:08:45 -04:00
teor (Tim Wilson-Brown)
2cbad2aac7
Revert "Switch between fallback and authority when auth cert fetch fails"
...
This reverts commit 92d7ee08b8
.
2016-05-11 13:06:13 -04:00
Roger Dingledine
b8b5bccfd9
refactor the #19003 patches
...
fix the logic in one of the comments
2016-05-11 13:03:49 -04:00
Nick Mathewson
71267bef4c
Merge branch 'maint-0.2.8'
2016-05-11 12:36:55 -04:00
Nick Mathewson
28e1aa1118
Merge branch 'bug18761_028_squashed' into maint-0.2.8
2016-05-11 12:36:27 -04:00
Nick Mathewson
b59d79134e
Log find_rp_for_intro_() failures at LOG_PROTOCOL_WARN.
...
Closes ticket 18761.
Also fix a whitespace issue.
2016-05-11 12:36:19 -04:00
Nick Mathewson
79f9e63ebf
Merge branch 'maint-0.2.8'
2016-05-11 12:30:18 -04:00
Nick Mathewson
e71dfb6344
Merge remote-tracking branch 'teor/bug18816-squashed' into maint-0.2.8
2016-05-11 12:28:37 -04:00
Nick Mathewson
e31980f693
Merge branch 'maint-0.2.8'
2016-05-11 12:23:40 -04:00