teor
2b73dbf2a4
Always initialise return value in compute_desc_id in rendcommon.c
...
Fix on e6a581f126
, released in 0.2.7.1-alpha.
2015-06-03 04:19:05 +10:00
teor
b3f79da0d5
Silence unused variable warnings in find_cipher_by_id
...
Unused variable warnings were still generated under some versions of OpenSSL.
Instead, make sure all variables are used under all versions.
Fix on 496df21c89
, not in any released version of tor.
2015-06-03 04:19:05 +10:00
teor
b1094fdec5
Fix an incorrect comment on spawn_func
...
spawn_func calls pthread_create on unix, not fork
Fix on existing code split out of compat.c into
compat_pthreads.c in c2f0d52b7f
2015-06-03 04:18:43 +10:00
Nick Mathewson
0030765e04
Merge remote-tracking branch 'public/bug15760_hard_026_v2'
...
Conflicts:
src/common/tortls.c
2015-06-02 13:45:27 -04:00
Nick Mathewson
ff835e2328
Use autoconf, not OPENSSL_VERSION_NUMBER, to detect SSL_CIPHER_find
...
Repairs build with libressl
2015-06-02 13:38:27 -04:00
Nick Mathewson
f90a704f12
Use accessor functions for client_random/server_random/master_key
...
If OpenSSL accepts my patch to introduce these functions, they'll
be a way to help Tor work with OpenSSL 1.1.
2015-06-02 13:38:27 -04:00
Nick Mathewson
3d653dff5e
Add a master-key-ed25519 line for convenience
2015-06-01 11:24:55 -04:00
Nick Mathewson
3028507e96
More check-spaces fixes
2015-06-01 10:56:54 -04:00
Nick Mathewson
fcc01d7caf
Fix a memory leak in routerkeys.c
2015-06-01 10:45:51 -04:00
Nick Mathewson
d31877c6bf
Fix some memory leaks in ed25519 code and tests
2015-06-01 10:26:11 -04:00
Andrea Shepard
0e0b65db4f
Appease make check-spaces
2015-06-01 12:59:14 +00:00
Sharif Olorin
90e07ab338
Fix return-type gcc warning
...
find_dl_schedule_and_len caused gcc to spit up with -Werror.
Signed-off-by: Sharif Olorin <sio@tesser.org>
2015-05-30 06:03:50 +00:00
Nick Mathewson
12a2321501
Another memory leak bytes the dust.
2015-05-29 16:17:54 -04:00
Nick Mathewson
a6e3db5f72
Attempt to fix keypinning on Windows
...
Not that I would countenance a directory authority on Windows, but
it would be nice if the unit tests passed.
2015-05-29 14:38:59 -04:00
Nick Mathewson
ba17968534
Fix another int-to-ptr cast.
2015-05-29 14:09:11 -04:00
Nick Mathewson
10dd50dfcb
Fix a warning from the clangalyzer.
2015-05-29 14:08:51 -04:00
Nick Mathewson
27bc0da14d
Fix a sizeof(ptr) mistake in test-memwipe.c
2015-05-29 13:50:12 -04:00
Nick Mathewson
e71c8801cf
more generic scan-build script
2015-05-29 13:50:05 -04:00
Nick Mathewson
b66f4cfc9d
Merge remote-tracking branch 'origin/maint-0.2.6'
2015-05-28 14:06:01 -04:00
Nick Mathewson
97330ced0c
Fix sandbox use with systemd. bug 16212.
2015-05-28 14:05:46 -04:00
Nick Mathewson
5dce1829bf
Avoid double-free on rend_add_service() failure
...
Rend_add_service() frees its argument on failure; no need to free again.
Fixes bug 16228, bugfix on 0.2.7.1-alpha
Found by coverity; this is CID 1301387.
2015-05-28 13:23:09 -04:00
Nick Mathewson
97a2dbb3e3
There sure are a lot of these in test_hs.c. CID 1301385
2015-05-28 13:17:24 -04:00
Nick Mathewson
49c31877b6
Fix a bug in earlier torcert fix, fix another.
2015-05-28 13:14:30 -04:00
Nick Mathewson
9f289e3b9e
Another test_hs leak. CID 1301383.
2015-05-28 13:13:15 -04:00
Nick Mathewson
83ad7d2fbb
Memory leak in tor_cert_parse. CID 1301382.
2015-05-28 13:11:54 -04:00
Nick Mathewson
3df6f8591d
Memory leak in tor_cert_parse. CID gi1301381
2015-05-28 13:09:00 -04:00
Nick Mathewson
3262f3c3f6
Fix leak-on-test-failure in test_routerkeys.c
...
CID 1301379
2015-05-28 13:06:30 -04:00
Nick Mathewson
0585d4e94b
Memory leak in test_hs_rend_data
...
CID 1301377
2015-05-28 13:01:48 -04:00
Nick Mathewson
72714270e2
Fix memory leak in test_routerkeys
...
CID 1301376
2015-05-28 13:00:25 -04:00
Nick Mathewson
2c32b2848a
Small leak in ed_key_init_from_file. CID 1301373
2015-05-28 12:52:34 -04:00
Nick Mathewson
5f15b0e1e2
Memory leak on error in connection_or_compute_auth_cell_body. CID 1301372
2015-05-28 12:51:20 -04:00
Nick Mathewson
b76815d110
fix memory leak on bad ns convote. CID 1301371.
2015-05-28 12:49:39 -04:00
Nick Mathewson
a85d58af62
Fix memory leak on failure to generate EI. CID 1301370.
2015-05-28 12:47:31 -04:00
Nick Mathewson
24a2bb08ab
Fix null dereference on key setup error.
...
CID 1301369
2015-05-28 12:46:06 -04:00
Nick Mathewson
e045c3e1e8
Update trunnel code.
...
This gets the minor change in trunnel 1.4.1, which should avoid
deadcode warnings from Coverity.
2015-05-28 12:44:52 -04:00
Nick Mathewson
a348df6d8b
Avoid dereferencing null on unit test failure for link handshakes.
...
This fixes CID 1301368 -- found by coverity
2015-05-28 12:41:00 -04:00
Nick Mathewson
c03694938e
Fix a bug when we fail to read a cert from a file.
...
Found by coverity -- CID 1301366.
2015-05-28 12:30:25 -04:00
Nick Mathewson
7816ba8f1a
Add assertions to crypto_dh_dup()
...
Without these, coverity is annoyed that aren't checking for NULL in bench.c
CID 1293335 -- found by coverity.
2015-05-28 12:27:22 -04:00
Nick Mathewson
a194385d56
Impose an upper limit on threads per threadpool.
...
Found by Coverity; Fixes CID 1268069
2015-05-28 12:24:29 -04:00
Nick Mathewson
4a9f41e1ec
Bug 12498 needs a changes file.
2015-05-28 11:40:20 -04:00
Nick Mathewson
1b52e95028
Merge branch '12498_ed25519_keys_v6'
...
Fixed numerous conflicts, and ported code to use new base64 api.
2015-05-28 11:04:33 -04:00
Nick Mathewson
5eb584e2e9
Document some ed25519 key options
2015-05-28 10:47:47 -04:00
Nick Mathewson
277c9a3580
Note some functions that should move or be merged
2015-05-28 10:47:47 -04:00
Nick Mathewson
8f15423b76
Do not allocate our ed-link crosscert till after tls ctx
...
We need this to prevent some annoying chutney crash-at-starts
2015-05-28 10:47:47 -04:00
Nick Mathewson
3bee74c6d1
Generate weird certificates correctly
...
(Our link protocol assumes that the link cert certifies the TLS key,
and there is an RSA->Ed25519 crosscert)
2015-05-28 10:47:47 -04:00
Nick Mathewson
32f59d7337
Regenerate ed25519 keys when they will expire soon.
...
Also, have testing-level options to set the lifetimes and
expiration-tolerances of all key types, plus a non-testing-level
option to set the lifetime of any auto-generated signing key.
2015-05-28 10:44:09 -04:00
Nick Mathewson
57189acd6f
# This is a combination of 2 commits.
...
# The first commit's message is:
Regenerate ed25519 keys when they will expire soon.
Also, have testing-level options to set the lifetimes and
expiration-tolerances of all key types, plus a non-testing-level
option to set the lifetime of any auto-generated signing key.
# The 2nd commit message will be skipped:
# fixup! Regenerate ed25519 keys when they will expire soon.
2015-05-28 10:42:30 -04:00
Nick Mathewson
64450c5f77
Only load master ed25519 secret keys when we absolutely must.
2015-05-28 10:42:29 -04:00
Nick Mathewson
d4a6b1a420
Implement ed25519 identity collation for voting.
...
This is a new collator type that follows proposal 220 for deciding
which identities to include. The rule is (approximately):
If a <ed,rsa> identity is listed by more than half of authorities,
include it. And include all <rsa> votes about that node as
matching.
Otherwise, if an <*,rsa> or <rsa> identity is listed by more than
half of the authorities, and no <ed,rsa> has been listed, include
it.
2015-05-28 10:42:29 -04:00
Nick Mathewson
6c564e6c08
Refactor code that matches up routers with the same identity in votes
...
This makes 'routerstatus collation' into a first-class concept, so
we can change how that works for prop220.
2015-05-28 10:42:29 -04:00