713 Commits

Author	SHA1	Message	Date
Nick Mathewson	1cda6f3e75	Merge commit 'origin/maint-0.2.1'	2009-09-01 15:59:40 -04:00
Sebastian Hahn	742788b737	typo	2009-09-01 21:58:06 +02:00
Sebastian Hahn	aea9cf1011	Fix compile warnings on Snow Leopard ... Big thanks to nickm and arma for helping me with this!	2009-09-01 18:36:27 +02:00
Nick Mathewson	00b37f071d	Revise parsing of time and memory units to handle spaces. ... When we added support for fractional units (like 1.5 MB) I broke support for giving units with no space (like 2MB). This patch should fix that. It also adds a propoer tor_parse_double(). Fix for bug 1076. Bugfix on 0.2.2.1-alpha.	2009-08-31 00:18:55 -04:00
Karsten Loesing	7b716878cb	Fix dirreq and cell stats on 32-bit architectures. ... When determining how long directory requests take or how long cells spend in queues, we were comparing timestamps on microsecond detail only to convert results to second or millisecond detail later on. But on 32-bit architectures this means that 2^31 microseconds only cover time differences of up to 36 minutes. Instead, compare timestamps on millisecond detail.	2009-07-27 16:23:53 +02:00
Karsten Loesing	8f1a973669	Two tweaks to exit-port statistics. ... Add two functions for round_to_next_multiple_of() for uint32_t and uint64_t. Avoid division in every step of the loop over all ports.	2009-07-13 22:43:06 +02:00
Nick Mathewson	fd992deeea	Don't attempt to log messages to a controller from a worker thread. ... This patch adds a function to determine whether we're in the main thread, and changes control_event_logmsg() to return immediately if we're in a subthread. This is necessary because otherwise we will call connection_write_to_buf, which modifies non-locked data structures. Bugfix on 0.2.0.x; fix for at least one of the things currently called "bug 977".	2009-05-30 18:16:24 -04:00
Nick Mathewson	f0453c45c8	Spelling fixes in comments and strings	2009-05-27 16:36:13 -04:00
Nick Mathewson	11b9c839f0	Stop using malloc_usable_size(): valgrind hates it.	2009-05-17 01:55:02 -04:00
Karsten Loesing	9b32e8c141	Update copyright to 2009.	2009-05-04 11:28:27 -04:00
Nick Mathewson	cbbc0c9c86	Actually use tor_sscanf() to parse untrusted input. ... svn:r18761	2009-03-03 18:02:36 +00:00
Nick Mathewson	26d83fc04c	Add a simple locale-independent no-surprises sscanf replacement. ... tor_sscanf() only handles %u and %s for now, which will make it adequate to replace sscanf() for date/time/IP parsing. We want this to prevent attackers from constructing weirdly formed descriptors, cells, addresses, HTTP responses, etc, that validate under some locales but not others. svn:r18760	2009-03-03 18:02:31 +00:00
Nick Mathewson	25c6ff6f55	Support 64-bit time_t. Patch from Matthias Drochner. Partial backport candidate. ... svn:r18234	2009-01-22 16:28:12 +00:00
Nick Mathewson	a87980c2eb	Add a better (non-locale-having) ctypes implementation to avoid protocol and parsing mismatches on different platforms. ... svn:r18189	2009-01-20 21:33:56 +00:00
Nick Mathewson	743c6c8277	OpenBSD malloc.h believes that you should be able to detect headers with autoconf, or build without warnings, but not both. So never include malloc.h on OpenBSD. Backport candidate. ... svn:r17891	2009-01-04 22:47:42 +00:00
Nick Mathewson	c4b8fef362	Remove svn $Id$s from our source, and remove tor --version --version. ... The subversion $Id$ fields made every commit force a rebuild of whatever file got committed. They were not actually useful for telling the version of Tor files in the wild. svn:r17867	2009-01-04 00:35:51 +00:00
Nick Mathewson	558e9899e4	Document most undocumented variables. ... svn:r17754	2008-12-23 17:56:31 +00:00
Nick Mathewson	b4d387c28b	Make freelist_len in memarea.c static; document a few variables. ... svn:r17741	2008-12-22 19:14:08 +00:00
Nick Mathewson	b68379b13b	Add DOCDOC entries for undocumented static and global variables. ... svn:r17739	2008-12-22 19:00:05 +00:00
Nick Mathewson	1e5f457461	Fix most DOCDOCs remaining and/or added by redox. ... svn:r17734	2008-12-22 17:53:04 +00:00
Nick Mathewson	1725c0c8a5	Add DOCDOC comments for all undocumented functions. Add missing *s to other comments so that they will get recognized as doxygen. ... svn:r17729	2008-12-22 14:56:28 +00:00
Nick Mathewson	55348884b5	Fix all of the doxygen warnings not pertaining to missing documentation. ... svn:r17727	2008-12-22 14:56:16 +00:00
Nick Mathewson	efb863189c	Expose hex_decode_digit from util.c ... svn:r17706	2008-12-19 18:51:52 +00:00
Nick Mathewson	bf80e2df3f	Replace calls to time(NULL) that occur on the order of once per read, one per write, or once per cell with calls to a function that looks at a cached value of time. This is tricksy to benchmark, since it will only help on systems where time() is a syscall and syscalls are relatively slow. ... svn:r17690	2008-12-18 17:19:04 +00:00
Nick Mathewson	122170c1d3	Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this patch. ... svn:r17686	2008-12-18 16:11:24 +00:00
Nick Mathewson	8d5a9d762c	Log an error on win32 if directory listing fails. ... svn:r17684	2008-12-18 16:11:12 +00:00
Nick Mathewson	37bd9181f0	Do not use O_APPEND on fd-based operations that do not really want it; have them just lseek instead. ... svn:r17460	2008-12-02 23:49:40 +00:00
Nick Mathewson	35bef7fefd	make read_all and write_all return ssize_t. ... svn:r17194	2008-11-05 19:29:17 +00:00
Nick Mathewson	b56d1545db	Fix freebsd 7 compile by adding malloc_np.h header. Fix bug 850. ... svn:r17190	2008-11-05 15:56:53 +00:00
Nick Mathewson	3f84ed3d46	Add a new memcmpstart to use instead of strcmpstart when the thing we are comparing is not nul-terminated. ... svn:r17187	2008-11-03 16:35:48 +00:00
Nick Mathewson	0ab45fee73	Document some dmalloc stuff and some stupid C tricks. ... svn:r17161	2008-10-27 16:30:52 +00:00
Jacob Appelbaum	7873d324df	This patch changes some of the code in util.c to refactor calls to ... dmalloc_malloc, dmalloc_realloc and dmalloc_strdup. It only calls those functions if we're using the magic USE_DMALLOC macro. If we're not doing that, we call the normal malloc, realloc and strdup. This is my first night at malloc disambiguation club, so I had to disambiguate. Also, first commit, I have my commit bit now. Huzzzah!!! svn:r17157	2008-10-26 22:56:53 +00:00
Roger Dingledine	4eab76f074	remove a code path that should never happen (and if it did, we'd be ... complaining about an errno set from some arbitrary previous problem). svn:r16684	2008-08-29 09:06:18 +00:00
Nick Mathewson	9da0482007	r17358@pc-10-8-1-079: nickm | 2008-07-25 16:41:03 +0200 ... Split out the address manipulation functions from compat and util: they were about 21% of the total of those, and spread out too much. svn:r16208	2008-07-25 14:43:24 +00:00
Nick Mathewson	3ce6e2fba2	r17346@aud-055: nickm | 2008-07-24 15:37:19 +0200 ... Make generic address manipulation functions work better. Switch address policy code to use tor_addr_t, so it can handle IPv6. That is a good place to start. svn:r16178	2008-07-24 13:44:04 +00:00
Nick Mathewson	9d7a2d4eae	r16689@tombo: nickm | 2008-07-03 11:03:14 -0400 ... Fix for bug 742: do not use O_CREAT on 2-option version of open(). Especially do not use it on /dev/null. Fix from Michael Scherer. Bugfix on 0.0.2pre19 (wow). svn:r15626	2008-07-03 15:04:16 +00:00
Nick Mathewson	d0a4ad3a1c	r16127@tombo: nickm | 2008-06-10 14:03:01 -0400 ... Improved code for counting clients by country: support recording by number of directory status requests in addition to number of IPs seen. svn:r15097	2008-06-10 18:08:56 +00:00
Nick Mathewson	ac330d9ba7	New code to implement proposal for local geoip stats. Only enabled with --enable-geoip-stats passed to configure. ... svn:r14802	2008-05-29 02:29:35 +00:00
Nick Mathewson	09cd8fa371	r19795@catbus: nickm | 2008-05-16 14:54:24 -0400 ... Rename tor_addr_t manipulation functions for a consistent style. svn:r14639	2008-05-16 19:19:49 +00:00
Nick Mathewson	cc7a8a63b1	r15120@tombo: nickm | 2008-04-08 18:01:58 -0400 ... Add very short 0.2.1.x list based on discussion from arma. needs fleshing out and merging with other lists. svn:r14324	2008-04-08 22:02:08 +00:00
Nick Mathewson	7dd78f1576	r18929@catbus: nickm | 2008-03-18 12:08:16 -0400 ... Detect errors from directory listing correctly on win32. Bug found by lodger. svn:r14102	2008-03-18 16:08:49 +00:00
Nick Mathewson	ea6f636e94	r18890@catbus: nickm | 2008-03-17 13:19:29 -0400 ... Clarify documentation for file_status a little svn:r14079	2008-03-17 17:21:09 +00:00
Nick Mathewson	2ed4b818cb	r18878@catbus: nickm | 2008-03-17 00:11:02 -0400 ... Clean up an overwide line. svn:r14072	2008-03-17 04:11:05 +00:00
Peter Palfrader	3a92e3f15f	I wonder what the DISGARD service is ... svn:r13999	2008-03-13 14:09:01 +00:00
Roger Dingledine	04efc74e18	be a little bit more helpful than "Error reading directory." ... make a note to try to be more helpful still. svn:r13776	2008-02-28 21:37:39 +00:00
Nick Mathewson	69300eb606	r14374@tombo: nickm | 2008-02-21 16:57:39 -0500 ... Fix all remaining shorten-64-to-32 errors in src/common. Some were genuine problems. Many were compatibility errors with libraries (openssl, zlib) that like predate size_t. Partial backport candidate. svn:r13665	2008-02-21 21:57:47 +00:00
Nick Mathewson	b375472d14	r14373@tombo: nickm | 2008-02-21 16:29:18 -0500 ... Apply warnings about implicit 64-to-32 conversions; some from Sebastian Hahn; some not. svn:r13664	2008-02-21 21:57:42 +00:00
Nick Mathewson	8b1789c71f	r18336@catbus: nickm | 2008-02-21 09:33:15 -0500 ... Patch from Sebastian Hahn: remove obsolete timeval manipulation functions. svn:r13653	2008-02-21 14:33:20 +00:00
Nick Mathewson	24e8e1fb36	r14185@tombo: nickm | 2008-02-15 18:05:54 -0500 ... Replace the hefty tor_strpartition with a simple function to replace its only (trivial) use. svn:r13532	2008-02-15 23:39:14 +00:00
Roger Dingledine	509d2912dc	doxygen and other cleanups ... svn:r13440	2008-02-09 03:11:10 +00:00
Nick Mathewson	729555e1ca	r17967@catbus: nickm | 2008-02-07 11:44:51 -0500 ... Fix some warnings identified by building with -D_FORTIFY_SOURCE=2. Remove a redundant (and nuts) definition of _FORTIFY_SOURCE from eventdns.c. svn:r13424	2008-02-08 21:09:29 +00:00
Nick Mathewson	842a33ff20	Update some copyright notices: it is now 2008. ... svn:r13412	2008-02-07 05:31:47 +00:00
Nick Mathewson	a869574c56	r17947@catbus: nickm | 2008-02-06 11:57:53 -0500 ... Fix a bunch of DOCDOC items; document the --quiet flag; refactor a couple of XXXX020 items. svn:r13405	2008-02-06 16:58:05 +00:00
Nick Mathewson	a51deb9a9c	r17903@catbus: nickm | 2008-02-05 14:40:03 -0500 ... Remove some dead code; fix some XXX020s; turn some XXX020s into XXXX_IP6s (i.e., "needs to be fixed when we add ipv6 support"). svn:r13382	2008-02-05 19:40:26 +00:00
Nick Mathewson	b4ebe55d12	r13971@tombo: nickm | 2008-01-30 14:25:25 -0500 ... Write a new autoconf macro to test whether a function is declared. It is suboptimal and possibly buggy in some way, but it seems to work for me. use it to test for a declaration of malloc_good_size, so we can workaround operating systems (like older OSX) that have the function in their libc but do not deign to declare it in their headers. Should resolve bug 587. svn:r13339	2008-01-30 19:25:31 +00:00
Nick Mathewson	24aae484c9	r17624@catbus: nickm | 2008-01-15 00:42:01 -0500 ... Fixes to more anonymously-reported typos and logic errors. svn:r13136	2008-01-15 05:57:19 +00:00
Roger Dingledine	8ba1ba7d81	<tup> tor segfaults when reading a config value that contains a malformed ... escape sequence; this patch fixes it svn:r13086	2008-01-09 18:23:28 +00:00
Nick Mathewson	6d58d80e78	r17472@catbus: nickm | 2008-01-05 22:10:19 -0500 ... Another test for the increasingly bad check-spaces style checker to check: #else\n#if is almost a sure sign of a failure to use #elif. Fortunately, we only did that 3 times. svn:r13039	2008-01-06 03:16:08 +00:00
Nick Mathewson	614dc52623	r17467@catbus: nickm | 2008-01-05 19:54:20 -0500 ... fix whitespace svn:r13035	2008-01-06 00:54:22 +00:00
Nick Mathewson	58de695f90	r15787@tombo: nickm | 2008-01-02 01:59:07 -0500 ... Allow config values in quotes to contain special characters, with full C escape syntax. With tests. Addresses bug 557. svn:r13021	2008-01-02 06:59:15 +00:00
Nick Mathewson	86f5180853	r15786@tombo: nickm | 2008-01-02 01:11:51 -0500 ... Push the strdups used for parsing configuration lines into parse_line_from_string(). This will make it easier to parse more complex value formats, which in turn will help fix bug 557 svn:r13020	2008-01-02 06:59:12 +00:00
Nick Mathewson	11fff225fa	r15779@tombo: nickm | 2008-01-01 23:43:24 -0500 ... Use reference-counting to avoid allocating a zillion little addr_policy_t objects. (This is an old patch that had been sitting on my hard drive for a while.) svn:r13017	2008-01-02 04:43:44 +00:00
Nick Mathewson	c03ef9c395	r17423@catbus: nickm | 2007-12-28 01:54:42 -0500 ... Fix compilation with dmalloc svn:r12998	2007-12-28 06:54:46 +00:00
Nick Mathewson	0c8142e981	r15691@tombo: nickm | 2007-12-25 18:13:54 -0500 ... New, slightly esoteric function, tor_malloc_roundup(). While tor_malloc(x) allocates x bytes, tor_malloc_roundup(&x) allocates the same size of chunk it would use to store x bytes, and sets x to the usable size of that chunk. svn:r12981	2007-12-26 00:12:01 +00:00
Roger Dingledine	1d8a8063b9	clean up copyrights, and assign 2007 copyrights to The Tor Project, Inc ... svn:r12786	2007-12-12 21:09:01 +00:00
Nick Mathewson	593ab7e808	r15106@tombo: nickm | 2007-12-04 00:08:35 -0500 ... Change tor_addr_t to be a tagged union of in_addr and in6_addr, not of sockaddr_in and sockaddr_in6. It's hardly used in the main code as it is, but let's get it right before it gets popular. svn:r12660	2007-12-04 05:19:56 +00:00
Nick Mathewson	6fe70f4c69	r16879@catbus: nickm | 2007-11-30 14:07:05 -0500 ... Log *useful* information from dmalloc. (Unfreed pointers, not total of freed and unfreed). svn:r12616	2007-11-30 19:07:11 +00:00
Roger Dingledine	fa2c3a73e4	make dmalloc 5.4.2 work again too ... svn:r12615	2007-11-30 19:02:56 +00:00
Nick Mathewson	ac82d81538	r16874@catbus: nickm | 2007-11-30 13:11:09 -0500 ... When using dmalloc, dump the top ten memory consumers to the _DMALLOC_ logfile when we get a SIGUSR1. Hint: it is not what you would think. svn:r12613	2007-11-30 18:11:26 +00:00
Roger Dingledine	188cb920d0	cleanups while i was trying to figure out how it worked ... svn:r12612	2007-11-30 17:23:46 +00:00
Nick Mathewson	c0c2001a5b	r16279@catbus: nickm | 2007-10-30 11:14:29 -0400 ... Improved skew reporting: "You are 365 days in the duture" is more useful than "You are 525600 minutes in the future". Also, when we get something that proves we are at least an hour in the past, tell the controller "CLOCK_SKEW MIN_SKEW=-3600" rather than just "CLOCK_SKEW" svn:r12283	2007-10-30 15:17:07 +00:00
Nick Mathewson	99d72f7295	r16100@catbus: nickm | 2007-10-24 11:33:52 -0400 ... Make tor_mmap_file() set and preserve errno in a useful way. svn:r12153	2007-10-24 15:45:42 +00:00
Roger Dingledine	bab60e5ade	bugfix on r11301: ... Fix a minor memory leak whenever we wrote out a file. Bugfix on 0.2.0.7-alpha. svn:r11863	2007-10-11 03:10:52 +00:00
Roger Dingledine	900ddcb8fd	bugfix on r11298: ... Fix a minor memory leak whenever we parse guards from our state file. Bugfix on 0.2.0.7-alpha. svn:r11862	2007-10-11 02:03:53 +00:00
Nick Mathewson	6f7847b378	r15530@catbus: nickm | 2007-10-04 12:16:27 -0400 ... Add a bunch of function documentation; clean up a little code; fix some XXXXs; tag the nonsensical EXTRAINFO_PURPOSE_GENERAL as nonsesnse; note another bit of "do not cache special routers" code to nuke. svn:r11761	2007-10-04 16:21:58 +00:00
Nick Mathewson	565f5f32c5	r14363@Kushana: nickm | 2007-09-08 16:25:45 -0400 ... Another round of whitespeace fixes. svn:r11407	2007-09-08 20:25:57 +00:00
Nick Mathewson	509bc3b4a0	r14359@Kushana: nickm | 2007-09-08 15:07:17 -0400 ... Add some generic skew-and-tolerance functions so we can handle time more sanely. svn:r11406	2007-09-08 19:08:46 +00:00
Nick Mathewson	c341bc090e	r14869@catbus: nickm | 2007-08-31 08:49:26 -0400 ... Fix a segfault in expand_filename("~"). Found by lindi. svn:r11332	2007-08-31 12:51:52 +00:00
Nick Mathewson	f189ecbf20	r14832@catbus: nickm | 2007-08-29 15:00:27 -0400 ... Use (and debug) new file-writing functions in order to simplify code that formerly built big strings in RAM. svn:r11301	2007-08-29 19:02:43 +00:00
Nick Mathewson	8408122222	r14831@catbus: nickm | 2007-08-29 14:17:42 -0400 ... Refactor write_chunks_to_file_impl: break out the "pick a temporary name if it makes sense, and open the right filename" logic and the "close the file and unlink or rename if necessary" logic. This will let us write big files in a smarter way than "Build a big string" or "make a list of chunks", once we get around to using it. svn:r11300	2007-08-29 19:02:37 +00:00
Nick Mathewson	d3224bad42	r14227@Kushana: nickm | 2007-08-27 11:33:28 -0400 ... Add a new ClientDNSRejectInternalAddresses option (default: on) to refuse to believe that any address can map to or from an internal address. This blocks some kinds of potential browser-based attacks, especially on hosts using DNSPort. Also clarify behavior in some comments. Backport candiate? svn:r11287	2007-08-27 15:33:58 +00:00
Roger Dingledine	05f12bffe9	Handle unexpected whitespace better in malformed descriptors. Bug ... found using Benedikt Boss's new Tor fuzzer! Bugfix on 0.2.0.x. svn:r11229	2007-08-20 20:05:56 +00:00
Nick Mathewson	f8b3927e07	r14634@catbus: nickm | 2007-08-17 16:43:49 -0400 ... Try to fix bug 482: do not rely on s6_addr16 or s6_addr32 on MSVC. How ugly. svn:r11155	2007-08-17 20:44:54 +00:00
Nick Mathewson	181ba71a90	r14051@Kushana: nickm | 2007-08-15 15:55:36 -0400 ... Fix an XXXX020 and a few DOCDOCs. svn:r11127	2007-08-15 19:56:01 +00:00
Nick Mathewson	50f5f63678	r14091@catbus: nickm | 2007-08-08 01:13:17 -0400 ... Fix an annoying warning on OpenBSD: only include malloc.h if we are using it. svn:r11059	2007-08-08 05:14:03 +00:00
Nick Mathewson	484c8b776d	r13872@Kushana: nickm | 2007-07-31 08:27:54 -0700 ... Rename IN4_ADDR and IN6_ADDR to try to avoid conflicting with Windows definitions. This may fix the windows build. svn:r11011	2007-08-01 15:57:34 +00:00
Nick Mathewson	2872a43386	r13871@Kushana: nickm | 2007-07-31 08:10:58 -0700 ... Fix warning aobut unused parameter on platforms without mallinfo. svn:r11010	2007-08-01 15:57:07 +00:00
Nick Mathewson	45c82b1d85	r14024@catbus: nickm | 2007-07-30 14:13:58 -0400 ... Glibc (and maybe others) define a mallinfo() that can be used to see how the platform malloc is acting inside. When we have it, dump its output on dumpmemusage(). svn:r10996	2007-07-30 18:14:14 +00:00
Nick Mathewson	23a345b3c2	r14015@catbus: nickm | 2007-07-30 13:18:05 -0400 ... Add missing code documentation in src/common svn:r10991	2007-07-30 17:46:12 +00:00
Nick Mathewson	25bd4204d0	r13964@catbus: nickm | 2007-07-28 22:55:10 -0400 ... Change "IN_ADDR" macro to "IN4_ADDR" in an attempt to fix mingw compilation svn:r10963	2007-07-29 02:55:24 +00:00
Nick Mathewson	679b55eb1f	r13836@catbus: nickm | 2007-07-19 15:43:04 -0400 ... Some older GCCs think that iph4 could be used uninitialized. Fix that. svn:r10882	2007-07-19 19:43:08 +00:00
Nick Mathewson	4a240552c4	r13834@catbus: nickm | 2007-07-19 15:40:42 -0400 ... Another patch from croup: drop support for address masks that do not correspond to bit prefixes. Nobody has used this for a while, and we have given warnings for a long time. svn:r10881	2007-07-19 19:40:45 +00:00
Nick Mathewson	bbbf504281	r13827@catbus: nickm | 2007-07-19 14:42:25 -0400 ... Merge in some generic address manipulation code from croup. Needs some work. svn:r10880	2007-07-19 18:46:09 +00:00
Nick Mathewson	ad45ddfb07	r13788@catbus: nickm | 2007-07-16 14:26:25 -0400 ... Patch from croup: rewrite the logic of get_next_token() to do the right thing with input that ends at weird places, or aligns with block boundaries after mmap. should fix bug 455. Needs fuzzing. svn:r10847	2007-07-16 18:26:31 +00:00
Nick Mathewson	7e20fdbefb	r13687@catbus: nickm | 2007-07-10 16:08:14 -0400 ... Possible partial fix for bug 455: use eos logic everywhere. svn:r10786	2007-07-10 20:08:18 +00:00
Nick Mathewson	6faa9e2641	r13239@catbus: nickm | 2007-06-04 11:30:37 -0400 ... Fix the fix for bug 445: set umask properly. Also use open+fdopen rather than just umask+fopen, and create authority identity key with mode 400. svn:r10485	2007-06-04 15:30:40 +00:00
Nick Mathewson	aee7f01624	r13154@catbus: nickm | 2007-06-02 11:26:44 -0400 ... Server-side support for If-Modified-Since in HTTP requsts for v1 stuff, and for network-status documents. svn:r10451	2007-06-02 15:26:57 +00:00
Roger Dingledine	b1ee20f0e8	trivial changes from my sandbox ... svn:r10429	2007-05-31 23:57:46 +00:00
Nick Mathewson	bb524e99c9	r12955@catbus: nickm | 2007-05-25 13:17:30 -0400 ... First bare stubs of ipv6 work: commit some (untested, hence doublessly broken) implementations of inet_ntop/pton for systems that lack them. svn:r10326	2007-05-25 18:22:37 +00:00
Nick Mathewson	d3d86b17a7	r12916@catbus: nickm | 2007-05-24 12:43:45 -0400 ... Add math functions to round values to the nearest power of 2. Make mempools more careful about making sure that the size of their chunks is a little less than a power of 2, not a little more. svn:r10304	2007-05-24 17:12:57 +00:00
Nick Mathewson	c9fa4e6583	r12898@catbus: nickm | 2007-05-22 13:11:04 -0400 ... More v3 directory code: have authorities load certificates; have everybody store certificates to disk and load them; provide a way to configure v3 authorities. svn:r10293	2007-05-22 17:58:25 +00:00
Nick Mathewson	4ec5e139c8	r12850@catbus: nickm | 2007-05-21 22:20:42 -0400 ... Partial backport candidate: do not rely on finding a \0 after an mmaped() router/extrainfo file. Also, set journal length correctly when starting up. svn:r10248	2007-05-22 02:20:52 +00:00
Nick Mathewson	e043b86f47	r12764@catbus: nickm | 2007-05-15 17:17:39 -0400 ... Enable (and cope with) more GCC 4.2 warnings. svn:r10196	2007-05-15 21:17:48 +00:00
Nick Mathewson	227b2e0226	r12759@Kushana: nickm | 2007-04-20 08:47:20 -0400 ... Track the number of connection_t separately from the number of open sockets. It is already possible to have connections that do not count: resolving conns, for one. Once we move from socketpairs to linked conns, and once we do dns proxying, there will be lots of such connections. svn:r9994	2007-04-21 17:24:18 +00:00
Nick Mathewson	02ce8e6b12	r12474@Kushana: nickm | 2007-03-06 16:10:05 -0500 ... We have a PATH_SEPARATOR macro. How about we use it? svn:r9782	2007-03-09 21:39:30 +00:00
Nick Mathewson	5d1bee87ff	r12468@Kushana: nickm | 2007-03-06 15:24:00 -0500 ... More unit tests: gcov is fun. svn:r9748	2007-03-06 20:25:44 +00:00
Nick Mathewson	7fcceb2c25	r12074@catbus: nickm | 2007-03-04 15:11:43 -0500 ... Make all LD_BUG log messsages get prefixed with "Bug: ". Remove manually-generated "Bug: "s from log-messages. (Apparently, we remembered to add them about 40% of the time.) svn:r9733	2007-03-04 20:11:46 +00:00
Nick Mathewson	f38240435a	r12001@catbus: nickm | 2007-02-28 15:24:12 -0500 ... Try to build without warnings on mingw with verbose warnings on. First attempt. svn:r9688	2007-02-28 20:24:27 +00:00
Nick Mathewson	e1176ece5a	r11992@catbus: nickm | 2007-02-28 12:46:32 -0500 ... compile fix on mingw: mingw does not define _MSC_VER. svn:r9682	2007-02-28 17:46:36 +00:00
Roger Dingledine	50f22e858a	doc pedant ... svn:r9634	2007-02-24 07:50:38 +00:00
Nick Mathewson	d2893398f6	r11832@catbus: nickm | 2007-02-16 15:31:59 -0500 ... Fix 35 remaining DOCDOC comments. Yowza. svn:r9596	2007-02-16 20:39:37 +00:00
Nick Mathewson	759c58151e	r11775@catbus: nickm | 2007-02-12 16:39:09 -0500 ... Update copyright dates. svn:r9570	2007-02-12 21:39:53 +00:00
Nick Mathewson	30e7c05075	r11774@catbus: nickm | 2007-02-12 16:31:47 -0500 ... Handle errors on opening cached-routers* more uniformly and sanely: log not-found errors at level INFO, and all other errors at level WARN. Needs testing on win32. svn:r9569	2007-02-12 21:39:44 +00:00
Nick Mathewson	f02be02356	r11639@catbus: nickm | 2007-02-05 13:33:38 -0500 ... Add documentation to src/common/*.h; improve documentation for SMARTLIST_FOREACH; remove never-used options and corresponding tests from tor_strpartition. svn:r9483	2007-02-05 18:33:52 +00:00
Nick Mathewson	fefba95363	r11629@catbus: nickm | 2007-02-02 15:06:17 -0500 ... Removing the last DOCDOC comment hurt so much that I had to use Doxygen to identify undocumented macros and comments, and add 150 more DOCDOCs to point out where they were. Oops. Hey, kids! Fixing some of these could be your first Tor patch! svn:r9477	2007-02-02 20:06:43 +00:00
Nick Mathewson	5cb99857bc	r11620@catbus: nickm | 2007-02-01 13:06:27 -0500 ... Call stat() slightly less often; use fstat() when possible. svn:r9472	2007-02-01 18:09:27 +00:00
Nick Mathewson	c57ef84fc5	r11987@Kushana: nickm | 2007-01-19 14:57:28 -0500 ... Implement SOCKS_BAD_HOSTNAME status event. Defer remaining status events. Clean up control-spec.txt a little, and fill in recommendations for events. svn:r9374	2007-01-19 21:25:32 +00:00
Nick Mathewson	39e50cbb48	r9776@totoro: nickm | 2007-01-18 14:37:01 -0500 ... Yes, apparently saying strcpy in front of openbsd is like saying "intellectual property" in front of RMS. They both have a point, I guess, even though they extend it to contexts where it is completely irrelevant. svn:r9370	2007-01-18 19:37:23 +00:00
Nick Mathewson	093d71762c	r11978@Kushana: nickm | 2007-01-15 18:54:25 -0500 ... Apparently, the OpenBSD linker thinks it knows C better than I do, and gets to call me names for having strcat and strcpy and sprintf in my code--whether I use them safely or not. All right, OpenBSD. You win... this round. svn:r9360	2007-01-15 23:56:38 +00:00
Nick Mathewson	6fbf17e7b0	r11749@Kushana: nickm | 2006-12-29 00:51:42 -0500 ... Remove dead code; make targets of addressmap commands/configs use AllowNonRFC953Hostnames svn:r9211	2006-12-29 05:51:50 +00:00
Nick Mathewson	94d7d8d88f	r11670@Kushana: nickm | 2006-12-21 12:23:55 -0500 ... Clean up logic in parse_port_range(); accept 0 on low end and 65536 on high end for people who are bad at math. svn:r9169	2006-12-21 17:38:15 +00:00
Nick Mathewson	ca516311e3	r11668@Kushana: nickm | 2006-12-20 22:22:53 -0500 ... Fix bug found by Keith Skinner: Treat malformed max-ports in address ranges as an error, and dont ignore errors with min-ports even if a max-port is present. svn:r9168	2006-12-21 03:22:59 +00:00
Nick Mathewson	078aab810b	r11597@Kushana: nickm | 2006-12-15 15:49:27 -0500 ... Add a rudimentary line-wrapping function for use in dumping comments in config files. svn:r9132	2006-12-15 21:26:23 +00:00
Nick Mathewson	309c579452	r11581@Kushana: nickm | 2006-12-15 00:12:24 -0500 ... Make PIDFile work on windows. Reported by Arrakis. svn:r9116	2006-12-15 05:12:52 +00:00
Nick Mathewson	d6cc235eba	r9315@totoro: nickm | 2006-11-13 22:40:59 -0500 ... Fix a build warning on angela-sid svn:r8949	2006-11-14 03:41:05 +00:00
Nick Mathewson	9243e54177	r9313@totoro: nickm | 2006-11-13 20:07:41 -0500 ... Try to compile with fewer warnings on irix64's MIPSpro compiler / environment, which apparently believes that: - off_t can be bigger than size_t. - only mean kids assign things they do not subsequently inspect. I don't try to fix the "error" that makes it say: cc-3970 cc: WARNING File = main.c, Line = 1277 conversion from pointer to same-sized integral type (potential portability problem) uintptr_t sig = (uintptr_t)arg; Because really, what can you do about a compiler that claims to be c99 but doesn't understand that void* x = NULL; uintptr_t y = (uintptr_t) x; is safe? svn:r8948	2006-11-14 01:07:52 +00:00
Nick Mathewson	7551c44a53	r9274@Kushana: nickm | 2006-10-19 16:16:58 -0400 ... Add unit tests for tor_mmap_file(); make tor_mmap_t.size always be the size of the file (not the size of the mapping); add an extra argument to read_file_to_str() so it can return the size of the result string. svn:r8762	2006-10-19 23:05:02 +00:00
Andrew Lewman	563be121c2	Add missing return so this builds on mingw. ... svn:r8649	2006-10-08 18:24:31 +00:00
Nick Mathewson	f07f7a7a12	r8923@totoro: nickm | 2006-10-07 11:44:33 -0400 ... More doxygen comments svn:r8637	2006-10-07 16:25:28 +00:00
Roger Dingledine	f2bd0e2f16	more minor cleanups ... svn:r8630	2006-10-07 06:28:50 +00:00
Nick Mathewson	4c56ac93ca	r8851@totoro: nickm | 2006-10-02 18:13:27 -0400 ... Remove/clarify some XXXs for no longer being accurate; for begin things we do not indend to fix; for already being parts of big todo issues (like "/* XXX ipv6 */"); etc. Also fix some spaces. svn:r8580	2006-10-02 22:13:42 +00:00
Nick Mathewson	bff83b666c	r8846@totoro: nickm | 2006-10-02 16:59:57 -0400 ... Move is_local_IP to config.c; have it check for same-/24; make it used only for reachability (not for banwidth, because that is probably not what we want). Fixes an XXX. svn:r8578	2006-10-02 21:00:35 +00:00
Nick Mathewson	d75edc35cc	r8845@totoro: nickm | 2006-10-02 16:34:58 -0400 ... Fix an XXXX: make path_is_relative work on windows even though we never use it there. svn:r8577	2006-10-02 21:00:24 +00:00
Nick Mathewson	7d366f61cb	r9025@Kushana: nickm | 2006-09-29 18:33:13 -0400 ... Differentiate more duplicated log entries svn:r8542	2006-09-29 22:33:40 +00:00
Nick Mathewson	8308a37908	r9023@Kushana: nickm | 2006-09-29 17:27:24 -0400 ... Make distinct all non-bug messages at notice or higher that appear 3 or more times. svn:r8541	2006-09-29 22:33:34 +00:00
Nick Mathewson	87648bdcf8	r9008@Kushana: nickm | 2006-09-29 13:50:10 -0400 ... Doxygen comments for code in common. Also simplify a few code paths to be more clear/speedy/correct. svn:r8536	2006-09-29 18:13:37 +00:00
Nick Mathewson	d3a06684bc	r8974@Kushana: nickm | 2006-09-28 17:05:59 -0400 ... Improvement to last entry guards patch: track when we last attempted to connect to a node in our state file along with how long it has been unreachable. Also clarify behavior of parse_iso_time() when it gets extra characters. svn:r8520	2006-09-28 23:57:49 +00:00
Nick Mathewson	7c21dabef1	r8878@Kushana: nickm | 2006-09-21 17:15:47 -0400 ... Trivial whitespace cleanups. svn:r8443	2006-09-21 21:48:55 +00:00
Nick Mathewson	b2cc52fa02	Speed up eat_whitespace by a lot. ... svn:r8434	2006-09-19 23:55:35 +00:00
Nick Mathewson	6b716fdfb9	NEEDS REVIEW. Act on previous comment, and handle named servers differently: now, we allow multiple servers with the same name in the routerlist even if that name is reserved, but we check whether names are reserved when we try to look up routers by nickname. This is a minor security fix. This makes router_add_to_routerlist O(1). This is a backport candidate. ... svn:r8433	2006-09-19 23:48:14 +00:00
Nick Mathewson	2d4950c837	Malloc and friends are critical-path: Thus, add an it-wont-happen branch prediction for NULL returns, and skip the malloc(0) check on platforms where malloc(0) returns a pointer. ... svn:r8431	2006-09-19 22:36:48 +00:00
Nick Mathewson	7b0ec744bc	Switch routerlist.c to using memcmp on digests rather than crypto_pk_cmp_keys(); speed up find_whitespace a lot (8x for me) by using a switch statement. This should speed parsing a lot of routers at once by a lot. ... svn:r8430	2006-09-19 22:20:09 +00:00
Nick Mathewson	93beeac01d	Merge in some bsockets calls, all wrapped inside #if defined(USE_BSOCKETS) ... svn:r8427	2006-09-19 20:41:31 +00:00
Roger Dingledine	9af3175687	parameterize the loudness of get_interface_address() ... svn:r8358	2006-09-09 19:20:27 +00:00
Roger Dingledine	5f6351ceb3	fix typo, add log message ... svn:r8357	2006-09-09 19:16:07 +00:00
Nick Mathewson	f170e5798f	r8692@Kushana: nickm | 2006-08-31 13:38:07 -0400 ... Fix bug 327 (part 2): Cast char to unsigned char before passing to toupper/tolower. (Follow the same idiom as with isupper and friends, in case we run into the same problem on SGI or whereever it was.) svn:r8310	2006-08-31 17:39:51 +00:00
Nick Mathewson	80282d8f55	r6993@Kushana: nickm | 2006-07-31 16:19:21 -0400 ... Interesting how much a ! can change the behavior of an assert. svn:r6962	2006-07-31 20:19:58 +00:00
Nick Mathewson	ea0f5ec8ad	r6980@Kushana: nickm | 2006-07-31 13:18:22 -0400 ... Add a utility function to verify that a string has been through strlower. svn:r6959	2006-07-31 18:01:37 +00:00
Nick Mathewson	6d2eb77555	Whitespace fix ... svn:r6816	2006-07-23 07:19:49 +00:00
Nick Mathewson	35960e1162	Add a mem_is_zero function (I think we will need this) and a STRUCT_OFFSET macro (we already need this). ... svn:r6810	2006-07-23 05:32:35 +00:00
Roger Dingledine	fad85f173a	when an exit node gets a malformed begin cell, don't complain to ... the node operator, since he can't do anything about it. svn:r6733	2006-07-06 02:44:07 +00:00
Nick Mathewson	73ada60d64	remove non-germane comment ... svn:r6640	2006-06-18 07:37:21 +00:00
Nick Mathewson	af8096815e	Add a memdup function to util ... svn:r6635	2006-06-18 07:22:36 +00:00
Nick Mathewson	1f585987c4	Another escape() fix, for picky sprintfs. ... svn:r6579	2006-06-09 17:07:22 +00:00
Nick Mathewson	2936da4c28	Override our notion of printability for esc_for_log. 127 and up are never printable. Take that, locales. ... svn:r6578	2006-06-09 15:57:58 +00:00
Nick Mathewson	853e2d99b6	Add a new warning to our "warn a lot" list: unused parameters. This means we have to explicitly "use" unuseds, but it can catch bugs. (It caught two coding mistakes so far.) ... svn:r6532	2006-06-04 22:42:13 +00:00
Roger Dingledine	731f4086c0	resolve an unused variable ... svn:r6503	2006-05-26 13:51:45 +00:00
Roger Dingledine	a4cdb834b9	Stop being picky about what the arguments to mapaddress look like. ... we were refusing names that had $ in them, which people who specify $key.exit will be sad about. There are likely other examples. If people can think of reasons why we should be picky, let me know. svn:r6496	2006-05-25 20:06:09 +00:00
Peter Palfrader	f7ba9d77e4	All these headers we get via torint.h ... svn:r6452	2006-05-10 10:24:17 +00:00
Nick Mathewson	8a13a7cfe8	mainline branch. Remove some more dead XXXs. ... svn:r6401	2006-04-18 03:58:42 +00:00
Roger Dingledine	7e3a98b489	"" is not a plausible address for addressmaps. ... svn:r6299	2006-04-03 00:26:51 +00:00
Roger Dingledine	0e62befab8	add tor_strisprint() back in, this time with comments. ... svn:r6170	2006-03-15 23:35:55 +00:00
Roger Dingledine	4cd4353847	and remove now-extraneous function ... svn:r6168	2006-03-15 19:17:46 +00:00
Nick Mathewson	4d3e709c4b	Use escaped() for remaining cases. ... svn:r6117	2006-03-11 02:21:30 +00:00
Roger Dingledine	a385b0087f	fix infinite loop ... svn:r6090	2006-03-06 20:01:46 +00:00
Nick Mathewson	5777ee0e1a	Add some functions to escape values from the network before sending them to the log. Use them everywhere except for routerinfo->plaftorm, routerinfo->contact_info, and rend*.c. (need sleep now) ... svn:r6087	2006-03-05 09:50:26 +00:00
Nick Mathewson	6a4e304d9e	Allow private:* in routerdescs; not generated yet (because older Tors do not understand it); needs testing. ... svn:r6086	2006-03-05 05:27:59 +00:00
Roger Dingledine	6ce36ead42	Start the process of converting warn to log_warn and so on. ... This is needed because Windows already has an err() that we can't clobber. And we need to be able to make the log functions a macro so we can print the function's name in the log entry. svn:r6000	2006-02-13 08:01:59 +00:00
Nick Mathewson	2cc66125b8	try to fix bug with spurious "everything is broken" warning ... svn:r5994	2006-02-13 00:26:43 +00:00
Nick Mathewson	dba155ecff	Generate 18.0.0.0/8 address policy format in descs when we can; warn when the mask is not reducible to a bit-prefix. ... svn:r5991	2006-02-12 23:58:22 +00:00
Roger Dingledine	5f051574d5	Happy new year! ... svn:r5949	2006-02-09 05:46:49 +00:00
Nick Mathewson	7fc62029d4	Refuse to use RunAsDaemon when torrc is a relative path. Fixes bug 229. ... svn:r5767	2006-01-10 20:00:20 +00:00
Nick Mathewson	0da2069643	Clearner fix for timegm assert problem. ... svn:r5690	2006-01-01 23:13:19 +00:00
Nick Mathewson	04db9de847	Fix assertion-trigger bug found by sjmurdoch ... svn:r5689	2006-01-01 23:09:19 +00:00
Nick Mathewson	1af630d32c	Bite the bullet and limit all our source lines to 80 characters, the way IBM intended. ... svn:r5582	2005-12-14 20:40:40 +00:00
Roger Dingledine	c0a6e2232c	let is_internal_IP() know whether you're asking about an IP ... address for connecting or an IP address for binding, because in the latter, 0.0.0.0 is a special case. svn:r5543	2005-12-09 02:45:33 +00:00
Nick Mathewson	cf5facf3e1	Do not free a constant string. ... svn:r5527	2005-12-08 04:01:37 +00:00
Peter Palfrader	1bf56b452e	Remove superfluous strdup ... svn:r5503	2005-12-05 01:30:11 +00:00
Peter Palfrader	7a70a142f4	Also print usernames, not just numeric UIDs when we tell the user that his data directory has the wrong owner ... svn:r5502	2005-12-05 01:28:10 +00:00
Roger Dingledine	8b0f1f029c	give a hint when people are running tor as the wrong user, rather than ... telling them to start chowning random directories. svn:r5500	2005-12-05 01:07:58 +00:00
Nick Mathewson	6b49a93bd5	Move code to check for zero digests into util.c ... svn:r5468	2005-11-30 02:47:59 +00:00
Nick Mathewson	6c361468c1	Loops without an increment step can suck, even on windows. ... svn:r5376	2005-11-15 03:16:32 +00:00
Nick Mathewson	9b432311c4	Make new logging stuff work on windows; fix a couple of windows typos. ... svn:r5375	2005-11-15 03:05:23 +00:00
Nick Mathewson	932106f54c	Efficiency hack: call tor_fix_source_file late, not early. Add "BUG" domain. Domains are now bitmasks... just in case. Make some err msgs non-general. ... svn:r5309	2005-10-25 07:05:03 +00:00
Nick Mathewson	a20835ac92	Check for even more windows version flags, and note any we do not recognize. ... svn:r5297	2005-10-24 18:37:09 +00:00
Nick Mathewson	edf5698474	Start dividing log messages into logging domains. No, LD_ is not the best of identifiers. src/or has not been converted yet. Domains dont do anything yet. ... svn:r5284	2005-10-18 21:58:19 +00:00
Nick Mathewson	48ade882c3	Remove assert in sort-of c-itical path ... svn:r5267	2005-10-18 05:06:36 +00:00
Nick Mathewson	c5ee3e961e	Reorganize some quick-and-dirty code to find out what openssl stuff is leaking, using dmalloc. ... svn:r5178	2005-10-03 20:20:38 +00:00
Nick Mathewson	26e7a05725	even better function start checks; give dmalloc a chance of working. ... svn:r5162	2005-09-30 01:39:24 +00:00
Nick Mathewson	92451f74a8	Reformat inconsistent function declarations. ... svn:r5160	2005-09-30 01:09:52 +00:00
Nick Mathewson	5c53545d81	Add a bunch more warnings to out warning suite; resolve them; pack structs a little better. ... svn:r5150	2005-09-29 22:59:17 +00:00
Nick Mathewson	d4fb1fcd6c	Two new functions like write_bytes_to_file: one takes a list of byte-and-len structs; one appends. ... svn:r5024	2005-09-13 06:19:31 +00:00
Nick Mathewson	a4f32e77ef	Fix segfault in win32 unittests. ... svn:r4983	2005-09-10 02:34:32 +00:00
Nick Mathewson	09d83c564b	Add missing arg to windows tor_listdir() ... svn:r4972	2005-09-09 21:34:59 +00:00
Nick Mathewson	2f6eb10fb4	Implement tor_listdir on windows. Untested. ... svn:r4971	2005-09-09 21:29:23 +00:00
Nick Mathewson	c4b3bf06c6	add strupper function ... svn:r4934	2005-09-08 18:33:51 +00:00
Nick Mathewson	b6a13b6cdf	Add directory listing functions to util.[ch]. Watch the features creep! ... svn:r4906	2005-09-03 04:40:05 +00:00
Roger Dingledine	fa507c63e8	put quotes around user-supplied strings so they are more likely to ... realize if they add bad characters (like quotes) to the torrc svn:r4844	2005-08-26 18:40:44 +00:00
Roger Dingledine	d5e426ab51	add a tor_dup_addr() function to simplify malloc()+tor_inet_ntoa() ... svn:r4838	2005-08-26 07:37:07 +00:00
Nick Mathewson	789374dbbd	Make GCC very happy, even with lots of warnings set. Also, try to fix some reported Solaris x86 warnings. ... svn:r4770	2005-08-12 17:24:53 +00:00
Nick Mathewson	666ab41e2b	parse_addr_port was vague about what to do when port_out was NULL. Make it behave usefully. ... svn:r4716	2005-08-05 01:51:19 +00:00
Nick Mathewson	546fba7b04	Fix windows warning ... svn:r4697	2005-08-04 22:25:39 +00:00
Nick Mathewson	11ff0aba80	Make clients regenerate their keys when their IP address changes. ... svn:r4688	2005-08-03 20:42:17 +00:00
Nick Mathewson	584a0ae397	Fix an fd leak in start_daemon ... svn:r4508	2005-06-30 06:56:00 +00:00
Roger Dingledine	fcd0fc3364	flesh out the source file descriptions for doxygen ... svn:r4404	2005-06-11 05:31:17 +00:00
Nick Mathewson	0831823763	Change end-of-file NLNL convention. It turns out arma I and I agree. ... svn:r4382	2005-06-09 19:03:31 +00:00
Roger Dingledine	652dde72f1	bugfix: chdir to your datadirectory at the *end* of the ... daemonize process, not the beginning. this was a problem because the first time you run tor, if your datadir isn't there, and you have runasdaemon set to 1, it will try to chdir to it before it tries to create it. oops. svn:r4033	2005-04-06 19:07:38 +00:00
Nick Mathewson	0e81265359	update copyright notices. ... svn:r3982	2005-04-01 20:15:56 +00:00
Nick Mathewson	df9c8feac7	Commit fixes for several pending tor core tasks: document all DOCDOCed functions; time out uncontrolled unattached streams; feed reasons to SOCKS5 (refactoring connection_ap_handshake_socks_reply in the process); change DirFetchPeriod/StatusFetchPeriod to have a special "Be smart" value. ... svn:r3769	2005-03-17 12:38:37 +00:00
Nick Mathewson	be38e0a490	Fix a fun windows bug: apparently windows stat wants paths not to end with slash. ... svn:r3766	2005-03-16 00:04:59 +00:00
Nick Mathewson	bbaa3c7792	Implement more control spec functionality ... - Mapaddress - Postdescriptor - GetInfo on descriptors Required changes elsewhere: - Keep the most recent running_routers_t in the routerlist_t. That way we can learn about new routers and remember whether we were last told that they were up or down. Also enables more simplifications. - Keep the signed descriptor inside routerinfo_t. This makes descriptor_entry_t in dirservers.c unneeded. - Rename AddressMap (the verb) to MapAddress. Keep AddressMap as a noun. - Check addresses for plausibility before mapping them. svn:r3696	2005-02-25 20:46:13 +00:00
Nick Mathewson	6e6d95b3db	Change from inet_ntoa to a threadproof tor_inet_ntoa. ... svn:r3656	2005-02-22 08:18:36 +00:00
Nick Mathewson	e8da6b26b6	Note a non-bug in read_file_to_str as used. If we start to rely on it behaving differently, we need to change how it behaves. [Noticed by Chris Palmer] ... svn:r3655	2005-02-22 07:18:46 +00:00
Nick Mathewson	70c3580f81	Patch to localtime/gmtime handling: use the _r variants where available. Use mutexes to fake _r where necessary. Make mutexes no-ops where no threading is enabled. ... svn:r3653	2005-02-22 07:03:03 +00:00
Nick Mathewson	d01718841e	Remove assumptions that maximum path length is anything like 1024. From comments by Chris Palmer ... svn:r3652	2005-02-22 06:38:39 +00:00
Roger Dingledine	051cda803e	point out a potential thread/process leak problem when we're out of memory ... svn:r3512	2005-02-03 07:35:24 +00:00
Peter Palfrader	ddd724ef94	Add --with-dmalloc configure option ... svn:r3508	2005-02-03 07:25:10 +00:00
Roger Dingledine	74bc4e5af0	help avoid overflow from len_in + (len_in/n)*len_ins ... nick, do you think this does it? if so, we should maybe backport too. svn:r3334	2005-01-10 16:30:51 +00:00
Roger Dingledine	cf17d0d29c	move network_init from or/main to common/compat ... call network_init in tor-resolve.c too move tor_lookup_hostname from common/util to common/compat svn:r3203	2004-12-22 05:29:06 +00:00
Nick Mathewson	fe6eb34a10	Solaris CC freaks out if isspace and friends get anything other than an int. We learned that, so we casted. But it is also a bad idea to cast a signed char to an int and expect things to work on win32. Now we cast to unsigned char, then to int, then pass to isspace. Ug ... svn:r3120	2004-12-08 00:42:50 +00:00
Nick Mathewson	249a36586f	Fix parse_iso_time on platforms without strptime. ... svn:r3091	2004-12-06 22:39:10 +00:00
Nick Mathewson	a980446d0c	Be more proactive about noticing underflows: size_t values greater than 0x800...00 are likely to be trouble. ... svn:r3064	2004-12-02 04:33:01 +00:00
Nick Mathewson	b457cfb5eb	Spell-check strings and comments ... svn:r3052	2004-12-01 03:48:14 +00:00
Roger Dingledine	7a8c1ca1e4	a few minor tweaks ... svn:r3041	2004-11-30 08:54:08 +00:00
Nick Mathewson	ad7db5e43a	Add casei versions of strcmpstart/strcmpend ... svn:r3026	2004-11-30 03:10:56 +00:00
Nick Mathewson	7fbd297532	Suggestion from weasel: Make tor --version --version dump the cvs Id of every file. ... svn:r3019	2004-11-29 22:25:31 +00:00
Roger Dingledine	22727b4edc	wrong is ok, and right is fine, but in between is apparently ... totally unacceptable to me. svn:r3005	2004-11-28 11:39:53 +00:00
Nick Mathewson	f7c6ad065e	correct multiple internal spaces ... svn:r3004	2004-11-28 09:14:07 +00:00
Nick Mathewson	6f5dbefa7e	Normalize space: add one between every control keyword and control clause. ... svn:r3003	2004-11-28 09:05:49 +00:00
Roger Dingledine	7c9a707900	remove emacs droppings, since nick says he doesn't need them anymore ... svn:r2989	2004-11-26 04:00:55 +00:00
Nick Mathewson	cd70264377	Clean up some logging and interfaces ... svn:r2945	2004-11-23 00:08:26 +00:00
Nick Mathewson	22dba27d8d	Normalize a few more kinds of whitespace. We now dislike: ... - func (args) - if (x){ This doesn't normalize if(x), for(x); while(x), and friends. svn:r2943	2004-11-22 23:28:26 +00:00
Nick Mathewson	55df2620c6	Add function to format local time in ISO format ... svn:r2935	2004-11-22 21:38:44 +00:00
Nick Mathewson	89a456a1d4	Fix a fun bug in read_all that was corrupting config files on windows, and probably doing other bad stuff too. ... svn:r2898	2004-11-16 00:08:56 +00:00
Nick Mathewson	a3788d5c9d	Fix argument to strncpy. ... svn:r2824	2004-11-12 21:14:51 +00:00
Nick Mathewson	c466b7e72f	Speed up tor_strndup a lot: profiling suggests that our use of strlcpy here was a bad idea. ... svn:r2821	2004-11-12 20:41:03 +00:00
Nick Mathewson	60880cda84	Resolve a bunch of FIXME items; mark a lot more for attention; ask for clarification on some. Turn all XXXX008 ("showstopper for 0.0.8 release") items into XXXX009 or XXXX, since plainly they were not showstoppers for 0.0.8. Add/clean some docs. ... svn:r2808	2004-11-12 16:39:03 +00:00
Nick Mathewson	8de9cfe184	Resolve FIXME items: make expand_filename handle ~ and ~username ... svn:r2789	2004-11-10 14:23:31 +00:00
Nick Mathewson	5a5be93f80	Normalize whitespace; add a "tell me about all the unnormalized whitespace" target; fix a braino in dirserv.c ... svn:r2758	2004-11-09 20:04:00 +00:00
Nick Mathewson	d9d053d70b	Clean windows a little ... svn:r2757	2004-11-09 19:30:50 +00:00
Nick Mathewson	7daab4034d	Fix windows build for VC6; centralize newline-fiasco-damage-control logic ... svn:r2756	2004-11-09 19:13:08 +00:00
Nick Mathewson	cd753df7bf	Resolve many XXXs and all DOCDOCs ... svn:r2755	2004-11-09 18:22:17 +00:00
Nick Mathewson	180e0a9326	Make check_private_dir trimodal (check/create/ignore), not bimodal (create/ignore). ... svn:r2733	2004-11-09 07:12:31 +00:00
Roger Dingledine	8c7b2ff7ed	various fixes ... svn:r2712	2004-11-09 01:24:10 +00:00
Roger Dingledine	865f341708	parse_line_from_file is obsolete. ... svn:r2693	2004-11-06 05:18:29 +00:00
Nick Mathewson	38ed0ce5e6	Unify tor_parse_(numeric); make sure MAX_UINT32 and MAX_UINT64 are defined ... svn:r2688	2004-11-05 17:54:50 +00:00
Nick Mathewson	9d604ec615	Add code to read configuration lines from a string as well as a file ... svn:r2676	2004-11-04 22:29:45 +00:00
Nick Mathewson	b74b72a5ce	Fix windows build ... svn:r2670	2004-11-04 04:01:19 +00:00
Nick Mathewson	871bf904ae	Remove extraneous local ... svn:r2663	2004-11-03 19:15:38 +00:00
Nick Mathewson	d5244e3872	Add a write_bytes_to_file so we can have files with NULs in them. ... svn:r2662	2004-11-03 19:02:48 +00:00
Nick Mathewson	67f14032b1	Handle strlcat/strlcpy correctly on platforms that have them. ... svn:r2647	2004-11-02 19:25:52 +00:00
Roger Dingledine	85c79ffbc7	canonicalize "src" and "dest" arg order in crypto.c (and others) ... svn:r2644	2004-11-02 02:28:51 +00:00
Roger Dingledine	037fba7595	util.c needs ctype.h for tolower and isspace ... svn:r2642	2004-11-01 21:54:12 +00:00
Nick Mathewson	ce79bab7f1	Split util into util (general utilities), container (smartlist and strmap), and compat (cross-platform compatability). ... svn:r2640	2004-11-01 20:41:47 +00:00
Roger Dingledine	4689243242	make sure options.MaxConn can be reached ... svn:r2638	2004-11-01 08:24:34 +00:00
Nick Mathewson	5bc0dba933	Move all util functions that need openssl into crypto.c; make non-openssl functions that util needs into util. Now openssl can be separated. ... svn:r2628	2004-10-30 19:26:31 +00:00
Nick Mathewson	6874c39904	Fix windows build ... svn:r2613	2004-10-27 18:14:38 +00:00
Nick Mathewson	6980929e64	Use strlcpy, not strcpy. ... svn:r2610	2004-10-27 06:48:16 +00:00
Nick Mathewson	44d4516155	Use tor_snprintf, not snprintf ... svn:r2609	2004-10-27 06:37:34 +00:00
Nick Mathewson	22dc19b590	snprintf wrapper with consistant (though not C99) overflow behavior ... svn:r2606	2004-10-27 06:26:23 +00:00
Nick Mathewson	f67f83b1fa	Use strlcpy, not strncpy ... svn:r2603	2004-10-27 06:03:28 +00:00
Nick Mathewson	bc62f8e983	Replace sprintf with snprintf ... svn:r2602	2004-10-27 05:53:07 +00:00
Nick Mathewson	26f3cb8652	Add SysLog option to direct log messages to the system log instead of a FILE*. ... svn:r2591	2004-10-26 21:48:41 +00:00
Roger Dingledine	e9e9a25881	i take back everything i've said about unit tests ... svn:r2547	2004-10-16 22:56:03 +00:00
Roger Dingledine	6d873e5743	don't assert multiple things in the same tor_assert() ... svn:r2545	2004-10-16 22:28:11 +00:00
Nick Mathewson	47dc024f7e	Change interface of parse_addr_port() to return address in host order, since most users seem to want that. ... svn:r2542	2004-10-16 21:53:30 +00:00
Nick Mathewson	69d7b468b4	Refactor parse-addr-mask-and-port-range into a separate function ... svn:r2540	2004-10-16 21:41:12 +00:00
Nick Mathewson	2fb08fe46c	add documentation for smartlist_join_strings ... svn:r2524	2004-10-15 03:55:02 +00:00
Nick Mathewson	c5964d6738	Basic string-join functionality ... svn:r2521	2004-10-14 19:51:47 +00:00
Roger Dingledine	5f4a390b33	oh, and some more in common/ ... svn:r2483	2004-10-14 02:48:57 +00:00
Roger Dingledine	a7d858bd6e	start the great migration from int to size_t ... and clean some deadweight from util.h svn:r2455	2004-10-12 20:20:19 +00:00
Nick Mathewson	19da1f36c2	Make a bounds-checking replacement for strtol with slightly easier error-checking in the common case ... svn:r2452	2004-10-12 19:32:41 +00:00
Nick Mathewson	e7241044e8	Better bounds checking on parsed ints ... svn:r2450	2004-10-12 19:01:53 +00:00
Nick Mathewson	a91fc48b39	Note byte-order on result for parse_addr_port() ... svn:r2444	2004-10-12 16:02:15 +00:00
Nick Mathewson	8b037509f3	Add functions to parse addr[:port] consistently ... svn:r2440	2004-10-12 15:48:30 +00:00
Roger Dingledine	2bcd0f34f5	fix compile error: move variable declarations before code ... svn:r2430	2004-10-08 05:43:28 +00:00
Nick Mathewson	6c970aec94	Turn tor_strpartion into a swiss-army-knife function, so it can terminate or not-terminate appropriately. ... svn:r2429	2004-10-07 21:37:06 +00:00
Nick Mathewson	7b98fb58eb	More complete docs for crypto.c; factor out string partitioning code ... svn:r2427	2004-10-07 20:58:53 +00:00
Nick Mathewson	b56bb39ed6	Add a function to remove a set of characters from a string ... svn:r2420	2004-10-06 13:26:37 +00:00
Roger Dingledine	1e3b9e7d31	make the warn message better for reading short files ... svn:r2385	2004-09-28 08:40:03 +00:00
Nick Mathewson	09586ef712	Make read_all distinguish between error and EOF; read_file_to_string should only check bytes read against st_size when in binary mode. ... svn:r2375	2004-09-26 16:51:31 +00:00
Roger Dingledine	8954cd91ce	LOG_ERR is for when we're going to exit ... svn:r2348	2004-09-10 21:39:53 +00:00
Nick Mathewson	0ef85f6dba	Some platforms have weird translations when you open files in "test" mode; make read/write_str_to_file aware. ... svn:r2336	2004-09-08 07:16:34 +00:00
Nick Mathewson	f311206d1d	Make split function smarter; add a strcmpstart function so we can stop bungling strcmp(x, y, strlen(y)); ... svn:r2325	2004-09-02 18:25:50 +00:00
Nick Mathewson	31b81650b7	Define LONG_MAX and UINT_MAX when they are missing ... svn:r2317	2004-08-25 19:16:18 +00:00
Roger Dingledine	444a01610c	make the compile work (and not complain) on sunos 5.9 ... svn:r2312	2004-08-25 17:31:47 +00:00
Roger Dingledine	d91cacb839	agree with nick: this legal-chars-in-filename stuff gets us nothing ... svn:r2310	2004-08-24 21:57:12 +00:00
Nick Mathewson	015232bd39	As far as I can tell, CONFIG_LEGAL_FILENAME_CHARACTERS is both pointless and broken. #if it out, pending agreement from arma. This fixes a bug on win32 that rejected paths with a : in them. ... svn:r2309	2004-08-24 20:48:22 +00:00
Nick Mathewson	7cb93e5bb6	Move string-splitting into a separate function ... svn:r2263	2004-08-17 21:06:36 +00:00
Nick Mathewson	8566bbb489	Add strmap_isempty ... svn:r2250	2004-08-17 06:28:34 +00:00
Nick Mathewson	15a903b21c	Convenience function to do a strcmp on each member of a smartlist of strings ... svn:r2243	2004-08-16 20:46:00 +00:00
Nick Mathewson	6453a25567	Add replace_file to util.[ch] to survive stupidity of windows rename call ... svn:r2208	2004-08-09 04:28:25 +00:00
Nick Mathewson	f6cc218742	Refactor ISO-style (yyyy-mm-dd hh:mm:ss) time parsing into util.c; rename format/parse_rfc1123_time; make rephist remember used bandwidth; published used bandwidth in descriptors in 15-minute chunks. Breaks unittests. ... svn:r2182	2004-08-07 02:46:16 +00:00
Nick Mathewson	2091dab7f4	fencepost ... svn:r2178	2004-08-07 01:18:02 +00:00
Nick Mathewson	380f32f07d	hex_encode is obsoleted by base16_encode, and never actually worked in the first place. (Thanks to Timo Lindfors for noticing the never-actually-worked part.) ... svn:r2175	2004-08-07 01:03:33 +00:00
Nick Mathewson	14d5478f29	Add functions to format and parse RFC1123-style times, for HTTP protocol. ... svn:r2129	2004-08-04 01:11:15 +00:00
Nick Mathewson	5b61dd0457	Fix all warnings on win32 build ... svn:r2127	2004-08-03 23:57:05 +00:00
Nick Mathewson	849e998ac6	It is possible to have struct timeval but not gettimeofday. ... svn:r2125	2004-08-03 23:31:22 +00:00
Roger Dingledine	5525606653	check return value of fclose while writing to disk, since it might ... return out-of-space, etc svn:r2122	2004-07-23 21:25:28 +00:00
Roger Dingledine	7459d067a5	now base16_encode() and base32_encode() can't ever fail ... svn:r2103	2004-07-22 08:30:06 +00:00
Nick Mathewson	06c11a61ce	When faking gettimeofday with ftime, do it right. ... svn:r2068	2004-07-20 21:23:50 +00:00
Nick Mathewson	bc36db351f	Resolve all DOCDOCs. ... svn:r2050	2004-07-16 22:23:18 +00:00
Nick Mathewson	9364c40afd	Add generic expand_filename function to handle expanding ~/ ... svn:r2047	2004-07-15 02:00:43 +00:00
Roger Dingledine	7e344f191a	add is_local_IP() function to help distinguish which bandwidth "matters" ... svn:r2040	2004-07-13 16:57:37 +00:00
Nick Mathewson	88451ce25b	Yes, I did mean "else if". ... svn:r2016	2004-07-06 23:29:34 +00:00
Nick Mathewson	d5e275ddf4	Fix bug reported by peter palfrader: an empty address is unresolvable, but not an occasion for an assertion failure in a dnsworker. ... svn:r2015	2004-07-06 23:25:21 +00:00
Nick Mathewson	b1e9adf056	Always use get_data_directory() instead of options.DataDirectory; fix a memory leak in router.c ... svn:r1991	2004-06-30 16:37:08 +00:00
Roger Dingledine	43295ca61f	if datadirectory isn't owned by this uid, tell the user he must ... fix it before he can proceed. svn:r1968	2004-06-13 11:28:32 +00:00
Nick Mathewson	0d1b4b5024	Unbork windows whitespace ... svn:r1949	2004-06-05 01:56:54 +00:00
Nick Mathewson	17b5b3685f	Make tor build on win32 again; handle locking for server ... svn:r1948	2004-06-05 01:50:35 +00:00
Roger Dingledine	1ef411fefd	use sys/param.h if it's there ... svn:r1927	2004-06-01 17:03:01 +00:00
Roger Dingledine	1841aa456b	rik's patch to not complain about freebsd's bug ... svn:r1921	2004-05-26 20:27:54 +00:00
Nick Mathewson	7511fbf993	Resolve some XXXs ... svn:r1889	2004-05-18 15:35:21 +00:00
Nick Mathewson	93576d5289	Add doxygen markup for util and buffers ... svn:r1820	2004-05-07 17:04:12 +00:00
Nick Mathewson	e6f3bf2a68	tor_assert(), not assert() ... svn:r1777	2004-05-02 20:27:48 +00:00
Nick Mathewson	3dd1ef8783	Fix windows compile. ... svn:r1776	2004-05-02 20:23:35 +00:00
Nick Mathewson	af08c4f878	Working strerror for windows socket errors, plus some snide comments. ... svn:r1775	2004-05-02 20:18:21 +00:00
Roger Dingledine	1558fb7650	some patches on the patches ... svn:r1761	2004-05-01 23:29:20 +00:00
Nick Mathewson	4dc30ea3c8	Remove bogus */ so util.c compiles ... svn:r1759	2004-05-01 21:50:53 +00:00
Nick Mathewson	9a041591ac	Finish documenting the functions in common ... svn:r1758	2004-05-01 21:41:23 +00:00
Nick Mathewson	908ccb9dcd	Handle windows socket errors correctly; comment most of common. ... svn:r1756	2004-05-01 20:46:28 +00:00
Roger Dingledine	4b316b4a7d	some cosmetic fixes ... svn:r1747	2004-04-29 02:52:49 +00:00
Nick Mathewson	9322641710	Use socketclose on windows as appropriate; end pid files with newline ... svn:r1745	2004-04-28 21:14:56 +00:00
Nick Mathewson	7055f837ab	Make Tor build on win32 with VC6 without warnings. ... svn:r1739	2004-04-28 20:13:21 +00:00
Nick Mathewson	ac622d94dc	Workarounds for a couple of pieces of windows strangeness. ... svn:r1734	2004-04-28 19:35:12 +00:00
Nick Mathewson	568a4d187a	Check for machine/limits.h in addition to sys/limits.h ... svn:r1705	2004-04-25 23:47:26 +00:00
Roger Dingledine	37192bd25e	use tor_assert and PUBLIC_KEY_OK ... but don't use tor_assert inside log.c, to avoid loops svn:r1696	2004-04-25 19:59:38 +00:00
Roger Dingledine	06a60c4fbb	use the real socketpair if we've got it ... now it's just windows that has to use the kludged one svn:r1675	2004-04-19 21:31:32 +00:00
Roger Dingledine	a54ded2879	util.c uses LONG_MAX, needs another include on fbsd 5.x ... svn:r1653	2004-04-17 06:35:03 +00:00
Nick Mathewson	024c059fae	Force tor_malloc(0) to always be sane ... svn:r1558	2004-04-08 03:05:08 +00:00
Nick Mathewson	8169da5c30	Don't use Tor version 0.0.5 for intro/rendezvous points. (We don't need ... to worry about 0.0.4 or earlier, because nobody is running them any more.) svn:r1533	2004-04-07 21:36:03 +00:00
Nick Mathewson	3d60cd1d61	Delete trailing whitespace and expand tabs; remove unused aes decrypt code ... svn:r1522	2004-04-07 19:57:40 +00:00
Nick Mathewson	75c19716a8	Put ourself in router list; act accordingly. ... svn:r1521	2004-04-07 19:46:27 +00:00
Nick Mathewson	8b371c2aa5	router_choose_random_node wants a smartlist of routers, not of nicknames. ... svn:r1510	2004-04-06 21:19:59 +00:00
Nick Mathewson	6290d027c9	Continue attack on magic numbers; use new crypto wrappers where possible ... svn:r1504	2004-04-06 20:16:12 +00:00
Nick Mathewson	257d509b91	Document stuff, reduce magic numbers, add emacs magic ... svn:r1502	2004-04-06 03:44:36 +00:00
Nick Mathewson	b3c2b62a14	Make "common" no longer depend on or.h ... svn:r1466	2004-04-03 04:05:12 +00:00
Nick Mathewson	7451de5d97	Loops work better when they terminate. Non-terminating loops are easier ... to diagnose when they don't trash the stack. svn:r1460	2004-04-03 02:55:42 +00:00
Nick Mathewson	fc4d15baf6	Hide smartlist internals ... svn:r1451	2004-04-03 00:58:54 +00:00
Nick Mathewson	e8345bfced	refactor; start adding debugging logs to midpoint rend stuff ... svn:r1445	2004-04-02 23:30:54 +00:00
Nick Mathewson	b32440a028	Implement hidserv_XX functions; there is still an XXX in directory_handle_command ... svn:r1404	2004-03-31 03:42:56 +00:00
Nick Mathewson	93ab51e9ac	Make smartlist Do What Arma Expects. ... svn:r1401	2004-03-30 22:59:00 +00:00
Nick Mathewson	96a86ef14d	Remove maximum-size field from smartlists ... svn:r1397	2004-03-30 20:05:52 +00:00
Nick Mathewson	abcf3d9341	Make smartlists start small and grow as needed. ... svn:r1394	2004-03-30 19:25:43 +00:00
Nick Mathewson	b69f5f3e1b	Add an autoconf test for whether unaligned int access is permitted. ... It works on macos, and works correctly when I twiddle the test code to generate a spurious segfault. Will it work anywhere else? svn:r1329	2004-03-21 04:14:06 +00:00
Nick Mathewson	0d8feba6d8	Add macros and functions to wrap memcpy/alignment logic. ... svn:r1326	2004-03-21 02:01:17 +00:00
Roger Dingledine	d10fcc89ec	make uname() more likely to work on solaris ... (linux says 0 is success, solaris says 1 is success) svn:r1322	2004-03-20 21:22:16 +00:00
Nick Mathewson	b0ef4e1143	Use strmap code for client DNS. ... svn:r1309	2004-03-20 01:21:19 +00:00
Nick Mathewson	9199696182	Add some wrappers around SPLAY_* for the common map-from-string-to-X case. ... It will probably be less blindingly fast than using SPLAY_* directly, but only slightly so. svn:r1306	2004-03-19 22:07:24 +00:00
Roger Dingledine	df3f37b84f	getpid returns a pid_t. we all know that's an int. but solaris doesn't know. ... svn:r1305	2004-03-19 21:34:04 +00:00