Nick Mathewson
0bd220adcb
Don't pass invalid memory regions to digestmap_set/get in test_routerlist
...
Fixes bug in c887e20e6a5a2c17c65; bug in no released Tor version.
2014-09-15 14:04:19 -04:00
Nick Mathewson
1dc0d26b50
Clean up a clangalyzer warning in directory_remove_invalid
...
"At this point in the code, msg has been set to a string
constant. But the tor code checks that msg is not NULL, and the
redundant NULL check confuses the analyser[...] To avoid this
spurious warning, the patch initialises msg to NULL."
Patch from teor. another part of 13157.
2014-09-15 13:52:56 -04:00
Nick Mathewson
53a94c4b4b
Clear up another clangalyzer issue
...
"The NULL pointer warnings on the return value of
tor_addr_to_in6_addr32() are incorrect. But clang can't work this
out itself due to limited analysis depth. To teach the analyser that
the return value is safe to dereference, I applied tor_assert to the
return value."
Patch from teor. Part of 13157.
2014-09-15 13:52:13 -04:00
George Kadianakis
a77e44d8c0
Add changes file for Tor2webRendezvousPoints.
2014-09-15 16:07:48 +03:00
George Kadianakis
bc80b0a50c
Write some unittests for Tor2webRendezvousPoints.
2014-09-15 16:07:48 +03:00
George Kadianakis
a72b92676e
Fix up testhelper to be used by the entryguard unittests.
2014-09-15 16:07:48 +03:00
George Kadianakis
532ab7e13c
Move some useful unittest functions to a testhelper.c file.
...
This commit only moves code.
2014-09-15 16:07:48 +03:00
George Kadianakis
6c512d2f63
Fix a tor2web log message that referenced the wrong configure switch.
2014-09-15 16:07:48 +03:00
George Kadianakis
24a7726955
Implement Tor2webRendezvousPoints functionality.
2014-09-15 16:07:48 +03:00
George Kadianakis
3e7c5e9f44
Block circuit canibalization when Tor2webRendezvousPoints is active.
2014-09-15 16:07:48 +03:00
George Kadianakis
e02138eb65
Introduce the Tor2webRendezvousPoints torrc option.
2014-09-15 16:07:46 +03:00
Roger Dingledine
d6b2a1709d
fix typo in comment
2014-09-13 17:10:04 -04:00
Nick Mathewson
f8f0cb0443
Mention "make check" in doc/HACKING
2014-09-12 16:14:49 -04:00
Sebastian Hahn
8448901148
Give an example how to run the unit tests
2014-09-12 22:08:27 +02:00
Nick Mathewson
974f4d2ceb
Merge remote-tracking branch 'origin/maint-0.2.5'
...
(Do an "ours" merge to avoid taking version number changes)
2014-09-11 21:41:56 -04:00
Nick Mathewson
550c03336c
Bump maint-0.2.5 to 0.2.5.7-rc-dev
2014-09-11 21:38:32 -04:00
Nick Mathewson
383238b2f6
forward-port changelog from 0.2.5.7-rc
2014-09-11 21:25:03 -04:00
Nick Mathewson
89e32c7c08
One more whitespace fix
2014-09-11 14:40:24 -04:00
Nick Mathewson
32f75c870e
Whitespace cleanups in test_util
2014-09-11 14:37:12 -04:00
Nick Mathewson
6d66e9068b
Whitespace cleanups in transports/test_pt
2014-09-11 14:36:51 -04:00
Nick Mathewson
b16254dce9
Update HACKING instructions to mention format_changelog script
2014-09-11 11:34:57 -04:00
Nick Mathewson
43a47ae726
Use tor_malloc_zero() in pt tests
...
Fixes for PT tests merged with 8402; patch from Yawning.
2014-09-11 09:17:13 -04:00
Nick Mathewson
2914d56ea4
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-11 08:59:24 -04:00
Nick Mathewson
121f4a9ca4
Merge remote-tracking branch 'public/bug13104_025'
2014-09-11 08:30:41 -04:00
Nick Mathewson
d02937a203
Fix "comparison is always false" warnings in new test_util_di_ops
...
Having a constant zero means that unsigned < 0 is always false.
2014-09-11 08:28:46 -04:00
Roger Dingledine
6215ebb266
Reduce log severity for unused ClientTransportPlugin lines
...
Tor Browser includes several ClientTransportPlugin lines in its
torrc-defaults file, leading every Tor Browser user who looks at her
logs to see these notices and wonder if they're dangerous.
Resolves bug 13124; bugfix on 0.2.5.3-alpha.
2014-09-11 08:02:37 -04:00
Nick Mathewson
48558ed1aa
Merge remote-tracking branch 'public/bug13104_025'
2014-09-11 00:11:26 -04:00
Nick Mathewson
2491eadf00
C90 compliance for #13104 fixes
2014-09-11 00:10:53 -04:00
Nick Mathewson
9e595a95a8
Add a changes file for bug 13104
2014-09-11 00:05:56 -04:00
Nick Mathewson
284cc9a224
Avoid an overflow on negation in format_helper_exit_status
...
Part of 13104; patch from teor.
2014-09-11 00:00:13 -04:00
Nick Mathewson
59f9a5c786
Avoid divide by zero and NaNs in scale_array_elements_to_u64
...
Patch from teor; part of 13104
2014-09-10 23:59:21 -04:00
Nick Mathewson
5126bc2ebd
Extra tests for tor_memeq and memcmp
...
(Patch from teor; part of 13104)
2014-09-10 23:58:02 -04:00
Nick Mathewson
d2463c0cfe
Avoid overflows and underflows in sscanf and friends
...
(Patch from teor on 13104)
2014-09-10 23:57:31 -04:00
Nick Mathewson
73ee161d8a
Merge remote-tracking branch 'origin/maint-0.2.5'
2014-09-10 23:48:59 -04:00
Nick Mathewson
3c2c6a6116
In routerlist_assert_ok(), check r2 before taking &(r2->cache_info)
...
Technically, we're not allowed to take the address of a member can't
exist relative to the null pointer. That makes me wonder how any sane
compliant system implements the offsetof macro, but let's let sleeping
balrogs lie.
Fixes 13096; patch on 0.1.1.9-alpha; patch from "teor", who was using
clang -fsanitize=undefined-trap -fsanitize-undefined-trap-on-error -ftrapv
2014-09-10 23:48:11 -04:00
Nick Mathewson
e07206afea
Merge remote-tracking branch 'yawning/bug_8402'
2014-09-10 23:41:55 -04:00
Nick Mathewson
5474d8ae05
Merge remote-tracking branch 'public/torrc_minimal'
2014-09-10 23:36:27 -04:00
Nick Mathewson
93dfb12037
Remember log messages that happen before logs are configured
...
(And replay them once we know our first real logs.)
This is an implementation for issue 6938. It solves the problem of
early log mesages not getting sent to log files, but not the issue of
early log messages not getting sent to controllers.
2014-09-10 23:34:43 -04:00
Nick Mathewson
6e2ef4bc5e
Refactor the 'deliver a log message' logic to its own function.
2014-09-10 22:58:36 -04:00
Nick Mathewson
de114587f0
Turn log loop into a for loop, and "Does this lf want this" into a fn
2014-09-10 22:39:55 -04:00
Nick Mathewson
15a318b49a
Refactor pending_cb_message_t into a type with proper functions
...
Also, rename it.
2014-09-10 22:35:16 -04:00
Nick Mathewson
a9b2e5eac6
Merge remote-tracking branch 'public/bug12908_025' into maint-0.2.5
2014-09-10 22:12:47 -04:00
Nick Mathewson
916d53d6ce
Mark StrictE{ntry,xit}Nodes as obsolete.
2014-09-10 07:10:10 -04:00
Yawning Angel
cae44838fe
Fix issues brought up in nickm's review.
...
* Update pt_get_proxy_uri() documentation.
* proxy_supported is now unsigned.
* Added a changes file.
2014-09-09 18:21:19 +00:00
George Kadianakis
01800ea1e4
Add unittests for finding the third quartile of a set.
2014-09-09 12:28:15 -04:00
Nick Mathewson
8e39395199
Merge remote-tracking branch 'asn/bug13064'
2014-09-09 12:26:16 -04:00
Nick Mathewson
40b7dfaed2
Remove now-pointless SIZE_MAX stanza from OpenBSD_malloc_linux
2014-09-09 12:09:18 -04:00
Nick Mathewson
1eea7a68ed
Use S?SIZE_MAX, not S?SIZE_T_MAX
...
This fixes bug 13102 (not on any released Tor) where using the
standard SSIZE_MAX name broke mingw64, and we didn't realize.
I did this with
perl -i -pe 's/SIZE_T_MAX/SIZE_MAX/' src/*/*.[ch] src/*/*/*.[ch]
2014-09-09 12:08:03 -04:00
Sebastian Hahn
409a56281e
Remove client-side bad directory logic
...
Implements the second half of #13060 .
2014-09-09 11:54:20 -04:00
Sebastian Hahn
8099dee992
Remove dirauth support for the BadDirectory flag
...
Implements the first half of #13060 . The second half will be to remove
client support, too.
2014-09-09 11:54:15 -04:00