Nick Mathewson
234c5015f1
Move protocol-specific functions out of buffers.c
...
This commit does not change the implementation of any function: it
only moves code and adds new includes as necessary. Part of #23149 .
2017-09-05 13:57:51 -04:00
Nick Mathewson
e2969759a7
Remove changes files that are already merged in 0.3.1.6-rc
2017-09-05 10:43:17 -04:00
Nick Mathewson
42394053c9
Merge branch 'maint-0.3.1'
2017-09-04 15:48:12 -04:00
Nick Mathewson
4d97efd4d1
Merge branch 'bug22752_031_simple' into maint-0.3.1
2017-09-04 15:48:01 -04:00
Nick Mathewson
33989cd002
Merge remote-tracking branch 'dgoulet/bug23366_032_01'
2017-09-04 12:48:26 -04:00
Nick Mathewson
e2e13e7c8a
Merge branch 'maint-0.3.1'
2017-09-04 11:40:02 -04:00
Nick Mathewson
a7aeb6f58f
Merge remote-tracking branch 'public/bug23275_031' into maint-0.3.1
2017-09-04 11:39:28 -04:00
David Goulet
651629cbdf
config: Make parse_outbound_addresses() return failures
...
The function was never returning an error code on failure to parse the
OutboundAddress* options.
In the process, it was making our test_options_validate__outbound_addresses()
not test the right thing.
Fixes #23366
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-08-31 08:29:09 -04:00
Nick Mathewson
a58a41c15a
Changes file for bug22752 (simple version)
2017-08-29 13:09:39 -04:00
Nick Mathewson
209bfe715c
Merge branch 'maint-0.3.1'
2017-08-29 11:11:12 -04:00
David Goulet
6507ecb7e8
hs: Fix the intro circuit max retry
...
Some parentheses were missing making the rend_max_intro_circs_per_period()
return a lower value than it was suppose to.
The calculation is that a service at most will open a number of intro points
that it wants which is 3 by default or HiddenServiceNumIntroductionPoints. Two
extra are launched for performance reason. Finally, this can happen twice for
two descriptors for the current and next time period.
From:
2 * n_intro_wanted + 2
...which resulted in 8 for 3 intro points, this commit fixes it to:
(n_intro_wanted + 2) * 2
... resulting in 12 possible intro point circuit which is the correct maximum
intro circuit allowed per period.
Last, this commit rate limits the the log message if we ever go above that
limit else over a INTRO_CIRC_RETRY_PERIOD, we can print it often!
Fixes #22159
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-08-28 14:43:42 -04:00
Nick Mathewson
63fc23f826
Merge branch 'ticket22348_031' into maint-0.3.1
2017-08-28 11:44:18 -04:00
Nick Mathewson
c107aae3c2
Merge branch 'ticket22348_031'
2017-08-28 11:43:55 -04:00
Nick Mathewson
4b4b3afb56
Merge branch 'bug22802_squashed'
2017-08-28 10:23:05 -04:00
Nick Mathewson
e37c1df9cd
Don't use "0" as a "base" argument to tor_parse_*().
...
Telling these functions to autodetect the numeric base has lead to
trouble in the past.
Fixes bug 22469. Bugfix on 0.2.2.various.
2017-08-28 10:21:29 -04:00
Nick Mathewson
f2f1cab2b3
Restore documentation for approved-routers
...
We removed this documentation in 607724c696
, when we removed
Naming Authoritative Directories, but actually this file is still
used by authorities to indicate rejected and invalid fingerprints.
Closes ticket 21148.
2017-08-25 12:35:38 -04:00
Nick Mathewson
b91dce9454
Merge branch 'maint-0.3.1'
2017-08-25 11:39:38 -04:00
Nick Mathewson
6069c829f9
Merge branch 'bug19418_029' into maint-0.3.1
2017-08-25 11:38:24 -04:00
Nick Mathewson
e7c1a6f4f7
Changes file for 22497
2017-08-24 16:11:08 -04:00
Nick Mathewson
b5c5086aba
Merge branch 'bug23106_032'
2017-08-24 09:45:03 -04:00
Nick Mathewson
35a29e81ae
Merge branch 'bug19281_025'
2017-08-24 09:27:26 -04:00
Nick Mathewson
d37e8b407a
Merge branch 'feature22976_squashed'
2017-08-24 09:23:43 -04:00
Nick Mathewson
a0bb1ff6ab
Also disable spawning on Sandbox.
...
This isn't a functional change, but it makes our logic more clear,
and catches bugs earlier.
2017-08-24 09:23:32 -04:00
Nick Mathewson
f4f828640f
Merge branch 'bug22779_031'
2017-08-24 09:18:39 -04:00
Nick Mathewson
53c82c0821
Merge branch 'bug22677'
2017-08-24 09:18:03 -04:00
Nick Mathewson
86ee35ad5b
Don't do expensive consensus stuff when not a cache.
...
This includes generating and storing compressed consensuses, and
consensus diffs. Fixes bug 23275; bugfix on 0.3.1.1-alpha.
2017-08-23 10:22:51 -04:00
Nick Mathewson
8f8a061b0c
Merge branch 'maint-0.3.1'
2017-08-21 15:08:17 -04:00
Nick Mathewson
10b2428224
Merge branch 'bug23291_028' into maint-0.3.1
2017-08-21 15:06:39 -04:00
Nick Mathewson
b943cedf34
changes file for bug 23291
2017-08-21 15:04:35 -04:00
Nick Mathewson
6f3208670a
Merge branch 'maint-0.3.1'
2017-08-21 14:20:38 -04:00
George Kadianakis
1491c0d024
Fix triggerable BUG() when decoding hsv3 descriptors.
...
Also improve the unittest to make sure it catches the right error.
2017-08-21 19:16:45 +03:00
Nick Mathewson
efbd4a33f4
Raise MIN_DL_PER_REQUEST to 32
...
This change should improve overhead for downloading small numbers of
descriptors and microdescriptors by improving compression
performance and lowering directory request overhead.
Closes ticket 23220.
2017-08-11 13:54:01 -04:00
Nick Mathewson
a368cadf95
Merge branch 'bug18982'
2017-08-11 12:11:42 -04:00
Nick Mathewson
6247f5a5ba
Merge branch 'maint-0.3.1'
2017-08-11 11:51:06 -04:00
Nick Mathewson
133e1e870b
Merge remote-tracking branch 'dgoulet/bug23091_032_01'
2017-08-11 09:39:57 -04:00
Nick Mathewson
d655388a4a
Document all the arguments of PublishServerDescriptor.
...
Implements 15645.
2017-08-09 11:17:27 -04:00
Nick Mathewson
eb43401bfb
Add a 'NoExec' option that causes tor_spawn_background() to fail
...
Core of an implementation for 22976.
2017-08-09 10:45:48 -04:00
Nick Mathewson
69222fe87d
Clarify that "sandbox 1" requires linux and seccomp2
...
Closes 22677.
2017-08-09 09:29:34 -04:00
Nick Mathewson
418f3d6298
Make sure we always wind up checking i2d_*'s output.
...
The biggest offender here was sometimes not checking the output of
crypto_pk_get_digest.
Fixes bug 19418. Reported by Guido Vranken.
2017-08-09 09:24:16 -04:00
Nick Mathewson
6f7d548bc4
Make write_escaped_data more robust to large inputs.
...
The old implementation would fail with super-long inputs. We never
gave it any, but still, it's nicer to dtrt here.
Reported by Guido Vranken. Fixes bug 19281.
2017-08-09 09:02:12 -04:00
Nick Mathewson
72832086e2
Use a single free-and-exit strategy in config_process_include.
...
This avoids a double-free when a pointer already freed with
tor_free(config_line) is freed again in the cleanup-and-exit code.
Fixes bug 23155.
2017-08-08 20:08:43 -04:00
Nick Mathewson
b08a2dc954
Merge branch 'maint-0.3.1'
2017-08-08 19:29:10 -04:00
Nick Mathewson
a47b8fcf92
Merge branch 'bug23139' into maint-0.3.1
2017-08-08 19:29:05 -04:00
Nick Mathewson
48a57f9815
Merge branch 'maint-0.3.1'
2017-08-08 10:10:52 -04:00
Nick Mathewson
5368eaf62b
chages file on 22286
2017-08-08 10:09:54 -04:00
Nick Mathewson
3af4aafbcb
Fix a memory leak in consdiffmgr.c
...
Fixes bug 23139; bugfix on 0.3.1.1-alpha.
2017-08-08 09:13:45 -04:00
cypherpunks
0265ced02b
Remove usage of the PATH_MAX variable
...
GNU Hurd does not define the PATH_MAX variable. Using the variable on
this platform results in compilation errors.
Closes #23098 .
2017-08-04 12:22:53 -04:00
Nick Mathewson
3b646bf887
Fix ntohs() that should have been htons()
...
Fixes bug 23106; bugfix on 0.2.4.8-alpha.
Fortunately, we only support big-endian and little-endian platforms,
and on both of those, hton*() and ntoh*() behave the same. And if
we did start to support middle endian systems (haha, no), most of
_those_ have hton*(x) == ntoh*(x) too.
2017-08-04 12:17:53 -04:00
Isis Lovecruft
b2a7e8df90
routerkeys: Add cmdline option for learning signing key expiration.
...
* CLOSES #17639 .
* ADDS new --key-expiration commandline option which prints when the
signing key expires.
2017-08-03 22:20:02 +00:00
Nick Mathewson
fabc3deb75
Merge branch 'bug20152'
2017-08-03 10:11:44 -04:00