8019 Commits

Author	SHA1	Message	Date
Roger Dingledine	926ca5befd	Merge branch 'maint-0.2.1'	2009-09-16 21:28:49 -04:00
Roger Dingledine	7d838971dd	Merge commit 'karsten/no-time-maint-0.2.1'	2009-09-16 20:45:01 -04:00
Roger Dingledine	9eb5edc093	Merge commit 'sebastian/specconformance'	2009-09-16 20:37:43 -04:00
Sebastian Hahn	1aac7de1ea	Fix unit tests and compile issues on Snow Leopard	2009-09-16 17:22:21 -07:00
Mike Perry	e2c2fa7a1f	Change liveness value to be a function of the timeout. ... And also the number of recent circuits used to decide when the network changes.	2009-09-16 17:20:34 -07:00
Mike Perry	e4e0ce94f0	Add log message so we have accurate build time values.	2009-09-16 17:20:34 -07:00
Mike Perry	5bd60d8a41	Address nickm's issues from his review #1.	2009-09-16 17:20:29 -07:00
Mike Perry	0352d43917	Move circuitbuildtimeout config check. ... We want it to be under our control so it doesn't mess up initialization. This is likely the cause for the bug the previous assert-adding commit (09a75ad) was trying to address.	2009-09-16 15:58:42 -07:00
Mike Perry	09a75ad316	Time for some debugging by asserts. ... Got a negative timeout value on startup. Need to narrow it down.	2009-09-16 15:55:51 -07:00
Mike Perry	742e08046f	Fix bugs relating to not counting timeouts as circuit builds. ... Also use bin midpoints for time values.	2009-09-16 15:55:51 -07:00
Mike Perry	67cee75ca2	Document functions and constants.	2009-09-16 15:55:50 -07:00
Mike Perry	c9363df09f	Remove an assert. ... It seems to fire because of precision issues. Added more debug info to the warn to try to figure out for sure.	2009-09-16 15:55:50 -07:00
Mike Perry	63be2df84f	Fix issues found by arma in review.	2009-09-16 15:55:36 -07:00
Roger Dingledine	672e2f6908	space/indent cleanups, plus point out three bugs	2009-09-16 15:55:32 -07:00
Mike Perry	4b3bc714a3	Woops. Fix a couple memory leaks. ... Also change the max timeout quantile to 0.98, so we can avoid huge synthetic timeout values.	2009-09-16 15:54:37 -07:00
Karsten Loesing	b508e4748f	Remove trailing spaces. As if bytes were free... ... Also correct some typos.	2009-09-16 15:52:05 -07:00
Mike Perry	535423a3bb	Resolve mode ties in favor of the higher (slower) mode.	2009-09-16 15:52:04 -07:00
Mike Perry	8210336182	More detail for some log msgs.	2009-09-16 15:52:04 -07:00
Mike Perry	6eba08e22f	Use our variable directly for timeout. ... Using CircuitBuildTimeout is prone to issues with SIGHUP, etc. Also, shuffle the circuit build times array after loading it in so that newer measurements don't replace chunks of similarly timed measurements.	2009-09-16 15:52:04 -07:00
Mike Perry	fca8446949	Fix a couple of assert bugs.	2009-09-16 15:52:03 -07:00
Mike Perry	c4e6b3eadb	Fix timeout edge case when we get enough samples. ... Also switch Xm calculation to mode, not min.	2009-09-16 15:52:03 -07:00
Mike Perry	95735e5478	Fix the math.h log() conflict. ... It was compiling, but causing segfaults. Also, adjust when the timer starts for new test circs and save state every 25 circuits.	2009-09-16 15:51:17 -07:00
Mike Perry	7ac9a66c8f	Recover from changing network connections. ... Also add code to keep creating circuits every minute until we hit our minimum threshhold.	2009-09-16 15:51:16 -07:00
Mike Perry	411b60325b	Factor out the pretimeout handling code. ... We need to also call it if we're going to calculate alpha after a normal circuit build.	2009-09-16 15:51:15 -07:00
Mike Perry	b52bce91fc	Write unit tests and fix issues they uncovered.	2009-09-16 15:51:10 -07:00
Mike Perry	04414830fe	Implement the pareto fitting and timeout calculating bits.	2009-09-16 15:48:52 -07:00
Mike Perry	7750bee21d	Clean up Fallon's partially complete GSoC project. ... The code actually isn't that bad. It's a shame she didn't finish. Using it as the base for this feature.	2009-09-16 15:48:51 -07:00
Roger Dingledine	2dbf5b7741	Merge branch 'tmp'	2009-09-16 17:18:35 -04:00
Sebastian Hahn	dc3229313b	Teach connection_ap_can_use_exit about Exclude*Nodes ... To further attempt to fix bug 1090, make sure connection_ap_can_use_exit always returns 0 when the chosen exit router is excluded. This should fix bug1090.	2009-09-16 02:29:57 +02:00
Nick Mathewson	ed7283d283	Merge commit 'origin/maint-0.2.1' ... Resolved conflicts in: src/or/circuitbuild.c	2009-09-15 19:37:26 -04:00
Nick Mathewson	24c740e5fd	Merge commit 'sebastian/memleak' into maint-0.2.1	2009-09-15 19:35:16 -04:00
Sebastian Hahn	113ba0e727	make some bug 1090 warnings go away ... When we excluded some Exits, we were sometimes warning the user that we were going to use the node regardless. Many of those warnings were in fact bogus, because the relay in question was not used to connect to the outside world. Based on patch by Rotor, thanks!	2009-09-16 01:17:51 +02:00
Nick Mathewson	f9226ae030	Merge commit 'origin/maint-0.2.1'	2009-09-15 12:53:44 -04:00
Sebastian Hahn	b73ecdc232	Fix compile on Snow Leopard	2009-09-15 07:13:36 -04:00
Sebastian Hahn	5e01a86b42	some cleanups: ... documentation fix for get_uint64 remove extra "." from a log line fix a long line	2009-09-15 07:12:12 -04:00
Roger Dingledine	c43859c5c1	Read "circwindow=x" from the consensus and use it ... Tor now reads the "circwindow" parameter out of the consensus, and uses that value for its circuit package window rather than the default of 1000 cells. Begins the implementation of proposal 168.	2009-09-15 06:33:33 -04:00
Roger Dingledine	40bcab1faf	ConsensusParams config option lists key=value params ... finishes the authority-operator interface side of proposal 167.	2009-09-15 04:40:08 -04:00
Nick Mathewson	56c6d78520	Parameter access function, with unit tests.	2009-09-14 23:39:08 -04:00
Nick Mathewson	381766ce4b	Implement proposal 167: Authorities vote on network parameters. ... This code adds a new field to vote on: "params". It consists of a list of sorted key=int pairs. The output is computed as the median of all the integers for any key on which anybody voted. Improved with input from Roger.	2009-09-14 23:21:53 -04:00
Nick Mathewson	0edc39303d	Add a median_int32 and find_nth_int32	2009-09-14 23:21:52 -04:00
Sebastian Hahn	b792afa919	Fix a memory leak when parsing a ns ... Adding the same vote to a networkstatus consensus leads to a memory leak on the client side. Fix that by only using the first vote from any given voter, and ignoring the others. Problem found by Rotor, who also helped writing the patch. Thanks!	2009-09-14 22:25:08 +02:00
Sebastian Hahn	c1a6fb42ac	Fix a spec conformance issue when parsing a ns vote ... A vote may only contain exactly one signature. Make sure we reject votes that violate this. Problem found by Rotor, who also helped writing the patch. Thanks!	2009-09-14 22:06:21 +02:00
Roger Dingledine	86af2ecbda	minor fixes in some comments	2009-09-06 20:09:08 -04:00
Karsten Loesing	995606a7e1	Avoid calling time(NULL) too often. ... Found by "rotator".	2009-09-03 10:17:08 +02:00
Roger Dingledine	fcacf22491	Fix obscure 64-bit big-endian hidserv bug ... Fix an obscure bug where hidden services on 64-bit big-endian systems might mis-read the timestamp in v3 introduce cells, and refuse to connect back to the client. Discovered by "rotor". Bugfix on 0.2.1.6-alpha.	2009-09-02 20:36:11 -04:00
Roger Dingledine	3de5ac9baa	i couldn't break nick's tor_parse_double() ... i guess that means i should call them unit tests and check them in.	2009-09-02 01:10:10 -04:00
Sebastian Hahn	0a71d1c6a7	Fix compile warnings on Snow Leopard ... Big thanks to nickm and arma for helping me with this!	2009-09-01 22:16:46 +02:00
Nick Mathewson	1cda6f3e75	Merge commit 'origin/maint-0.2.1'	2009-09-01 15:59:40 -04:00
Sebastian Hahn	d76fd59a7e	Remove a debug printf	2009-09-01 21:58:11 +02:00
Sebastian Hahn	742788b737	typo	2009-09-01 21:58:06 +02:00
Nick Mathewson	bddda9bbdb	Use an _actual_ fix for the byte-reverse warning. ... (Given that we're pretty much assuming that int is 32 bits, and given that hex values are always unsigned, taking out the "ul" from 0xff000000 should be fine.)	2009-09-01 15:51:09 -04:00
Nick Mathewson	2f0184ece1	Use a simpler fix for the byte-reversing warning	2009-09-01 15:41:38 -04:00
Sebastian Hahn	aea9cf1011	Fix compile warnings on Snow Leopard ... Big thanks to nickm and arma for helping me with this!	2009-09-01 18:36:27 +02:00
Nick Mathewson	cdc8ea2976	Merge commit 'public/bug1076'	2009-09-01 02:01:49 -04:00
Roger Dingledine	075c004095	Add getinfo accepted-server-descriptor. Clean spec. ... Add a "getinfo status/accepted-server-descriptor" controller command, which is the recommended way for controllers to learn whether our server descriptor has been successfully received by at least on directory authority. Un-recommend good-server-descriptor getinfo and status events until we have a better design for them.	2009-08-31 18:37:25 -04:00
Karsten Loesing	da219ee924	Reduce log level for bug case that we now know really exists.	2009-09-01 00:16:33 +02:00
Roger Dingledine	a225469ded	Merge branch 'maint-0.2.1'	2009-08-31 16:26:01 -04:00
Roger Dingledine	4c297f74f7	Only send reachability status events on overall success/failure ... We were telling the controller about CHECKING_REACHABILITY and REACHABILITY_FAILED status events whenever we launch a testing circuit or notice that one has failed. Instead, only tell the controller when we want to inform the user of overall success or overall failure. Bugfix on 0.1.2.6-alpha. Fixes bug 1075. Reported by SwissTorExit.	2009-08-31 16:14:41 -04:00
Nick Mathewson	00b37f071d	Revise parsing of time and memory units to handle spaces. ... When we added support for fractional units (like 1.5 MB) I broke support for giving units with no space (like 2MB). This patch should fix that. It also adds a propoer tor_parse_double(). Fix for bug 1076. Bugfix on 0.2.2.1-alpha.	2009-08-31 00:18:55 -04:00
Karsten Loesing	dd8f16beb5	Avoid segfault when accessing hidden service.	2009-08-29 19:41:08 +02:00
Roger Dingledine	0bb59f1c38	Merge branch 'maint-0.2.1'	2009-08-28 03:47:18 -04:00
Roger Dingledine	64f393d56f	Only send netinfo clock_skew to controller if an authority told us so ... We were triggering a CLOCK_SKEW controller status event whenever we connect via the v2 connection protocol to any relay that has a wrong clock. Instead, we should only inform the controller when it's a trusted authority that claims our clock is wrong. Bugfix on 0.2.0.20-rc; starts to fix bug 1074. Reported by SwissTorExit.	2009-08-28 03:42:09 -04:00
Roger Dingledine	85e22a8adb	bump to 0.2.2.1-alpha-dev	2009-08-27 22:27:31 -04:00
Roger Dingledine	659552a3c6	Merge branch 'maint-0.2.1'	2009-08-27 21:42:58 -04:00
Karsten Loesing	889c07f1fc	When Tor fails to parse a descriptor of any kind, dump it to disk.	2009-08-26 20:15:47 -04:00
Roger Dingledine	5308eceef3	bump to 0.2.2.1-alpha	2009-08-26 15:01:43 -04:00
Nick Mathewson	1d9b8a1e16	Merge commit 'karsten/proposal-166-impl-master'	2009-08-26 11:36:40 -04:00
Nick Mathewson	c9203749a2	A changelog entry and a bit more documentation for socks-client	2009-08-26 11:34:45 -04:00
Nick Mathewson	707a6bd659	Merge commit 'public/socks-client' ... Resolved conflict in: src/or/or.h	2009-08-26 11:27:19 -04:00
Nick Mathewson	903f9ef50e	Clean up a couple of style issues in the socks-client branch.	2009-08-25 10:30:54 -04:00
Karsten Loesing	8c29b7920a	Add some fixes after discussion with Nick. ... - Refactor geoip.c by moving duplicate code into rotate_request_period(). - Don't leak memory when cleaning up cell queues. - Make sure that exit_(streams|bytes_(read|written)) are initialized in all places accessing these arrays. - Read only the last block from *stats files and ensure that its timestamp is not more than 25 hours in the past and not more than 1 hour in the future. - Stop truncating the last character when reading *stats files. The only thing that's left now is to avoid reading whole *stats files into memory.	2009-08-21 23:02:36 +02:00
Nick Mathewson	b51c592547	Refactor geoip_get_dirreq_history() some more. ... This patch avoids a bunch of allocations, and avoids using unallocated memory.	2009-08-21 13:50:32 -04:00
Nick Mathewson	d4a75a222f	Fix a memory leak in summarizing directory request timing. ... Spotted by Coverity Scan.	2009-08-21 13:33:20 -04:00
Nick Mathewson	daa0326aaa	Add the first 8 bytes of the git commit digest to our versions. ... Note that unlike subversion revision numbers, it isn't meaningful to compare these for anything but equality. We define a sort-order anyway, in case one of these accidentally slips into a recommended-versions list.	2009-08-21 12:31:13 -04:00
Roger Dingledine	eb829cc330	Survive unparseable cached cert file	2009-08-20 16:56:21 -04:00
Roger Dingledine	7f518873eb	Notice v3 cert parsing failures ... If any the v3 certs we download are unparseable, we should actually notice the failure so we don't retry indefinitely. Bugfix on 0.2.0.x; reported by "rotator".	2009-08-20 16:50:51 -04:00
Nick Mathewson	5da3b45fdc	Make crypto_digest_get_digest nondestructive again. ... Fixes bug in f57883a39.	2009-08-20 12:03:32 -04:00
Nick Mathewson	9d11827780	Fix a rare infinite-recursion bug when shutting down. ... Once we had called log_free_all(), anything that tried to log a message (like a failed tor_assert()) would fail like this: 1. The logging call eventually invokes the _log() function. 2. _log() calls tor_mutex_lock(log_mutex). 3. tor_mutex_lock(m) calls tor_assert(m). 4. Since we freed the log_mutex, tor_assert() fails, and tries to log its failure. 5. GOTO 1. Now we allocate the mutex statically, and never destroy it on shutdown. Bugfix on 0.2.0.16-alpha, which introduced the log mutex. This bug was found by Matt Edman.	2009-08-20 11:55:33 -04:00
Nick Mathewson	8771fdfda4	Make consensus_method_is_supported() be the canonical source for its info. ... Add a new function to derive the declared method list from consensus_method_is_supported().	2009-08-20 10:04:33 -04:00
Nick Mathewson	d0c212995a	Add a SHA256 implementation for platforms that lack it. ... (This would be everywhere running OpenSSL 0.9.7x and earlier, including all current Macintosh users.) The code is based on Tom St Denis's LibTomCrypt implementation, modified to be way less general and use Tor's existing facilities. I picked this one because it was pretty fast and pretty free, and because Python uses it too.	2009-08-20 01:47:13 -04:00
Nick Mathewson	f57883a39e	Add basic support for SHA256. ... This adds an openssl 0.9.8 dependency. Let's see if anybody cares.	2009-08-19 19:43:54 -04:00
Karsten Loesing	75c59d1a92	Some final (?) cleanups of proposal 166 implementation.	2009-08-19 23:36:27 +02:00
Karsten Loesing	93fd0d3755	Fix a couple of bugs that showed up at runtime.	2009-08-19 19:16:00 +02:00
Karsten Loesing	6592cbe3e1	Don't write extra-info document to debug logs.	2009-08-19 17:15:51 +02:00
Karsten Loesing	42229d1d84	Move all *-stats file to subdirectory stats/.	2009-08-19 17:10:40 +02:00
Karsten Loesing	a5508583ee	Include only the last 24 hours of stats in extra-info documents.	2009-08-19 16:30:00 +02:00
Karsten Loesing	4e29f33427	Write all statistics to disk exactly every 24 hours.	2009-08-19 15:41:12 +02:00
Karsten Loesing	dccadb30cd	Clean up proposal 166 and its implementation.	2009-08-18 15:53:08 +02:00
Karsten Loesing	799af41157	Use memory pool for insertion times.	2009-08-17 13:30:11 +02:00
Karsten Loesing	f37af0180d	Implement queue with O(1) operations, and correct some math.	2009-08-17 13:30:11 +02:00
Karsten Loesing	858a8f809d	Reduce cell statistics accuracy from 1 ms to 10 ms.	2009-08-17 13:30:11 +02:00
Karsten Loesing	20c95a3d21	Fix trivial bug when uploading extra-info documents.	2009-08-17 13:30:10 +02:00
Karsten Loesing	9179bcb923	Include contents of *-stats files in descriptor.	2009-08-17 13:30:10 +02:00
Karsten Loesing	d97e95cb62	Remove ./configure option for cell statistics.	2009-08-17 13:30:09 +02:00
Karsten Loesing	ab7729f472	Remove ./configure option for entry and dir request statistics.	2009-08-17 13:29:50 +02:00
Nick Mathewson	b9e45cc508	Merge commit 'mikeperry/bandwidth-voting-final'	2009-08-14 17:12:05 -04:00
Karsten Loesing	9d16a59fcc	Remove ./configure option for exit port statistics.	2009-08-14 14:56:38 +02:00
Nick Mathewson	e0dc2e907e	Merge commit 'origin/maint-0.2.1'	2009-08-12 22:02:07 -04:00
Karsten Loesing	a98643c1b5	Fix possible segmentation fault on directory authorities. ... The more verbose logs that were added in ee58153 also include a string that might not have been initialized. This can lead to segfaults, e.g., when setting up private Tor networks. Initialize this string with NULL.	2009-08-11 17:33:58 +02:00
Roger Dingledine	afc9da7287	Merge branch 'maint-0.2.1'	2009-08-10 04:17:32 -04:00
Roger Dingledine	e50b7768b9	Send sendmes when we're down 100 cells, not 101. ... Send circuit or stream sendme cells when our window has decreased by 100 cells, not when it has decreased by 101 cells. Bug uncovered by Karsten when testing the "reduce circuit window" performance patch. Bugfix on the 54th commit on Tor -- from July 2002, before the release of Tor 0.0.0. This is the new winner of the oldest-bug prize.	2009-08-10 04:13:18 -04:00
Roger Dingledine	5f0fb9a109	Merge branch 'maint-0.2.1' into tmp_merge	2009-08-10 01:37:29 -04:00
Roger Dingledine	8abe3bac7e	Set up urras as the seventh v3 directory authority.	2009-08-10 01:32:51 -04:00
Mike Perry	9e1fe29beb	Switch over to tor_strtok_r instead of strtok_r.	2009-08-09 18:42:29 -07:00
Mike Perry	cb477f9cc0	Merge commit 'nickm/strtok' into mp-voting-final	2009-08-09 18:23:53 -07:00
Mike Perry	1060b4d824	Fix issues found by Nick in code review.	2009-08-09 18:21:15 -07:00
Nick Mathewson	3886467f38	Add a new tor_strtok_r for platforms that don't have one, plus tests. ... I don't think we actually use (or plan to use) strtok_r in a reentrant way anywhere in our code, but would be nice not to have to think about whether we're doing it.	2009-08-09 17:30:15 -07:00
Jacob Appelbaum	33762b5296	LetsKillNoConnect removes support for .noconnect ... This is a patch to remove support for .noconnect. We are removing .noconnect because of a talk at Defcon 17 by Gregory Fleischer.	2009-08-08 19:15:22 -07:00
Roger Dingledine	3e4379c2e7	Disable .exit notation unless AllowDotExit is 1.	2009-08-07 19:26:41 -04:00
Mike Perry	ca676c3924	Display consensus bandwidth to the control port. ... Also div vote and other bandwidth by 1000, not 1024.	2009-08-06 14:47:08 -07:00
Mike Perry	b074e61ad3	Throw the switch on consensus method 6.	2009-08-06 14:47:04 -07:00
Roger Dingledine	da88e05edc	try loading the bandwidth measurement file on startup too, ... in case it's broken.	2009-08-06 11:48:03 -07:00
Mike Perry	6fbdf635fa	Implement measured bw parsing + unit tests.	2009-08-06 11:48:03 -07:00
Nick Mathewson	df354a002c	Merge commit 'origin/maint-0.2.1' ... Resolved onflicts in: ChangeLog src/or/config.c src/or/or.h	2009-07-30 10:16:04 -04:00
Nick Mathewson	4577bda766	Cleaner fix for get_effective_bw(rate|burst), with comment on why it is ok.	2009-07-30 10:14:12 -04:00
Nick Mathewson	efe966944d	Fix signed/unsigned comparison warnings in get_effective_bw(rate|burst)	2009-07-30 09:15:07 -04:00
Roger Dingledine	6249b0fd77	Fix a signed/unsigned compile warning in 0.2.1.19	2009-07-28 18:34:35 -04:00
Roger Dingledine	e8e88922a7	Merge branch 'maint-0.2.1' into master	2009-07-28 18:19:57 -04:00
Roger Dingledine	69706f99e8	bump to 0.2.1.19	2009-07-28 17:39:51 -04:00
Sebastian Hahn	3e45445104	Changing MaxAdvertisedBW may not need a republish ... Relays no longer publish a new server descriptor if they change their MaxAdvertisedBandwidth config option but it doesn't end up changing their advertised bandwidth numbers. Bugfix on 0.2.0.28-rc; fixes bug 1026. Patch from Sebastian.	2009-07-27 23:53:06 -04:00
Roger Dingledine	a73acdd46f	Write fingerprint to file and log without spaces ... Now it will look like the fingerprints in our bridges documentation, and confuse fewer users.	2009-07-27 22:51:20 -04:00
Roger Dingledine	0a4e2397c0	Don't leak memory if we get too many create cells ... Specifically, every time we get a create cell but we have so many already queued that we refuse it. Bugfix on 0.2.0.19-alpha; fixes bug 1034. Reported by BarkerJr.	2009-07-27 22:38:09 -04:00
Roger Dingledine	2b63fa40e8	three hacks to workaround bug 1038 ... The problem is that clients and hidden services are receiving relay_early cells, and they tear down the circuit. Hack #1 is for rendezvous points to rewrite relay_early cells to relay cells. That way there are never any incoming relay_early cells. Hack #2 is for clients and hidden services to never send a relay_early cell on an established rendezvous circuit. That works around rendezvous points that haven't upgraded yet. Hack #3 is for clients and hidden services to not tear down the circuit when they receive an inbound relay_early cell. We already refuse extend cells at clients.	2009-07-27 21:58:32 -04:00
Karsten Loesing	7b716878cb	Fix dirreq and cell stats on 32-bit architectures. ... When determining how long directory requests take or how long cells spend in queues, we were comparing timestamps on microsecond detail only to convert results to second or millisecond detail later on. But on 32-bit architectures this means that 2^31 microseconds only cover time differences of up to 36 minutes. Instead, compare timestamps on millisecond detail.	2009-07-27 16:23:53 +02:00
Nick Mathewson	2b0e8fb39f	Merge commit 'ioerror/DirFetchInfoExtraEarly' ... Conflicts: ChangeLog	2009-07-25 00:52:54 -04:00
Roger Dingledine	52b142219b	bump to 0.2.1.18	2009-07-24 17:31:04 -04:00
Karsten Loesing	f80537e3e0	Fix unit tests. ... Now that we require EntryStatistics to be 1 for counting connecting clients, unit tests need to set that config option, too. Reported by Sebastian Hahn.	2009-07-24 01:13:33 +02:00
Sebastian Hahn	5c0b418a6f	don't warn about DirReqStatistics when the option is disabled ... Reported by Zax on #tor	2009-07-23 13:50:18 +02:00
Karsten Loesing	b71bbdc69a	Make exit stats compile on 64-bit machines, too.	2009-07-18 10:35:20 -04:00
Roger Dingledine	c0a2d7dc73	Clean up the accountingmax section in torrc.sample ... Also, suggest a default of 4GB/day (46KB/s) rather than 1GB/day (11.5KB/s). No use asking low.	2009-07-16 17:15:59 -04:00
Nick Mathewson	022d251cb7	Merge branch 'dirreq-timing'	2009-07-16 15:26:07 -04:00
Nick Mathewson	cbe4327391	Switch dirreq_map to use HT_ functions rather than strmap.	2009-07-16 15:26:01 -04:00
Nick Mathewson	82795eebb7	Include AccountingMax in torrc.sample ... "There's room for one more till the end of creation." -- _Sandman_ (Based on patch from David [edeca]. Closes bug 1036.)	2009-07-16 14:02:07 -04:00
Sebastian Hahn	989e74e5c0	fix long line	2009-07-15 17:26:11 +02:00
Karsten Loesing	8c496d1660	Some tweaks to statistics. ... Changes to directory request statistics: - Rename GEOIP statistics to DIRREQ statistics, because they now include more than only GeoIP-based statistics, whereas other statistics are GeoIP-dependent, too. - Rename output file from geoip-stats to dirreq-stats. - Add new config option DirReqStatistics that is required to measure directory request statistics. - Clean up ChangeLog. Also ensure that entry guards statistics have access to a local GeoIP database.	2009-07-15 16:32:40 +02:00
Karsten Loesing	416940d93b	Some tweaks to directory request download times. ... - Use common prefixes DIRREQ_* and dirreq_*. - Replace enums in structs with bitfields.	2009-07-15 16:14:14 +02:00
Karsten Loesing	85e7f67e1c	Round up results to the next multiple of 4.	2009-07-15 16:12:45 +02:00
Karsten Loesing	4002980d1c	Right, the u in uint stands for unsigned.	2009-07-15 16:12:45 +02:00
Karsten Loesing	3c05132575	Directories now also measure download times of network statuses.	2009-07-15 16:12:45 +02:00
Nick Mathewson	d4b31cf98f	Allow interval and memunit cfg variables to be set to fractions.	2009-07-15 10:02:49 -04:00
Roger Dingledine	05975e2a89	make it compile without warnings	2009-07-14 14:13:04 -04:00
Nick Mathewson	31b72732c6	Merge commit 'karsten/geoipstats-download-resp-master' ... Conflicts: src/or/geoip.c	2009-07-14 12:18:27 -04:00
Nick Mathewson	e90843eb68	Merge commit 'karsten/geoipstats-shares-master'	2009-07-14 12:15:24 -04:00
Nick Mathewson	49136bb18f	Merge commit 'karsten/geoipstats-newoverthereistan-master'	2009-07-14 12:14:19 -04:00
Karsten Loesing	409386cede	Handle unsigned ints correctly.	2009-07-14 01:50:55 +02:00
Karsten Loesing	59dd9de858	Write number of rejected requests to geoip-stats file.	2009-07-14 01:46:17 +02:00
Jacob Appelbaum	e7576f92de	Add support for a new option: FetchDirInfoExtraEarly ... This new option will allow clients to download the newest fresh consensus much sooner than they normally would do so, even if they previously set FetchDirInfoEarly. This includes a proper ChangeLog entry and an updated man page.	2009-07-13 16:30:42 -07:00
Roger Dingledine	b48e3371d7	remove experimental 'getinfo unregistered-servers-' ... it never really worked, and hasn't been used for years.	2009-07-13 17:34:47 -04:00
Roger Dingledine	9ece0955f7	fix comments and other typos	2009-07-13 17:34:46 -04:00
Karsten Loesing	8f1a973669	Two tweaks to exit-port statistics. ... Add two functions for round_to_next_multiple_of() for uint32_t and uint64_t. Avoid division in every step of the loop over all ports.	2009-07-13 22:43:06 +02:00
Karsten Loesing	707a44a7b0	Replace two %d with %u's.	2009-07-13 22:11:21 +02:00
Karsten Loesing	d1437245c7	Simplify the math to round up to the next multiple of some value.	2009-07-11 00:44:27 +02:00
Karsten Loesing	7fb206e554	Tweak exit port statistics a bit. ... Introduce a threshold of 0.01% of bytes that must be read and written per port in order to be included in the statistics. Otherwise we cannot include these statistics in extra-info documents, because they are too big. Change the labels "-written" and "-read" so that the meanings are as intended.	2009-07-09 23:55:13 +02:00
Karsten Loesing	fa2374a163	List unresolved requests in geoip stats as country '??'.	2009-07-09 15:34:53 +02:00
Nick Mathewson	041a7b9896	Merge commit 'karsten/entrystats-master' ... Conflicts: ChangeLog configure.in src/or/config.c src/or/or.h	2009-07-07 14:26:50 -04:00
Nick Mathewson	1c1b223910	Merge commit 'karsten/bufferstats-master'	2009-07-07 13:21:33 -04:00
Nick Mathewson	aa0cf31c51	Merge commit 'origin/maint-0.2.1' ... Conflicts: ChangeLog configure.in contrib/tor-mingw.nsi.in src/win32/orconfig.h	2009-07-07 12:42:24 -04:00
Nick Mathewson	d996b7463e	Bump version to 0.2.1.17-rc-dev	2009-07-07 12:39:35 -04:00
Nick Mathewson	32d4060724	Bump version to 0.2.1.17-rc	2009-07-07 12:22:46 -04:00
Nick Mathewson	258b980331	Make "Invalid onion hostname" msg respect SafeLogging. ... Patch by Roger; fixes bug 1027.	2009-07-07 12:19:04 -04:00
Karsten Loesing	c0b6cb132b	If configured, write entry-node statistics to disk periodically.	2009-07-05 20:48:16 +02:00
Karsten Loesing	b493a2ccb9	If configured, write cell statistics to disk periodically.	2009-07-05 19:53:25 +02:00
Karsten Loesing	c1f6c2ba30	Estimate v2 and v3 shares as mean values over measurement interval.	2009-07-04 22:17:08 +02:00
Karsten Loesing	4d6af73db8	If configured, write per-port exit statistics to disk periodically. ... [Original patch series from Karsten, revised and squashed by Nick]	2009-07-02 12:37:05 -04:00
Nick Mathewson	078c34e28e	Merge commit 'origin/maint-0.2.1' ... [Didn't take Karsten's full bug 1024 workaround, since 0.2.2 doesn't use v0 rend descs.]	2009-07-02 10:20:20 -04:00
Karsten Loesing	3e6bb050dd	Make an attempt to fix bug 1024. ... The internal error "could not find intro key" occurs when we want to send an INTRODUCE1 cell over a recently finished introduction circuit and think we built the introduction circuit with a v2 hidden service descriptor, but cannot find the introduction key in our descriptor. My first guess how we can end up in this situation is that we are wrong in thinking that we built the introduction circuit based on a v2 hidden service descriptor. This patch checks if we have a v0 descriptor, too, and uses that instead.	2009-07-02 10:00:28 -04:00
Roger Dingledine	690db1331d	another minor patch to add to 0.2.1.x ... o Minor features: - If we're a relay and we change our IP address, be more verbose about the reason that made us change. Should help track down further bugs for relays on dynamic IP addresses.	2009-06-30 10:21:30 -04:00
Nick Mathewson	9f28cfe86a	Merge commit 'origin/maint-0.2.1'	2009-06-30 10:13:51 -04:00
Roger Dingledine	e7bc189f7c	the third piece of bug 969 fixing ... when we write out our stability info, detect relays that have slipped through the cracks. log about them and correct the problem. if we continue to see a lot of these over time, it means there's another spot where relays fall out of the routerlist without being marked as unreachable.	2009-06-30 10:10:13 -04:00
Roger Dingledine	bdca5476da	the second piece of bug 969 fixing ... whenever we remove a relay from the main routerlist, tell the rephist module that it's no longer running.	2009-06-30 10:10:13 -04:00
Roger Dingledine	0cd16c4ad3	the first piece of bug 969 fixing ... tell the rephist module that a given relay is down whenever we determine that it's down, not just when we thought it used to be up.	2009-06-30 10:10:13 -04:00
Nick Mathewson	7ce767181f	Have eventdns set the "truncated" bit correctly. ... Fixed bug 1022; This isn't actually a live bug in Tor, since in Tor we never generate large DNS replies.	2009-06-30 10:05:42 -04:00
Nick Mathewson	f466f3d12c	Merge commit 'sebastian/geoipnotice'	2009-06-25 12:09:57 -04:00
Sebastian Hahn	38476e2555	Log a notice about collecting geoip stats	2009-06-25 18:06:52 +02:00
Roger Dingledine	9fc3d87827	stop capping bandwidths we see in the consensus ... but continue capping bandwidths we see in local server descriptors, if we have no consensus weights for them.	2009-06-25 11:38:05 -04:00
Nick Mathewson	d2cac1afc3	Merge commit 'origin/maint-0.2.1'	2009-06-24 19:02:00 -04:00
Marcus Griep	d308738919	Ignore control port commands after a QUIT ... When a QUIT has been issued on a control port connection, then ignore further commands on that port. This fixes bug 1016.	2009-06-24 00:10:22 -04:00
Marcus Griep	fa89c9f086	Flush long replies over control port on QUIT ... Marks the control port connection for flushing before closing when the QUIT command is issued. This allows a QUIT to be issued during a long reply over the control port, flushing the reply and then closing the connection. Fixes bug 1015.	2009-06-24 00:10:20 -04:00
Nick Mathewson	39551b494e	Merge commit 'origin/maint-0.2.1'	2009-06-22 14:08:19 -04:00
Roger Dingledine	1aaab8288d	Clients now use bandwidth values in the consensus ... rather than the bandwidth values in each relay descriptor. This approach opens the door to more accurate bandwidth estimates once the directory authorities start doing active measurements. Implements more of proposal 141.	2009-06-22 14:01:34 -04:00
Nick Mathewson	3f4f6f9075	Merge commit 'origin/maint-0.2.1' ... Conflicts: ChangeLog	2009-06-22 12:36:06 -04:00
Nick Mathewson	262455527a	Serve DirPortFrontPage even if the write bucket is low. ... arma's rationale: "I think this is a bug, since people intentionally set DirPortFrontPage, so they really do want their relay to serve that page when it's asked for. Having it appear only sometimes (or roughly never in Sebastian's case) makes it way less useful." Fixes bug 1013; bugfix on 0.2.1.8-alpha.	2009-06-22 12:34:32 -04:00
Karsten Loesing	e6a1e7001b	Add warning that the results of --enable-geoip-stats are different from those in master.	2009-06-22 11:51:19 -04:00
Nick Mathewson	da416d9884	Bump version to 0.2.1.16-rc.dev	2009-06-20 21:54:56 -04:00
Nick Mathewson	ac3dedacce	Bump version to 0.2.1.16-rc	2009-06-20 01:14:07 -04:00
Nick Mathewson	659fc13da5	Change proxy-address type to tor_addr_t to allow ipv6 proxies.	2009-06-19 12:48:00 -04:00
Nick Mathewson	015189b5df	Move SOCKS reason-decoding switches into reasons.c	2009-06-19 12:40:23 -04:00
Christopher Davis	75472c19c3	Enable Tor to connect through SOCKS 4/5 proxies ... Added a sanity check in config.c and a check in directory.c directory_initiate_command_rend() to catch any direct connection attempts when a socks proxy is configured.	2009-06-19 12:16:15 -04:00
Karsten Loesing	f266ecbeec	Better fix for 997.	2009-06-19 16:26:02 +02:00
Karsten Loesing	20883f5e83	Revert "Backport fix for bug 997." ... This reverts commit 3847f54945.	2009-06-19 15:46:13 +02:00
Nick Mathewson	aa88c8d91a	Merge commit 'origin/maint-0.2.1'	2009-06-18 11:10:27 -04:00
Nick Mathewson	298dc95dfd	tor-resolve: Don't automatically refuse .onion addresses. ... If the Tor is running with AutomapHostsOnResolve set, it _is_ reasonable to do a DNS lookup on a .onion address. So instead we make tor-resolve willing to try to resolve anything. Only if Tor refuses to resolve it do we suggest to the user that resolving a .onion address may not work. Fix for bug 1005.	2009-06-18 11:08:10 -04:00
Nick Mathewson	94e8c34cb7	Set EV_PERSIST flag on signal events with Libevent < 2.0. ... Fix for bug 1007.	2009-06-18 10:07:26 -04:00
Nick Mathewson	df03d6eca8	Merge commit 'karsten/bug997-hidservfetch'	2009-06-16 16:26:02 -04:00
Karsten Loesing	3847f54945	Backport fix for bug 997. ... Backporting 6a32beb and ca8708a.	2009-06-16 16:25:35 -04:00
Nick Mathewson	0d2976d64b	Merge commit 'origin/maint-0.2.1'	2009-06-16 16:18:16 -04:00
Nick Mathewson	7f8a6c5e92	Revise earlier check for correct IPv4 addr length to check for ==4. ... We need this to match the check in connection_ap_handshake_socks_resolved(). Found by optimist.	2009-06-16 16:12:06 -04:00
Sebastian Hahn	0caf8dd0b6	Fix bug 1001 ... For compatibility with Libevent2, tor_event_new should accept a NULL base without crashing.	2009-06-16 17:30:08 +02:00
Karsten Loesing	ca8708a9ce	Fix more of bug 997. ... Fix refetching of hidden service descriptors when all introduction points have turned out to not work.	2009-06-13 12:21:58 +02:00
Nick Mathewson	74bf885b2d	Whitespace and osx fixes on libevent2 patch.	2009-06-12 15:09:09 -04:00
Nick Mathewson	1e709c79d1	Isolate Libevent API dependency to just main.c and dns.c in src/or. ... The rest of the code was only including event.h so that it could see EV_READ and EV_WRITE, which we were using as part of the connection_watch_events interface for no very good reason.	2009-06-12 14:27:53 -04:00
Nick Mathewson	33b1d714e7	Make Tor compile with Libevent 1.0 again.	2009-06-12 14:27:53 -04:00
Nick Mathewson	c0af3cdfb6	Move the Libvent setup logic into compat_libevent from config. ... This has been some pretty ugly and voodoo-laden code. I've tried to clean it up a bit, but more work probably remains.	2009-06-12 14:27:52 -04:00
Nick Mathewson	e5b88dc83f	Update Tor to use Libevent 2.0 APIs when available. ... This patch adds a new compat_libevent.[ch] set of files, and moves our Libevent compatibility and utilitity functions there. We build them into a separate .a so that nothing else in src/commmon depends on Libevent (partially fixing bug 507). Also, do not use our own built-in evdns copy when we have Libevent 2.0, whose evdns is finally good enough (thus fixing Bug 920).	2009-06-12 14:27:52 -04:00
Roger Dingledine	845326317d	Check answer_len in the remap_addr case of process_relay_cell_not_open. ... Fix an edge case where a malicious exit relay could convince a controller that the client's DNS question resolves to an internal IP address. Bug found and fixed by "optimist"; bugfix on 0.1.2.8-beta.	2009-06-12 11:22:54 -04:00
Roger Dingledine	cb1617f18e	Check answer_len in the remap_addr case of process_relay_cell_not_open. ... Fix an edge case where a malicious exit relay could convince a controller that the client's DNS question resolves to an internal IP address. Bug found and fixed by "optimist"; bugfix on 0.1.2.8-beta.	2009-06-12 11:18:02 -04:00
Karsten Loesing	6a32beb877	Apply fix for bug 997. ... Hidden service clients didn't use a cached service descriptor that was older than 15 minutes, but wouldn't fetch a new one either. Now, use a cached descriptor no matter how old it is and only fetch a new one when all introduction points fail. Fix for bug 997. Patch from Marcus Griep.	2009-06-12 11:39:35 +02:00
Karsten Loesing	77f5ad6b07	Restore changes from f79688d that got lost somehow during a merge.	2009-06-12 02:05:21 +02:00
Nick Mathewson	358efe1eea	Merge commit 'origin/maint-0.2.1'	2009-06-08 00:01:31 -04:00
Nick Mathewson	20193fc7ab	Avoid a memory corruption problem related to "private" in DirPolicy. ... This is a posible fix for bug 996.	2009-06-05 19:41:40 -04:00
Nick Mathewson	4945fee65a	Merge commit 'origin/maint-0.2.1'	2009-06-04 03:31:12 -04:00
Karsten Loesing	48bf1d97ee	Update the rest of the geoip file.	2009-06-04 00:47:58 +02:00
Nick Mathewson	0b23035e43	Update the geoip file	2009-06-03 17:35:41 -04:00
Nick Mathewson	b262e76563	Fix gprof bottlenecks on exit nodes found by Jacob. ... Apparently all the stuff that does a linear scan over all the DNS cache entries can get really expensive when your DNS cache is very large. It's hard to say how much this will help performance, since gprof doesn't count time spent in OpenSSL or zlib, but I'd guess 10%. Also, this patch removes calls to assert_connection_ok() from inside the read and write callbacks, which are similarly unneeded, and a little costlier than I'm happy with. This is probably worth backporting to 0.2.0.	2009-06-03 13:52:03 -04:00
Nick Mathewson	77ffd6b2a7	Merge commit 'origin/maint-0.2.1'	2009-05-31 19:17:22 -04:00
Nick Mathewson	c4c7dcd453	Do not report a node as a "chosen exit" when it is not in fact an exit. ... Provide a useful warning when launch_circuit tries to make us use a node we don't want to use. Just give an info message when this is a normal and okay situation. Fix for logging issues in bug 984.	2009-05-31 19:15:36 -04:00
Nick Mathewson	e8ac2a8477	Make the second argument to routerset_contains_extendinfo const	2009-05-31 19:15:36 -04:00
Nick Mathewson	e84ddead34	Merge branch 'hardware_accel_improvements'	2009-05-31 13:36:50 -04:00
Nick Mathewson	3ca10bb62f	Fix-ups for dynamic OpenSSL engine patch. ... Include a changelog, and don't try to compare strings with !=.	2009-05-31 13:36:18 -04:00
Nick Mathewson	fd992deeea	Don't attempt to log messages to a controller from a worker thread. ... This patch adds a function to determine whether we're in the main thread, and changes control_event_logmsg() to return immediately if we're in a subthread. This is necessary because otherwise we will call connection_write_to_buf, which modifies non-locked data structures. Bugfix on 0.2.0.x; fix for at least one of the things currently called "bug 977".	2009-05-30 18:16:24 -04:00
Karsten Loesing	dfebc88d56	Warn and exit when we are configured to measure GeoIP statistics, but have no GeoIP database.	2009-05-30 23:35:21 +02:00
Nick Mathewson	d66c379765	Clean up a bit of C logic, and fix an erroneous warning. ... (Simplify "if (cond) return 1; return 0;" to "return cond;", and don't give a warning when we start with accounting on but dirport off.)	2009-05-29 23:28:01 -04:00
Sebastian Hahn	e70fe116d3	Consider *ListenAddress when warning about low ports and hibernation ... Tas (thanks!) noticed that when *ListenAddress is set, Tor would still warn on startup when *Port is low and hibernation is active. The patch parses all the *ListenAddress lines, and checks the ports. Bugfix on 0.2.1.15-rc	2009-05-30 03:09:39 +02:00
Nick Mathewson	3599e9051e	Restore changes from Karsten's "Remove unused rendversion parameters". ... These were made undone by a merge.	2009-05-28 16:19:05 -04:00
Nick Mathewson	4913a8c4ba	Merge commit 'origin/maint-0.2.1'	2009-05-28 16:07:49 -04:00
Nick Mathewson	873faffb5a	Two more spelling fix fixes.	2009-05-28 12:26:17 -04:00
Nick Mathewson	260de44313	Fixes to spelling fixes. Thanks, Roger!	2009-05-28 12:22:48 -04:00
Nick Mathewson	cb18fc2190	Merge commit 'origin/maint-0.2.1'	2009-05-27 18:12:18 -04:00
Karsten Loesing	d49711e52c	Fix unit tests that were broken after last fix of #932. ... With the last fix of task 932 (5f03d6c), client requests are only added to the history when they happen after the start of the current history. This conflicts with the unit tests that insert current requests first (defining the start of the client request history) followed by requests in the past. The fix is to insert requests in chronological order in the unit tests.	2009-05-27 18:04:55 -04:00
Nick Mathewson	ec7e054668	Spell-check Tor.	2009-05-27 17:55:51 -04:00
Nick Mathewson	f0453c45c8	Spelling fixes in comments and strings	2009-05-27 16:36:13 -04:00
Nick Mathewson	0e2618dd54	Merge commit 'origin/maint-0.2.1'	2009-05-27 14:20:18 -04:00
Nick Mathewson	181674e9bb	Fix a signed/unsigned comparison warning	2009-05-27 14:19:24 -04:00
Karsten Loesing	54c97c9133	Change the way how directories that are configured with --enable-geoip-stats write geoip stats to disk. ... - Write geoip stats to disk every 24 hours, not every hour. - Remove configuration options and define reasonable defaults. - Clear history of client requests every 24 hours (which wasn't done at all before).	2009-05-27 19:13:31 +02:00
Karsten Loesing	02a417d4e0	Improve documentation for the last fix of bug 932.	2009-05-27 19:10:55 +02:00
Karsten Loesing	5f03d6c547	Fix bug 932 even more. ... Ignore connections two hours after switching from bridge to relay or back.	2009-05-27 19:10:54 +02:00
Karsten Loesing	bf7e5d6553	Some cleanups on geoip.c. ... Use two bitfields for last_seen and action in clientmap_entry_t rather than having both share a 32-bit. Also, documentation fixes.	2009-05-26 21:32:56 +02:00
Nick Mathewson	b805e5debf	Merge commit 'origin/maint-0.2.1' into master. ... Conflicts: ChangeLog configure.in contrib/tor-mingw.nsi.in src/win32/orconfig.h	2009-05-25 16:43:52 -04:00
Nick Mathewson	99c315a473	Use tor_socket_strerror in eventdns.c. Fixes bug 987.	2009-05-25 16:38:50 -04:00
Nick Mathewson	f334297d38	Bump version to 0.2.1.15-rc-dev.	2009-05-25 16:32:47 -04:00
Roger Dingledine	2f39eca28b	bump to 0.2.1.15-rc	2009-05-25 13:23:08 -04:00
Nick Mathewson	3b47be20ec	Update newer control_event_stream_bandwidth code to revised control impl	2009-05-25 12:55:59 -04:00
Nick Mathewson	b998fed9b9	Remove support for events without the extended format or long names. ... Supporting the old formats made our code complex; running without them has been discouraged since 0.2.1.x.	2009-05-25 12:52:25 -04:00
Roger Dingledine	05e55d82b6	simplify options_act()	2009-05-24 20:31:50 -04:00
Roger Dingledine	9a4b0446b0	fix a comment	2009-05-24 20:31:50 -04:00
Sebastian Hahn	f26abf5f54	fix codestyle issues	2009-05-24 02:42:37 +02:00
Martin Peck	7703b887f5	Add support for dynamic OpenSSL hardware crypto acceleration engines.	2009-05-23 16:42:44 -07:00
Jacob Appelbaum	75f963e951	Log the number and size of DNS cache entries on SIGUSR1. ... Specifically if you send SIGUSR1, it will add two lines to the log file: May 22 07:41:59.576 [notice] Our DNS cache has 3364 entries. May 22 07:41:59.576 [notice] Our DNS cache size is approximately 1022656 bytes. [tweaked a bit by nickm]	2009-05-22 23:33:44 -04:00
Nick Mathewson	793e97bb2a	Add a quick macro to calculate hashtable memory usage	2009-05-22 23:30:52 -04:00
Nick Mathewson	a3fadddd4a	Improved bug-957 fix for 0.2.2. ... Really, our idiocy was that we were calling event_set() on the same event more than once, which sometimes led to us calling event_set() on an event that was already inserted, thus making it look uninserted. With this patch, we just initialize the timeout events when we create the requests and nameservers, and we don't need to worry about double-add and double-del cases at all.	2009-05-22 14:06:39 -04:00
Nick Mathewson	4201a3735f	Merge commit 'origin/maint-0.2.1'	2009-05-22 11:56:51 -04:00
Nick Mathewson	1d002a25a2	Finish up the 0.2.1 version of the bug 957 fix. ... Basically, all this means is downgrading our warning messages to debug messages, since the bug workaround code here is adequate to stop the bug.	2009-05-22 11:47:09 -04:00
phobos	678092750b	fix a spelling mistake in config.c for "contries"	2009-05-22 01:26:17 -04:00
Nick Mathewson	79762aac17	Merge commit 'origin/maint-0.2.1'	2009-05-18 16:17:12 -04:00
Nick Mathewson	34030a3d23	Possible fix for crash bug related to event timeouts. [Bug 957] ... If we ever add an event, then set it, then add it again, there will be now two pointers to the event in the event base. If we delete one and free it, the first pointer will still be there, and possibly cause a crash later. This patch adds detection for this case to the code paths in eventdns.c, and works around it. If the warning message ever displays, then a cleverer fix is in order. {I am not too confident that this *is* the fix, since bug 957 is very tricky. If it is, it is a bugfix on 0.2.0.}	2009-05-18 16:12:39 -04:00
Nick Mathewson	14a549552a	Merge branch 'maint-0.2.1' into merge_tmp	2009-05-17 02:11:34 -04:00
Roger Dingledine	2fa5410218	Fix a memory leak when v3 directory authorities load their keys ... and cert from disk. Bugfix on 0.2.0.1-alpha.	2009-05-17 02:04:59 -04:00
Nick Mathewson	c0515b307c	Fix valgrind error when marking a descriptor as never-downloadable. ... When we got a descriptor that we (as an authority) rejected as totally bad, we were freeing it, then using the digest in its RAM to look up its download status. Caught by arma with valgrind. Bugfix on 0.2.1.9-alpha.	2009-05-17 02:01:09 -04:00
Nick Mathewson	11b9c839f0	Stop using malloc_usable_size(): valgrind hates it.	2009-05-17 01:55:02 -04:00
Nick Mathewson	e563874045	Merge commit 'origin/maint-0.2.1'	2009-05-17 00:05:38 -04:00
Nick Mathewson	9f25a5529a	Fix an assertion-failure in memarea_alloc() on 64-bit platforms. ... The trick is that we should assert that our next_mem pointer has not run off the end of the array _before_ we realign the pointer, since doing that could take us over the end... but only if we're on a system where malloc() gives us ram in increments smaller than sizeof(void*).	2009-05-17 00:02:59 -04:00
Mike Perry	29bf271ba2	Fix misreporting of stream bandwidths.	2009-05-14 17:52:26 -04:00
potentiate	1b61c8bf37	Fix misreporting of stream bandwidths.	2009-05-14 17:50:06 -04:00
Nick Mathewson	479d21254a	Merge commit 'origin/maint-0.2.1'	2009-05-13 16:55:42 -04:00
Nick Mathewson	a38ed1a235	Use | with flags, not +.	2009-05-13 16:45:59 -04:00
Karsten Loesing	9e97067b2f	Prevent bridges from publishing router descriptors. ... Bridges are not supposed to publish router descriptors to the directory authorities. It defeats the point of bridges when they are included in the public relay directory. This patch puts out a warning and exits when the node is configured as a bridge and to publish v1, v2, or v3 descriptors at the same time. Also fixes part of bug 932.	2009-05-13 16:45:59 -04:00
Nick Mathewson	fc091e8a96	When our bridge status changes, forget old geoip data. ... This fixes bug 932, where all of our usage totals for users when we were a regular server would get included in the extrainfo document.	2009-05-13 16:45:59 -04:00
Nick Mathewson	c36efb0c45	Use a mutex to protect the count of open sockets. ... This matters because a cpuworker can close its socket when it finishes. Cpuworker typically runs in another thread, so without a lock here, we can have a race condition and get confused about how many sockets are open. Possible fix for bug 939.	2009-05-13 09:38:48 -04:00
Nick Mathewson	d9650cfa50	Add sentinel values to the end of memarea chunks. ... This might detect some possible causes of bug 930, and will at least make sure we aren't doing some dumb memory-corruption stuff with the heap and router-parsing.	2009-05-12 15:10:23 -04:00
Nick Mathewson	a271c5370a	Merge commit 'origin/maint-0.2.1' into m3	2009-05-12 14:04:51 -04:00
Sebastian Hahn	a28215a150	Warn when hibernation and low-port on non-windows is configured ... This addresses the first part of bug 918. Users are now warned when they try to use hibernation in combination with a port below 1024 when they're not on Windows. We don't want to die here, because people might run Tor as root, use a capabilities system or some other platform that will allow them to re-attach low ports. Wording suggested by Marian	2009-05-12 20:00:00 +02:00
Nick Mathewson	5fc08d1920	Merge 0.2.1 onto the development branch. ... Manually resolved conflicts on version number; all else applied cleanly.	2009-05-12 13:57:58 -04:00
Nick Mathewson	88d81ead83	Better debugging output for bug 977 case. ... (Don't crash immediately if we have leftover chunks to free after freeing chunks in a buffer freelist; instead log a debugging message that might help.)	2009-05-12 13:54:21 -04:00
Nick Mathewson	fdbdb4dc15	Include the *_sha1.i files in their own *_codedigest.c files. ... This way we do not need to rebuild util.c and/or config.c whenever any unrelated source file in src/common or src/or has changed.	2009-05-08 12:35:36 -04:00
Sebastian Hahn	b9b16ef9a5	Add a missing newline	2009-05-05 11:12:41 -04:00
Sebastian Hahn	d230827912	Remove all svn metadata minus what I missed. ... Tor doesn't use SVN anymore, making $Revision$, $Id$ and $Date$ meaningless. Remove them without replacement.	2009-05-05 17:05:46 +02:00
Karsten Loesing	948835c680	Remove unused rendversion parameters. YAGNI.	2009-05-04 13:46:30 -04:00
Karsten Loesing	f79688ddef	Clients do not request version 0 hidserv descs anymore.	2009-05-04 13:46:30 -04:00
Karsten Loesing	0d68da2381	Drop version 0 hidserv support on service side.	2009-05-04 13:46:29 -04:00
Karsten Loesing	9b32e8c141	Update copyright to 2009.	2009-05-04 11:28:27 -04:00
Karsten Loesing	4ebcc4da34	Update copyright to 2009.	2009-05-02 22:00:54 +02:00
Karsten Loesing	e25fdce900	Documentation fix.	2009-05-02 21:47:03 +02:00
Nick Mathewson	596e852c31	Remove the long-deprecated GETINFO addr-mappings/	2009-05-01 06:25:18 -04:00
Nick Mathewson	6ac3a8b0cd	Command-line option to dump SHA1 digests of all source files. ... Now, when you call tor --digests, it dumps the SHA1 digest of each source file that Tor was built with. We support both 'sha1sum' and 'openssl sha1'. If the user is building from a tarball and they haven't edited anything, they don't need any program that calculates SHA1. If they _have_ modified a file but they don't have a program to calculate SHA1, we try to build so we do not output digests.	2009-04-29 14:46:04 -04:00
Nick Mathewson	e3ec061bc0	Bump master version to 0.2.2.0-alpha-dev.	2009-04-29 14:18:32 -04:00
Nick Mathewson	6cf933f107	Bump 0.2.1 branch version to 0.2.1.14-rc-dev	2009-04-29 14:16:15 -04:00
Sebastian Hahn	5675be39a0	Return -1 in the error case from read_bandwidth_usage. ... svn:r19367	2009-04-23 22:04:10 +00:00
Karsten Loesing	4e6120cffb	Documentation fix. ... svn:r19337	2009-04-16 08:25:36 +00:00
Roger Dingledine	72e4d48c7a	Update to the "April 3 2009" ip-to-country file. ... svn:r19307	2009-04-12 08:09:38 +00:00
Roger Dingledine	a31d9cec82	bump to 0.2.1.14-rc ... svn:r19306	2009-04-12 08:02:14 +00:00
Roger Dingledine	39ceda7e05	Raise the minimum bandwidth to be a relay from 20000 bytes to 20480 ... bytes (aka 20KB/s), to match our documentation. Also update directory authorities so they always assign the Fast flag to relays with 20KB/s of capacity. Now people running relays won't suddenly find themselves not seeing any use, if the network gets faster on average. svn:r19305	2009-04-12 07:56:58 +00:00
Roger Dingledine	115474a44e	put HashedControlPassword and CookieAuthentication explicitly in the ... torrc.sample.in, so unix people don't shoot themselves in the foot. svn:r19304	2009-04-12 06:45:46 +00:00
Roger Dingledine	c024928b63	For belt-and-suspenders, relays that don't set Address in their config ... now avoid using begin_dir for all direct connections. svn:r19296	2009-04-11 19:40:42 +00:00
Roger Dingledine	419d158c74	make it compile too ... svn:r19295	2009-04-11 19:22:38 +00:00
Roger Dingledine	9c6b135e1a	play make-believe that addr isn't a uint32_t ... svn:r19293	2009-04-11 18:21:18 +00:00
Roger Dingledine	fa003351ae	fix the same bug in two more locations (thanks to lark for prodding ... me further) svn:r19292	2009-04-11 18:19:57 +00:00
Roger Dingledine	8d82583d97	Finally fix the bug where dynamic-IP relays disappear when their ... IP address changes: directory mirrors were mistakenly telling them their old address if they asked via begin_dir, so they never got an accurate answer about their new address, so they just vanished after a day. Should fix bugs 827, 883, and 900 -- but alas, only after every directory mirror has upgraded. svn:r19291	2009-04-11 18:09:15 +00:00
Roger Dingledine	235a1196b3	only log that at loglevel notice if there's a problem with the ... version. otherwise there's no reason to tell the user we're doing behind-the-scenes cleaning. svn:r19288	2009-04-11 12:06:27 +00:00
Roger Dingledine	48118b228e	Clients replace entry guards that were chosen more than a few months ... ago. This change should significantly improve client performance, especially once more people upgrade, since relays that have been a guard for a long time are currently overloaded. svn:r19287	2009-04-11 12:00:18 +00:00
Roger Dingledine	7e32f0d5c8	fix a comment ... svn:r19262	2009-04-11 00:40:11 +00:00
Roger Dingledine	93c0a81491	If the bridge config line doesn't specify a port, assume 443. ... This makes bridge lines a bit smaller and easier for users to understand. Also, remove a duplicate changelog entry from the past. svn:r19260	2009-04-11 00:16:05 +00:00
Sebastian Hahn	8390787a5f	Directory authorities should accept a descriptor as changed when the relay operator changed the bandwithrate or bandwithburst settings. ... svn:r19259	2009-04-11 00:12:52 +00:00
Roger Dingledine	c4145e5390	commit sebastian's patch to not require contactinfo when testingtornetwork ... is set svn:r19257	2009-04-10 07:02:19 +00:00
Nick Mathewson	d50501e5ed	Fix a few crash bugs related to malormed descriptors. Lark found one; fuzzing found the rest. ... svn:r19250	2009-04-09 19:58:16 +00:00
Roger Dingledine	ee58153b50	log more verbosely when we accept or decline a router descriptor, ... to help track whether we received them when a relay operator claims they got sent. svn:r19213	2009-04-01 13:02:04 +00:00
Roger Dingledine	b4ceb830e0	if a directory authority declines our server descriptors because it's ... not new enough, write that in the logs. might be helpful one day. svn:r19195	2009-03-31 05:24:36 +00:00
Roger Dingledine	7170c5b4f8	Limit uploaded directory documents to be 16M rather than 500K. ... The directory authorities were refusing v3 consensus votes from other authorities, since the votes are now 504K. Fixes bug 959; bugfix on 0.0.2pre17 (where we raised it from 50K to 500K ;). svn:r19194	2009-03-31 04:03:37 +00:00
Roger Dingledine	793f1ce007	Directory authorities should never send a 503 "busy" response to ... requests for votes or keys. Bugfix on 0.2.0.8-alpha; exposed by bug 959. svn:r19189	2009-03-31 01:29:07 +00:00
Nick Mathewson	be9d72303e	Actually do that memarea_strndup fix right. Not only must you not examine unmapped ram, but you also must not copy it. From lark. ... svn:r19095	2009-03-21 16:01:52 +00:00
Nick Mathewson	0fa01654b9	fix from lark: make memarea_strndup() work even at the end of a mmap chunk. Bug was harmless for now, I think. ... svn:r19094	2009-03-21 11:52:53 +00:00
Nick Mathewson	b5135f1190	Whitespace cleanup. ... svn:r19080	2009-03-18 19:30:37 +00:00
Nick Mathewson	c2f8d97212	Do not generate the non-verbose circuit path when generating a circuit event unless we will use it. ... svn:r19079	2009-03-18 19:30:34 +00:00
Nick Mathewson	a335b43a67	If we have a routerstatus but no routerinfo to name a router, use the routerstatus instead when generating circuit events. Also refactor a little. ... svn:r19078	2009-03-18 19:30:30 +00:00
Nick Mathewson	e591aafca4	Add a function to get a LongName from a routerstatus. Needed for partial bug 941 fix. ... svn:r19077	2009-03-18 19:30:26 +00:00
Nick Mathewson	cb3b95de19	Add some asserts to try to catch bug 930 ... svn:r19074	2009-03-18 15:12:56 +00:00
Nick Mathewson	30ec1d1d50	Don't double-free successful_uploads. ... When we used smartlist_free to free the list of succesful uploads because we had succeeded in uploading everywhere, we did not actually set the successful_uploads field to NULL, so later it would get freed again in rend_service_descriptor_free. Fix for bug 948; bug introduced in 0.2.1.6-alpha. svn:r19073	2009-03-18 14:35:24 +00:00
Nick Mathewson	ad7ebec24c	Free very-old descriptors that we do not want to add. Fix for bug 672. Backport candidate ... svn:r19057	2009-03-16 18:47:45 +00:00
Karsten Loesing	309080b6aa	Make directory usage recording work again. Fixing bug introduced in r17009. ... svn:r18924	2009-03-11 22:08:37 +00:00
Roger Dingledine	4e094ddc4d	when we get an unrecognized relay streamid, log it ... svn:r18919	2009-03-11 20:51:47 +00:00
Steven Murdoch	43145fc9f5	In tor-resolve, when the Tor client to use is specified by <hostname>:<port>, actually use the specified port rather than defaulting to 9050 ... svn:r18833	2009-03-10 00:52:45 +00:00
Roger Dingledine	4774e593b8	Bugfix on r17756: ... Avoid trying to print raw memory to the logs when we decide to give up on downloading a given relay descriptor. Bugfix on 0.2.1.9-alpha. svn:r18831	2009-03-09 22:05:17 +00:00
Roger Dingledine	7ee8afe82d	bump to 0.2.1.13-alpha-dev ... svn:r18830	2009-03-09 21:43:31 +00:00
Nick Mathewson	d40cbda2cd	Log cached-at-exit exit policies to try to fix bug 672. ... svn:r18827	2009-03-09 15:53:37 +00:00
Roger Dingledine	2f69c67957	doxygen tweak ... svn:r18818	2009-03-09 06:20:15 +00:00
Roger Dingledine	e80ee33857	bump to 0.2.1.13-alpha ... svn:r18814	2009-03-09 00:56:22 +00:00
Roger Dingledine	5d50bc3e1d	We were already rejecting relay begin cells with destination port ... of 0. Now also reject extend cells with destination port or address of 0. Suggested by lark. svn:r18812	2009-03-09 00:53:42 +00:00
Roger Dingledine	0f46c1dc6e	Update to the "February 26 2009" ip-to-country file ... svn:r18774	2009-03-05 10:47:25 +00:00
Nick Mathewson	cbbc0c9c86	Actually use tor_sscanf() to parse untrusted input. ... svn:r18761	2009-03-03 18:02:36 +00:00
Nick Mathewson	26d83fc04c	Add a simple locale-independent no-surprises sscanf replacement. ... tor_sscanf() only handles %u and %s for now, which will make it adequate to replace sscanf() for date/time/IP parsing. We want this to prevent attackers from constructing weirdly formed descriptors, cells, addresses, HTTP responses, etc, that validate under some locales but not others. svn:r18760	2009-03-03 18:02:31 +00:00
Nick Mathewson	9f8d095e0f	Add and use set/get_uint64 on onion tags. [bug 604; backportable] ... It seems that 64-bit Sparc Solaris demands 64-bit-aligned access to uint64_t, but does not 64-bit-align the stack-allocated char array we use for cpuworker tags. So this patch adds a set/get_uint64 pair, and uses them to access the conn_id field in the tag. svn:r18743	2009-03-02 19:15:05 +00:00
Nick Mathewson	27c3b43817	Fix one case of bug 929. ... svn:r18683	2009-02-23 20:04:51 +00:00
Nick Mathewson	c7f3416a9e	Add some debugging code to try to catch the likely cause of bug 929 ... svn:r18682	2009-02-23 18:57:21 +00:00
Nick Mathewson	261670b57e	Patch from lark: if we get two extend cells for the same circuit id, drop the second. Previously, we had leaked an extend_info if the target connection was not open when the second arrived. ... svn:r18668	2009-02-21 19:07:05 +00:00
Nick Mathewson	192b701fac	Patch from lark: drop BEGIN cells from a rendevous circuit if they do not originate from the end of the circuit. ... svn:r18667	2009-02-21 19:07:01 +00:00
Roger Dingledine	1b6688786c	send the newconsensus event if the controller has asked for newconsensus ... events, not if he's asked for ns events svn:r18656	2009-02-20 10:25:08 +00:00
Nick Mathewson	b13496b62a	Possible fix for broken country settings in ExcludeExitNodes. ... It turns out that we weren't updating the _ExcludeExitNodesUnion set's country numbers when we reloaded (or first loaded!) the IP-to-country file. Spotted by Lark. Bugfix on 0.2.1.6-alpha. svn:r18575	2009-02-16 15:15:06 +00:00
Roger Dingledine	d3289c6b87	docdoc and changelog for r18556 ... svn:r18566	2009-02-16 10:39:10 +00:00
Roger Dingledine	d13cc5f989	and list the new event here too ... svn:r18557	2009-02-16 06:18:44 +00:00
Roger Dingledine	9ded433abb	new controller event NEWCONSENSUS that lists the networkstatus ... lines for every recommended relay. still needs docdoc and changelog entry. svn:r18556	2009-02-16 06:18:03 +00:00
Roger Dingledine	c8474f9d93	If the controller claimed responsibility for a stream, but that ... stream never finished making its connection, it would live forever in circuit_wait state. Now we close it after SocksTimeout seconds. Bugfix on 0.1.2.7-alpha; reported by Mike Perry. svn:r18516	2009-02-13 04:11:14 +00:00
Roger Dingledine	b03f78e8af	Update to the "January 23 2009" ip-to-country file ... svn:r18503	2009-02-12 12:32:14 +00:00
Nick Mathewson	65dc835773	Revert an erroneous part of the non-fix to bug 326, and add comments to explain why it was erroneous. ... svn:r18494	2009-02-11 17:23:11 +00:00
Nick Mathewson	6e4afe6f13	I worry that the CLEAR() macro in eventdns.c is hiding bugs. That is sad, because it was meant to make them more detectable. Change it to change stuff to garbage rather than to 0. If no bugs turn up, we can remove it in 0.2.2.x ... svn:r18493	2009-02-11 17:22:34 +00:00
Nick Mathewson	8d9aadf57c	Port some mostly cosmetic eventdns changes from libevent ... svn:r18492	2009-02-11 17:22:29 +00:00
Nick Mathewson	356b40f58b	Clients and non-caches do not need to cache unrecognized authority certificates. ... svn:r18480	2009-02-10 20:28:30 +00:00
Nick Mathewson	009752823a	Enhance tor-checkkey tool so it can generate key hashes too. ... svn:r18478	2009-02-10 20:03:58 +00:00
Karsten Loesing	34b285b09f	As an exit node, scrub the IP address to which we are exiting in the logs. Bugfix on 0.2.1.8-alpha. ... svn:r18477	2009-02-10 18:52:47 +00:00
Nick Mathewson	91fece7be2	Don't extend introduction circuits indefinitely. ... Doing so could run you out of relay_early cells and give you a senselessly long circuit. Patch from Karsten; may fix bug 878. svn:r18459	2009-02-10 00:45:30 +00:00
Nick Mathewson	6f90f6f2a2	Retry circuits if the exit node is optional and nonexistant. ... Previously, when we had the chosen_exit set but marked optional, and we failed because we couldn't find an onion key for it, we'd just give up on the circuit. But what we really want to do is try again, without the forced exit node. Spotted by rovv. Another case of bug 752. I think this might be unreachable in our current code, but proposal 158 could change that. svn:r18451	2009-02-09 16:55:48 +00:00
Nick Mathewson	c7315e65ae	Disable KQUEUE from inside Tor if the OSX version is prior to 10.4.0 ... svn:r18450	2009-02-09 16:07:02 +00:00
Nick Mathewson	f99098cca4	Use prctl to reenable core dumps when we have setuid to a non-root user. ... svn:r18449	2009-02-09 15:20:17 +00:00
Nick Mathewson	f95ab83792	Bump version to 0.2.1.12-alpha-dev ... svn:r18448	2009-02-09 15:09:51 +00:00
Roger Dingledine	ad8e4924bd	bump to 0.2.1.12-alpha ... svn:r18429	2009-02-09 03:28:59 +00:00
Roger Dingledine	28d97f8262	uh, and commit the patch too. ... svn:r18423	2009-02-09 03:13:14 +00:00
Nick Mathewson	fe987d3a17	Remove some deadcode and use tor_inet_aton uniformly. ... svn:r18422	2009-02-09 03:13:05 +00:00
Nick Mathewson	2ebdf91a52	Fix a remote-crash bug. This will need a patch release. ... svn:r18421	2009-02-09 03:13:02 +00:00
Roger Dingledine	3845087b04	decide that mikeperry's bug should be fixed in 0.2.1.x ... (but not in 0.2.1.12-alpha, sorry) svn:r18417	2009-02-09 02:50:19 +00:00
Roger Dingledine	decdf4537a	If we're using bridges and our network goes away, be more willing ... to forgive our bridges and try again when we get an application request. Bugfix on 0.2.0.x. svn:r18396	2009-02-04 23:27:35 +00:00
Roger Dingledine	45aeabf8f7	make a note about a clause in connection_edge.c that is probably ... redundant, and is definitely confusing. we should take it out in 0.2.2.x and see who squeaks. svn:r18383	2009-02-04 08:27:36 +00:00
Nick Mathewson	261f49fe26	Fix a possible cause of bug 915 when parsing multiple votes one of which was bad. Bugfix on 0.2.0.8-alpha. ... svn:r18354	2009-01-31 18:27:38 +00:00
Roger Dingledine	ec9c059757	give torrc.sample its yearly overhaul. the main change is to ... merge the 'bridge relay' section into the 'main relay' section, so people stop getting confused about whether they should fill out both sections (they shouldn't). svn:r18348	2009-01-30 19:37:59 +00:00
Nick Mathewson	0f2e171653	fix a wide line. ... svn:r18341	2009-01-30 15:23:44 +00:00
Nick Mathewson	e1f03572ca	Support setting serverdnsrandomizecase during sighup. Backportable, unless too trivial. ... svn:r18307	2009-01-28 19:53:03 +00:00
Nick Mathewson	f78793879d	Fix a race condition on nameserver reconfiguration. ... This resolves bug 526, wherein we would crash if the following events occurred in this order: A: We're an OR, and one of our nameservers goes down. B: We launch a probe to it to see if it's up again. (We do this hourly in steady-state.) C: Before the probe finishes, we reconfigure our nameservers, usually because we got a SIGHUP and the resolve.conf file changed. D: The probe reply comes back, or times out. (There is a five-second window for this, after B has happens). IOW, if one of our nameservers is down and our nameserver configuration has changed, there were 5 seconds per hour where HUPing the server was unsafe. Bugfix on 0.1.2.1-alpha. Too obscure to backport. svn:r18306	2009-01-28 18:26:20 +00:00
Nick Mathewson	e06de61d84	Don't obsolete a very-new connection for having no circuits yet. ... This fixes the last known case of bug 891, which could happen if two hosts, A and B, disagree about how long a circuit has been open, because of clock drift of some kind. Host A would then mark the connection as is_bad_for_new_circs when it got too old and open a new connection. In between when B receives a NETINFO cell on the new conn, and when B receives a conn cell on the new circuit, the new circuit will seem worse to B than the old one, and so B will mark it as is_bad_for_new_circs in the second or third loop of connection_or_group_set_badness(). Bugfix on 0.1.1.13-alpha. Bug found by rovv. Not a backport candidate: the bug is too obscure and the fix too tricky. svn:r18303	2009-01-28 17:36:41 +00:00
Nick Mathewson	0d5f4d4e73	Remove some dead code. ... svn:r18301	2009-01-28 17:36:34 +00:00
Nick Mathewson	8027c8c6dd	Forward-port: Fix bug 893: check AP connections for markedness before expiring them. ... svn:r18299	2009-01-28 16:30:06 +00:00
Nick Mathewson	ef001cf85d	Actually send the extra_headers content in write_http_response_header_impl. This make X-Descriptor-Now-New get sent. Bugfix on 0.2.0.10-alpha. Spotted by "multiplication". ... svn:r18297	2009-01-28 16:06:46 +00:00
Roger Dingledine	9fdae765e3	clean up r18287 ... svn:r18288	2009-01-28 07:16:22 +00:00
Roger Dingledine	edff606317	patch from matt to implement 'getinfo status/clients-seen' ... svn:r18287	2009-01-28 06:50:36 +00:00
Roger Dingledine	59f57a0117	gah. yet another place that needs to be edited when we add ... a new event. what a mess. svn:r18277	2009-01-27 04:43:43 +00:00
Nick Mathewson	72e420ff3c	Fix typo found by Justin Coffi on or-talk ... svn:r18258	2009-01-23 22:45:08 +00:00
Nick Mathewson	25c6ff6f55	Support 64-bit time_t. Patch from Matthias Drochner. Partial backport candidate. ... svn:r18234	2009-01-22 16:28:12 +00:00
Nick Mathewson	8ebceeb352	Make sure that even in the weird fiddly paths that lead to init_keys, ... crypto_global_init gets called. Also have it be crypto_global_init that calls crypto_seed_rng, so we are not dependent on OpenSSL's RAND_poll in these fiddly cases. Should fix bug 907. Bugfix on 0.0.9pre6. Backport candidate. svn:r18210	2009-01-21 15:38:39 +00:00
Nick Mathewson	bf2b71beb8	Fix an error in tor_addr_parse that kept us from having a hidden service or a bridge live at an IPv6 address. ... svn:r18206	2009-01-21 07:24:50 +00:00
Nick Mathewson	3f8ab367c1	Fix warning on panther compile, and bug 913. Backport candidate. ... svn:r18203	2009-01-21 03:51:14 +00:00
Roger Dingledine	a5a6b9a08a	Let controllers actually ask for the "clients_seen" event. Bugfix ... on 0.2.1.10-alpha; reported by Matt Edman. svn:r18201	2009-01-21 03:24:27 +00:00
Roger Dingledine	90a5042aeb	get ready for more development ... svn:r18200	2009-01-21 02:51:30 +00:00
Roger Dingledine	3c668245b7	bump to 0.2.1.11-alpha, clean up changelog ... svn:r18192	2009-01-20 23:33:04 +00:00
Nick Mathewson	a87980c2eb	Add a better (non-locale-having) ctypes implementation to avoid protocol and parsing mismatches on different platforms. ... svn:r18189	2009-01-20 21:33:56 +00:00
Nick Mathewson	87124f54d0	This patch changes the default location where config and data files ... are stored when the --enable-local-appdata option is configured. This changes the Windows path from %APPDATA% to a host local %USERPROFILE%\Local Settings\Application Data\ path (aka, LOCAL_APPDATA). Patch from coderman. svn:r18122	2009-01-15 23:07:11 +00:00
Nick Mathewson	a899f5eaf2	make an assert tighter and replace another with an if. ... svn:r18102	2009-01-14 06:36:33 +00:00
Nick Mathewson	6bf5d49b8a	Now that we can hit the end of router_rebuild_store before chunk_list is set, we need to test it before freeing it. ... svn:r18101	2009-01-14 06:36:30 +00:00
Nick Mathewson	d7be03427d	Refactor MIN_IPS_TO_NOTE_* macros in geoip.c: simplify code. ... It was dumb to have an "announce the value if it's over 0" version of the code coexisting with an "announce the value if it's at least N" version. Retain the latter only, with N set to 1. Incidentally, this should fix a Coverity REVERSE_INULL warning. svn:r18100	2009-01-14 06:20:57 +00:00
Nick Mathewson	2aaf71826d	Fix a compile warning on win32. ... svn:r18099	2009-01-14 04:03:24 +00:00
Karsten Loesing	42c824b405	True, 17 is greater than 0. But this applies to 4111 as well. ... svn:r18097	2009-01-13 15:02:32 +00:00
Nick Mathewson	a33452c401	Fix up (I hope) most ot the things that coverity suddenly claimed were REVERSE_INULL. This is what we get for bragging about being down to 0 issues. ... svn:r18096	2009-01-13 14:43:51 +00:00
Nick Mathewson	c32a4ce6b3	Do the tor_assert hack everywhere in test_crypto_aes_iv. ... svn:r18095	2009-01-13 14:43:46 +00:00
Nick Mathewson	943626050c	Fix a leak memory on the failing case of test_memeq_hex ... svn:r18094	2009-01-13 14:43:43 +00:00
Nick Mathewson	0fe5ce423a	Fix a harmless-to-us bug in ht.h. ... There was a field that _HT_FOI_INSERT was never setting. Everything that calls _HT_FOI_INSERT was setting it via tor_malloc_zero, but that's fragile. svn:r18064	2009-01-10 14:40:43 +00:00
Nick Mathewson	dbc8a44bae	Fix ServerDNSRandomizeCase so that setting it to 0 works. ... Bugfix on 0.2.1.7-alpha. Backport candidate. Fixes bug 905. svn:r18063	2009-01-10 14:38:14 +00:00
Nick Mathewson	a0a5440826	Make the last bunch of libevent version detection silliness work on macosx. ... svn:r18015	2009-01-07 21:13:02 +00:00
Nick Mathewson	a6504cdea7	Check that Libevent header version matches Libevent library version. ... Unfortunately, old Libevents don't _put_ a version in their headers, so this can get a little tricky. Fortunately, the only binary-compatibility issue we care about is the size of struct event. Even more fortunately, Libevent 2.0 will let us keep binary compatiblity forever by letting us decouple ourselves from the structs, if we like. svn:r18014	2009-01-07 21:05:02 +00:00
Roger Dingledine	c123163043	Discard router descriptors as we load them if they are more than ... five days old. Otherwise if Tor is off for a long time and then starts with cached descriptors, it will try to use the onion keys in those obsolete descriptors when building circuits. Bugfix on 0.2.0.x. Fixes bug 887. svn:r17993	2009-01-07 02:13:42 +00:00
Roger Dingledine	18ffea77ae	actually find the right identity_digest to blame when we get ... a destroy cell from our first hop. svn:r17991	2009-01-07 00:30:12 +00:00
Roger Dingledine	bf33182459	well, that was a disaster. this time for sure. ... svn:r17989	2009-01-06 22:20:31 +00:00
Roger Dingledine	c052494a4f	no actual changes besides a seg fault on startup, i meant ... svn:r17986	2009-01-06 21:42:05 +00:00
Roger Dingledine	cdda852cec	simplify. no actual changes i think. ;) ... svn:r17985	2009-01-06 21:31:46 +00:00
Roger Dingledine	b36a98ff5a	When our circuit fails at the first hop (e.g. we get a destroy ... cell back), avoid using that OR connection anymore, and also tell all the one-hop directory requests waiting for it that they should fail. Bugfix on 0.2.1.3-alpha. svn:r17984	2009-01-06 21:28:48 +00:00
Nick Mathewson	462f64b6b9	Make outgoing DNS requests respect OutboundBindAddress. ... Fixes the bug part of bug 789. svn:r17983	2009-01-06 20:50:55 +00:00
Nick Mathewson	585d4a12b5	Note a problem in the interface tor_addr_to_sockaddr. ... svn:r17982	2009-01-06 20:50:51 +00:00
Roger Dingledine	e61c40e9f4	ok, all set to destabilize it again ... svn:r17980	2009-01-06 20:38:05 +00:00
Roger Dingledine	2d9e8a75b8	bump to 0.2.1.10-alpha, reorganize the changelog ... svn:r17974	2009-01-06 20:11:47 +00:00
Roger Dingledine	4f27e73aaa	clarify which relay gave us the good netinfo cell ... svn:r17973	2009-01-06 19:21:47 +00:00
Roger Dingledine	68806c7fb7	When a relay gets a create cell it can't decrypt (e.g. because it's ... using the wrong onion key), we were dropping it and letting the client time out. Now actually answer with a destroy cell. Bugfix on 0.0.2pre8. svn:r17970	2009-01-06 19:03:15 +00:00
Roger Dingledine	0955a1b9e1	Jan 06 13:03:57.309 [info] networkstatus_set_current_consensus(): Loaded an obsolete consensus. Discarding. ... Jan 06 13:03:57.309 [warn] Couldn't load consensus networkstatus from "bridge/cached-consensus" doesn't need a real warn. svn:r17969	2009-01-06 18:06:49 +00:00
Roger Dingledine	d1351750ed	Update to the "December 19 2008" ip-to-country file ... svn:r17968	2009-01-06 18:03:01 +00:00
Nick Mathewson	5e44581412	Clean up (and mark for 0.2.2.) comments relating to non-beauty of current bug-743 fix. ... svn:r17966	2009-01-06 17:37:22 +00:00
Nick Mathewson	6f1ceaefaa	Slightly better messages on ControlListenAddress 0.0.0.0 ... svn:r17963	2009-01-06 16:57:42 +00:00
Roger Dingledine	e127072318	Prevent bridge relays from serving their 'extrainfo' document ... to anybody who asks, now that extrainfo docs include potentially sensitive aggregated client geoip summaries. svn:r17958	2009-01-06 16:03:38 +00:00
Nick Mathewson	9abfb564a0	Make dirserv_get_routerdesc_fingerprints() treat extrainfos with send_unencrypted==0 correctly. Irrelevant, since we will soon never send them at all. ... svn:r17953	2009-01-06 15:37:51 +00:00
Roger Dingledine	d95b63f1e4	Bugfix on r13098. Backport candidate. ... When we made bridge authorities stop serving bridge descriptors over unencrypted links, we also broke DirPort reachability testing for bridges. So bridges with a non-zero DirPort were printing spurious warns to their logs. Bugfix on 0.2.0.16-alpha. Fixes bug 709. svn:r17945	2009-01-06 07:13:24 +00:00
Nick Mathewson	f772fc0c36	apply a variant of rovv's bug 872 patch, and document that we want a better solution for 0.2.2.x. ... svn:r17924	2009-01-05 20:52:14 +00:00
Roger Dingledine	e3388230c4	Bridge relays that had DirPort set to 0 would stop fetching ... descriptors shortly after startup, and then briefly resume after a new bandwidth test and/or after publishing a new bridge descriptor. Bridge users that try to bootstrap from them would get a recent networkstatus but would get descriptors from up to 18 hours earlier, meaning most of the descriptors were obsolete already. Reported by Tas; bugfix on 0.2.0.13-alpha. svn:r17920	2009-01-05 18:54:11 +00:00
Roger Dingledine	9e75c06197	If the cached networkstatus consensus is more than five days old, ... discard it rather than trying to use it. In theory it could be useful because it lists alternate directory mirrors, but in practice it just means we spend many minutes trying directory mirrors that are long gone from the network. Helps bug 887 a bit; bugfix on 0.2.0.x. svn:r17917	2009-01-05 16:56:11 +00:00
Mike Perry	da430cfcf7	Preserve reporting of stream end reasons to the local control ... port. They were lost in the changes for Proposal 148. svn:r17911	2009-01-05 14:14:57 +00:00
Karsten Loesing	fe9790740f	Use doxygen-style comments instead of C-style comments. ... svn:r17893	2009-01-04 23:44:43 +00:00
Nick Mathewson	765bb14f69	Another fun openbsd warning fix. On ioerror's computer at least, they redefined an unsigned field in zlib.h to be signed. I am quite sure this makes me more secure somehow. ... svn:r17892	2009-01-04 23:15:42 +00:00
Nick Mathewson	743c6c8277	OpenBSD malloc.h believes that you should be able to detect headers with autoconf, or build without warnings, but not both. So never include malloc.h on OpenBSD. Backport candidate. ... svn:r17891	2009-01-04 22:47:42 +00:00
Karsten Loesing	26482e855b	Document some variables used for generating statistics on usage of V0 hidden service directory authorities. ... svn:r17890	2009-01-04 19:59:35 +00:00
Nick Mathewson	92ce533f71	Another round of downgrading removing or postponing XXXX021 issues. Some remain, though. ... svn:r17888	2009-01-04 19:47:21 +00:00
Nick Mathewson	9c94b428d9	Fix the oldest bug in a while: stop accepting 1.2.3 as a valid IPv4 address on any platform. ... svn:r17887	2009-01-04 19:47:17 +00:00
Nick Mathewson	360a059948	Fix an xxx021: do not remove routerinfos as too old and unlisted unless we have a consensus. Backport candidate. ... svn:r17886	2009-01-04 19:47:12 +00:00
Nick Mathewson	c4b8fef362	Remove svn $Id$s from our source, and remove tor --version --version. ... The subversion $Id$ fields made every commit force a rebuild of whatever file got committed. They were not actually useful for telling the version of Tor files in the wild. svn:r17867	2009-01-04 00:35:51 +00:00
Nick Mathewson	9201586ed5	Another attempt at fixing coverity scan CID 361. ... svn:r17863	2009-01-03 23:06:12 +00:00
Nick Mathewson	9c20441bcb	Only set sin_len/sin6_len when they exist. ... svn:r17851	2009-01-02 20:57:10 +00:00
Roger Dingledine	89d268848f	take out my IMPOSSIBLE_TO_DOWNLOAD+1 hack ... svn:r17850	2009-01-02 20:46:32 +00:00
Nick Mathewson	48f2ce298b	Try harder to make sure we zero-out the extraneous sockaddr fields and that we set sockaddr_len. Conceivably a backport candidate, though nothing has yet been sen to break. ... svn:r17849	2009-01-02 20:39:38 +00:00
Nick Mathewson	b07baba879	Increment n_download_failures up to IMPOSSIBLE_TO_DOWNLOAD-1, not up to IMPOSSIBLE_TO_DOWNLOAD. ... svn:r17835	2008-12-31 17:22:18 +00:00
Roger Dingledine	dfc6555ddd	switch over the bridge descriptor download mechanism to ... use the same download mechanism as other places. i had to make an ugly hack around "IMPOSSIBLE_TO_DOWNLOAD+1". we should unhack that sometime. svn:r17834	2008-12-31 14:19:57 +00:00
Roger Dingledine	9ea7e7f0cd	fix a bug in download failure logging; don't do this "stop ... downloading forever" thing with bridge descriptor downloads. svn:r17833	2008-12-31 14:11:46 +00:00
Karsten Loesing	9a04358d87	Debug code for task 878. ... svn:r17828	2008-12-30 11:43:50 +00:00
Nick Mathewson	52932d6f1a	Remove some code that is #ifdefed out, and that we no longer seem to use, if we ever did. ... svn:r17827	2008-12-30 04:16:49 +00:00
Nick Mathewson	ffe22fab9b	Indeed, arma was right. There was one ntohl too many in debug_ntop in eventdns.c ... svn:r17826	2008-12-30 04:08:45 +00:00
Roger Dingledine	c190842a34	point out the bug location to nick. unless i'm wrong. ... svn:r17825	2008-12-30 02:36:11 +00:00
Nick Mathewson	3a8a2cb2de	Downgrade some xxx021s, comment more on others, etc ... svn:r17823	2008-12-29 20:17:24 +00:00
Nick Mathewson	8625297cee	Actually log reasons on unusable guards again. ... svn:r17822	2008-12-29 20:17:20 +00:00
Nick Mathewson	d640e2ab00	Spec compliance: if weighted MTBF of a router is at least 5 days, always vote it as Stable. ... svn:r17821	2008-12-29 20:17:18 +00:00
Nick Mathewson	f7fb1bf931	Refactor sockaddr family match check into a new function ... svn:r17820	2008-12-29 19:57:17 +00:00
Nick Mathewson	83491796ee	Explain why the XXXX021 in connection_or.c was there, and explain why it doesn' actually need to get fixed in 0.2.1, I think. ... svn:r17819	2008-12-29 19:57:13 +00:00
Nick Mathewson	45bd6c650d	Replace kludgy assert with something a little less awful, and avoid needless strlcpy in rend descriptor encoding. ... svn:r17818	2008-12-29 19:57:08 +00:00
Nick Mathewson	76a2e11f91	Downgrade the last xxx021 in routerparse. The duplicate code stands for now. ... svn:r17817	2008-12-29 19:57:04 +00:00
Nick Mathewson	c1c7f982d9	Do not not cannibalize a circuit that has run out of RELAY_EARLY cells. Partial bug 878 fix. ... svn:r17815	2008-12-29 19:55:17 +00:00
Nick Mathewson	145ead96ed	Do not cannibalize a circuit that has run out of RELAY_EARLY cells. Partial bug 878 fix. ... svn:r17814	2008-12-29 19:55:13 +00:00
Nick Mathewson	a332805a55	Extact parse-the-token-arguments to its own function, and change it to a single-pass algorithm. This simplifies the parsing code and speeds it up a little. ... svn:r17812	2008-12-29 16:54:56 +00:00
Nick Mathewson	fa6e72dc4b	Remove a call to find_whitespace_eos that didn't actually do anything. ... svn:r17811	2008-12-29 16:54:51 +00:00
Nick Mathewson	a42e82b0de	While I'm at it, refactor control.c a little so that the dead code no longer exists. ... svn:r17810	2008-12-29 14:21:25 +00:00
Nick Mathewson	272b007268	coverity thinks it's dumb to check networkstatus_v2_list in one place and not another. Coverity has a point, even though the check may be redundant. CID 361. ... svn:r17809	2008-12-29 14:06:47 +00:00
Nick Mathewson	2c4097e99d	More compilation tweaks on Android: fix two clear errors in our code that apparently the compiler cares about there. ... svn:r17808	2008-12-29 04:01:58 +00:00
Nick Mathewson	e8a3fa91a6	Use a consistent naming standard for header file guard macros, taking care not to collide with any system headers. This tripped us up on Android. ... svn:r17805	2008-12-29 02:21:02 +00:00
Nick Mathewson	b0a8ecd193	Use RSA_generate_key_ex where available. ... svn:r17804	2008-12-29 02:20:57 +00:00
Nick Mathewson	46f8ef8116	Switch address comparisons in policies to be exact rather than semantic. Until we do ipv6 exit policies and until we know whether we even allow ::ffff:0:0/96 addresses, there is no point in doing "semantic" comparisons. This was also showing up on oprofile. ... svn:r17803	2008-12-29 01:47:33 +00:00
Nick Mathewson	870fd18b8f	Refactor some exit-policy-related functions that showed up in oprofile. ... Specifically, split compare_tor_addr_to_addr_policy() from a loop with a bunch of complicated ifs inside into some ifs, each with a simple loop. Rearrange router_find_exact_exit_enclave() to run a little faster. Bizarrely, router_policy_rejects_all() shows up on oprofile, so precalculate it per routerinfo. svn:r17802	2008-12-29 01:47:28 +00:00
Nick Mathewson	94507f1b6d	Fix bug in recent address.c patch: actually set the value of address * to 0.0.0.0 as we did before. This makes CMP_EXACT comparisons with bitmask 0 work on address * again. ... svn:r17801	2008-12-29 01:30:35 +00:00
Nick Mathewson	ccda4e481c	Fix compilation under gethostbyname-based systems. ... svn:r17800	2008-12-27 15:46:16 +00:00
Nick Mathewson	ae71b52945	remove the responsibility for setting listensocklen to the function that made the sockaddr ... svn:r17799	2008-12-27 15:46:13 +00:00
Roger Dingledine	365c72246c	partial move to letting bridge descriptor fetches use our new (well, ... new from their perspective) directory download schedule abstraction. not done yet, but i'd better get this out of my sandbox before nick does another sweeping change. :) svn:r17798	2008-12-27 07:30:47 +00:00
Roger Dingledine	5519e633ec	New controller event "clients_seen" to report a geoip-based summary ... of which countries we've seen clients from recently. Now controllers like Vidalia can show bridge operators that they're actually making a difference. svn:r17796	2008-12-27 06:50:07 +00:00
Nick Mathewson	0c5e03fa21	Remove a deprecated controller alias; make another one generate a warning. ... svn:r17793	2008-12-27 00:20:08 +00:00
Nick Mathewson	a87335472c	Make connection_create_listener take a sockaddr_len, not just a sockaddr whose length we try to divine. ... svn:r17792	2008-12-27 00:20:06 +00:00
Nick Mathewson	b3b14bf25d	Add some early checks to keep ipv6 addresses from failing by accident. Now, they fail on purpose, at least till 0.2.2.something. ... svn:r17791	2008-12-26 22:51:25 +00:00
Nick Mathewson	374c1e979f	Refactor tor_addr_t manipulation functions so that as few as possible look at the tor_addr_t representation. ... svn:r17790	2008-12-26 21:26:05 +00:00
Nick Mathewson	616f6643ef	get_interface_addr6(), and by extension get_interface_addr(), were pretty borked. Copying a tor_addr_t from a sockaddr_storage using memcpy is a poor notion. ... svn:r17789	2008-12-26 21:26:03 +00:00
Nick Mathewson	61722638ea	Refactor tor_addr_compare_masked() so that CMP_SEMANTIC makes more sense, and has decent semantics for maskbits; and so that CMP_EXACT works right for bits==0. ... svn:r17788	2008-12-26 20:37:18 +00:00
Nick Mathewson	f182e9707f	Bump version to 0.2.1.9-alpha-dev ... svn:r17787	2008-12-26 17:39:22 +00:00
Nick Mathewson	f7adc017c4	Document and make more conservative the logic for picking the size of the bloom filter to use for retaining descriptors. ... svn:r17786	2008-12-26 17:35:36 +00:00
Nick Mathewson	73e1a1d26e	Document our Bloom filter parameter choices. ... svn:r17785	2008-12-26 17:35:18 +00:00
Nick Mathewson	0f9f45ff33	Document the pk operation count fields in rephist.c, and move them into a struct for clarity, and change their type to what we actually want to cast them to. ... svn:r17784	2008-12-26 17:35:12 +00:00
Nick Mathewson	df5e8f65bc	Add more missing documentation, and correct an error in container.c documentation: Don't introduce two parameters called n when you're calling an algorithm O(n). ... svn:r17783	2008-12-26 17:35:08 +00:00
Roger Dingledine	20f964c6da	prepare for 0.2.1.9-alpha ... svn:r17778	2008-12-25 20:32:49 +00:00
Roger Dingledine	2a42986c96	ok, fair enough, some of these variables were time_t's after all ... svn:r17777	2008-12-25 20:16:22 +00:00
Roger Dingledine	4ff04fda77	so which is it? TIME_MAX or INT_MAX? pick INT_MAX for now. ... svn:r17772	2008-12-25 15:42:03 +00:00
Roger Dingledine	a12c3f2c86	some fixes i found in my sandbox ... svn:r17771	2008-12-25 15:37:47 +00:00
Nick Mathewson	272e64e674	Use the literal parse of an address in dns_resolve_impl if parsing the address as an ipv4 or ipv6 address _succeeded_. Not if it failed. Bug introduced in r17707 (post 0.2.1.8-alpha), and found by xiando. ... svn:r17758	2008-12-24 02:38:07 +00:00
Nick Mathewson	df608fef45	Checkpoint my big bug-891 patch. ... svn:r17757	2008-12-24 02:38:04 +00:00
Nick Mathewson	ac2f6b608a	Patch from Sebiastian for bug 888: mark a descriptor as "Impossible" if we reject it after downloading it so that we do not download it again ... svn:r17756	2008-12-23 21:17:52 +00:00
Nick Mathewson	e6bf9fdf94	Remove bogus extern declaration for unused (and nonexistant) field from test.c ... svn:r17755	2008-12-23 17:56:39 +00:00
Nick Mathewson	558e9899e4	Document most undocumented variables. ... svn:r17754	2008-12-23 17:56:31 +00:00
Nick Mathewson	d7f55dafe0	Properly zero-out addresses when setting them. Probably this was not hurting anything. ... svn:r17749	2008-12-23 14:21:34 +00:00
Nick Mathewson	b4d387c28b	Make freelist_len in memarea.c static; document a few variables. ... svn:r17741	2008-12-22 19:14:08 +00:00
Nick Mathewson	7d79bec54d	Expose bench_* functions via test cli ... svn:r17740	2008-12-22 19:00:09 +00:00
Nick Mathewson	b68379b13b	Add DOCDOC entries for undocumented static and global variables. ... svn:r17739	2008-12-22 19:00:05 +00:00
Nick Mathewson	43b111535a	Make doxygen not complain about the way we spell CRLFNUL in control.c ... svn:r17735	2008-12-22 17:53:30 +00:00
Nick Mathewson	1e5f457461	Fix most DOCDOCs remaining and/or added by redox. ... svn:r17734	2008-12-22 17:53:04 +00:00
Nick Mathewson	167d266dbf	Documentation and conformance for WRA_* returns. ... shahn: "Add some documentation for the WRA_* family of functions, also make sure that (hopefully) all functions that return was_router_added_t don't return ints directly and that they don't refer to integers in their documentation anymore." svn:r17731	2008-12-22 16:37:20 +00:00
Nick Mathewson	1e666bfcc1	Partially apply bug 891 parch from forest: check EXTEND cell address against real_addr, not addr. I have questions about the rest of the patch: see the flyspray entry. ... svn:r17730	2008-12-22 16:22:04 +00:00
Nick Mathewson	1725c0c8a5	Add DOCDOC comments for all undocumented functions. Add missing *s to other comments so that they will get recognized as doxygen. ... svn:r17729	2008-12-22 14:56:28 +00:00
Nick Mathewson	55348884b5	Fix all of the doxygen warnings not pertaining to missing documentation. ... svn:r17727	2008-12-22 14:56:16 +00:00
Roger Dingledine	df89748388	fix typo noticed by wood ... svn:r17726	2008-12-22 09:52:56 +00:00
Roger Dingledine	0f6514e041	some windows users are outraged that tor refuses to work even ... when their clock and date are correct, if their timezone is totally wrong. now we at least tell them. svn:r17725	2008-12-22 09:10:06 +00:00
Roger Dingledine	0c6ff7d990	the default should not be the notify the poster, unless something ... more extreme happens. the default should be to be quiet unless something more extreme happens. at least, this doesn't generate complaints anymore. perhaps that means it is working better? :) svn:r17724	2008-12-22 06:25:49 +00:00
Roger Dingledine	7262bf5eab	fix a fun bug on r17656 that was making us send HTTP/1.0 404 as ... the message body, no matter the message headers, when answering a descriptor or extrainfo post request. svn:r17723	2008-12-22 06:21:28 +00:00
Nick Mathewson	e36c7a74bd	Yet still more propagating of things that need to be was_router_added_t now. ... svn:r17722	2008-12-22 05:21:49 +00:00
Nick Mathewson	98a376fab1	More propagating of things that need to be was_router_added_t now. ... svn:r17721	2008-12-22 04:53:11 +00:00
Nick Mathewson	df22dcb602	WRA_MORE_SEVERE is not WRA_GET_MORE_SEVERE. ... svn:r17720	2008-12-22 04:36:52 +00:00
Karsten Loesing	61055ae719	gabelmoo has a new IP address (once more). ... svn:r17717	2008-12-22 00:48:10 +00:00
Nick Mathewson	029be5ad02	Move in-addr.arpa parsing and generation into address.c, and simplify the code that does it elsewhere. Incidentally, this lets exit servers answer requests for ip6.arpa addresses. ... svn:r17707	2008-12-19 18:52:00 +00:00
Nick Mathewson	efb863189c	Expose hex_decode_digit from util.c ... svn:r17706	2008-12-19 18:51:52 +00:00
Nick Mathewson	a259af179b	When we need to open a new origin circuit, log why. ... svn:r17705	2008-12-19 18:51:49 +00:00
Nick Mathewson	16f1d4cb72	Doc RRS_DONT_REMOVE_OLD; improve router_rebuild_store documentation. ... svn:r17704	2008-12-19 18:51:44 +00:00
Nick Mathewson	8c90a4b7ee	More approx_time() calls. Noted by forest. ... svn:r17702	2008-12-19 18:51:35 +00:00
Nick Mathewson	c67bd80487	Make cell pools always-on. ... svn:r17692	2008-12-18 17:28:50 +00:00
Nick Mathewson	c3e4b12e7f	Why were we using gettimeofday() in second_elapsed_callback? We were only ever looking at the tv_sec field. ... svn:r17691	2008-12-18 17:19:23 +00:00
Nick Mathewson	bf80e2df3f	Replace calls to time(NULL) that occur on the order of once per read, one per write, or once per cell with calls to a function that looks at a cached value of time. This is tricksy to benchmark, since it will only help on systems where time() is a syscall and syscalls are relatively slow. ... svn:r17690	2008-12-18 17:19:04 +00:00
Nick Mathewson	b91335117f	Document the purpose argument of circuit_find_to_cannibalize ... svn:r17689	2008-12-18 17:18:14 +00:00
Nick Mathewson	b6f89a647a	One log.c XXX021 was a misunderstanding. Also, clip log messages passed to syslog to their maximum length when there is a maximum. ... svn:r17688	2008-12-18 17:18:06 +00:00
Nick Mathewson	122170c1d3	Downlgrade tweak, and answer lots of XXX021s. No actual code fixes in this patch. ... svn:r17686	2008-12-18 16:11:24 +00:00
Nick Mathewson	6c6b0283cb	Ben confirms that the MUST in rfc2631 is only for compatibility with X9.42, and isn't actually a security thing. ... svn:r17685	2008-12-18 16:11:16 +00:00
Nick Mathewson	8d5a9d762c	Log an error on win32 if directory listing fails. ... svn:r17684	2008-12-18 16:11:12 +00:00
Nick Mathewson	c449e6e5be	whitespace fixes. ... svn:r17683	2008-12-18 16:11:08 +00:00
Nick Mathewson	ecaee1d927	Remove fixed xxx020s; downgrade unfixed ones. ... (The unfixed ones are being downgraded to regular XXXs mainly on the rationale that they don't seem to be exploding Tor, and they were apparently not showstoppers for 0.2.0.x-final.) svn:r17682	2008-12-18 16:11:03 +00:00
Nick Mathewson	f9133f2528	Fix a memory leak of one address string per DNSPort request. ... svn:r17681	2008-12-18 15:00:27 +00:00
Nick Mathewson	148e4e8837	Do not leak the DNS server port structure. ... svn:r17680	2008-12-18 15:00:18 +00:00
Nick Mathewson	4911ec627b	Call release_lockfile() before exiting. ... svn:r17679	2008-12-18 15:00:13 +00:00
Nick Mathewson	9c3d17ebb5	Fix a small memory leak of around 32 bytes per TLS connection opened. Bugfix on 0.2.1.1-alpha. ... svn:r17678	2008-12-18 15:00:09 +00:00
Nick Mathewson	290b6f54a3	Make unit tests slower but more reliable by disabling an old optimization. ... To turn it back on, re-define CACHE_GENERATED_KEYS option in test.c. svn:r17677	2008-12-18 06:12:19 +00:00
Nick Mathewson	8ba2a15a49	Fix more leaks in unit tests. ... svn:r17676	2008-12-18 06:02:23 +00:00
Nick Mathewson	1b735e46dd	Make it possible to call set_onion_key twice without leaking RAM. ... svn:r17673	2008-12-18 05:40:57 +00:00
Nick Mathewson	cebdf93949	Fix bug 889: share deep-copied keys between threads to avoid races in reference counts. Bugfix on 0.1.0.1-rc. ... svn:r17672	2008-12-18 05:28:27 +00:00
Roger Dingledine	7b5be147ee	fix a minor memory leak if we start up as a relay but don't ... have any files in the cached-status/ directory svn:r17671	2008-12-18 05:15:11 +00:00
Nick Mathewson	d597b23c42	Massage a little code to hopfully please coverity. ... svn:r17669	2008-12-18 04:45:51 +00:00
Nick Mathewson	f3f6daf819	Avoid nop call to control_event_or_authdir_new_descriptor that makes coverity think we are dereferencing a null pointer. It is safe, I think, but entirely too clever for our own good. ... svn:r17668	2008-12-18 04:45:47 +00:00
Nick Mathewson	676175103d	Fix a valgrind-located memory stomp. Bugfix on 0.2.1.6-alpha. ... svn:r17667	2008-12-18 04:27:23 +00:00
Nick Mathewson	5c235cb5ec	Fix memory leak in rend_cache_store_v2_desc_as_client(), and refactor the function to use the "goto err" idiom. ... svn:r17665	2008-12-18 00:11:49 +00:00
Nick Mathewson	1510d50fab	Oops: SeverDNS->ServerDNS. ... svn:r17664	2008-12-17 23:20:07 +00:00
Nick Mathewson	7d92053286	Remove RedirectExit feature; it has been deprecated since 0.2.0.3-alpha ... svn:r17663	2008-12-17 23:02:04 +00:00
Nick Mathewson	6693f32530	Resolve many DOCDOCs. ... svn:r17662	2008-12-17 22:58:20 +00:00
Nick Mathewson	2ad36f68c8	Rename ServerDNSAllowBrokenResolvConf to ServerDNSAllowBrokenConfig. ... (Many users have no idea what a resolv.conf is, and shouldn't be forced to learn. The old option will keep working for now.) Also, document it. svn:r17661	2008-12-17 22:58:14 +00:00
Roger Dingledine	03f413f5c7	declare that we're putting out 0.2.1.9-alpha next week ... svn:r17659	2008-12-17 22:46:00 +00:00
Roger Dingledine	048f2a179b	Clip the MaxCircuitDirtiness config option to a minimum of 10 ... seconds. Warn the user if lower values are given in the configuration. Bugfix on 0.1.0.1-rc. Patch by Sebastian. Clip the CircuitBuildTimeout to a minimum of 30 seconds. Warn the user if lower values are given in the configuration. Bugfix on 0.1.1.17-rc. Patch by Sebastian. svn:r17657	2008-12-17 22:32:17 +00:00
Nick Mathewson	33e2053ebc	Make return code from router_add_to_routerlist a nice sensible enum. Based on patch from Sebastian. ... svn:r17656	2008-12-17 21:50:01 +00:00
Nick Mathewson	2de9bd7bae	Rename a couple of v2-networkstatus-only fields so that it is clear they are v2-networkstatus-only. ... svn:r17652	2008-12-17 17:20:48 +00:00
Nick Mathewson	f43bcdc063	Use ctags and a python script to find identifiers that are never used anywhere, and remove the ones that we really want gone. ... svn:r17651	2008-12-17 17:20:42 +00:00
Nick Mathewson	fc5e686b19	Whitespace fix. ... svn:r17650	2008-12-17 17:20:36 +00:00
Nick Mathewson	1beb1c113b	Add some missing documentation in or.h ... svn:r17649	2008-12-17 17:20:31 +00:00
Nick Mathewson	0dc724d19c	Make ALLOW_INVALID_* into an enum. ... svn:r17648	2008-12-17 17:20:26 +00:00
Nick Mathewson	d0e1cc6fe2	Remove the no-longer-used incoming_cmd_type field from control_connection_t. ... svn:r17647	2008-12-17 17:20:22 +00:00
Nick Mathewson	68a6935afb	Change CELL_DIRECTION_* to an enum. ... svn:r17646	2008-12-17 17:20:19 +00:00
Nick Mathewson	44e19a4949	Oops; remove extraneous comma. ... svn:r17644	2008-12-17 15:04:43 +00:00
Nick Mathewson	7678ac5193	Move edge-only flags from connection_t to edge_connection_t. ... svn:r17643	2008-12-17 14:59:28 +00:00
Nick Mathewson	26632d59dd	Rename or_is_obsolete and move it to or_connection_t where it belongs. ... svn:r17642	2008-12-17 14:59:19 +00:00
Nick Mathewson	e53ffaa4e4	Don't extend circuits over noncanonical connections with mismatched addresses. ... Also, refactor the logic to check whether we will use a connection or launch a new one into a new function. svn:r17628	2008-12-15 21:17:53 +00:00
Nick Mathewson	51c29e1e24	Apply rovv's bug 805 fix: take more care never to prefer a non-canonical connection. ... svn:r17627	2008-12-15 21:17:43 +00:00
Roger Dingledine	5822e14dc9	When a stream at an exit relay is in state "resolving" or ... "connecting" and it receives an "end" relay cell, the exit relay would silently ignore the end cell and not close the stream. If the client never closes the circuit, then the exit relay never closes the TCP connection. Bug introduced in Tor 0.1.2.1-alpha; reported by "wood". svn:r17625	2008-12-14 19:40:56 +00:00
Roger Dingledine	2ad06eef11	comment tweak ... svn:r17624	2008-12-14 19:39:54 +00:00
Nick Mathewson	a4a481d81c	Implement proposal 148: Make client stream end reasons uniform. ... This patch makes every RELAY_COMMAND_END cell that we send pass through one of two functions: connection_edge_end and relay_send_end_cell_from_edge. Both of these functions check the circuit purpose, and change the reason to MISC if the circuit purpose means that it's for client use. svn:r17612	2008-12-12 20:30:42 +00:00
Nick Mathewson	5fb2ab1e65	Implement the /tor/keys/fp-sk/ URL format. That mostly finishes the server side of 157. ... svn:r17611	2008-12-12 19:05:36 +00:00
Nick Mathewson	69ce955484	Add cross-certification to authority key certificates. Partial implementation of proposal 157. ... svn:r17610	2008-12-12 18:31:39 +00:00
Nick Mathewson	519de7970e	Do not discard sign on return values of iv crypto functions in tests. May fix CID 9. Might not. ... svn:r17603	2008-12-11 21:11:31 +00:00
Nick Mathewson	7e351a6341	Note that a couple of line in control.c are supposed to be dead-code. ... I'm hoping not to have to litter the rest of our codebase with Coverity ignores, but I think these are the only one we need right now. svn:r17602	2008-12-11 21:11:28 +00:00
Nick Mathewson	02e26ebc49	If we are building under Coverity, enable geoip_stats and instrument_downloads. ... This makes sure that a) optional code gets analyzed too, and b) it doesn't look like dead code to Coverity. svn:r17601	2008-12-11 21:11:26 +00:00
Nick Mathewson	98066d62bc	Lower sprintf buffer max to ~SSIZE_T_MAX from SIZE_T_CEILING, since we need to compare it to a signed int. ... svn:r17600	2008-12-11 21:11:22 +00:00
Nick Mathewson	b20694758e	Fix two more unit-test bugs (deadcode this time) spotted by Coverity run 7. ... CIDs == 357, 356. svn:r17599	2008-12-11 21:11:19 +00:00
Nick Mathewson	04ec7d1f98	Now that tor_assert is no longer using a broken force-to-boolean formulation, we can tor_assert a bitfield without a gcc compile error. ... svn:r17598	2008-12-11 20:28:50 +00:00
Nick Mathewson	4277b0e926	Remove some cargo-cult gcc hacks around tor_assert and predict_unlikely; instead, use the standard convert-to-boolean hack of "svn st" ... svn:r17597	2008-12-11 20:23:46 +00:00
Nick Mathewson	d9aa57253d	Fix error in last unit test mem-leak-fixing. ... svn:r17596	2008-12-11 19:41:03 +00:00
Nick Mathewson	bb02f919f1	Refactor find_first_by_keyword into one variant that can return NULL and one that can't. ... This makes it easier for us to avoid errors where we we forgot to list a keyword as mandatory, and easier for Coverity to detect cases like this too. svn:r17595	2008-12-11 19:40:58 +00:00
Nick Mathewson	f3b52e331e	Avoid multiple descriptor-fetch connections to authorities. Fixes bug 366. ... svn:r17594	2008-12-11 19:12:55 +00:00
Nick Mathewson	043b4fc59e	Add a PDS_ flag to exclude authorities from which we are fetching descs. ... Yes, this is maybe a little overspecific. Part of a bug 366 fix. svn:r17593	2008-12-11 19:12:48 +00:00
Nick Mathewson	29f5a65a16	Change directory_get_from_dirserver to take a set of flags to be passed to pick_(trusted_)dirserver. This lets us make its interface smarter, and makes code that calls it a little more readable. ... svn:r17592	2008-12-11 19:12:45 +00:00
Nick Mathewson	4e69284e89	Fix wide line in main.c ... svn:r17587	2008-12-11 17:23:00 +00:00
Nick Mathewson	240ee1866b	Add experimental support for learning svn revision number in git-svn based repositories. Fancy. ... svn:r17581	2008-12-11 06:52:24 +00:00
Nick Mathewson	d7563ee231	Fix memory leaks in test_util_smartlist_* functions. ... svn:r17580	2008-12-11 06:18:09 +00:00
Nick Mathewson	595e77c8d7	Fix memory leaks in test_v3_networkstatus. ... svn:r17579	2008-12-11 06:18:01 +00:00
Nick Mathewson	6ffb4d4ab6	Fix memory leaks in test_dir_format ... svn:r17578	2008-12-11 06:17:59 +00:00
Nick Mathewson	3be88b2c70	Change test_memeq macro to not leak memory. Addresses coverity CID 47. ... svn:r17577	2008-12-11 06:17:54 +00:00
Nick Mathewson	d8027aa689	Fix a logic error that would automatically reject all but the first configured DNS server. Bugfix on 0.2.1.5-alpha. Possible fix for part of 813/868. Spotted by coderman ... svn:r17569	2008-12-10 22:57:41 +00:00
Nick Mathewson	53d3f812bd	Add new internal-use-only option for controllers to use to prevent SIGHUP from reloading the configuration. Fixes bug 856. ... svn:r17567	2008-12-10 22:17:02 +00:00
Nick Mathewson	9aa706e20c	Bug 691 fix: do not shutdown Tor servers right away if the network is down. ... svn:r17566	2008-12-10 20:45:31 +00:00
Nick Mathewson	426b53d85a	Apply patch from Karsten to fix bug 879. Backport candidate. ... svn:r17562	2008-12-10 18:16:58 +00:00
Nick Mathewson	7aa7d1a3e7	Give a better error when something has changed our descriptor cache out from under us. Based on patch from Karsten. Addresses bug 885. ... svn:r17550	2008-12-10 03:01:26 +00:00
Roger Dingledine	d7bf7e0b32	When a directory authority gives us a new guess for our IP address, ... log which authority we used. Hopefully this will help us debug the recent complaints about bad IP address guesses. svn:r17549	2008-12-10 01:46:51 +00:00
Roger Dingledine	4053b47459	note a potential bug in status events. need to look at spec to ... see if it's really a bug. svn:r17548	2008-12-10 01:35:21 +00:00
Roger Dingledine	145e589b6c	Resume using the correct "REASON=" stream when telling the ... controller why we closed a stream. Bugfix in 0.2.1.1-alpha. svn:r17547	2008-12-10 01:34:24 +00:00
Nick Mathewson	d60d8976b9	Better error message when told to setuid to ourself. ... svn:r17543	2008-12-09 23:26:12 +00:00
Nick Mathewson	ab75c0d9e3	remove a bogus comment. Now that there is no undocumented synonym for EXTENDED_EVENTS, we do not need to point out that EXTENDED_EVENTS is documented ... svn:r17542	2008-12-09 23:10:38 +00:00
Nick Mathewson	a7b4a7b9f8	Finally remove deprecated-since-0.1.2.4-alpha EXTENDED_FORMAT synonym for EXTENDED_EVENTS ... svn:r17538	2008-12-09 19:55:19 +00:00
Nick Mathewson	3841e1b230	Bump version to 0.2.1.8-alpha-dev ... svn:r17537	2008-12-09 18:18:48 +00:00
Nick Mathewson	0280a72500	Add a new status event for consensus arrival ... svn:r17535	2008-12-09 18:16:41 +00:00
Nick Mathewson	07c8b2be21	Compile without warnings on mingw. ... svn:r17522	2008-12-08 19:52:26 +00:00
Roger Dingledine	027a8cceed	bump to 0.2.1.8-alpha ... svn:r17521	2008-12-08 19:25:18 +00:00
Nick Mathewson	b32bac88e8	Mark DirPortFrontPage as a FILENAME rather than a STRING. Right now this has no effect. ... svn:r17520	2008-12-08 18:00:34 +00:00
Roger Dingledine	b1c8fb7058	this function is no longer used. ... svn:r17515	2008-12-08 00:09:28 +00:00
Roger Dingledine	e5be0504ab	When the client is choosing entry guards, now it selects at most ... one guard from a given relay family. Otherwise we could end up with all of our entry points into the network run by the same operator. Suggested by Camilo Viecco. Fix on 0.1.1.11-alpha. Not a backport candidate, since I think this might break for users who only have a given /16 in their reachableaddresses, or something like that. svn:r17514	2008-12-08 00:04:29 +00:00
Roger Dingledine	f31c16d993	Directory mirrors no longer fetch the v1 directory or ... running-routers files. They are obsolete, and nobody asks for them anymore. This is the first step to making v1 authorities obsolete. svn:r17513	2008-12-07 23:53:39 +00:00
Jacob Appelbaum	48aca3c999	Small whitespace fix to properly format if () {} statement. ... svn:r17503	2008-12-07 01:51:56 +00:00
Jacob Appelbaum	f70146ca91	This helps return a better error message when the file supplied to DirPortFrontPage is missing. ... svn:r17502	2008-12-07 01:48:30 +00:00
Roger Dingledine	21892d8a9c	cleanups on r17500 ... svn:r17501	2008-12-07 01:34:45 +00:00
Jacob Appelbaum	6b178b46ef	New DirPortFrontPage option that takes an html file and publishes it as "/" on the DirPort. Now relay operators can provide a disclaimer without needin to set up a separate webserver. There's a sample disclaimer in contrib/tor-exit-notice.html. ... svn:r17500	2008-12-07 01:21:19 +00:00
Jacob Appelbaum	cf75162a0c	Add comment clarifying OpenSSL usage. ... svn:r17498	2008-12-07 01:14:49 +00:00
Nick Mathewson	6fb06f334a	Try to fix windows mmap code. ... svn:r17493	2008-12-05 19:36:35 +00:00
Nick Mathewson	af03faa1a6	Fix more leaks in test_util_memarea(). ... svn:r17491	2008-12-05 02:25:39 +00:00
Nick Mathewson	7f793fa733	Simplify mmap object layout to avoid confusing static analysis tools, and us too. ... svn:r17490	2008-12-05 02:17:41 +00:00
Nick Mathewson	475fbbbccc	Fix a resource leak in test_dir_formats() ... svn:r17488	2008-12-05 02:05:39 +00:00
Nick Mathewson	1affbd3464	Split test_util_smartlist into manageable chunks; make them free memory properly. ... svn:r17487	2008-12-05 01:58:35 +00:00
Nick Mathewson	30377823c3	Add a few more tests to our tests so that our tests make sense to coverity. CIDs 139, 138, 137. ... svn:r17486	2008-12-05 01:49:15 +00:00
Nick Mathewson	e06442b648	Add a couple of sanity-checks for return values that coverity thinks we ought to have. CIDs 337, 335. ... svn:r17485	2008-12-05 01:35:49 +00:00
Nick Mathewson	2be5215181	Fix a hard-to-trigger memory leak in log_credential status. Found by Coverity scan. CID 349. ... svn:r17484	2008-12-05 01:29:59 +00:00
Nick Mathewson	a26188cee9	fix bug 880: find the end of an authority cert by looking for the first ----END SIGNATURE----- after the first dir-key-certification, not for the first ----END SIGNATURE. Harmless bug, but it made us non-spec-compliant. ... svn:r17470	2008-12-03 03:42:19 +00:00
Nick Mathewson	37bd9181f0	Do not use O_APPEND on fd-based operations that do not really want it; have them just lseek instead. ... svn:r17460	2008-12-02 23:49:40 +00:00