George Kadianakis
43324b0e4d
Fix minor memleak in edge-case of crypto_rsa.c function.
2018-09-18 14:01:15 +03:00
Nick Mathewson
1f9055c884
Merge remote-tracking branch 'teor/ticket27757'
2018-09-17 21:43:34 -04:00
teor
4e50db573a
ChangeLog: add onion service versions to the Tor2web deprecation notice
...
Tor2web was never implemented for v3 onion services.
2018-09-18 11:36:49 +10:00
teor
073953716b
ChangeLog: the ContactInfo UTF-8 requirement is a major UI change
...
(Even if it only affects a few relay operators.)
2018-09-18 11:36:46 +10:00
teor
5b3b7f8e26
ChangeLog: bugfixes are on previous releases, not this release
2018-09-18 11:36:39 +10:00
teor
ab0203dd1e
ChangeLog: delete both consensus flavours to un-break nss
...
The required protocol version check occurs before the consensus flavour
check. So on directory mirrors (and some client configs), alpha users need
to delete both consensus flavours to workaround nss bugs.
Closes ticket 27756.
2018-09-18 10:42:59 +10:00
Mike Perry
8a83c4b613
Merge branch 'bug23512-v4-033' into bug23512-v4-master
2018-09-18 00:17:14 +00:00
Mike Perry
ad10cafd9f
Bug 23512: Test fix: cmux is now allocated by new_fake_channel()
2018-09-17 23:31:48 +00:00
Mike Perry
72cef61028
Merge branch 'bug23512-v4-032' into bug23512-v4-033
2018-09-17 23:31:34 +00:00
Mike Perry
dd15998d28
Remove duplicate TLS define from kist code.
...
Duplicate comes from introducing this define into 0.2.9, which did not yet
have KIST.
2018-09-17 23:21:58 +00:00
Mike Perry
dfd3823047
Bug 23512: Mock assert_circuit_ok in tests.
...
This mocking was not available in 0.2.9.
2018-09-17 23:12:53 +00:00
Mike Perry
36e81e1f59
Merge branch 'bug23512-v4-029' into bug23512-v4-032
2018-09-17 23:12:45 +00:00
Mike Perry
6af352172d
Bug 23512: Test recording bytes in circ queues.
2018-09-17 22:24:25 +00:00
Mike Perry
2ceda207d3
Bug 23512: Changes file.
2018-09-17 22:19:43 +00:00
Mike Perry
bbaa398d26
Bug 23512: Report queued cells on or circs as written.
...
This avoids asymmetry in our public relay stats, which can be exploited for
guard discovery and other attacks.
2018-09-17 22:19:42 +00:00
Mike Perry
7dc435e6bc
Promote rep_hist bw functions to uint64_t.
...
The rest of rephist uses uint64_t internally. Let's make these take it too,
so we don't have to worry about overflowing size_t on 32 bit systems.
2018-09-17 22:19:05 +00:00
Nick Mathewson
aebc98d58c
More changelog edits
2018-09-17 16:35:13 -04:00
Nick Mathewson
3d80246a4e
Write a blurb, pull UI changes to the front, edit
2018-09-17 16:04:30 -04:00
Nick Mathewson
765caaea77
Light edits on changelog. mostly combining sections.
2018-09-17 15:42:29 -04:00
Nick Mathewson
f606b3cfd1
Lower the maximum size of a private key file to 16 MB
...
This shouldn't be a user-visible change: nobody has a 16 MB RSA
key that they're trying to use with Tor.
I'm doing this to fix CID 1439330 / ticket 27730, where coverity
complains (on 64-bit) that we are making a comparison that is never
true.
2018-09-17 11:08:56 -04:00
Nick Mathewson
307275a5e4
Bump to 0.3.5.1-alpha
2018-09-17 09:12:42 -04:00
Nick Mathewson
b96e2ab341
Start a changelog for 0.3.5.1-alpha
2018-09-17 09:12:10 -04:00
Nick Mathewson
b729bc202c
Add tortls.h includes to expose critical macro. Fix #27734 .
2018-09-16 22:08:02 -04:00
Nick Mathewson
a8ac21fbb5
Don't try to link C from rust doctests for nss detection
...
This is really annoying, since we can't use cfg(test) for doctests.
2018-09-16 14:34:31 -04:00
Nick Mathewson
078debb0de
Merge branch 'bug25573-034-typefix'
2018-09-16 13:46:12 -04:00
Nick Mathewson
7fd61cf536
Fix duplicate declaration of pathbias_count_valid_cells.
2018-09-16 13:45:43 -04:00
Nick Mathewson
991bec67ee
When Tor is compiled with NSS, don't claim support for LinkAuth=1
...
Closes ticket 27288
2018-09-16 13:28:29 -04:00
traumschule
863e2fcb48
Update description of onion_extend_cpath() ( #27333 )
2018-09-16 04:01:17 +02:00
Alexander Færøy
3477a73af9
Add proxy headers as early as possible.
...
This patch moves the logic that adds the proxy headers to an earlier
point in the exit connection lifetime, which ensures that the
application data cannot be written to the outbuf before the proxy header
is added.
See: https://bugs.torproject.org/4700
2018-09-15 22:17:57 +02:00
Alexander Færøy
9b511dc5d6
Change HiddenServiceExportCircuitID to take a string parameter: the protocol.
...
This patch changes HiddenServiceExportCircuitID so instead of being a
boolean it takes a string, which is the protocol. Currently only the
'haproxy' protocol is defined.
See: https://bugs.torproject.org/4700
2018-09-15 16:52:36 +03:00
Alexander Færøy
8f085841ef
Encode the 32-bit Global Identifier as 2 x 16-bit in the IPv6 address.
...
Without this patch we would encode the IPv6 address' last part as
::ffffffff instead of ::ffff:ffff when the GID is UINT32_MAX.
See: https://bugs.torproject.org/4700
2018-09-15 16:52:36 +03:00
George Kadianakis
e44e6a1857
Add man page entry.
2018-09-15 16:52:36 +03:00
George Kadianakis
b2092f1ced
Add unittest for HiddenServiceExportCircuitID.
...
Had to move a function to test helpers.
2018-09-15 16:52:32 +03:00
George Kadianakis
6069185bcc
Save original virtual port in edge conn HS ident.
2018-09-15 16:32:24 +03:00
George Kadianakis
5d34a8cbbb
Improve export_hs_client_circuit_id() function.
...
- Change default values.
- Beautify.
- Documentation.
2018-09-15 16:32:23 +03:00
George Kadianakis
27d7491f5a
Introduce per-service HiddenServiceExportCircuitID torrc option.
...
Moves code to a function, better viewed with --color-moved.
2018-09-15 16:31:22 +03:00
Nick Mathewson
035166e7bf
Add a missing function for windows
2018-09-14 15:02:11 -04:00
Nick Mathewson
af39649aad
Explicitly ignore BIO_set_close() return val to fix #27711
2018-09-14 13:09:10 -04:00
Nick Mathewson
4bdba5fa4b
Merge branch 'maint-0.3.4'
2018-09-14 12:56:31 -04:00
Nick Mathewson
6f47734ea8
Merge branch 'maint-0.3.3' into maint-0.3.4
2018-09-14 12:56:30 -04:00
Nick Mathewson
a546e07600
Merge branch 'maint-0.3.2' into maint-0.3.3
2018-09-14 12:56:30 -04:00
David Goulet
0971b3ce4d
hs-v3: Don't BUG() on directory permission check failure
...
In hs_config.c, we do validate the permission of the hidden service directory
but we do not try to create it. So, in the event that the directory doesn't
exists, we end up in the loading key code path which checks for the
permission and possibly creates the directory. On failure, don't BUG() since
there is a perfectly valid use case for that function to fail.
Fixes #27335
Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-09-14 12:56:26 -04:00
Nick Mathewson
6e940829cc
Merge remote-tracking branch 'dgoulet/ticket27040_035_01'
2018-09-14 12:54:13 -04:00
Nick Mathewson
79f8641ee5
Merge branch 'nss_countbytes_squashed'
2018-09-14 12:45:30 -04:00
Nick Mathewson
ac93c911ce
Allow malloc includes in tls library
2018-09-14 12:44:56 -04:00
Nick Mathewson
126819c947
Add support for lower-level byte counting with NSS
...
This is harder than with OpenSSL, since OpenSSL counts the bytes on
its own and NSS doesn't. To fix this, we need to define a new
PRFileDesc layer that has its own byte-counting support.
Closes ticket 27289.
2018-09-14 12:44:56 -04:00
David Goulet
33c99cf565
hs-v2: Demote log warning to info when we don't have a consensus
...
Fixes #27040
Signed-off-by: David Goulet <dgoulet@torproject.org>
2018-09-14 12:04:01 -04:00
cypherpunks
5c47f725b0
rust/protover: delete ProtoSet::retain
...
As the comment noted, it was horribly inefficient.
2018-09-14 15:10:22 +00:00
cypherpunks
c613d55134
rust/protover: use .and_not_in() instead of .retain() in all_supported()
...
.retain() would allocating a Vec of billions of integers and check them
one at a time to separate the supported versions from the unsupported.
This leads to a memory DoS.
Closes ticket 27206. Bugfix on e6625113c9
.
2018-09-14 15:08:55 +00:00
cypherpunks
578f7326ed
rust/protover: add ProtoSet::and_not_in()
...
This is a way more efficient version of retain().
2018-09-14 15:08:54 +00:00