Nick Mathewson
0792cc107e
Convert connection_free to a nulling macro.
2017-12-08 14:47:19 -05:00
Nick Mathewson
a48ba072a9
Rename connection_free_ to connection_free_minimal.
2017-12-08 14:47:19 -05:00
Nick Mathewson
b0cc9856ee
Update free functions into macros: src/or/ part 1
...
This covers addressmap.h (no change needed) through confparse.h
2017-12-08 14:47:19 -05:00
Nick Mathewson
c92ac9f5cb
Convert the rest of src/common's headers to use FREE_AND_NULL
2017-12-08 14:47:19 -05:00
Nick Mathewson
94db8f32e4
Make all the free() functions from container.h clear their targets
2017-11-17 12:01:19 -05:00
Nick Mathewson
fcdec00685
Merge branch 'maint-0.3.2'
2017-11-17 09:59:26 -05:00
Nick Mathewson
3a5ca47d8f
Fix a clang unitialized-var warning
2017-11-17 09:57:52 -05:00
George Kadianakis
7e52947d57
Intoduce unittest for skipping outdated dirservers.
2017-11-17 09:57:46 -05:00
Nick Mathewson
11eaf208c0
Merge branch 'bug24247_032'
2017-11-11 14:46:33 -05:00
Nick Mathewson
a7ca71cf6b
Fix mock_crypto_pk_public_checksig__nocheck() to handle short RSA keys
...
This function -- a mock replacement used only for fuzzing -- would
have a buffer overflow if it got an RSA key whose modulus was under
20 bytes long.
Fortunately, Tor itself does not appear to have a bug here.
Fixes bug 24247; bugfix on 0.3.0.3-alpha when fuzzing was
introduced. Found by OSS-Fuzz; this is OSS-Fuzz issue 4177.
2017-11-11 14:44:45 -05:00
Nick Mathewson
6ea3db6fa7
Fix unit test behavior: we need to be in STATE_LIVE.
2017-11-09 09:30:43 -05:00
Nick Mathewson
0626031564
Merge branch 'ticket20895'
2017-11-09 09:17:53 -05:00
Nick Mathewson
c2c1fa6b95
Merge branch 'maint-0.3.2'
2017-11-08 08:13:14 -05:00
Nick Mathewson
e5a83062ed
Merge branch 'bug23816_029_squashed' into maint-0.3.2
2017-11-08 08:11:22 -05:00
Nick Mathewson
cb29687e93
Replace our random-exponential-delay algorithm.
...
This patch has implementations of the "decorrelated" and "full"
algorithms from https://www.awsarchitectureblog.com/2015/03/backoff.html
2017-11-08 07:56:16 -05:00
Nick Mathewson
c6c4a421fd
Merge branch 'maint-0.3.2'
2017-11-07 09:58:53 -05:00
Nick Mathewson
9d848ca58a
Merge remote-tracking branch 'asn/ticket23623_032_01' into maint-0.3.2
2017-11-07 09:58:42 -05:00
Nick Mathewson
0227aab1b7
Merge branch 'maint-0.3.2'
2017-11-06 13:01:56 -05:00
Nick Mathewson
7d767706ef
Merge branch 'bug24150_032_squashed' into maint-0.3.2
2017-11-06 12:59:23 -05:00
Nick Mathewson
5240afa713
Fix a memory leak on decryption non-failure of v3 hsdesc
...
If it decrypts something that turns out to start with a NUL byte,
then decrypt_desc_layer() will return 0 to indicate the length of
its result. But 0 also indicates an error, which causes the result
not to be freed by decrypt_desc_layer()'s callers.
Since we're trying to stabilize 0.3.2.x, I've opted for the simpler
possible fix here and made it so that an empty decrypted string will
also count as an error.
Fixes bug 24150 and OSS-Fuzz issue 3994.
The original bug was present but unreachable in 0.3.1.1-alpha. I'm
calling this a bugfix on 0.3.2.1-alpha since that's the first version
where you could actually try to decrypt these descriptors.
2017-11-06 12:59:11 -05:00
Nick Mathewson
7097c4a37a
Merge remote-tracking branch 'dgoulet/bug24053_033_01'
2017-11-06 10:04:22 -05:00
Nick Mathewson
9f650b24e9
Merge branch 'maint-0.3.2'
2017-11-05 14:09:21 -05:00
Sebastian Hahn
d3fee8b823
ClientDNSRejectInternalAddresses in non-default networks
...
Once again allow the flag to be set, unless the default network is used.
Thanks to nickm for a suggestion for the workaround to a test failure.
2017-11-04 18:31:02 +01:00
Sebastian Hahn
5a46074e55
Revert "Make ClientDNSRejectInternalAddresses testing-only."
...
This reverts commit 27fa4a98d2
2017-11-04 18:30:59 +01:00
Nick Mathewson
f865993653
Merge branch 'maint-0.3.2'
2017-11-02 10:26:30 -04:00
teor
27ea6fcd31
Test that IPv6-only clients can use microdescriptors
...
When running "make test-network-all", test that IPv6-only clients can use
microdescriptors. IPv6-only microdescriptor client support was fixed in
tor 0.3.0.1-alpha.
Requires chutney master 61c28b9 or later.
Closes ticket 24109.
2017-11-02 10:25:49 -04:00
Nick Mathewson
a46dcc0709
Merge branch 'maint-0.3.2'
2017-11-02 10:22:35 -04:00
Nick Mathewson
3aab8307a5
Merge branch 'ticket23820_032_01_squashed' into maint-0.3.2
2017-11-02 10:19:29 -04:00
teor
176bfe1bed
Don't run IPv6-only v3 single onion service tests using chutney
...
Part of #23820 .
2017-11-02 10:19:05 -04:00
Nick Mathewson
ef25f957e7
Merge branch 'tor_api_squashed'
2017-11-01 13:22:16 -04:00
David Goulet
198ede5314
test: Fix SR initialization in routerlist test
...
Fixes #24053
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-11-01 11:39:52 -04:00
David Goulet
bd631a649b
test: Fix voting schedule for hs_service.c
...
Part of #23623
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-10-31 14:49:31 -04:00
David Goulet
814f4c6967
test: Fix voting schedule for hs_common.c
...
Part of #23623
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-10-31 14:49:19 -04:00
David Goulet
19d32fd0d6
test: Fix voting schedule for shared random
...
Part of #23623
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-10-31 14:48:50 -04:00
Nick Mathewson
43cbcd3896
Merge branch 'maint-0.3.2'
2017-10-31 14:31:55 -04:00
Nick Mathewson
0627512368
Merge branch 'bug24082_032' into maint-0.3.2
2017-10-31 14:31:21 -04:00
David Goulet
33da5d7672
test: Initialize the voting schedule in test_dir.c
...
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-10-31 14:07:41 -04:00
Nick Mathewson
2b6f246652
Merge branch 'maint-0.3.2'
2017-10-31 14:04:34 -04:00
Nick Mathewson
8dffc46748
Merge branch 'hsdescv3_fuzz_more' into maint-0.3.2
2017-10-31 14:04:31 -04:00
Nick Mathewson
b76a161e01
Merge branch 'fix-torrcd-sandbox-22605v2'
2017-10-31 13:58:33 -04:00
Nick Mathewson
4700ba6c3d
Merge branch 'maint-0.3.2'
2017-10-31 12:19:42 -04:00
Nick Mathewson
3d93ec3ef4
Merge branch 'bug23762_032_02_squashed' into maint-0.3.2
2017-10-31 12:14:21 -04:00
David Goulet
5dbcd48f0e
hs-v3: Attempt descriptor refetch when dirinfo changes
...
When the directory information changes, callback to the HS client subsystem so
it can check if any pending SOCKS connections are waiting for a descriptor. If
yes, attempt a refetch for those.
Fixes #23762
Signed-off-by: David Goulet <dgoulet@torproject.org>
2017-10-31 12:14:11 -04:00
Nick Mathewson
5dce134fbb
Initialize the mock options in the fuzzing code
...
Fixes bug 24082; bugfix on 0.3.0.3-alpha. Found by Brian Carpenter.
2017-10-30 17:05:26 -04:00
Nick Mathewson
26e0909e51
In the hsdescv3 fuzzer, replace the decryption function.
...
The new decryption function performs no decryption, skips the salt,
and doesn't check the mac. This allows us to fuzz the
hs_descriptor.c code using unencrypted descriptor test, and exercise
more of the code.
Related to 21509.
2017-10-27 14:28:02 -04:00
Nick Mathewson
12f58b42a8
Allow test_rust.sh to run from outside the makefile
...
(This is just a matter of making sure that we handle the case where
abs_top_builddir is not set)
2017-10-27 12:54:52 -04:00
Nick Mathewson
30a681553f
Merge remote-tracking branch 'public/exit_carefully'
2017-10-27 11:13:05 -04:00
Nick Mathewson
fa78546dbc
Make sure all C files have copyright/license notices
2017-10-27 10:59:36 -04:00
Nick Mathewson
f5e9e2748f
Merge branch 'protover-rust-impl_squashed'
2017-10-27 10:05:30 -04:00
Chelsea Holland Komlo
91bca5c31b
move to allocating c strings from rust
2017-10-27 10:02:08 -04:00
