Nick Mathewson
8f362b7bce
Extract extend_info manipulation functions into a new file.
2020-07-02 09:51:03 -04:00
David Goulet
7a6e1f2491
scripts: Fix rename_c_identifier.py uncommitted warning
...
Only warn when we actually want a commit _and_ there are uncommitted changes
found. Else, it is fine to rename if the script is not creating a commit.
Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-06-30 13:48:22 -04:00
David Goulet
86da0cfd36
Merge branch 'tor-github/pr/1945'
2020-06-24 13:51:51 -04:00
George Kadianakis
279225acdd
Merge branch 'tor-github/pr/1929'
2020-06-24 17:20:25 +03:00
David Goulet
6da8c0b4fa
addr: Rename resolve_my_address to be v4 specific
...
Part of #33233
Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-06-23 09:25:36 -04:00
George Kadianakis
3cb77a9cca
Merge branch 'maint-0.4.4'
2020-06-11 17:29:54 +03:00
Nick Mathewson
f3c82c86f9
Improve our clang-format.sh script
...
Previously, this script ran over every C file in our source code,
which took up to a minute on my desktop.
Instead, the script now has several modes that it can run in, to
minimize the time spent and improve useful output. It should now be
suitable for everyday use and git hooks. I hope.
I've also renamed this script, so that we can keep using it in the
future if we were to move to some tool other than clang-format.
2020-06-11 10:28:03 -04:00
George Kadianakis
52edea121e
Fold in a changes file and update exceptions.txt.
...
Co-authored-by: Florentin Rochet <florentin.rochet@uclouvain.be>
2020-06-11 16:13:25 +03:00
Nick Mathewson
fc16dbf7aa
Remove "enable_practracker_in_hooks" for 0.4.4.
2020-06-09 15:47:25 -04:00
Nick Mathewson
354f085e5f
Merge remote-tracking branch 'tor-github/pr/1888/head'
2020-06-09 15:44:58 -04:00
c
76d07940fd
scripts/maint: Remove obsolete generated tor.sh
...
Per <https://trac.torproject.org/projects/tor/ticket/34381 >, these
contrib scripts were generated by older versions of Tor and shellcheck
will throw warnings if they still exist.
2020-06-08 01:41:36 +00:00
teor
8ec4d9cc3c
practracker: Accept extra file lines, enforce a smaller function
...
Accept extra lines in nodelist and routerlist due to extra features, and
due to refactors that simplify some functions.
Most of the refactor eliminated duplicate code in smaller functions, so
there's only one large function that got smaller.
Part of 34200.
2020-05-18 21:53:52 +10:00
Nick Mathewson
bbfdee4c4e
Fix a python warning in format_changelog.py.
2020-05-14 10:37:52 -04:00
teor
de979dd7bd
practracker: Allow a few extra lines in circuituse
...
Part of 33222.
2020-05-13 20:08:29 +10:00
teor
b64972edcd
practracker: Accept extra or.h lines
2020-05-11 14:39:42 +10:00
teor
24099680f1
Appease practracker: wrapping costs lines
2020-05-07 20:19:19 +10:00
David Goulet
a25f167072
config: New file resolve_addr.{c|h}
...
Move a series of function from config.c into that new file which is related to
address resolving.
Part of #33789
Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-05-05 14:24:04 -04:00
teor
a202f03c64
practracker: Accept some wrapped long lines
...
Part of 33222.
2020-04-30 15:15:53 +10:00
teor
efcae919ae
practracker: Accept the connection buf refactor
...
Accept a few extra lines from the connection_buf_read_from_socket()
refactor.
Cleanup after 33131.
2020-04-30 13:55:26 +10:00
teor
ed4420b4b8
practracker: Allow an extra line in tor_addr_parse_mask_ports()
...
We added a cast, and wrapped a line.
2020-04-30 06:54:42 +10:00
teor
f5c34d340d
Run practracker regen
...
Lock-in improvements.
Accept some small function size increases.
Allow a small amount of extra file size increase.
2020-04-14 15:42:52 +10:00
Nick Mathewson
80031db32a
Merge remote-tracking branch 'tor-github/pr/1801/head'
2020-04-09 11:50:20 -04:00
teor
75aba30abf
relay: Run practracker --regen
...
Lock in some file and function size improvements.
Accept some small file size and dependency increases.
Part of 33633.
2020-04-09 11:00:04 +10:00
teor
065ccda4f6
Merge branch 'pr1838_squashed'
2020-04-07 17:36:17 +10:00
Nick Mathewson
ea9ff58921
Try rewriting normalize_srcdir to normalize harder.
2020-04-07 17:36:05 +10:00
Nick Mathewson
d3db84c1e7
Make check_subsystem_order work in distcheck builds.
2020-04-07 17:36:02 +10:00
Nick Mathewson
5f49695f94
Make check_subsystem_order work in out-of-tree builds.
2020-04-07 17:35:58 +10:00
Nick Mathewson
9b434b79ce
Add a test script to check subsystem order as part of make check.
2020-04-07 17:35:51 +10:00
teor
a762234ba2
scripts: Ignore editor temporary files
...
Ignore editor temporary files when autostyling in:
* rectify_include_paths.py
* rename_c_identifier.py
Obviously correct changes to already-reviewed code.
2020-04-03 19:16:57 +10:00
Nick Mathewson
978b7ef45c
Teach --check-subsystem-order to take input from stdin
2020-03-26 12:30:30 -04:00
Nick Mathewson
a40d539f7c
Extend includes.py to compare topology with subsystem init order.
2020-03-26 12:17:53 -04:00
teor
a34a88c6f1
practracker: Accept changes
...
Accept a smaller file and function.
Let router.c grow slightly without warning.
Accept an extra comment line.
Cleanup after 32588.
2020-03-21 04:10:24 +10:00
teor
5d53b2317f
practracker: Accept larger dirvote file
...
Due to improved function comments.
2020-03-21 02:48:51 +10:00
teor
78b2984ac9
practracker: Regenerate exceptions file
...
Accept the current state of the tor codebase, including all the
files and functions that have increased technical debt over the
last few months.
Accepts all the current practracker warnings, so that reviewers
can focus on new warnings.
Closes ticket 33635.
2020-03-19 16:59:52 +10:00
teor
c86d08e3e6
Run "practracker.py --regen-overbroad"
...
We've successfully resolved a bunch of technical debt over the last
few months. Let's remove the allowances for that debt from the
practracker exceptions.
2020-03-17 23:02:16 +10:00
David Goulet
df3f2bd9aa
hs-v3: Log reasons why service can't upload descriptor
...
When a service can not upload its descriptor(s), we have no logs on why. This
adds logging for each possible reason for each descriptors.
That logging is emitted every second so it is rate limited for each reason and
per descriptor.
Closes #33400
Signed-off-by: David Goulet <dgoulet@torproject.org>
2020-03-11 15:32:11 +02:00
Nick Mathewson
686494f0f7
Merge branch 'clang_format_prep_3'
2020-03-05 08:23:32 -05:00
Nick Mathewson
caa392a73a
Merge remote-tracking branch 'tor-github/pr/1685/head'
2020-02-24 07:45:20 -05:00
Nick Mathewson
7ba7f9c0de
Merge branch 'maint-0.4.3'
2020-02-20 10:44:43 -05:00
Nick Mathewson
7b42502869
Merge remote-tracking branch 'tor-github/pr/1757/head' into maint-0.4.3
2020-02-20 10:44:36 -05:00
Nick Mathewson
66bbdadbbe
Merge branch 'extract_routerkeys_squashed'
2020-02-20 10:41:12 -05:00
Nick Mathewson
1d068625dd
Move relay_handshake.[ch] into src/feature/relay, and make it optional
2020-02-20 10:41:06 -05:00
Nick Mathewson
09fb7987c5
Merge branch 'maint-0.4.3'
2020-02-20 08:50:18 -05:00
Nick Mathewson
dd4fa9b468
Extract relay-only handshake code into its own file.
...
This is not the only relay-only handshake code, but it is most of
such code that is in connection_or.c.
2020-02-19 19:11:57 -05:00
teor
57ff8d4a53
practracker: Read unicode files when using Python 2
...
Allow the "practracker" coding best practices checking script to read
unicode files, when using Python 2.
We made the script use unicode literals in 0.4.3.1-alpha, but didn't
change the codec for opening files.
Fixes bug 33374; bugfix on 0.4.3.1-alpha.
2020-02-19 08:22:01 +10:00
teor
d8cbb2965e
Run "practracker --regen-overbroad"
...
Closes ticket 33373.
2020-02-19 08:13:02 +10:00
David Goulet
17724a7cde
Merge branch 'tor-github/pr/1743'
2020-02-18 09:06:13 -05:00
Nick Mathewson
d3c23b079a
lintChanges: Tolerate variants that sortChanges knows how to clean up.
2020-02-18 09:01:56 -05:00
Panagiotis Vasilopoulos
674a821fbb
Stop assuming that /usr/bin/python exists
...
Fixes 33192
2020-02-16 21:58:01 +02:00
Taylor Yu
55f088bb29
Script to check sorting of manpage entries
...
Add a script to help check the alphabetical ordering of option names
in a manpage. Closes ticket 33339.
2020-02-14 11:02:16 -06:00
