Nick Mathewson
040b478692
Remove a needless check in channel_tls_handle_incoming
...
This patch removes an "if (chan)" that occurred at a place where
chan was definitely non-NULL. Having it there made some static
analysis tools conclude that we were up to shenanigans.
This resolves #9979 .
2014-02-07 12:01:16 -05:00
Nick Mathewson
ef4eb823f3
Merge the circuit_{free,clear}_cpath functions
...
(Based on a suggestion by arma at #9777 )
2014-02-07 10:50:06 -05:00
Nick Mathewson
babbd3ff08
Merge remote-tracking branch 'public/feature9777_024_squashed'
...
Conflicts:
src/or/circuitbuild.c
2014-02-07 10:47:34 -05:00
Nick Mathewson
1068e50aec
Discard circuit paths on which nobody supports ntor
...
Right now this accounts for about 1% of circuits over all, but if you
pick a guard that's running 0.2.3, it will be about 6% of the circuits
running through that guard.
Making sure that every circuit has at least one ntor link means that
we're getting plausibly good forward secrecy on every circuit.
This implements ticket 9777,
2014-02-07 10:45:34 -05:00
Nick Mathewson
372adfa09a
Merge remote-tracking branch 'origin/maint-0.2.4'
2014-02-07 10:38:24 -05:00
Nick Mathewson
a7e946596d
Attribute bug 9602 to a version.
2014-02-07 10:38:00 -05:00
Andrea Shepard
707c1e2e26
NULL out conns on tlschans when freeing in case channel_run_cleanup() is late; fixes bug 9602
2014-02-06 14:47:34 -08:00
Nick Mathewson
5990edd195
Merge remote-tracking branch 'origin/maint-0.2.4'
2014-02-06 16:29:33 -05:00
Nick Mathewson
b4e8d8dc0e
Merge remote-tracking branch 'public/bug9716_024' into maint-0.2.4
2014-02-06 16:29:08 -05:00
Nick Mathewson
075482ff80
Merge remote-tracking branch 'public/bug10543_024_v2'
2014-02-06 16:25:26 -05:00
Nick Mathewson
dffac251f1
Make the handling for usable-exit counting handle ExitNodes better
...
It's possible to set your ExitNodes to contains only exits that don't
have the Exit flag. If you do that, we'll decide that 0 of your exits
are working. Instead, in that case we should look at nodes which have
(or which might have) exit policies that don't reject everything.
Fix for bug 10543; bugfix on 0.2.4.10-alpha.
2014-02-06 16:24:08 -05:00
Nick Mathewson
2d41cab150
Merge remote-tracking branch 'origin/maint-0.2.4'
2014-02-06 16:12:42 -05:00
Nick Mathewson
9e2de8cecc
changelog for 10793
2014-02-06 16:09:12 -05:00
Florent Daigniere
01132c93fd
Some anti-forensics paranoia...
...
sed -i 's/BN_free/BN_clear_free/g'
2014-02-06 16:09:12 -05:00
Nick Mathewson
1b93e3c6d9
Merge remote-tracking branch 'origin/maint-0.2.4'
...
Conflicts:
changes/bug10485
src/or/rephist.c
src/or/status.c
2014-02-06 13:27:04 -05:00
Nick Mathewson
655adbf667
Add a missing include
2014-02-06 13:25:36 -05:00
Nick Mathewson
534acf400e
Merge branch 'bug10485_024' into maint-0.2.4
2014-02-06 13:24:12 -05:00
Nick Mathewson
edc6fa2570
Deliver circuit handshake counts as part of the heartbeat
...
Previously, they went out once an hour, unconditionally.
Fixes 10485; bugfix on 0.2.4.17-rc.
2014-02-06 13:03:01 -05:00
Nick Mathewson
34740a17ea
Rename sun to s_un in test_addr.c
...
Apparently the compiler on solaris 9 didn't like "sun" as an identifier.
Fix for bug 10565; bugfix on 0.2.5.1-alpha.
2014-02-06 12:36:33 -05:00
Nick Mathewson
4268cbf294
Distcheck repair: add new python testing code to "tarballs"
...
'make distcheck' now passes again.
2014-02-04 11:08:22 -05:00
Nick Mathewson
c61a472076
test_config.c: log which address should have failed
2014-02-03 16:21:32 -05:00
Nick Mathewson
24544a10c0
Clean up test_hs.c: warning fix; tor_free() usage.
...
My OSX laptop rightly gave a warning because of sticking strlen() into
an int, but once I took a closer look... it appears that the strlen()
was part of a needlessly verbose implementation for tor_strdup().
While I was there, I fixed the usage of tor_free() in test_hs.c: It
checks for NULL, and it zeros its argument. So instead of
if (foo) {
tor_free(foo);
foo = NULL;
}
we should just say
tor_free(foo);
2014-02-03 16:12:30 -05:00
Nick Mathewson
5991f9a156
TransProxyType replaces TransTPROXY option
...
I'm making this change now since ipfw will want its own option too,
and proliferating options here isn't sensible.
(See #10582 and #10267 )
2014-02-03 13:56:19 -05:00
Karsten Loesing
00ec6e6af0
More fixes to rip out all of the v2 directory code.
...
(This was a squash commit, but I forgot to squash it. Sorry! --Nick)
2014-02-03 13:34:30 -05:00
rl1987
881c7c0f7d
10365: Close connections if the VERSIONS cell has an odd length.
...
Fixes issue 10365.
2014-02-03 13:14:27 -05:00
Nick Mathewson
8db8fda43f
check-spaces fixes for test_router.c
2014-02-03 13:00:15 -05:00
Nick Mathewson
696b484d4d
Defensive programming in control_event_hs_descriptor_*
...
It looks to me like these functions can never get called with NULL
arguments, but better safe than sorry.
2014-02-03 12:35:35 -05:00
Nick Mathewson
fee7f25ff8
Merge remote-tracking branch 'houqp/hs_control'
2014-02-03 12:28:42 -05:00
Nick Mathewson
27d81c756b
slownacl's pure-python curve25519 lets us test ntor everywhere.
...
Improvement on f308adf838
2014-02-03 11:34:13 -05:00
Nick Mathewson
c6c87fb6d1
Merge remote-tracking branch 'public/bug10758'
2014-02-03 11:05:29 -05:00
Nick Mathewson
3502b10229
changelog for 10793
2014-02-03 10:48:15 -05:00
Florent Daigniere
9d6e805d28
Some anti-forensics paranoia...
...
sed -i 's/BN_free/BN_clear_free/g'
2014-02-03 10:44:19 -05:00
Nick Mathewson
cac5949697
Merge branch 'feature_10582'
2014-02-02 15:48:27 -05:00
Nick Mathewson
25f0eb4512
Add a sandbox rule to allow IP_TRANSPARENT
2014-02-02 15:47:48 -05:00
Nick Mathewson
fd8947afc2
Move the friendly warning about TPROXY and root to EPERM time
...
I'm doing this because:
* User doesn't mean you're running as root, and running as root
doesn't mean you've set User.
* It's possible that the user has done some other
capability-based hack to retain the necessary privileges.
2014-02-02 15:45:00 -05:00
Nick Mathewson
09ccc4c4a3
Add support for TPROXY via new TransTPRoxy option
...
Based on patch from "thomo" at #10582 .
2014-01-31 12:59:35 -05:00
Qingping Hou
ebd99314cf
add test case for node_describe_by_id
2014-01-29 22:47:05 -05:00
Qingping Hou
0b0d4b4ebc
add test case for hidden service async events
2014-01-29 22:43:11 -05:00
Qingping Hou
29c18f5b71
add hidden service descriptor async control event
2014-01-29 22:23:57 -05:00
Qingping Hou
3b38fd87e8
add change log for hs_desc async event
2014-01-29 21:04:18 -05:00
Nick Mathewson
3193cbe2ba
Rip out all of the v2 directory code.
...
The remaining vestige is that we continue to publish the V2dir flag,
and that, for the controller, we continue to emit v2 directory
formats when requested.
2014-01-29 15:17:05 -05:00
Roger Dingledine
4fe253ef40
sort the changes entries that nick added
...
also replace them with the versions of the changelog stanzas from
release-0.2.4, for consistency
2014-01-26 19:48:57 -05:00
Nick Mathewson
6a6bc9da53
Document more coverage tricks in doc/HACKING
2014-01-21 16:44:48 -05:00
Nick Mathewson
01c7d06b91
Add some more options to the findMoreChanges.pl kludge-script
2014-01-20 15:47:54 -05:00
Nick Mathewson
3e0967191d
Note a missing number.
2014-01-20 15:45:49 -05:00
Nick Mathewson
17466ce10e
Incorporate changes from 0.2.4.20 into 0.2.5.2 changelog-in-progress
2014-01-20 15:44:31 -05:00
Nick Mathewson
694562815f
Move all merged-in-0.2.4.18-rc items into 0.2.5.2-alpha changelog section.
2014-01-20 15:41:06 -05:00
Nick Mathewson
9be105f94b
whitespace fixes
2014-01-17 12:41:56 -05:00
Nick Mathewson
8a49fac9e0
Coverate in util.c: test that tor_parse_* rejects negative base.
2014-01-17 11:58:09 -05:00
Nick Mathewson
ab0fdbb618
Add an --accel switch to run unit tests with crypto acceleration
2014-01-17 11:58:09 -05:00
