23208 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
teor	0ee9049e94	Use the latest options in rend_service_check_private_dir ... Fixup on both: * Refactor, adding a create argument... and * Check every hidden service directory's permissions...	2016-11-02 14:55:14 +11:00
teor	1747f28861	Check every hidden service directory's permissions when configuring ... Previously, we would only check the last hidden service directory. Fixes #20529, bugfix on ticket 13942 commit 85bfad1 in 0.2.6.2-alpha.	2016-11-02 14:32:04 +11:00
teor	01fe039b78	Test single onion service configs where the directory does not exist ... Runs a test for each combination of create/don't create directories. Tests #20484.	2016-11-02 14:17:52 +11:00
teor	13fbbe9cce	Make sure passthrough_test_setup doesn't inadvertently fail or skip tests ... passthrough_test_setup doesn't pass through arguments if the argument is equal to 0 or TT_SKIP. Instead, it fails or skips the test. Assert on this, so we don't accidentally fail or skip tests.	2016-11-02 14:16:14 +11:00
teor	77e1d660ee	Add get_fname_rnd for unit tests that want a unique path every time	2016-11-02 14:14:19 +11:00
teor	d7634dc519	Create get_fname_suffix, and refactor get_fname to use it	2016-11-02 14:13:34 +11:00
teor	2f48693663	Improve comments in check_private_dir and onion poisoning ... Comment changes only	2016-11-02 14:11:26 +11:00
teor	a906ff88a3	fixup! Refactor, adding a create argument to rend_service_check_private_dir	2016-11-02 14:10:52 +11:00
teor	fedafe7c0e	Use check_private_dir in test_single_onion_poisoning ... This avoids Win32 conditionals for mkdir.	2016-11-02 11:37:11 +11:00
teor	6c54181559	Remove redundant group permission code from rend_service_check_private_dir ... check_private_dir already does this for existing directories.	2016-11-02 11:20:49 +11:00
teor	c9db775243	Refactor, adding a create argument to rend_service_check_private_dir ... It used to be rend_service_check_and_create_private_dir, which always created the directory. No behaviour change.	2016-11-02 11:20:19 +11:00
Nick Mathewson	b2f82d45b7	Always call connection_ap_attach_pending() once a second. ... Fixes bug 19969; bugfix on b1d56fc58. We can fix this some more in later Tors, but for now, this is probably the simplest fix possible. This is a belt-and-suspenders fix, where the earlier fix ("Ask event_base_loop to finish when we add a pending stream") aims to respond to new streams as soon as they arrive, and this one aims to make sure that we definitely respond to all of the streams.	2016-11-01 20:09:44 -04:00
Roger Dingledine	d89804a69d	Ask event_base_loop to finish when we add a pending stream ... Fixes bug 19969; bugfix on b1d56fc58. We can fix this some more in later Tors, but for now, this is probably the right fix for us.	2016-11-01 19:52:55 -04:00
Roger Dingledine	28b755e660	refactor out the tor_event_base_loopexit() call ... no actual changes	2016-11-01 19:52:54 -04:00
Nick Mathewson	ff3e08f2af	Attempt to fix unit tests on netbsd	2016-11-01 13:32:21 -04:00
Nick Mathewson	733b245283	Merge remote-tracking branch 'teor/bug20472-029-v2' into maint-0.2.9	2016-11-01 13:05:33 -04:00
Nick Mathewson	9248466f0a	Merge branch 'bug20487_029' into maint-0.2.9	2016-11-01 12:44:20 -04:00
Nick Mathewson	e712b5d784	Merge branch 'bug19968_029' into maint-0.2.9	2016-10-31 16:33:03 -04:00
Nick Mathewson	24b7b922ae	Actually free the worker_state_t object when we do an update with it ... Previously we freed the old "keys" object, but leaked the worker_state_t that we had taken it from. Fixes bug 20401; bugfix on 0.2.6.3-alpha.	2016-10-31 15:20:25 -04:00
Nick Mathewson	b858452f94	Add a sentence to the manpage about nonanonymous=>Socksport 0. ... Closes 20487.	2016-10-31 15:13:27 -04:00
Nick Mathewson	d73c671d6d	policy_is_reject_star(): ... ome policies are default-reject, some default-accept. But policy_is_reject_star() assumed they were all default_reject. Fix that! Also, document that policy_is_reject_star() treats a NULL policy as empty. This allows us to simplify the checks in parse_reachable_addresses() by quite a bit. Fxes bug 20306; bugfix on 0.2.8.2-alpha.	2016-10-31 15:05:56 -04:00
Nick Mathewson	8841a9e396	Create single-onion-service directory before poisoning it, if needed ... (Also, refactor the code to create a hidden service directory into a separate funcion, so we don't have to duplicate it.) Fixes bug 20484; bugfix on 0.2.9.3-alpha.	2016-10-31 14:54:20 -04:00
Nick Mathewson	becc957839	Actually clamp the number of detected CPUs to 16. ... Previously we said we did, but didn't. Fixes #19968; bugfix on 0.2.3.1-alpha.	2016-10-31 14:19:39 -04:00
teor	3158777d35	Rename routerstatus_version_supports_ntor to *_supports_extend2_cells ... This helps avoid the confusion that caused bug 20472. Bugfix on commit 10aa913 from #19163 in tor-0.2.9.3-alpha.	2016-10-31 17:02:21 +11:00
teor	d81f2b5d81	Refactor circuit_pick_create_handshake ... Make the structure of circuit_pick_create_handshake consistent with circuit_pick_extend_handshake. No behaviour change.	2016-10-31 17:01:33 +11:00
teor	26d7a07ad7	In circuit_pick_extend_handshake, assume all hops support EXTEND2 and ntor ... This simplifies the function: if we have an ntor key, use ntor/EXTEND2, otherwise, use TAP/EXTEND. Bugfix on commit 10aa913 from 19163 in 0.2.9.3-alpha.	2016-10-31 17:01:04 +11:00
Nick Mathewson	d288704023	Avoid tor_fragile_assert() failure with DNSPort on RESOLVED_TYPE_ERROR ... The tor_fragile_assert() bug has existed here since c8a5e2d588 in tor-0.2.1.7-alpha forever, but tor_fragile_assert() was mostly a no-op until 0.2.9.1-alpha. Fixes bug 19869.	2016-10-26 14:16:40 -04:00
Nick Mathewson	9a3adb07c4	changes file for module docs	2016-10-18 19:35:10 -04:00
Nick Mathewson	54fda6b98a	Module-level docs for ext_orport and router.c	2016-10-18 19:32:49 -04:00
Nick Mathewson	4396540129	Turn replaycache.c module doc into doxygen	2016-10-18 12:31:50 -04:00
Nick Mathewson	d1b45786b1	Document connection_or.c and connection.c at module level	2016-10-18 12:25:55 -04:00
Nick Mathewson	84829e336c	Module documentation for circuitmux_ewma.c	2016-10-18 11:28:40 -04:00
Nick Mathewson	56933787d5	Turn circuitmux.c comments into module docs.	2016-10-18 11:17:34 -04:00
Nick Mathewson	35df48b189	Module docs for channel.c and channeltls.c	2016-10-18 10:53:12 -04:00
Nick Mathewson	6e823a27f1	Merge branch 'maint-0.2.8' ... "ours" commit to avoid bumping version.	2016-10-17 16:32:31 -04:00
Nick Mathewson	b0f1241a1d	Bump to 0.2.8.9-dev	2016-10-17 16:32:11 -04:00
Nick Mathewson	702c1dcf7b	Bump master to 0.2.9.4-alpha-dev	2016-10-17 16:31:40 -04:00
Nick Mathewson	8b0755c9bb	release-notes for 0.2.8.9	2016-10-17 15:00:58 -04:00
Nick Mathewson	3b6f924e50	Merge branch 'maint-0.2.8' ... ("ours" merge to avoid taking version bump)	2016-10-17 14:57:44 -04:00
Nick Mathewson	0fa3811c78	bump to 0.2.8.9	2016-10-17 14:57:26 -04:00
Nick Mathewson	52b2b2c82f	Fold 20384 into changelog	2016-10-17 14:55:05 -04:00
Nick Mathewson	66ecdcdd75	Update the buffer sentinel fix to work with our #20081 fix.	2016-10-17 14:52:44 -04:00
Nick Mathewson	1a74881063	Merge branch 'maint-0.2.8'	2016-10-17 14:51:45 -04:00
Nick Mathewson	1df114330e	Merge branch 'buf_sentinel_026_v2' into maint-0.2.8	2016-10-17 14:51:06 -04:00
Nick Mathewson	3cea86eb2f	Add a one-word sentinel value of 0x0 at the end of each buf_t chunk ... This helps protect against bugs where any part of a buf_t's memory is passed to a function that expects a NUL-terminated input. It also closes TROVE-2016-10-001 (aka bug 20384).	2016-10-17 14:49:54 -04:00
Nick Mathewson	eae0c00dda	changelog typo fixes from Rubiate	2016-10-17 14:06:20 -04:00
Nick Mathewson	edcad379cf	Bump version to 0.2.9.4-alpha.	2016-10-17 14:05:42 -04:00
Nick Mathewson	80530f706a	edits to changelog from kate and david	2016-10-17 14:03:48 -04:00
Nick Mathewson	949bfaf22b	Wrap the changelog, add a blurb	2016-10-17 11:04:11 -04:00
Nick Mathewson	20e9220d3d	Start on an 0.2.9.4-alpha changelog	2016-10-17 10:57:50 -04:00