Fix a low-impact memory leak in options_act_reversible()

Found by Coverity as CID 1455953

Fixes bug 32575; bug not in any released Tor.
This commit is contained in:
Nick Mathewson 2019-11-22 09:04:36 -05:00
parent cf22841e3b
commit ff7d0ebcfe

View File

@ -1945,7 +1945,7 @@ options_act_reversible,(const or_options_t *old_options, char **msg))
if (first_time) { if (first_time) {
if (options_switch_id(msg) < 0) if (options_switch_id(msg) < 0)
goto done; goto rollback;
} }
/* On the other hand, we need to touch the file system _after_ we /* On the other hand, we need to touch the file system _after_ we
@ -1954,7 +1954,7 @@ options_act_reversible,(const or_options_t *old_options, char **msg))
*/ */
if (first_time) { if (first_time) {
if (options_create_directories(msg) < 0) if (options_create_directories(msg) < 0)
goto done; goto rollback;
} }
/* Bail out at this point if we're not going to be a client or server: /* Bail out at this point if we're not going to be a client or server: