nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-24 04:13:28 +01:00
Code Issues Packages Projects Releases Wiki Activity

rust: abort on panic in all profiles

Browse Source 
Until https://github.com/rust-lang/rust/issues/52652 is fixed,
unwinding on panic is potentially unsound in a mixed C/Rust codebase.

The codebase is supposed to be panic-free already, but just to be safe.

This started mattering at commit d1820c1516.

Fixes #27199; bugfix on tor-0.3.3.1-alpha.
This commit is contained in:
cypherpunks 2018-08-18 19:18:48 +00:00
parent 87aacbfbba
commit fecd583c0e
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
changes/bug27199 Normal file
View File

@ -0,0 +1,3 @@
o Minor bugfixes (rust):
- Abort on panic in all build profiles, instead of potentially unwinding
into C code. Fixes bug 27199; bugfix on 0.3.3.1-alpha.

10
src/rust/Cargo.toml
View File

@ -1,7 +1,17 @@
[workspace] [workspace]
members = ["tor_util", "protover", "smartlist", "external", "tor_allocate", "tor_rust"] members = ["tor_util", "protover", "smartlist", "external", "tor_allocate", "tor_rust"]
# Can remove panic="abort" when this issue is fixed:
# https://github.com/rust-lang/rust/issues/52652
[profile.dev]
panic = "abort"
[profile.release] [profile.release]
debug = true debug = true
panic = "abort" panic = "abort"
[profile.test]
panic = "abort"
[profile.bench]
panic = "abort"