mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-10 13:13:44 +01:00
Disable ed25519-donna's batch verification.
Fixes bug 40078. As reported by hdevalence our batch verification logic can cause an assert crash. The assert happens because when the batch verification of ed25519-donna fails, the code in `ed25519_checksig_batch()` falls back to doing a single verification for each signature. The crash occurs because batch verification failed, but then all signatures individually verified just fine. That's because batch verification and single verification use a different equation which means that there are sigs that can pass single verification but fail batch verification. Fixing this would require modding ed25519-donna which is not in scope for this ticket, and will be soon deprecated in favor of arti and ed25519-dalek, so my branch instead removes batch verification.
This commit is contained in:
parent
399518da02
commit
fe5a9db1e6
3
changes/bug40078
Normal file
3
changes/bug40078
Normal file
@ -0,0 +1,3 @@
|
|||||||
|
o Minor bugfix (crypto):
|
||||||
|
- Disable the unused batch verification feature of ed25519-donna. Fixes
|
||||||
|
bug 40078; bugfix on 0.2.6.1-alpha. Found by Henry de Valence.
|
@ -102,7 +102,7 @@ static const ed25519_impl_t impl_donna = {
|
|||||||
|
|
||||||
ed25519_donna_open,
|
ed25519_donna_open,
|
||||||
ed25519_donna_sign,
|
ed25519_donna_sign,
|
||||||
ed25519_sign_open_batch_donna,
|
NULL, /* Don't use donna's batching code because of #40078 */
|
||||||
|
|
||||||
ed25519_donna_blind_secret_key,
|
ed25519_donna_blind_secret_key,
|
||||||
ed25519_donna_blind_public_key,
|
ed25519_donna_blind_public_key,
|
||||||
|
Loading…
Reference in New Issue
Block a user