If somebody tries to overflow my dirport, don't log his IP by default.

aka Fix an instance where a Tor directory mirror might accidentally
log the IP address of a misbehaving Tor client. Bugfix on
0.1.0.1-rc.
This commit is contained in:
Roger Dingledine 2009-11-21 23:09:24 -05:00
parent 4f8b36a1e2
commit fdd58f3bd5
2 changed files with 5 additions and 2 deletions

View File

@ -6,6 +6,9 @@ Changes in version 0.2.2.7-alpha - 2009-??-??
with a different memory value than we use for overwriting a freed
internal circuit structure. Should help with debugging. Suggested
by bug 1055.
- Fix an instance where a Tor directory mirror might accidentally
log the IP address of a misbehaving Tor client. Bugfix on
0.1.0.1-rc.
Changes in version 0.2.2.6-alpha - 2009-11-19

View File

@ -3242,8 +3242,8 @@ directory_handle_command(dir_connection_t *conn)
&body, &body_len, MAX_DIR_UL_SIZE, 0)) {
case -1: /* overflow */
log_warn(LD_DIRSERV,
"Invalid input from address '%s'. Closing.",
conn->_base.address);
"Request too large from address '%s' to DirPort. Closing.",
safe_str(conn->_base.address));
return -1;
case 0:
log_debug(LD_DIRSERV,"command not all here yet.");