nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 04:56:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix obscure 64-bit big-endian hidserv bug

Browse Source 
Fix an obscure bug where hidden services on 64-bit big-endian
systems might mis-read the timestamp in v3 introduce cells, and
refuse to connect back to the client. Discovered by "rotor".
Bugfix on 0.2.1.6-alpha.
This commit is contained in:
Roger Dingledine 2009-09-02 20:36:11 -04:00
parent 3db36d86c4
commit fcacf22491
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -18,6 +18,10 @@ Changes in version 0.2.1.20 - 2009-??-??
- Fix an extremely rare infinite recursion bug that could occur if - Fix an extremely rare infinite recursion bug that could occur if
we tried to log a message after shutting down the log subsystem. we tried to log a message after shutting down the log subsystem.
Found by Matt Edman. Bugfix on 0.2.0.16-alpha. Found by Matt Edman. Bugfix on 0.2.0.16-alpha.
- Fix an obscure bug where hidden services on 64-bit big-endian
systems might mis-read the timestamp in v3 introduce cells, and
refuse to connect back to the client. Discovered by "rotor".
Bugfix on 0.2.1.6-alpha.
- We were triggering a CLOCK_SKEW controller status event whenever - We were triggering a CLOCK_SKEW controller status event whenever
we connect via the v2 connection protocol to any relay that has we connect via the v2 connection protocol to any relay that has
a wrong clock. Instead, we should only inform the controller when a wrong clock. Instead, we should only inform the controller when

5
src/or/rendservice.c
View File

@ -1011,13 +1011,12 @@ rend_service_introduce(origin_circuit_t *circuit, const char *request,
} }
/* Check timestamp. */ /* Check timestamp. */
memcpy((char*)&ts, buf+1+v3_shift, sizeof(uint32_t)); ts = ntohl(get_uint32(buf+1+v3_shift));
v3_shift += 4; v3_shift += 4;
ts = ntohl((uint32_t)ts);
if ((now - ts) < -1 * REND_REPLAY_TIME_INTERVAL / 2 || if ((now - ts) < -1 * REND_REPLAY_TIME_INTERVAL / 2 ||
(now - ts) > REND_REPLAY_TIME_INTERVAL / 2) { (now - ts) > REND_REPLAY_TIME_INTERVAL / 2) {
log_warn(LD_REND, "INTRODUCE2 cell is too %s. Discarding.", log_warn(LD_REND, "INTRODUCE2 cell is too %s. Discarding.",
(now - ts) < 0 ? "old" : "new"); (now - ts) < 0 ? "old" : "new");
return -1; return -1;
} }
} }