nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 22:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'bug1141_v3' into maint-0.2.1

Browse Source
This commit is contained in:
Nick Mathewson 2010-08-17 11:55:58 -04:00
commit fc66a2ad1b
2 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/bug1141 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes:
- Fix an assertion failure that could occur in caches or bridge users
when using a very short voting interval on a testing network.
Diagnosed by Robert Hogan. Fixes bug 1141; bugfix on 0.2.0.8-alpha.

17
src/or/networkstatus.c
View File

@ -1132,11 +1132,21 @@ update_consensus_networkstatus_fetch_time(time_t now)
if (c) { if (c) {
long dl_interval; long dl_interval;
long interval = c->fresh_until - c->valid_after; long interval = c->fresh_until - c->valid_after;
long min_sec_before_caching = CONSENSUS_MIN_SECONDS_BEFORE_CACHING;
time_t start; time_t start;
if (min_sec_before_caching > interval/16) {
/* Usually we allow 2-minutes slop factor in case clocks get
desynchronized a little. If we're on a private network with
a crazy-fast voting interval, though, 2 minutes may be too
much. */
min_sec_before_caching = interval/16;
}
if (directory_fetches_dir_info_early(options)) { if (directory_fetches_dir_info_early(options)) {
/* We want to cache the next one at some point after this one /* We want to cache the next one at some point after this one
* is no longer fresh... */ * is no longer fresh... */
start = c->fresh_until + CONSENSUS_MIN_SECONDS_BEFORE_CACHING; start = c->fresh_until + min_sec_before_caching;
/* But only in the first half-interval after that. */ /* But only in the first half-interval after that. */
dl_interval = interval/2; dl_interval = interval/2;
} else { } else {
@ -1150,10 +1160,9 @@ update_consensus_networkstatus_fetch_time(time_t now)
* to choose the rest of the interval *after* them. */ * to choose the rest of the interval *after* them. */
if (directory_fetches_dir_info_later(options)) { if (directory_fetches_dir_info_later(options)) {
/* Give all the *clients* enough time to download the consensus. */ /* Give all the *clients* enough time to download the consensus. */
start = start + dl_interval + CONSENSUS_MIN_SECONDS_BEFORE_CACHING; start = start + dl_interval + min_sec_before_caching;
/* But try to get it before ours actually expires. */ /* But try to get it before ours actually expires. */
dl_interval = (c->valid_until - start) - dl_interval = (c->valid_until - start) - min_sec_before_caching;
CONSENSUS_MIN_SECONDS_BEFORE_CACHING;
} }
} }
if (dl_interval < 1) if (dl_interval < 1)