nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-10 13:13:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable unstable circuit padding unittest.

Browse Source 
until #29298 is implemented.
This commit is contained in:
George Kadianakis 2019-02-14 12:07:10 +02:00
parent c320c52e89
commit f5a6d4c6ea
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changes/bug29298 Normal file
View File

@ -0,0 +1,5 @@
o Minor bugfixes (testing, circuit padding):
- Disabled unstable circuit padding unittest that was causing intermittent
test failures because of ill-defined small histogram. Such histograms
will be allowed again after 29298 is implemented. Fixes second case of
bug 29122; bugfix on 0.4.0.1-alpha.

8
src/test/test_circuitpadding.c
View File

@ -46,7 +46,6 @@ void test_circuitpadding_conditions(void *arg);
void test_circuitpadding_serialize(void *arg); void test_circuitpadding_serialize(void *arg);
void test_circuitpadding_rtt(void *arg); void test_circuitpadding_rtt(void *arg);
void test_circuitpadding_tokens(void *arg); void test_circuitpadding_tokens(void *arg);
void test_circuitpadding_circuitsetup_machine(void *arg);
static void static void
simulate_single_hop_extend(circuit_t *client, circuit_t *mid_relay, simulate_single_hop_extend(circuit_t *client, circuit_t *mid_relay,
@ -1809,6 +1808,8 @@ test_circuitpadding_conditions(void *arg)
return; return;
} }
/** Disabled unstable test until #29298 is implemented (see #29122) */
#if 0
void void
test_circuitpadding_circuitsetup_machine(void *arg) test_circuitpadding_circuitsetup_machine(void *arg)
{ {
@ -2054,6 +2055,7 @@ test_circuitpadding_circuitsetup_machine(void *arg)
return; return;
} }
#endif
/** Helper function: Initializes a padding machine where every state uses the /** Helper function: Initializes a padding machine where every state uses the
* uniform probability distribution. */ * uniform probability distribution. */
@ -2340,11 +2342,11 @@ test_circuitpadding_global_rate_limiting(void *arg)
{ #name, test_##name, (flags), NULL, NULL } { #name, test_##name, (flags), NULL, NULL }
struct testcase_t circuitpadding_tests[] = { struct testcase_t circuitpadding_tests[] = {
//TEST_CIRCUITPADDING(circuitpadding_circuitsetup_machine, 0),
TEST_CIRCUITPADDING(circuitpadding_tokens, TT_FORK), TEST_CIRCUITPADDING(circuitpadding_tokens, TT_FORK),
TEST_CIRCUITPADDING(circuitpadding_negotiation, TT_FORK), TEST_CIRCUITPADDING(circuitpadding_negotiation, TT_FORK),
TEST_CIRCUITPADDING(circuitpadding_wronghop, TT_FORK), TEST_CIRCUITPADDING(circuitpadding_wronghop, TT_FORK),
TEST_CIRCUITPADDING(circuitpadding_circuitsetup_machine, TT_FORK), /** Disabled unstable test until #29298 is implemented (see #29122) */
// TEST_CIRCUITPADDING(circuitpadding_circuitsetup_machine, TT_FORK),
TEST_CIRCUITPADDING(circuitpadding_conditions, TT_FORK), TEST_CIRCUITPADDING(circuitpadding_conditions, TT_FORK),
TEST_CIRCUITPADDING(circuitpadding_rtt, TT_FORK), TEST_CIRCUITPADDING(circuitpadding_rtt, TT_FORK),
TEST_CIRCUITPADDING(circuitpadding_sample_distribution, TT_FORK), TEST_CIRCUITPADDING(circuitpadding_sample_distribution, TT_FORK),