nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 21:16:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Zero a cipher completely before freeing it

Browse Source 
We used to only zero the first ptrsize bytes of the cipher. Since
cipher is large enough, we didn't zero too many bytes. Discovered
and fixed by ekir. Fixes bug 1254.
This commit is contained in:
Sebastian Hahn 2010-02-22 11:39:29 +01:00
parent a7e0b2d6d9
commit f5112fa487
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -45,6 +45,9 @@ Changes in version 0.2.2.9-alpha - 2010-02-22
- Fix a spec conformance issue: the network-status-version token
must be the first token in a v3 consensus or vote. Discovered by
parakeep. Bugfix on 0.2.0.3-alpha.
- When freeing a cipher, zero it out completely. We only zeroed
the first ptrsize bytes. Bugfix on tor-0.0.2pre8. Discovered
and patched by ekir. Fixes bug 1254.
o Code simplifications and refactoring:
- Generate our manpage and HTML documentation using Asciidoc. This

2
src/common/aes.c
View File

@ -268,7 +268,7 @@ aes_free_cipher(aes_cnt_cipher_t *cipher)
#ifdef USE_OPENSSL_EVP
EVP_CIPHER_CTX_cleanup(&cipher->key);
#endif
memset(cipher, 0, sizeof(cipher));
memset(cipher, 0, sizeof(aes_cnt_cipher_t));
tor_free(cipher);
}