From 9876575d2c14ced3febca0c1a65808585fe8504d Mon Sep 17 00:00:00 2001 From: rl1987 Date: Sun, 3 Jun 2018 16:45:09 +0300 Subject: [PATCH] Silence -Wbad-function-cast warning (when DEBUG_SMARTLIST is on) --- changes/bug26283 | 4 ++++ src/or/routerlist.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 changes/bug26283 diff --git a/changes/bug26283 b/changes/bug26283 new file mode 100644 index 0000000000..5ec856af84 --- /dev/null +++ b/changes/bug26283 @@ -0,0 +1,4 @@ + o Minor bugfixes (C correctness): + - Avoid casting return value of smartlist_len() to double as + compiler does not like it when -Wbad-function-cast is on. + Fixes bug 26283; bugfix on 0.2.4.10-alpha. diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 7603eb3ecf..8788dc0190 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -2764,7 +2764,7 @@ frac_nodes_with_descriptors(const smartlist_t *sl, if (node_has_any_descriptor(node)) n_with_descs++; }); - return ((double)n_with_descs) / (double)smartlist_len(sl); + return ((double)n_with_descs) / smartlist_len(sl); } present = 0.0;