mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-11 05:33:47 +01:00
Remove a ??? comment in node_get_by_nickname
Bug 1859 shows that the router_get_by_nickname behavior was wrong, and the node_get_by_nickname is right.
This commit is contained in:
parent
bd1a694221
commit
f3eb2a10ae
@ -443,15 +443,6 @@ node_get_by_nickname(const char *nickname, int warn_if_unnamed)
|
||||
if (!the_nodelist)
|
||||
return NULL;
|
||||
|
||||
/* ???? NM Naming authorities had an additional weird behavior here where
|
||||
they would treat their own namings as slightly authoritative in a
|
||||
strange and inconsistent way. I think that this way is better, but we
|
||||
could get the old behavior back if we wanted to by adding a function
|
||||
to look in the fp_by_name table in fingerprint_list, and using this
|
||||
function to override the name-to-digest lookup below if we are a
|
||||
naming server. -NM
|
||||
*/
|
||||
|
||||
/* Handle these cases: DIGEST, $DIGEST, $DIGEST=name, $DIGEST~name. */
|
||||
if ((node = node_get_by_hex_id(nickname)) != NULL)
|
||||
return node;
|
||||
|
Loading…
Reference in New Issue
Block a user