From f3eb2a10ae432eb0907418ff69b5e9535b3c7970 Mon Sep 17 00:00:00 2001 From: Nick Mathewson Date: Thu, 21 Oct 2010 11:18:55 -0400 Subject: [PATCH] Remove a ??? comment in node_get_by_nickname Bug 1859 shows that the router_get_by_nickname behavior was wrong, and the node_get_by_nickname is right. --- src/or/nodelist.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/or/nodelist.c b/src/or/nodelist.c index 34482e607d..951a7a8e87 100644 --- a/src/or/nodelist.c +++ b/src/or/nodelist.c @@ -443,15 +443,6 @@ node_get_by_nickname(const char *nickname, int warn_if_unnamed) if (!the_nodelist) return NULL; - /* ???? NM Naming authorities had an additional weird behavior here where - they would treat their own namings as slightly authoritative in a - strange and inconsistent way. I think that this way is better, but we - could get the old behavior back if we wanted to by adding a function - to look in the fp_by_name table in fingerprint_list, and using this - function to override the name-to-digest lookup below if we are a - naming server. -NM - */ - /* Handle these cases: DIGEST, $DIGEST, $DIGEST=name, $DIGEST~name. */ if ((node = node_get_by_hex_id(nickname)) != NULL) return node;