nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-30 15:43:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable -Wthread-safety.

Browse Source 
See changes file; closes ticket 20110.
This commit is contained in:
Nick Mathewson 2016-09-08 09:37:40 -04:00
parent 8acb951fc8
commit f3cda3272a
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
changes/bug20110 Normal file
View File

@ -0,0 +1,6 @@
o Minor bugfixes (compilation):
- Stop trying to build with Clang 4.0's -Wthread-safety
warnings. They apparently require a set of annotations that we
aren't currently using, and they create false positives in our
pthreads wrappers. Fixes bug 20110; bugfix on 0.2.9.1-alpha.

13
configure.ac
View File

@ -1800,11 +1800,6 @@ if test "x$enable_gcc_warnings_advisory" != "xno"; then
-Wsync-nand -Wsync-nand
-Wtautological-constant-out-of-range-compare -Wtautological-constant-out-of-range-compare
-Wtentative-definition-incomplete-type -Wtentative-definition-incomplete-type
-Wthread-safety
-Wthread-safety-analysis
-Wthread-safety-attributes
-Wthread-safety-beta
-Wthread-safety-precise
-Wtrampolines -Wtrampolines
-Wtype-safety -Wtype-safety
-Wtypedef-redefinition -Wtypedef-redefinition
@ -1838,6 +1833,14 @@ if test "x$enable_gcc_warnings_advisory" != "xno"; then
-Wzero-length-array -Wzero-length-array
], [ TOR_CHECK_CFLAGS([warning_flag]) ]) ], [ TOR_CHECK_CFLAGS([warning_flag]) ])
dnl These seem to require annotations that we don't currently use,
dnl and they give false positives in our pthreads wrappers. (Clang 4)
dnl -Wthread-safety
dnl -Wthread-safety-analysis
dnl -Wthread-safety-attributes
dnl -Wthread-safety-beta
dnl -Wthread-safety-precise
CFLAGS="$CFLAGS -W -Wfloat-equal -Wundef -Wpointer-arith" CFLAGS="$CFLAGS -W -Wfloat-equal -Wundef -Wpointer-arith"
CFLAGS="$CFLAGS -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings" CFLAGS="$CFLAGS -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings"
CFLAGS="$CFLAGS -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2" CFLAGS="$CFLAGS -Wredundant-decls -Wchar-subscripts -Wcomment -Wformat=2"