Allow NULL circ->p_chan in circuit_is_suitable_for_introduce1()

This shouldn't be possible while Tor is running, but the tests can
hit this code.  Rather than force the tests to add a dummy channel
object, let's just tolerate their incompletely built circuits.
This commit is contained in:
Nick Mathewson 2019-07-23 12:36:40 -04:00
parent f2b1eb1f05
commit f14ce4bce6

View File

@ -548,7 +548,7 @@ circuit_is_suitable_for_introduce1(const or_circuit_t *circ)
}
/* Disallow single hop client circuit. */
if (channel_is_client(circ->p_chan)) {
if (circ->p_chan && channel_is_client(circ->p_chan)) {
log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL,
"Single hop client was rejected while trying to introduce. "
"Closing circuit.");