nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-11 13:43:47 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove XXXXprop271 comments from test_entrynodes.c

Browse Source 
These commments were complaints about how I didn't like some aspects
of prop271.  They have been superseded by ticket 20832.
This commit is contained in:
Nick Mathewson 2017-01-30 10:43:53 -05:00
parent 7d0df8bad8
commit ed4a3dfef2
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/test_entrynodes.c
View File

@ -2044,7 +2044,6 @@ test_entry_guard_select_for_circuit_highlevel_confirm_other(void *arg)
u = entry_guard_succeeded(&guard); u = entry_guard_succeeded(&guard);
/* We're on the internet (by fiat), so this guard will get called "confirmed" /* We're on the internet (by fiat), so this guard will get called "confirmed"
* and should immediately become primary. * and should immediately become primary.
* XXXX prop271 -- I don't like that behavior, but it's what is specified
*/ */
tt_int_op(guard->state, OP_EQ, GUARD_CIRC_STATE_COMPLETE); tt_int_op(guard->state, OP_EQ, GUARD_CIRC_STATE_COMPLETE);
tt_assert(u == GUARD_USABLE_NOW); tt_assert(u == GUARD_USABLE_NOW);
@ -2338,9 +2337,6 @@ test_entry_guard_upgrade_a_circuit(void *arg)
* primary guards are down, we have two WAITING circuits: one will * primary guards are down, we have two WAITING circuits: one will
* get upgraded to COMPLETED! (The one that started first.) * get upgraded to COMPLETED! (The one that started first.)
*/ */
/* XXXX prop271 -- perhaps the one that started first should
* also wind up in confirmed_entry_guards earlier?
*/
smartlist_t *result = smartlist_new(); smartlist_t *result = smartlist_new();
int r; int r;