nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-11-27 13:53:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove todos

Browse Source
This commit is contained in:
trinity-1686a 2023-10-18 18:23:02 +02:00 committed by David Goulet
parent 0cf4966acf
commit eca9973e9e
1 changed files with 4 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/core/or/connection_edge.c
View File

@ -4150,9 +4150,8 @@ connection_exit_begin_conn(cell_t *cell, circuit_t *circ)
log_debug(LD_EXIT,"about to start the dns_resolve()."); log_debug(LD_EXIT,"about to start the dns_resolve().");
/* TODO should this be moved higher to protect from a stream DoS on directory // in the future we may want to have a similar defense for BEGIN_DIR and
* requests, and possibly against an onion service? (for OS, more changes // BEGIN sent to OS.
* would be required) */
dos_defense_type = dos_stream_new_begin_or_resolve_cell(or_circ); dos_defense_type = dos_stream_new_begin_or_resolve_cell(or_circ);
switch (dos_defense_type) { switch (dos_defense_type) {
case DOS_STREAM_DEFENSE_NONE: case DOS_STREAM_DEFENSE_NONE:
@ -4166,17 +4165,7 @@ connection_exit_begin_conn(cell_t *cell, circuit_t *circ)
return 0; return 0;
case DOS_STREAM_DEFENSE_CLOSE_CIRCUIT: case DOS_STREAM_DEFENSE_CLOSE_CIRCUIT:
connection_free_(TO_CONN(n_stream)); connection_free_(TO_CONN(n_stream));
/* TODO we could return REASON_NONE or REASON_RESOURCELIMIT. When closing return -END_CIRC_REASON_RESOURCELIMIT;
* circuits, you either get:
* - END_CIRC_REASON_NONE: tons of notice level "We tried for 15
* seconds to connect to 'target' using exit X. Retrying on a new
* circuit."
* - END_CIRC_REASON_RESOURCELIMIT: warn level "Guard X is failing
* to carry an extremely large amount of streams on its circuits"
*
* I'm not sure which one we want
*/
return -END_CIRC_REASON_NONE;
} }
/* send it off to the gethostbyname farm */ /* send it off to the gethostbyname farm */
@ -4247,9 +4236,7 @@ connection_exit_begin_resolve(cell_t *cell, or_circuit_t *circ)
dns_send_resolved_error_cell(dummy_conn, RESOLVED_TYPE_ERROR_TRANSIENT); dns_send_resolved_error_cell(dummy_conn, RESOLVED_TYPE_ERROR_TRANSIENT);
return 0; return 0;
case DOS_STREAM_DEFENSE_CLOSE_CIRCUIT: case DOS_STREAM_DEFENSE_CLOSE_CIRCUIT:
/* TODO maybe use REASON_RESOURCELIMIT? return -END_CIRC_REASON_RESOURCELIMIT;
* See connection_exit_begin_conn() */
return -END_CIRC_REASON_NONE;
} }
/* send it off to the gethostbyname farm */ /* send it off to the gethostbyname farm */