nihilist/tor
1
0
Fork 0
mirror of https://gitlab.torproject.org/tpo/core/tor.git synced 2024-09-20 21:16:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

practracker: Improvements based on last Nick's review.

Browse Source
This commit is contained in:
George Kadianakis 2019-03-12 14:35:26 +02:00 committed by Nick Mathewson
parent 157f7ba93e
commit ec8c5b3fea
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/maint/practracker/metrics.py
View File

@ -26,8 +26,8 @@ def get_function_lines(f):
"""
# Skip lines with these terms since they confuse our regexp
REGEXP_CONFUSE_TERMS = ["MOCK_IMPL", "ENABLE_GCC_WARNINGS", "ENABLE_GCC_WARNING", "DUMMY_TYPECHECK_INSTANCE",
"DISABLE_GCC_WARNING", "DISABLE_GCC_WARNINGS"]
REGEXP_CONFUSE_TERMS = {"MOCK_IMPL", "ENABLE_GCC_WARNINGS", "ENABLE_GCC_WARNING", "DUMMY_TYPECHECK_INSTANCE",
"DISABLE_GCC_WARNING", "DISABLE_GCC_WARNINGS"}
in_function = False
for lineno, line in enumerate(f):
@ -43,7 +43,7 @@ def get_function_lines(f):
in_function = True
else:
# Fund the end of a function
# Find the end of a function
if line.startswith("}"):
n_lines = lineno - func_start
in_function = False

3
scripts/maint/practracker/problem.py
View File

@ -8,6 +8,7 @@ get worse.
"""
import os.path
import sys
class ProblemVault(object):
"""
@ -23,7 +24,7 @@ class ProblemVault(object):
with open(exception_fname, 'r') as exception_f:
self.register_exceptions(exception_f)
except IOError:
print("No exception file provided")
print("No exception file provided", file=sys.stderr)
def register_exceptions(self, exception_file):
# Register exceptions

2
scripts/maint/practracker/util.py
View File

@ -2,7 +2,7 @@ import os
# We don't want to run metrics for unittests, automatically-generated C files,
# external libraries or git leftovers.
EXCLUDE_SOURCE_DIRS = ["/src/test/", "/src/trunnel/", "/src/ext/", "/.git/"]
EXCLUDE_SOURCE_DIRS = {"/src/test/", "/src/trunnel/", "/src/ext/", "/.git/"}
def get_tor_c_files(tor_topdir):
"""