Remove a few dead assignments during router parsing

This commit is contained in:
Sebastian Hahn 2011-06-08 21:16:11 +02:00
parent ff75e8b02d
commit e6fff7235e
2 changed files with 4 additions and 3 deletions

View File

@ -1,5 +1,6 @@
o Code simplifications and refactoring:
- Remove some dead code as indicated by coverity.
- Remove a few dead assignments during router parsing. Found by coverity.
o Minor bugfixes:
- Add some forgotten return value checks during unit tests. Found
by coverity.

View File

@ -1544,10 +1544,10 @@ router_parse_entry_from_string(const char *s, const char *end,
}
}
if ((tok = find_opt_by_keyword(tokens, K_CACHES_EXTRA_INFO)))
if (find_opt_by_keyword(tokens, K_CACHES_EXTRA_INFO))
router->caches_extra_info = 1;
if ((tok = find_opt_by_keyword(tokens, K_ALLOW_SINGLE_HOP_EXITS)))
if (find_opt_by_keyword(tokens, K_ALLOW_SINGLE_HOP_EXITS))
router->allow_single_hop_exits = 1;
if ((tok = find_opt_by_keyword(tokens, K_EXTRA_INFO_DIGEST))) {
@ -1560,7 +1560,7 @@ router_parse_entry_from_string(const char *s, const char *end,
}
}
if ((tok = find_opt_by_keyword(tokens, K_HIDDEN_SERVICE_DIR))) {
if (find_opt_by_keyword(tokens, K_HIDDEN_SERVICE_DIR)) {
router->wants_to_be_hs_dir = 1;
}