mirror of
https://gitlab.torproject.org/tpo/core/tor.git
synced 2024-11-24 12:23:32 +01:00
Add a missing goto to an unusable branch and make the branch LD_BUG.
(It's LD_BUG to reach this point because the hashed password values were tested earlier from options_validate) [Coverity CID 1232091]
This commit is contained in:
parent
2a0a5fe612
commit
e6a05c1c54
@ -1160,9 +1160,10 @@ handle_control_authenticate(control_connection_t *conn, uint32_t len,
|
||||
}
|
||||
if (bad) {
|
||||
if (!also_cookie) {
|
||||
log_warn(LD_CONTROL,
|
||||
log_warn(LD_BUG,
|
||||
"Couldn't decode HashedControlPassword: invalid base16");
|
||||
errstr="Couldn't decode HashedControlPassword value in configuration.";
|
||||
goto err;
|
||||
}
|
||||
bad_password = 1;
|
||||
SMARTLIST_FOREACH(sl, char *, cp, tor_free(cp));
|
||||
|
Loading…
Reference in New Issue
Block a user