Add a comment explaining why we do a certain redundant check

Closes ticket 25291.
This commit is contained in:
Nick Mathewson 2018-04-09 12:58:17 -04:00
parent 2fac948158
commit e58555135a

View File

@ -2269,6 +2269,11 @@ options_act(const or_options_t *old_options)
} }
if ((!old_options || !old_options->EntryStatistics) && if ((!old_options || !old_options->EntryStatistics) &&
options->EntryStatistics && !should_record_bridge_info(options)) { options->EntryStatistics && !should_record_bridge_info(options)) {
/* If we get here, we've started recording bridge info when we didn't
* do so before. Note that "should_record_bridge_info()" will
* always be false at this point, because of the earlier block
* that cleared EntryStatistics when public_server_mode() was false.
* We're leaving it in as defensive programming. */
if (geoip_is_loaded(AF_INET) || geoip_is_loaded(AF_INET6)) { if (geoip_is_loaded(AF_INET) || geoip_is_loaded(AF_INET6)) {
geoip_entry_stats_init(now); geoip_entry_stats_init(now);
print_notice = 1; print_notice = 1;